wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-23 22:13:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

getTargetDataFromHref: catch error if passed invalid URL

Browse source 
Could trigger this by typing `https://` into the internal link
annotation inspector.

Bug: T366822
Change-Id: Ie58ded247dbfb6c001d8177953ea148cd82ec03d
This commit is contained in:
David Lynch 2024-06-05 14:36:24 -05:00
parent 291844dbee
commit b10fb53f8c
1 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
modules/ve-mw/preinit/ve.utils.parsoid.js
View file

@ -276,7 +276,13 @@ mw.libs.ve.getTargetDataFromHref = function ( href, doc ) {
return data;
}
const url = new URL( href, doc.baseURI );
let url;
try {
url = new URL( href, doc.baseURI );
} catch ( e ) {
// An invalid URL was provided (e.g. `https://`)
return returnExternalData();
}
// Equivalent to `ve.init.platform.getExternalLinkUrlProtocolsRegExp()`, which can not be called here
const externalLinkUrlProtocolsRegExp = new RegExp( '^(' + mw.config.get( 'wgUrlProtocols' ) + ')', 'i' );