I actually find this easier to read, to be honest. It also makes the
code a little more robust, e.g. undefined and the empty string are
both considered empty.
Note that unlike in PHP the string "0" is not empty in JavaScript.
Change-Id: I2961287c2798b8bb0f6992e002f5a6f333889448
On skins where the toolbar has no bottom margin (Vector 2022,
Timeless) this fixes the lack of gap between the toolbar and
the button. On skins that have a bottom margin on the toolbar
(Vector legacy, monobook), this will have no effect due to
margin collapse.
Bug: T375187
Change-Id: Id0a3e5696a9d6b7b7a2849483e81b38b426165c4
The goal is to make the code (especially the very large Dialog class)
more readable and easier to maintain.
Notable:
* Move cheap === comparison to the top.
* Use boolean .test() instead of .match() when we don't need an array.
* Use chained method calls where possible.
Change-Id: I1655174494911950d9d6530a512828e60bf5375d
As far as I can see this was never used, not even in the original
patch Ib739ee0 that added it.
Bug: T86916
Change-Id: Ibaed8504791e54348584a5f66095a9f36e83601d
The languages in this list are presented as "autonyms", meaning it's
the name of the language written in the language. They should be
marked accordingly in the DOM.
However, the current design breaks appart when we allow some of
the rows to be right-aligned. To avoid this we enforce the previous
left-align via CSS. This is not perfect but the best compromise at
the moment, in my opinion.
The code follows what we did in T238329, specifically the patch
Ifcbb877.
Bug: T324385
Change-Id: I53a5a96395b60f3e5d0d80bd5efa4024c4d97884
These messages are still used in ParamImportWidget, originally added
via I985ea03 in 2014. The comments have been added much later, see
Ib53aa55. This was really only a copy-paste mistake because of the
very similar message keys.
Change-Id: I78e1a8aec200299e72ce8354ea722ad9c1fd27c0
* deprecated means "please do not use this".
* required means "you must use this".
* suggested means "it's a good idea to use this".
* optional means "you typically don't need this".
There is no combination that makes any sense. They are really
exclusive to each other.
Still we have to keep the three checkboxes for backwards
compatibility reasons. It was always possible (and will probably
continue to be possible) to have more than one of the three fields
enabled. While users like VisualEditor will make a good guess (e.g.
ignore the rest when "deprecated" is checked) I really think we
should not attempt to hide (and auto-fix) it in this dialog. That's
why the proposed code continues to show the old checkboxes when
more than one is checked.
Bug: T202851
Change-Id: I994268d658602761b180f489bedb50b91fe0c419
Most of the code is already using a "prop" variable for the same
purpose. I hope that following the same pattern everywhere makes the
code easier to read.
Change-Id: I00e344b9041e1cb7e2dee129b17549959f32e4d9
New in OOUI v0.48.2.
Unlike the old version, this also prevents inserting line breaks by
copy-paste and other methods.
Change-Id: I2fe1b7cfe70ebb6b66a9dfdf012522b574f6e774
Turns out this was always pointless. Nothing the method does makes
sense without a language. A default language is only choosen much
later as part of getSetupProcess, and the method called a second
time, this time with a language.
Issue introduced a long, long time ago and finally surfaced via
Ifcbb877.
Bug: T238329
Change-Id: I47c8ce16107ebe7a1d955665dc890bef80ec892a
A small mistake made in I7a82143. This is only relevant for very few
(but critical) language codes. For example, the dialog allows to add
the MediaWiki code "zh-classical". This needs to be translated to
"lzh", but only when we use it directly in HTML.
Bug: T238329
Change-Id: Ifcbb877fb6a348937e85a82459e924548f5ca856
It's always true and doesn't make any difference because of this.
I think the idea was to do some validation in the method. This
never happened and is done outside of the method instead (better
separation of concerns).
This is split from I1655174 to make it easier to review.
Change-Id: I48b7da75659365e5a2f72b680d40ee4b5b2904a2
Reasons:
* It's not the job of this code to validate the incoming types. This
happens server-side.
* The new code reflects better what actually happened: we stopped
using the prefix "string/".
* This was not (probably never) in sync with the server-side
validation. Some types got replaced, some didn't.
Change-Id: I0a35ca334c9e243dee548b271ddb3e1ca4498611
This is split from I1655174 to make it much easier to review. This
patch here doesn't do anything but rename existing variables to
follow existing, less confusing naming schemes.
Change-Id: Ibd9db5ca5a355246eeaed98d48edc835659ec2c5
The "uneditablefield" was added in 2014 via I9b13e2f, apparently
as a temporary workaround. It was apparently not possible to edit
multi-lingual language object back then.
All code related to that was removed about 5 months later via
I985ea03. The patch made it possible to edit such fields. They just
forgot to remove the message.
The "actions" message was added via I863a819. Apparently used for
an "action" table column where parameters could be deleted. This
also got lost in the same big rewrite in I985ea03.
Change-Id: I57329bef8de10ee19e1904d33605d2102fd22741
The first patch I5f52fe3 worked only for fields with an existing
value. Turns out it's undefined for new fields.
Bug: T238329
Change-Id: I7a8214335b720c9ab738f6c4e47febbc0abf7dc4
E.g. in German it says "Neue Zuordnung hinzufügen". The long string
peaks into the other UI elements because OOUI enforces some `nowrap`
for no good reason.
Change-Id: Ib5f8584d4ac652479d6f646dcaa8cf06654832fd
OO.ui.ActionFieldLayout requires 3 parameters: 2 widgets and optional
configuration. But this code was passing only 1 widget. The config
object was actually used as a widget and never as config. It's a
miracle this was not throwing an error. ;-)
Replace with a more trivial FieldLayout which requires only 1 widget.
Also clean up some closely related code.
Change-Id: Idca9a39e9f442f3a5412027906de9f868fc12b76
This fixes a whole sequence of issues:
* It was actually possible to add a parameter with no name.
* It was also possible to add parameters where the name is nothing
but whitespace.
* Pressing enter was not possible.
* The button was initially enabled with the input field being empty.
* Validation code was duplicated, but incomplete, which made it
possible to add duplicate parameters with enter.
Bug: T324381
Change-Id: I598997efc63256fd59a2b4f71fb7c3d99306bd85
This placeholder was added in Ic8f9bf7. It makes sure the page
content below the button doesn't shift down the moment the button
appears. See T279869 for a screencast that demonstrates the issue.
Unfortunately something changed (possibly related to T323773) and
the size of the placeholder is not correct any more. At the moment
the page shifts up a few pixels.
Bug: T279869
Change-Id: Ie6e585d2061342c11aabb4414bb9b0bedecf3a12
