wikimedia/mediawiki-extensions-TemplateData
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/TemplateData synced 2024-09-23 10:21:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove two messages that are unused since 2014

Browse source 
The "uneditablefield" was added in 2014 via I9b13e2f, apparently
as a temporary workaround. It was apparently not possible to edit
multi-lingual language object back then.

All code related to that was removed about 5 months later via
I985ea03. The patch made it possible to edit such fields. They just
forgot to remove the message.

The "actions" message was added via I863a819. Apparently used for
an "action" table column where parameters could be deleted. This
also got lost in the same big rewrite in I985ea03.

Change-Id: I57329bef8de10ee19e1904d33605d2102fd22741
This commit is contained in:
thiemowmde 2023-09-14 18:01:35 +02:00
parent 616e136342
commit 9eb2e46f37
4 changed files with 0 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
extension.json
View file

@ -156,7 +156,6 @@
"templatedata-modal-search-input-placeholder",
"templatedata-modal-placeholder-mapinfo",
"templatedata-modal-placeholder-prompt-map-name",
"templatedata-modal-table-param-actions",
"templatedata-modal-table-param-aliases",
"templatedata-modal-table-param-autovalue",
"templatedata-modal-table-param-suggestedvalues",
@ -173,7 +172,6 @@
"templatedata-modal-table-param-required",
"templatedata-modal-table-param-suggested",
"templatedata-modal-table-param-type",
"templatedata-modal-table-param-uneditablefield",
"templatedata-modal-title",
"templatedata-modal-title-addparam",
"templatedata-modal-title-choose-language",

2
i18n/en.json
View file

@ -89,7 +89,6 @@
"templatedata-modal-placeholder-mapinfo": "This template has no maps object",
"templatedata-modal-placeholder-prompt-map-name": "Enter map name",
"templatedata-modal-search-input-placeholder": "Search by language name or code",
"templatedata-modal-table-param-actions": "Actions",
"templatedata-modal-table-param-aliases": "Aliases",
"templatedata-modal-table-param-autovalue": "Auto value",
"templatedata-modal-table-param-default": "Default ($1)",
@ -106,7 +105,6 @@
"templatedata-modal-table-param-suggestedvalues": "Suggested values",
"templatedata-modal-placeholder-multiselect": "Add value...",
"templatedata-modal-table-param-type": "Type",
"templatedata-modal-table-param-uneditablefield": "Uneditable",
"templatedata-modal-title": "Template data editor",
"templatedata-modal-title-addparam": "Add new parameter",
"templatedata-modal-title-choose-language": "Choose language",

2
i18n/qqq.json
View file

@ -102,7 +102,6 @@
"templatedata-modal-placeholder-mapinfo": "{{technical}}\nPlaceholder for the input that contains map information. See [[:mw:Extension:TemplateData#Maps object]].",
"templatedata-modal-placeholder-prompt-map-name": "{{technical}}\nPlaceholder for new map name prompter. See [[:mw:Extension:TemplateData#Maps object]].",
"templatedata-modal-search-input-placeholder": "Placeholder text for language search panel.",
"templatedata-modal-table-param-actions": "Label for a parameter property input: Parameter actions in the table\n{{Identical|Action}}",
"templatedata-modal-table-param-aliases": "Label for a parameter property input: Aliases of the parameter.",
"templatedata-modal-table-param-autovalue": "Label for a parameter property input: Parameter auto value in the table",
"templatedata-modal-table-param-default": "Label for a parameter property input: Default value of the parameter.\n\nParameters:\n* $1 - currently showing language\n{{Identical|Default}}",
@ -119,7 +118,6 @@
"templatedata-modal-table-param-suggestedvalues": "Label for a parameter property input: List of suggested values",
"templatedata-modal-placeholder-multiselect": "Placeholder text for suggested values field.",
"templatedata-modal-table-param-type": "Label for a parameter property input: Type of the parameter.\n{{Identical|Type}}",
"templatedata-modal-table-param-uneditablefield": "Placeholder text notifying the user the field is uneditable",
"templatedata-modal-title": "Title of the edit dialog.",
"templatedata-modal-title-addparam": "Title for add new parameter panel in the edit dialog.\n{{Identical|Add parameter}}",
"templatedata-modal-title-choose-language": "Title for the choose language panel in the edit dialog.",

6
modules/ext.templateDataGenerator.editTemplatePage/Dialog.js
View file

@ -1177,7 +1177,6 @@ Dialog.prototype.createParamDetails = function () {
this.propInputs[ property ] = propInput;
// The following classes are used here:
// * tdg-templateDataDialog-paramInput tdg-templateDataDialog-paramList-actions
// * tdg-templateDataDialog-paramInput tdg-templateDataDialog-paramList-aliases
// * tdg-templateDataDialog-paramInput tdg-templateDataDialog-paramList-autovalue
// * tdg-templateDataDialog-paramInput tdg-templateDataDialog-paramList-default
@ -1193,14 +1192,12 @@ Dialog.prototype.createParamDetails = function () {
// * tdg-templateDataDialog-paramInput tdg-templateDataDialog-paramList-suggested
// * tdg-templateDataDialog-paramInput tdg-templateDataDialog-paramList-suggestedvalues
// * tdg-templateDataDialog-paramInput tdg-templateDataDialog-paramList-type
// * tdg-templateDataDialog-paramInput tdg-templateDataDialog-paramList-uneditablefield
propInput.$element
.addClass( 'tdg-templateDataDialog-paramInput tdg-templateDataDialog-paramList-' + property );
this.propFieldLayout[ property ] = new OO.ui.FieldLayout( propInput, {
align: 'left',
// The following messages are used here:
// * templatedata-modal-table-param-actions
// * templatedata-modal-table-param-aliases
// * templatedata-modal-table-param-autovalue
// * templatedata-modal-table-param-default
@ -1216,7 +1213,6 @@ Dialog.prototype.createParamDetails = function () {
// * templatedata-modal-table-param-suggested
// * templatedata-modal-table-param-suggestedvalues
// * templatedata-modal-table-param-type
// * templatedata-modal-table-param-uneditablefield
label: mw.msg( 'templatedata-modal-table-param-' + property )
} );
@ -1248,7 +1244,6 @@ Dialog.prototype.updateParamDetailsLanguage = function ( lang ) {
for ( var i = 0; i < languageProps.length; i++ ) {
var prop = languageProps[ i ];
// The following messages are used here:
// * templatedata-modal-table-param-actions
// * templatedata-modal-table-param-aliases
// * templatedata-modal-table-param-autovalue
// * templatedata-modal-table-param-default
@ -1264,7 +1259,6 @@ Dialog.prototype.updateParamDetailsLanguage = function ( lang ) {
// * templatedata-modal-table-param-suggested
// * templatedata-modal-table-param-suggestedvalues
// * templatedata-modal-table-param-type
// * templatedata-modal-table-param-uneditablefield
var label = mw.msg( 'templatedata-modal-table-param-' + prop, lang );
this.propFieldLayout[ prop ].setLabel( label );
this.propInputs[ prop ].$input.attr( { lang: lang, dir: 'auto' } );