wikimedia/mediawiki-extensions-TemplateData
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/TemplateData synced 2024-11-23 23:43:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove unused lang argument from Dialog.updateParamDetailsLanguage

Browse source 
It's always `this.language` anyway.

Change-Id: Iaad6db9c5406c36307e827416ab8c08d80003f8b
This commit is contained in:
thiemowmde 2023-09-14 17:36:03 +02:00
parent 9eb2e46f37
commit 61ac3f9645
1 changed files with 5 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
modules/ext.templateDataGenerator.editTemplatePage/Dialog.js
View file

@ -704,7 +704,7 @@ Dialog.prototype.onLanguageDropdownWidgetSelect = function ( item ) {
this.repopulateParamSelectWidget();
// Update the parameter detail page
this.updateParamDetailsLanguage( this.language );
this.updateParamDetailsLanguage();
this.emit( 'change-language', this.language );
}
@ -1226,20 +1226,16 @@ Dialog.prototype.createParamDetails = function () {
paramFieldset.$element.append( this.propFieldLayout[ property ].$element );
}
// Update parameter property fields with languages
this.updateParamDetailsLanguage( this.language );
this.updateParamDetailsLanguage();
return paramFieldset.$element;
};
/**
* Update the labels for parameter property inputs that include language, so
* they show the currently used language.
*
* @param {string} [lang] Language. If not used, will use currently defined
* language.
*/
Dialog.prototype.updateParamDetailsLanguage = function ( lang ) {
Dialog.prototype.updateParamDetailsLanguage = function () {
var languageProps = Model.static.getPropertiesWithLanguage();
lang = lang || this.language;
for ( var i = 0; i < languageProps.length; i++ ) {
var prop = languageProps[ i ];
@ -1259,9 +1255,9 @@ Dialog.prototype.updateParamDetailsLanguage = function ( lang ) {
// * templatedata-modal-table-param-suggested
// * templatedata-modal-table-param-suggestedvalues
// * templatedata-modal-table-param-type
var label = mw.msg( 'templatedata-modal-table-param-' + prop, lang );
var label = mw.msg( 'templatedata-modal-table-param-' + prop, this.language );
this.propFieldLayout[ prop ].setLabel( label );
this.propInputs[ prop ].$input.attr( { lang: lang, dir: 'auto' } );
this.propInputs[ prop ].$input.attr( { lang: this.language, dir: 'auto' } );
}
};