Commit graph

2808 commits

Author SHA1 Message Date
Prateek Saxena 20f2bef272 renderer.article.getProcessedElements: Stop escaping the title and the extract
Both the title and the extract were being html escaped thus producing
string like ' and " when used with .text(). So, we now use
document.createTextNode() for the normal text and .text() with the bolded
one.

Bug: T93720
Change-Id: I6bbc52e427dc636b7b0be1ad4f749d9273ff61b3
2015-03-26 19:28:20 +05:30
jenkins-bot 1572bcf150 Merge "settings: Use .text() instead of .html() for option's label" 2015-03-26 10:34:41 +00:00
jenkins-bot 7d21948d1a Merge "renderer.article: Ignore thumnail if the URL has suspicious characters" 2015-03-26 10:33:42 +00:00
Prateek Saxena 2971d90831 Implement the new schema for when the popups are enabled
Bug: T88167
Change-Id: I38c9e474e0ec7da45af8338a458430e5d7427463
2015-03-26 11:42:39 +05:30
Prateek Saxena d49cfb9b65 Rename popups.eventLogging to popups.logger
...and eventLogging.logEvent to logger.log

Change-Id: I9af697a56c2248069a32ac586f5b78b55095460e
2015-03-26 04:56:29 +05:30
Translation updater bot d7bba41956 Localisation updates from https://translatewiki.net.
Change-Id: Id0ba70f4f6126005b2449ca52e01ea13e0bd9de0
2015-03-25 22:20:00 +01:00
Translation updater bot 13d3df306d Localisation updates from https://translatewiki.net.
Change-Id: I14e13ccf9b050a7b52365229ddeebe6e58b98ef9
2015-03-24 22:28:29 +01:00
Purodha a294827f2a i18n: Remove reference to color in description message
See:
https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Popups-settings-description/en

Change-Id: Ic89f2f71556bb1202f0d452e430f716ee359e264
2015-03-24 09:38:23 +00:00
Prateek Saxena 3b82fb60d9 settings: Use .text() instead of .html() for option's label
Bug: T88171
Change-Id: I5d4631870f916194901f897839cad4c90c2d8d01
2015-03-24 13:37:05 +05:30
Prateek Saxena 42d0347582 renderer.article: Ignore thumnail if the URL has suspicious characters
If the URL of the thumbnail has suspicious characters like ', " or \
return a <span> instead of trying to render a thumbnail.

Bug: T88171
Change-Id: Ide052ea2a7de166599d077a385a6e788bfa63302
2015-03-24 13:31:19 +05:30
Translation updater bot fc1fe6d473 Localisation updates from https://translatewiki.net.
Change-Id: Ic4cb4c916c068821b6c2f327b9629177b63b8e0b
2015-03-23 22:03:44 +01:00
Translation updater bot 6aa2688ba2 Localisation updates from https://translatewiki.net.
Change-Id: I600156349814062c6833cdca918a169a71d17353
2015-03-19 21:15:20 +01:00
Translation updater bot cd3aeeca41 Localisation updates from https://translatewiki.net.
Change-Id: I42d2a2490ac401aaa87f614269ff3af9a8fb6ace
2015-03-16 21:59:41 +01:00
jenkins-bot 5bdfbc6802 Merge "renderer.article: Don't apply tall/not-tall classes if the image wasn't shown" 2015-03-16 10:10:10 +00:00
Translation updater bot 1dc94ad7f6 Localisation updates from https://translatewiki.net.
Change-Id: I018d88c4736526d95d14e3d36d1784d812ec8514
2015-03-15 21:52:10 +01:00
Translation updater bot d49c2a26be Localisation updates from https://translatewiki.net.
Change-Id: I129097268a14f54474bd3e917da44980d8b6590c
2015-03-14 21:36:11 +01:00
Translation updater bot d59602ebbe Localisation updates from https://translatewiki.net.
Change-Id: I4a90c254a3f224d3a755f9946b717b22c5798764
2015-03-14 08:33:34 +01:00
Translation updater bot 3b0457a438 Localisation updates from https://translatewiki.net.
Change-Id: I6db6aef670f32ba05a9597c0af29234f824fd1a9
2015-03-09 22:08:55 +01:00
Translation updater bot e436f1544f Localisation updates from https://translatewiki.net.
Change-Id: Ib6c6731c72a60b7597d9ba642d5db4c6c06bd95d
2015-03-08 21:47:56 +01:00
Prateek Saxena 3eaf2829e8 renderer.article: Remove leading spaces before brackets
Bug: T69225
Change-Id: I83f79fa0ebd19bea6ed7ea266cece0778210adb2
2015-03-05 15:32:45 +05:30
Prateek Saxena df0b988eec renderer.article: Bold the title no matter what the trailing characters
Bug: T69229
Change-Id: I833c0dcae98010bc74b6b58ae8035aaac4e6465b
2015-03-05 15:31:42 +05:30
Prateek Saxena a43ef7ca51 Remove the need of .html in article.getProcessedHtml
Instead of replacing all instances of the title in the extract -

  '$1<b>$2</b>$3'

We now put symbolic strings there which we use to split the string
and then make an array of text and <b> elements that get appended
to $contentbox.

Bug: T76378
Change-Id: I02222bbff84532f63cac67af1bf889c328ec6ff2
2015-03-05 15:30:06 +05:30
Prateek Saxena e5880ffd40 renderer.article: Don't apply tall/not-tall classes if the image wasn't shown
Bug: T91433
Change-Id: I4499cc18e140c0bd18ee3731496aa427232922b4
2015-03-05 13:24:35 +05:30
jenkins-bot 62659d2c34 Merge "Improve mw.popups.selectPopupElements" 2015-03-04 12:10:23 +00:00
se4598 9974a75b50 Improve mw.popups.selectPopupElements
Use proven technology to create and compare URLs.
This will display popups also on anchored links again.

Change-Id: Ic010ca027017435f666782e709e641cf3bbb8767
2015-03-04 17:21:37 +05:30
Prateek Saxena 5ee43d6b3e core.less: Visual refinement & drop shadow
This what it looks like -
https://phabricator.wikimedia.org/T78641#984753

Bug: T78641
Change-Id: Id59acba49963eb02626444f91b716c53c1bef7b4
2015-03-04 16:45:56 +05:30
Translation updater bot bed295c948 Localisation updates from https://translatewiki.net.
Change-Id: I2a1ded2fa7681a42302b4e837cfc38e2fc253328
2015-03-02 22:10:39 +01:00
Translation updater bot 8707f8ec52 Localisation updates from https://translatewiki.net.
Change-Id: Ib0f022d94c2a9328110eb72707b764fdee8fac50
2015-03-01 22:07:49 +01:00
Translation updater bot 5e8b6ec6a6 Localisation updates from https://translatewiki.net.
Change-Id: I07c6eab4be1d40966b7c09d8489e137a7b22e8ed
2015-02-26 21:37:46 +01:00
Translation updater bot 80a00ee311 Localisation updates from https://translatewiki.net.
Change-Id: I928c71eac415295e305eee77004bb76ae65ab7e8
2015-02-24 22:03:06 +01:00
se4598 64195b8ff7 fix mw.popups.selectPopupElements
Hotfix for Ie34064860a81c7866b8e8b86858d2e12a8a196f4
Still won't show up popups for anchored links, but dunno if intended. 

Change-Id: I91a15153cb8bcae6d8ef2e5616855e4d45be6d78
2015-02-24 00:14:02 +01:00
jenkins-bot 782d9e37ba Merge "eventLogging: Use generateRandomSessionId" 2015-02-20 11:06:01 +00:00
jenkins-bot fd5cc437a3 Merge "Add a check for the EventLogging library before the logEvent call" 2015-02-20 11:03:32 +00:00
Prateek Saxena 44c57834b1 Disable Navigation Popups on render rather than document load
Bug: T64952
Change-Id: I7985341006d587671077f3dc32dd02e8dfb38972
2015-02-20 11:54:17 +01:00
Prateek Saxena b4cfa5c6d5 Add a check for the EventLogging library before the logEvent call
Bug: T70341
Change-Id: Idae926b1ddce544ab37b95018abc13879f515f71
2015-02-20 11:49:39 +01:00
Prateek Saxena 37442e6457 eventLogging: Use generateRandomSessionId
Bug: T88919
Change-Id: Ib859db7f55358d0cbd9f26b25d9fe96b76e718e9
2015-02-20 11:48:36 +01:00
se4598 45cf9c13e7 core: Better article link detection
Use the getUrl method to check that the <a> actually links
to the article that it has the title of. Only those elements
are returned by selectPopupElements.

Bug: T70039
Bug: T72512
Change-Id: Ie34064860a81c7866b8e8b86858d2e12a8a196f4
2015-02-18 17:02:14 +05:30
jenkins-bot 2fd9ac3569 Merge "Access native a.href property instead of attribute" 2015-02-18 10:33:55 +00:00
jenkins-bot f8e7b47bd9 Merge "core: Add missing leading '.' to oo-ui-buttonedElement-button in IGNORE_CLASSES" 2015-02-18 00:15:18 +00:00
Thiemo Mättig ddab3f9fd7 Access native a.href property instead of attribute
This is a subset of patch Ie340648. If reviewing and merging the much
larger other patch (it does much more things) is a problem, we can
merge this first, rebase the other one and have a much more focussed
discussion.

Change-Id: I4549fb1810c7dd36df8a70983d9508015c2bfadf
2015-02-17 15:03:13 +01:00
jenkins-bot 83cc5ad1ef Merge "Fix TypeError on <a> with no href" 2015-02-17 13:54:57 +00:00
Prateek Saxena 7a51668e56 core: Add missing leading '.' to oo-ui-buttonedElement-button in IGNORE_CLASSES
Follows up I418508fad97e81127084150221e10ccec418167a

Change-Id: Ib3c187feeb8de053416bb3ef131c8f5cfedf0c63
2015-02-17 18:19:11 +05:30
Translation updater bot 8067650cdb Localisation updates from https://translatewiki.net.
Change-Id: Ibd52252ed22fc388e56ef9661eee49eb99a5b229
2015-02-16 21:56:20 +01:00
Thiemo Mättig bf4016ecf1 Fix TypeError on <a> with no href
HTML5 allows <a> elements with no href="..." attribute. We do this in
Wikibase/Wikidata in a few places. Hovering these <a> elements causes
TypeErrors.

This is a hotfix. Please see Ie340648 for a much more advanced fix.

Change-Id: Ib20ef8348c964a6ba736d0fc76909fd4d496c11e
2015-02-12 15:37:37 +01:00
Translation updater bot d229877afb Localisation updates from https://translatewiki.net.
Change-Id: I0034f729f7ed7eb3e4dd9653d635f8c3f780f55b
2015-02-02 22:30:04 +01:00
jenkins-bot daa1a3e0de Merge "Add 'license-name' matching SPDX conventions" 2015-01-31 23:54:08 +00:00
Translation updater bot 895493b638 Localisation updates from https://translatewiki.net.
Change-Id: I14a3f4bd3663cb4bf0e993c7e5e55ef615ca2c9a
2015-01-30 21:52:06 +01:00
Translation updater bot 6f0ae85d8a Localisation updates from https://translatewiki.net.
Change-Id: Id7976975d6c60b15c47087c254219cc53a2a1b59
2015-01-29 23:04:54 +01:00
Ricordisamoa f249d370f1 Add 'license-name' matching SPDX conventions
References:
http://spdx.org/licenses/
https://www.mediawiki.org/wiki/Manual:$wgExtensionCredits#license-name

Change-Id: Ibc434d319c5c9b1f9eddf1427aa9e4db56b7f285
2015-01-29 15:32:09 +01:00
Translation updater bot 60c7bf4ece Localisation updates from https://translatewiki.net.
Change-Id: I37f2e39ab0ea3dd280b429747747c3ef263efa96
2015-01-28 22:38:36 +01:00