wikimedia/mediawiki-extensions-Popups
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Popups synced 2024-11-24 07:34:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

core: Better article link detection

Browse source 
Use the getUrl method to check that the <a> actually links
to the article that it has the title of. Only those elements
are returned by selectPopupElements.

Bug: T70039
Bug: T72512
Change-Id: Ie34064860a81c7866b8e8b86858d2e12a8a196f4
This commit is contained in:
se4598 2014-07-15 17:41:58 +02:00 committed by Prateek Saxena
parent 2fd9ac3569
commit 45cf9c13e7
1 changed files with 5 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
resources/ext.popups.core.js
View file

@ -137,16 +137,7 @@
*/
mw.popups.setupTriggers = function ( $elements ) {
$elements.on( 'mouseenter focus', function ( event ) {
var href = this.href;
// No popup if scrolling or on certain kinds of links.
if (
mw.popups.scrolled || // Prevents hovering on popups while scrolling
href.indexOf( '?' ) !== -1 ||
href.indexOf( 'javascript:' ) === 0 || // jshint ignore:line
href.indexOf( location.origin + location.pathname + '#' ) === 0
) {
// TODO No popup for this, but removeTooltips() has already blanked the title.
if ( mw.popups.scrolled ) {
return;
}
@ -161,7 +152,10 @@
*/
mw.popups.selectPopupElements = function () {
return mw.popups.$content
.find( 'a[href]:not(' + mw.popups.IGNORE_CLASSES.join(', ') + ')' );
.find( 'a[href][title]:not(' + mw.popups.IGNORE_CLASSES.join(', ') + ')' )
.filter( function () {
return ( this.href === mw.config.get( 'wgServer' ) + mw.util.getUrl( this.title ) );
} );
};
mw.hook( 'wikipage.content').add( function ( $content ) {