Commit graph

323 commits

Author SHA1 Message Date
Prateek Saxena b4cfa5c6d5 Add a check for the EventLogging library before the logEvent call
Bug: T70341
Change-Id: Idae926b1ddce544ab37b95018abc13879f515f71
2015-02-20 11:49:39 +01:00
se4598 45cf9c13e7 core: Better article link detection
Use the getUrl method to check that the <a> actually links
to the article that it has the title of. Only those elements
are returned by selectPopupElements.

Bug: T70039
Bug: T72512
Change-Id: Ie34064860a81c7866b8e8b86858d2e12a8a196f4
2015-02-18 17:02:14 +05:30
jenkins-bot 2fd9ac3569 Merge "Access native a.href property instead of attribute" 2015-02-18 10:33:55 +00:00
jenkins-bot f8e7b47bd9 Merge "core: Add missing leading '.' to oo-ui-buttonedElement-button in IGNORE_CLASSES" 2015-02-18 00:15:18 +00:00
Thiemo Mättig ddab3f9fd7 Access native a.href property instead of attribute
This is a subset of patch Ie340648. If reviewing and merging the much
larger other patch (it does much more things) is a problem, we can
merge this first, rebase the other one and have a much more focussed
discussion.

Change-Id: I4549fb1810c7dd36df8a70983d9508015c2bfadf
2015-02-17 15:03:13 +01:00
jenkins-bot 83cc5ad1ef Merge "Fix TypeError on <a> with no href" 2015-02-17 13:54:57 +00:00
Prateek Saxena 7a51668e56 core: Add missing leading '.' to oo-ui-buttonedElement-button in IGNORE_CLASSES
Follows up I418508fad97e81127084150221e10ccec418167a

Change-Id: Ib3c187feeb8de053416bb3ef131c8f5cfedf0c63
2015-02-17 18:19:11 +05:30
Translation updater bot 8067650cdb Localisation updates from https://translatewiki.net.
Change-Id: Ibd52252ed22fc388e56ef9661eee49eb99a5b229
2015-02-16 21:56:20 +01:00
Thiemo Mättig bf4016ecf1 Fix TypeError on <a> with no href
HTML5 allows <a> elements with no href="..." attribute. We do this in
Wikibase/Wikidata in a few places. Hovering these <a> elements causes
TypeErrors.

This is a hotfix. Please see Ie340648 for a much more advanced fix.

Change-Id: Ib20ef8348c964a6ba736d0fc76909fd4d496c11e
2015-02-12 15:37:37 +01:00
Translation updater bot d229877afb Localisation updates from https://translatewiki.net.
Change-Id: I0034f729f7ed7eb3e4dd9653d635f8c3f780f55b
2015-02-02 22:30:04 +01:00
jenkins-bot daa1a3e0de Merge "Add 'license-name' matching SPDX conventions" 2015-01-31 23:54:08 +00:00
Translation updater bot 895493b638 Localisation updates from https://translatewiki.net.
Change-Id: I14a3f4bd3663cb4bf0e993c7e5e55ef615ca2c9a
2015-01-30 21:52:06 +01:00
Translation updater bot 6f0ae85d8a Localisation updates from https://translatewiki.net.
Change-Id: Id7976975d6c60b15c47087c254219cc53a2a1b59
2015-01-29 23:04:54 +01:00
Ricordisamoa f249d370f1 Add 'license-name' matching SPDX conventions
References:
http://spdx.org/licenses/
https://www.mediawiki.org/wiki/Manual:$wgExtensionCredits#license-name

Change-Id: Ibc434d319c5c9b1f9eddf1427aa9e4db56b7f285
2015-01-29 15:32:09 +01:00
Translation updater bot 60c7bf4ece Localisation updates from https://translatewiki.net.
Change-Id: I37f2e39ab0ea3dd280b429747747c3ef263efa96
2015-01-28 22:38:36 +01:00
Translation updater bot 29203b556d Localisation updates from https://translatewiki.net.
Change-Id: I35df3841cb8c8aa9b07a8e7e993a689f6d003685
2015-01-27 22:16:04 +01:00
Translation updater bot 045c6b9235 Localisation updates from https://translatewiki.net.
Change-Id: I2f8c99b146a7a68be90d114492a5c2a42f2566f2
2015-01-26 22:41:53 +01:00
Translation updater bot 9660b3a3dc Localisation updates from https://translatewiki.net.
Change-Id: I2d10e40dac7ccff1af82b072bd63f0201a787f06
2015-01-25 21:49:49 +01:00
Translation updater bot 7cd79bfdc7 Localisation updates from https://translatewiki.net.
Change-Id: I9f8f9ed05527d9c4d1747324b0abb070b194b62d
2015-01-23 22:29:07 +01:00
Translation updater bot 358ce0c4ff Localisation updates from https://translatewiki.net.
Change-Id: I62c1d653e10ad676a669d3a47a9119e1c4cc373c
2015-01-22 23:23:00 +01:00
Translation updater bot ea2d8db09b Localisation updates from https://translatewiki.net.
Change-Id: Ibfcba0033c9b74cc57378763cf499b3838a81cb9
2015-01-21 22:21:29 +01:00
jenkins-bot 72362616a2 Merge "settings: Add help dialog" 2015-01-21 16:47:19 +00:00
Werdna 4685baed68 Merge "Fix event logging issues" 2015-01-20 22:14:40 +00:00
Translation updater bot 3b516c1c8d Localisation updates from https://translatewiki.net.
Change-Id: If5edebb1e687c4dd2f4b9e7bbbdfcdff425692b4
2015-01-14 22:41:49 +01:00
Prateek Saxena 9c1c62ce05 Fix event logging issues
- Don't prevent the link click event.
- Check with the currentLink element rather than jQuery selectoin.
- Add click handler to images (used to be only extract).
- Stop the 'closePopup' if 'reset' has already been run.

Bug: T86378
Change-Id: I8748ecffe55954425656c5103fa9ddc99b6f3f72
2015-01-13 18:48:02 +05:30
jenkins-bot 7bafa51c02 Merge "Re-position #mwe-popups-svg out of the view port" 2015-01-06 09:14:21 +00:00
Kunal Mehta 697b57b4b3 Use TEXT_EXTRACTS_INSTALLED instead of checking a class name
Change-Id: I4381ea4f7432f2b1d1e945ffadad49e19f3338b7
2014-12-31 15:39:05 -08:00
Prateek Saxena f7d5f890b6 Re-position #mwe-popups-svg out of the view port
This <div> had been sitting visible at the bottom of the page
and went unnoticed till it caused problems with the ContentTranslation
extension.

Hiding it using 'display: none;' causes issues with the masking
of the images, thus putting the div out of the view port.

Bug: T76718
Change-Id: I731128c827aa093e0ffab52dc378aea386b0bb3c
2014-12-29 14:44:39 +05:30
Translation updater bot 4350beabcf Localisation updates from https://translatewiki.net.
Change-Id: Icc3780d12b20976eaa4d21587a7e5cdb83602a3b
2014-12-20 22:26:34 +01:00
Translation updater bot 2ecb7c64f8 Localisation updates from https://translatewiki.net.
Change-Id: Ieb625231f9322ad7b66fd3d7143fc885de0a9028
2014-12-19 22:27:50 +01:00
Translation updater bot d3ac072982 Localisation updates from https://translatewiki.net.
Change-Id: I8be14d53414989a51bb5eda4c2c1ede1d08e5ddb
2014-12-18 23:22:02 +01:00
Translation updater bot e70524f45d Localisation updates from https://translatewiki.net.
Change-Id: I161bc08ea5bdce860c775d172d83352067233e3b
2014-12-16 21:58:03 +01:00
Translation updater bot 9579e1b1ae Localisation updates from https://translatewiki.net.
Change-Id: I98238ac560c2a8531397436ea244d7f6a71820f7
2014-12-14 22:23:27 +01:00
Translation updater bot c98d0ec13d Localisation updates from https://translatewiki.net.
Change-Id: I92bda4631d15b6754879d27ea6a8855e17bc9c6e
2014-12-13 22:35:15 +01:00
Translation updater bot 9455e28bc7 Localisation updates from https://translatewiki.net.
Change-Id: I6ce307ff995c773e510df495f4cb03a0f693ec04
2014-12-03 22:28:56 +01:00
jenkins-bot dbd3f6ff2b Merge "Make ':after' triangle larger so that the border of div is covered" 2014-12-03 15:37:00 +00:00
jenkins-bot eb7fb53baa Merge "article: Fix distance between image and text (landscape image & non flipped)" 2014-12-03 15:36:53 +00:00
jenkins-bot 1b6eaddba0 Merge "Reduce max height of text extract" 2014-12-03 15:33:21 +00:00
Prateek Saxena b24e39e9fc Run mw.html.escape on page extract and title
Add test for XSS attack

Bug: T69180
Change-Id: I213169bd9daed979e63f50cf3926f7196eb6181c
2014-12-01 11:23:14 -08:00
Prateek Saxena 9ab483ec6f settings: Add help dialog
Change-Id: I5f4cf435356748a1aceb05fcaf8c8980b8267804
2014-11-26 11:43:01 +05:30
jenkins-bot 895b6dfae0 Merge "Add rule to not show thumnail if its smaller than the card" 2014-11-23 20:07:41 +00:00
Translation updater bot ba5bbc668e Localisation updates from https://translatewiki.net.
Change-Id: Idc6febd2ef1d48cb3b4409a178ff283fcd9a4b60
2014-11-22 22:41:48 +01:00
Translation updater bot c9b7fb9e23 Localisation updates from https://translatewiki.net.
Change-Id: Ibc3f317e659b2b267653d22f97fec71d47798e49
2014-11-21 22:10:50 +01:00
Prateek Saxena 77538a1001 Reduce max height of text extract
Currently .mwe-popups-extract keeps some empty space after the last
line. This shifts a little when zooming in causing part of the text
of the next line to be visible. Reducing this to have lesser extra
empty space solves the problem.

Bug: 73551
Change-Id: I968fca23fe2de04cb3f73ba4e7d4f676fbf88536
2014-11-20 14:54:14 +05:30
Prateek Saxena 24a7d02080 article: Fix distance between image and text (landscape image & non flipped)
Change-Id: I4fb6891cd89546b6a55b6952be7e1a6df41fa0b5
2014-11-20 11:46:37 +05:30
Prateek Saxena cbebde39b9 Make ':after' triangle larger so that the border of div is covered
When zooming in the border of the div is visible over the :after
pseudo element.
 - Update top and bottom triangle mixins to include @extra argument
 - Update pseudo elements to use the new mixin and position them
   correctly according the extra size

Bug: 73550
Change-Id: I05b9c74a675c69e407c4c78771504f447da754c5
2014-11-19 11:12:12 +05:30
Prateek Saxena 45172f1f7b Increase z-index of hovercards from 5 to 110
Hovercards is currently at 5 z-index which causes
it to be rendered behind the compact personal bar.
Changing this also effects the border triangles and
masked SVGs, thus incrementing them too.

Bug: 72882
Change-Id: Ib3c889c748a9c919754d8281e68fd0664db7c408
2014-11-12 14:39:47 +05:30
Prateek Saxena 0a7d7573fa Add rule to not show thumnail if its smaller than the card
Added two conditions based on portrait and landscape sizes.

Bug: 73009
Change-Id: I022267430b540be48952f0cfc8dc0cf962cd13d5
2014-11-11 10:23:34 +05:30
Translation updater bot 8063da60ab Localisation updates from https://translatewiki.net.
Change-Id: I0f2d2b38e4fa116e3dfc1a90d7b3519ba2fbceab
2014-11-09 21:53:19 +01:00
jenkins-bot ae5493626f Merge "Fix bottom margin issues with portrait images" 2014-11-09 00:05:36 +00:00