Commit graph

1455 commits

Author SHA1 Message Date
Piotr Miazga 75a91cddb2
Allow persisting user without keys/modules
Previously the `UserRepository::persist()` always expected
keys/modules to be present when called.
This patch provides support to persist disabled user.

This solves an issue introduced in
Ibc3df9d6c8beceeff4e11d024acc42cf45e42b28

Change-Id: I92aedf6e09d636b12c61fa15cf4c64055e3a549f
2024-05-04 14:02:02 +03:00
jenkins-bot ed34066e59 Merge "OATHUser: Remove clearAllKeys()" 2024-05-04 08:11:47 +00:00
jenkins-bot 3559c5d7cf Merge "OATHUser: Drop getFirstKey()" 2024-05-04 08:11:44 +00:00
Translation updater bot ee887cc044 Localisation updates from https://translatewiki.net.
Change-Id: I1ee021c7ac2e2da5efff98a70a56e374d769511a
2024-04-29 09:23:49 +02:00
Reedy 44c952e01a OATHUserRepository: Start storing enrollment timestamp
Bug: T242847
Change-Id: I922cdced9d9c73140088f062a23daba6910c8272
2024-04-28 18:43:25 +01:00
Taavi Väänänen 156ee1bfcb
OATHUser: Remove clearAllKeys()
Unused. This was essentially disable() but with more handguns attached,
as it did not clear $module.

Depends-On: Ibc3df9d6c8beceeff4e11d024acc42cf45e42b28
Change-Id: Ic5b50dcba429e3a88561f1c081fb53788c474a0d
2024-04-26 18:11:16 +03:00
Taavi Väänänen 06d3bdafc7
OATHUser: Drop getFirstKey()
Bug: T242031
Depends-On: Id57dd0f37a9f90a492770f6a1de3d8a2f96df944
Depends-On: Iad31b9795eca700b15f6233749846f9f8ce5e89b
Change-Id: I7bbf5f54e97a563940fedaf67904730fac918af4
2024-04-26 18:11:15 +03:00
Taavi Väänänen 0dad2c7031
Fix disabling TOTP keys with scratch tokens
The current implementation of OATHUserRepository::persist() causes every
key to get a new ID when it's saved. This, combined with ::removeKey()
which compares keys by ID, means that using recovery codes to disable
TOTP is broken since TOTPKey calls persist() to mark the code as saved
just before the key is deleted.

In this patch I've chosen to add a new ::updateKey() method instead of
fixing ::persist(). This is more in line with the other new APIs in
OATHUserRepository (namely ::createKey() and ::removeKey()), and is
something I've been planning to do eventually - this bug just made that
a bit more urgent. ::persist() should be dropped once WebAuthn has been
updated too.

Tests are also updated - OATHUserRepositoryTest now updates the key
before deleting it and there's a new TOTPDisableFormTest to test the
entire disabling process.

Bug: T363548
Change-Id: I86ddc8e5bfc9cf74c587ffdff523f559c5a3c08c
2024-04-26 16:29:25 +03:00
Translation updater bot 3a29a04fb4 Localisation updates from https://translatewiki.net.
Change-Id: I87a27b9e255ce1ebe697721e54098c271eb0b7a6
2024-04-26 09:48:44 +02:00
Translation updater bot b607a4ca12 Localisation updates from https://translatewiki.net.
Change-Id: I00ab23e5fa7008721b23a7e3d1e285b12be57494
2024-04-22 09:29:03 +02:00
libraryupgrader 234b047c30 build: Updating eslint-config-wikimedia to 0.27.0
Change-Id: I6a09f8ed73b8ccbf2c7b34d3a9a9dbb4ccbd85f5
2024-04-20 00:07:56 +00:00
Translation updater bot 17c5a48664 Localisation updates from https://translatewiki.net.
Change-Id: Idf7aee7d377095f1f7d09a5db256372495af813a
2024-04-16 09:28:41 +02:00
Translation updater bot 7ab667c848 Localisation updates from https://translatewiki.net.
Change-Id: Id55c523d2759ccab58ac5289eb8406a02e181a3d
2024-04-15 09:28:29 +02:00
Translation updater bot 1f5a32add0 Localisation updates from https://translatewiki.net.
Change-Id: Ib761a8225cee381144506d3f46a0849ee97bb585
2024-04-03 09:24:07 +02:00
jenkins-bot 07ec66f30f Merge "Make the TOTP disable form only remove that single key" 2024-03-29 16:04:52 +00:00
Translation updater bot 47bcb47bd1 Localisation updates from https://translatewiki.net.
Change-Id: I7c4b16b848f6f54ac3e6c5677ef1e47353525ff4
2024-03-26 08:20:20 +01:00
Translation updater bot 13f90ae5c9 Localisation updates from https://translatewiki.net.
Change-Id: I79b47d07b1d06626dfe97be429798b6122a97d47
2024-03-22 08:45:08 +01:00
Translation updater bot 122761032a Localisation updates from https://translatewiki.net.
Change-Id: I3c7d20b4c827deb97a901fe18132a18392f287a9
2024-03-20 08:24:15 +01:00
Translation updater bot 61a4aec40b Localisation updates from https://translatewiki.net.
Change-Id: Iab16dc09b488cab65018af0fdbd076a628b5799e
2024-03-15 08:33:50 +01:00
Translation updater bot c26f57f670 Localisation updates from https://translatewiki.net.
Change-Id: Ia15863b41c36a8a7dcb76e3440e681987f9824a8
2024-03-14 09:03:30 +01:00
Umherirrender bc8a149b89 build: Upgrade mediawiki/mediawiki-codesniffer to v43.0.0
Change-Id: Ieff9fdac7b2235a38090d3ade14201961c845d8c
2024-03-11 20:43:28 +01:00
Translation updater bot f0c05a68c2 Localisation updates from https://translatewiki.net.
Change-Id: I0f494d899389227c29df1fd3d7162265e3a1ab0a
2024-03-11 08:27:36 +01:00
jenkins-bot 8cdbb2fd81 Merge "Make Key objects aware of their database IDs" 2024-03-07 18:41:57 +00:00
Translation updater bot a1f760bac3 Localisation updates from https://translatewiki.net.
Change-Id: Id84d142426e7987d93e925ceb9362295d9f43d8f
2024-03-07 08:49:00 +01:00
Translation updater bot 4712a6b19f Localisation updates from https://translatewiki.net.
Change-Id: I8cd46068efb14a271465ab47f6547423208ccc06
2024-03-05 08:28:00 +01:00
Taavi Väänänen c6a621d31c
Make the TOTP disable form only remove that single key
Bug: T242031
Change-Id: Iad07292cc96537e8ebd72da65e8f1e922cba3eca
2024-03-02 18:53:00 +02:00
Taavi Väänänen c09ec34213
Make Key objects aware of their database IDs
Bug: T242031
Depends-On: I1db9b04a42783b8b64ed69f1f950c794c8659209
Change-Id: I0d8d0a42ce627387949dbbbb32fc318088b3538e
2024-03-02 18:53:00 +02:00
Translation updater bot 18d7b47eb8 Localisation updates from https://translatewiki.net.
Change-Id: I77923a3d36dce004d1d3d38c001c4be4527f787e
2024-03-01 08:33:43 +01:00
Translation updater bot d1c092d4b9 Localisation updates from https://translatewiki.net.
Change-Id: Ifc24ebd2f00034f7d2baf9b9278c5e40b5c28f24
2024-02-28 08:14:41 +01:00
Translation updater bot 4ba333f051 Localisation updates from https://translatewiki.net.
Change-Id: Id4b9faef37f71eb38dd4e37ebdfd2baa97d94bac
2024-02-26 08:36:39 +01:00
Translation updater bot f85f5fa29e Localisation updates from https://translatewiki.net.
Change-Id: I904a48c25cf7b47662c48ce85955700b84a84824
2024-02-23 08:44:56 +01:00
Bartosz Dziewoński 9066046876 Use OutputPage::setPageTitleMsg() instead of ::setPageTitle()
Bug: T343994
Change-Id: Iac7ed4ab0bc1700b473d34141565c08ddbd9d860
2024-02-17 02:59:08 +01:00
jenkins-bot 7557758ab1 Merge "build: Updating dependencies" 2024-02-12 19:53:42 +00:00
libraryupgrader 9978022cf6 build: Updating dependencies
composer:
* mediawiki/mediawiki-phan-config: 0.12.1 → 0.14.0

npm:
* grunt-banana-checker: 0.11.0 → 0.11.1

Change-Id: If58b7ba9a8773b55ef43df7562aeb55debe8bdd8
2024-02-12 18:57:35 +00:00
Translation updater bot 88f97dc70a Localisation updates from https://translatewiki.net.
Change-Id: Ic0e3ee6ba8cdcaa2e3ce30f47b3de9a71cb65ecc
2024-02-12 14:50:13 +01:00
libraryupgrader d43a9a492d build: Updating eslint-config-wikimedia to 0.26.0
Change-Id: I886d037d2a64a9f17712a030429c62feaed1d5af
2024-02-09 08:36:11 +00:00
libraryupgrader 3a8f411d61 build: Updating npm dependencies
* grunt-eslint: 24.0.1 → 24.3.0
* grunt-stylelint: 0.18.0 → 0.19.0
* stylelint-config-wikimedia: 0.15.0 → 0.16.1

Change-Id: I93ecbb39b13c8482c909a2645e06980811728a0e
2024-02-07 20:54:36 +00:00
Translation updater bot a5224cfd3c Localisation updates from https://translatewiki.net.
Change-Id: I7da1ddd40dec212e6aa254941945df5b838c2de8
2024-02-07 08:27:17 +01:00
jenkins-bot b1dd354958 Merge "build: Updating npm dependencies" 2024-02-06 19:04:21 +00:00
libraryupgrader 3886709bb6 build: Updating npm dependencies
* eslint-plugin-compat: 4.1.2 → 4.2.0
  * https://github.com/advisories/GHSA-c2qf-rxjj-qqgw
  * https://github.com/advisories/GHSA-c2qf-rxjj-qqgw
  * https://github.com/advisories/GHSA-c2qf-rxjj-qqgw
* postcss: 8.4.19 → 8.4.33
  * https://github.com/advisories/GHSA-7fh5-64p2-3v2j
* semver: 6.3.0 → 6.3.1
  * https://github.com/advisories/GHSA-c2qf-rxjj-qqgw
  * https://github.com/advisories/GHSA-c2qf-rxjj-qqgw
  * https://github.com/advisories/GHSA-c2qf-rxjj-qqgw
* word-wrap: 1.2.3 → 1.2.5
  * https://github.com/advisories/GHSA-j8xg-fqg3-53r7

Depends-On: I8ec574a833a337bda84244cf38fbb870768cd89a
Change-Id: I4fd9b9b58bdc4cd275677c3fbb644ebcf3fcf325
2024-02-06 18:24:09 +00:00
Translation updater bot da91ad68fb Localisation updates from https://translatewiki.net.
Change-Id: Ief6fefd23e4d8fd09f68fa3ec42e8b29bfe812a0
2024-02-05 08:50:11 +01:00
Translation updater bot 293030387b Localisation updates from https://translatewiki.net.
Change-Id: Id355dac62b0ffc2f5d438db260d469d84386bfd1
2024-02-02 08:53:55 +01:00
Translation updater bot 141f3e57f9 Localisation updates from https://translatewiki.net.
Change-Id: I001123e55b055dac6161f5cbae830d41dd0234ed
2024-02-01 09:02:52 +01:00
jenkins-bot 433e3b2f2f Merge "Add return type hint to functions in ServiceWiring.php" 2024-01-31 19:36:47 +00:00
Umherirrender a6c3d2a16d Add return type hint to functions in ServiceWiring.php
This is a common pattern for serivce wiring functions

Change-Id: I4b4fad8ac28108e53300231b3812426e82ccf84f
2024-01-31 20:08:46 +01:00
Translation updater bot 30814a78d0 Localisation updates from https://translatewiki.net.
Change-Id: I7233e9f7d84ad2c995b9630f93987757330a381a
2024-01-30 09:39:30 +01:00
Translation updater bot 6547a3d836 Localisation updates from https://translatewiki.net.
Change-Id: Ic793fba28d39546d3bcead40b044cfda416df8d2
2024-01-28 16:07:37 +01:00
Umherirrender 2222799fa4 Stop writing to tablesUsed in tests
Bug: T351733
Change-Id: I0cefa7108296cbf2cd6221d2457396ab30a320fa
2024-01-20 12:38:26 +01:00
Translation updater bot 58db958f5c Localisation updates from https://translatewiki.net.
Change-Id: I7868935b638f3255a36af74d4232dd8e517b9b7d
2024-01-19 09:17:34 +01:00
Piotr Miazga 14a19b0379 OATH validation is available only to named users
Bug: T326925
Change-Id: I963099aeb37c52fec54c0e19731f8cce11723093
2024-01-17 19:11:10 +01:00