* From Feedback: The {smallmatrix} example has its fences wrapped in too many mrows I think, so it renders without stretching them in both Firefox and Chrome. Ideally you should be able to emit the <mo>(</mo> followed directly by an <mtable>, and trailed by <mo>)</mo>, and only wrap those 3 into a parent <mrow>.
* removes mrows and adds OPEN / CLOSE attributes
* tests MMLFullcoverage 194 to ~196 which cover the bigXYZ macros look
ok
Bug: T348971
Change-Id: Ie444e5bb3e3f87fac915d2692b69e976d721582e
* From Feedback: There is a curious use of <mstyle> around spacing elements, as in <mstyle scriptlevel="0"><mspace width="-0.167em"></mspace></mstyle>. I am not sure that wrapper element is needed? The mspace ought to be successful standalone.
* this is in the 'bmod' case
Bug: T349822
Change-Id: I9229ad73891d5000679761d3d4b2028d4a51ddf1
* rollback some previous changes for ce env in Parserhookhandler
* some minor fixes for feedback in previous commit
* set tex mode for mhchem preprocessor, since MediaWiki Hooks add
explicit ce tags: i.e. frormula coming to TexVC look like
"{\displaystyle \ce{ C6H5-CHO }}"
Bug: T348975
Change-Id: Id06852b030f9ea77f016289d4f9e2258d5a9f0d4
* currently, \begin{align} generates <mtable columnalign="right" but it should be <mtable columnalign="left"
Bug: T348791
Change-Id: Ic0df45aba4fdb6ffbdc790b5e4bc56e7daeca802
* updating the braces since mkern, mskip etc are Fun1 functions in TexVC
* updating TexVC support flag in test
* added macro longrightleftharpoons to rendered cases
* nearly all tests render correct in HTML now
Bug: T329620
Change-Id: I78da466c88d41f794e81f7222c9a67c3f4d482d2
* fix maintenance script in parametrization for generating correct
reference MathML
* update MathML references for MMLmhchemTest
* and update the reference formulas, which not display MathML correctly
* tests which have math enviroment switch (which is currently not defined) are currently skipped
Bug: T329620
Change-Id: I09f2c393880daa8fef3e2763821df59048c3c98c
* Remove \strokeint which was probably a typo and should be \strokedint
* Add \intBar command
Not done:
* Implement rendering of \intBar and \intbar, it would make sense to wait for
the mathoid reference rending here, which is just around the corner
Bug: T137787
Bug: T348373
Change-Id: I19d24fc23f59dda87c7c39a265f17efddb9fee8f
* defaults mathchoice to displaystyle
* adds several tests and introduces new Fun4 element for mathchoice in
grammar
Bug: T340024
Change-Id: I37c8fd35303e3b8a00faad18a3a131a716c7bb47
* adds the recently implemented cases for mhchem specific tex to check full macro coverage
* fix a minor issue with tripledash
Change-Id: Id3033fab7b3c3432bed6e11f7b50f7ff8e3906ea
* "\ln c, \lg d = \log e, \log_{10} f" : c d etc should have be more extra space
* "\Pr j, \hom l, \lVert z \rVert, \arg z ": same as above, specifically for \hom
* fixes expected result in LocalCheckerTest
Bug: T315978
Change-Id: I842b45b2d20dc267d828dca2040a3500ce06f45d
* All recognized macros are in category nullary macros, so this adds a
rule
* In test "\bigcap_{i=_1}^n E_i"
* In test "\bigcup_{i=_1}^n E_i"
Bug: T315978
Change-Id: I09287879c1448e404473891985457349a62554a7
* Test example in MathNativeTests: " "\not\operatorname{R}"
* fixed forwarding state in Fun1nb
Bug: T315978
Change-Id: Ia651b14ba16f39cc8cbc6b42e0598d959bf72989
* In test MathNativeTests: "\sum_{k=1}^N k^2"
* also verify that textstyle variant works correctly
Bug: T315978
Change-Id: I8f6cd5ef1e4539616439542184cb7d9dc5cf2363
* also fixes a warning in phan that there is a tainted parameter in args in BaseParsing
* this is to pass CI
Bug: T343636
Bug: T347320
Change-Id: I91328bf26e208bd4e0e939c4628def2f40e2f0b6
* In test MathNativeTests: "\underbrace{ a+b+\cdots+z }_{26}"
* Underbrace statement appear to right side
Bug: T315978
Change-Id: I3b1e1290ac07e7aa70ab5931d513984f011d3075
* Pilcrow was very big, see test on MatTestNative page:
* " \amalg \P \S \% \dagger \ddagger \ldots \cdots "
* and add specific testcase
Bug : T315978
Change-Id: I3074f3782ef821e7f9813b79a570bbd51ead28db
* mhchemParser v4.2.2 in Typescript was used as blueprint for this:
* https://github.com/mhchem/mhchemParser
* The mhchemParserPHP component tests can be run locally on a machine with PHP without MediaWiki-Environment with the MMLmhchemTestLocal.php
* For the tests it is probably only necessary to review the json files (Mhchemv4mml.json, Mhchemv4tex.json).
* src/TexVC/MHChem/MhchemParser.php contains the basic functionality, Patterns, StateMachines, Texify functions are located in dedicated classes
* added extracted mhchem commands which have intermediately have been introduced to the
texVC(PHP) grammar
Change-Id: I8cc3d04937b93339e352adc95c85a8a178b8825f
Bug: T329620
The VisualEditorFullRestbaseURL config variable is no longer used by
VisualEditor and is no longer set in Wikimedia production
configuration.
Bug: T344458
Change-Id: Ifd0b9f919f7a9bdceb8761125588fe72e8d1e50c
The use of "HookHandlers" attribute in extension.json makes it possible
to inject services into hook handler classes in a future patch.
Bug: T263364
Change-Id: Id8d9d0dcc6bb6ab60c5df3074803d132393415e9
Add a config option to enable passing special macros needed to
handle the output from the mhchem texify process.
Bug: T340023
Change-Id: I3553931c252184b54e7a13938e030825e5d45e59
It needs a database connection to create the user, which is unnecessary
here.
Depends-On: I80723b886b2b5a5d75cbb73571e1b19ea4a09af5
Change-Id: I260b8ca433733b7754616e6e24778935597981a5
texutil.json exists twice with identical contents in
test and main sections.
Delete the redundant copy in the test section and access
the main file in tests.
Change-Id: Ie1eba9ed599d6826f1efe2d37bf8370f8e9dd036
The test doesn't need to depend on what extensions are
available/installed. Also pass the test config more explicitly to
ServiceOptions.
Needed-by: I0a04c82250582fed7a66c1e10868d9b4f3823a28
Change-Id: Id2587fe7d31fcd652c26e5dd0a8cfcae3161efcc
* Cache results for checked tex and MathML string in one cache.
* Remove access to parsetree
* Introduce run method to speed up service wiring
Note that the indirection table used in previous versions was
abandoned here. texvc does only little unification's of the
input string so that it is not expected that the overall savings
in space and compute time warrant the additional table.
Change-Id: Ib9ce3d2ab02bd9a2a0f9926db6b937435b7e5458
In preparation for caching we store the MathML fragment returned by
local checker. The rational is that the string serialization of the
parse tree is better chachable as the parsetree.
Change-Id: Ice2ef1f4f7b83ed187507d4d067f446603d0d6a5
Introduce new classes for checked exceptions, and use SPL exceptions
for the unchecked ones.
Bug: T328220
Change-Id: Ic44463e910911afe6395c38fd2f59b9bfa02a4f0
Remove additional /v1 when computing internalRestbaseURL from
virtualRestConfig as this will be added in getUrl in MathRestbaseInterface.
internalRestbaseURL was introduced in I2fbc441955a1fe417f264f31f3729ce0715f7f16.
Bug: T334842
Bug: T338381
Change-Id: If2719fb9106e1414ce8814a2fbafa5dcedb84e39
createMock is not a static function (like atLeastOnce)
It is easier to spot that this needs a TestCase when using $this
Change-Id: I6b738e31f43fd7ee2ecd608d0bb853a3ebac3121
This new MathInternalRestbaseURL setting allows the internal URL of
Mathoid to be configured directly, instead of relying on
VirtualRestConfig.
This patch moves the fallback logic for the internal and external API
URL into an extension registration callback. This way, we can keep the
application logic simple, and we can issue config warnings that will
cause the updater to fail, forcing wiki owners to update their config.
Bug: T334842
Change-Id: I2fbc441955a1fe417f264f31f3729ce0715f7f16
Add test case for getType() method.
This will improve the code coverage for this method from 0 to 100%.
Add test case for getTex() method.
This will improve the code coverage for this method from 0 to 100%.
Add test case for evaluateRestbaseCheckResponse() method.
This will improve the code coverage for this method from 0 to 100%.
And covers getIdentifiers(), getWarnings(), setErrorMessage(),
methods from 0 to 100%.
Change-Id: I6bdb6919126e5488838d4fba53eb2f74c89ee63d
This fixes the problems with If208753edfdb301 which was reverted
and adds a new test.
Bug: T335347
Co-Authored-By: <rrana-ctr@wikimedia.org>
Change-Id: I7ddb7b294cbccc4dab42e286fc270f438385bee5
This add new function named "getMultiHttpClient" to the
MathRestbaseInterface.
The function creates a MultiHttpClient object using the HTTP
request factory.
This function will be useful for making HTTP requests to Mathoid.
Add test case for getUrl() method.
Bug: T335347
Change-Id: If208753edfdb3017f722c97cea7653170d05f8a5
In native MathML we only display MathML, also get
rid of enclosing <div / <span container.
Bug: T182041
Change-Id: I26bc4ea88d360d53cc7a34a89bef78812b84b2ea
* contains a minor fix for spacings, so that they are rendered by spacer
* and some minor fixes for section sign
* MMLFullCoverageTest cases: 216
Bug: T327391
Change-Id: I124e7aec5552dec98a8292e5bdb9449a3009560a
* escaped semicolon/commas get rendered as spaces, non escaped get
rendered as text
* MMLFullCoverageTest cases: 4,5,66
Bug: T327391
Change-Id: Icfa557fc43a8ac87fbf856795cb9c26d0fb2c456
* indices in FullCoverageTest: 58,59
* fix a minor issue with less and greater signs to escape case 58
correctly
Bug: T331998
Change-Id: I29265f7954552423924dfc898fd36ec1b387e198
* example "\sideset{_1^2}{_3^4}\sum"
* case 3 phabricator "sideset"
* index: 90
* since result has multiscripts which is not generated by mathoid, there is an explicit test in MMLRenderTest and the previous test is in MMLTexVCUtilTest is skipped
* in MMLGenerationTexUtilTest test for sideset is deactivated
* adds a case from FullCoverageTest for sideset with FQ
* fixes an issue which occured during Phan checks for merging that genFrac throws an error
Bug : T327391
Change-Id: I4c5a5f5a901dbc906f5a1b168d3a8d04f25b9290
* example "\definecolor{ultramarine}{RGB}{0,32,96} a {b \color{ultramarine} c} d"
* case 2 phabricator: "colors"
* index: 22
* some test for parsing color statements
Bug: T327391
Change-Id: I98fdf011a2089dad4e7cb5a7a6aa8433fafe4a94
In perparation to the PHP only native MathML rendering mode, we expose
the parsetree of the checker.
Change-Id: I8da8d0e236c2b001e664ce707c7469ebe8a91eb8
* fix the testfile so it can be read correctly for texvctreebugs category
* fix the test that category can be selected dynamically
Bug: T327391
Change-Id: I51508bddb83ba925c739962df41c04f1ccfd311b
* some adaptions to test and comparator
* minor fix in mappings for ncong
* introduce a LaTeXML Fallback for the tex-cases:
** "\ce{\ca}"
** "\mod"
Bug: T327392
Change-Id: Ie2efa392bd517a28fe8b6e8d0cecdba64cd1c415
* For MMLGenTexVCUtilTest and the MMLComparator
* Also skip some inputs which are not supported
Bug: T327392
Change-Id: Ifac913e2b8e4c70c7222f769c0e7cf93e65de5b8
* Update maintanance script with Chem-Fallback
* delete obsolete MML Lookup (was from mathjax-full)
* TexUtil-Ref is created without chem fallback
Bug: T327388
Change-Id: Id603d66feccf3716828c2aac57acac7d23131ddf
* For the existing MMLGeneration...Tests, reference MathML has been generated
for mathoid and latexml within reference files in json.
* The creation of json files was done with JsonToMathML script
* The test-classes have been adapted a bit, so they can read the new reference files.
* MMLGenerationTexUtil test has export function for input
for maintenance-script for
Bug: T327388
Change-Id: I05a8c7bb5e37cf75faf09ec43e9ce2acc7bf2040
* Implemented multiple-column generation for the HTML-Generator
* Items can be skipped in test by defining index
Bug: T327386
Change-Id: I13148d58246ddcc1f2e6dcd14fa5b4255a1fb8e7
Avoid that user input is passed to the HTML output directly by using
HTML methods for tag generation. This also enables additional phan checks.
Change-Id: Iff584ac829c190e413a36331c53d6835a86bc0d5
* Currently the regression test only tests if all formulae that passed the test before still pass the test
* This change also compares the output
Change-Id: Ib667de2e7e512cf7d045e28a19c6a5f7d994dfc6
* Uq and Dq was mixed
* Simplify regeneration of grammar for node developers
* Speed up npm test by ignoring local test json files
Change-Id: Iec273dcc967be46d3df52260fc56f1969667e497
* the php implementation had fewer curlies compared to the
js implmenetation
* remove unused function name (could be replace get_class)
* Add testcase for declh
Change-Id: I8132604a659d7ddf98e1f73686b40ff0591229f3
I compared with
6c6988c4f6/lib/astutil.js
and found two mistakes:
* Missing space at the end of the color regex.
* Not enough backslash escaping in the last regex.
Note how the code in lines #116 and #130 is now identical.
Change-Id: I13b75ad4a1e4da0766c0d73b8786b21865945697
Positive as well as negative tests. This patch intentionally doesn't
touch the implementation but simply documents how the code currently
behaves.
Change-Id: Ib670ad680087e520f4a99e932e5a2a9fd2d115de
Personally I find this easier to read. It allows to maintain a compact
list of input values with the expected output.
Change-Id: Ifeb532e2b94c674b512b3c40f101977939b83cd5
We fixed this in I47b6d5b but broke it again in Ie8d8106. Let's
finally add a test for this edge-case.
Change-Id: I9a43518f9edf0fab05e76bbb02a30fefd039b77d
Some notes:
* Note that array_column() strips array keys. I checked and this is
fine here.
* Html::element() will skip attributes that are set to null or false.
Perfect fit here.
* I routinely remove comments that do notjing but repeat what the
code already says.
Change-Id: Ie7797b78f1af5d8404c9e97b333fac8c6b3ac85e
