Commit graph

356 commits

Author SHA1 Message Date
physikerwelt 5713e1966e Fix rendering of underOver
We recently changed the internal treatment of macros
 to include the `\` in the macro names.
The respective code checked if the macro name had the letter 'o'
 at position 0. Now, this is position 1.

* Check for the entire start of over
* Output an error if the macro name does not star with under
  or over
* Remove dead code

Bug: T382196
Change-Id: I8eefd41e27319c8dbb05900ef2581ce4d548d4fe
2024-12-16 12:06:45 +00:00
jenkins-bot 90faa5ef0c Merge "Replace uses of deprecated ParserOutput::getText()" 2024-12-04 03:38:52 +00:00
Isabelle Hurbain-Palatin ace0b1412f Replace uses of deprecated ParserOutput::getText()
Bug: T293512
Change-Id: I966b0bcac5b5a9ae09f8243dd1fcee2e7c731515
2024-12-01 17:24:17 +01:00
physikerwelt 0781935316
Fix: Don't render ' inside LR structures
$\left(a\right)'$ produced rendered MathML output that
looked like $\left(a'\right)'$.

* Remove the deriv (') state when rendering the element
within the brackets.

Bug: T381102
Change-Id: Id7f192c1f6b7bf4109e735e393e2546e5a39efd7
2024-11-29 01:13:15 +01:00
physikerwelt 4743a5fe24
Fix: handling of AMS macros
In I94887f6ccb45072180a318776ae96aead8658a18 some ams macros were
 not taken into account.

Add \ to respective AMS macros.

Bug: T380184
Change-Id: I7c59569fb7242f4f6123047003de6cc86ce868ea
2024-11-26 00:34:12 +01:00
physikerwelt eb3fe78fc5
Fix: handling of named operators
In I94887f6ccb45072180a318776ae96aead8658a18 named operators that render
 as their tex command e.g. \gcd -> gcd, were not taken into account.

Remove additional \ in operator names.

Bug: T380184
Change-Id: If21cbd091cc9437715b10e3e6e7ffc86d6436010
2024-11-26 00:20:47 +01:00
physikerwelt cfe15c59b1
Fix: handling of array
In I94887f6ccb45072180a318776ae96aead8658a18 the array environment was missed.

Add the array environment in the same as matrix was added.

Bug: T380184
Change-Id: I92111829e7e93bc5abd40e01b6c036bbc01ee8a5
2024-11-25 23:24:25 +01:00
physikerwelt 4014491c39
Fix: handling of nullary macros
In I94887f6ccb45072180a318776ae96aead8658a18 nullary macros
such as $\AA$ were missed.

Instead of adding a backslash (cf. patch set 1) we move the
functionality to texutil.

Bug: T380184
Change-Id: Ie9947b48f03dac03612a5c33bce92bf00df70aa3
2024-11-25 23:21:03 +01:00
physikerwelt 0458ea160e Parse row height specification in multiline environments
* Transform structure rich information on LaTeX length
 specifications introduced in I08996129beca9ad852d23f28d7136c982707aea1
 into new TexNode class
* Adjust rows, i.e., arrays to hold length information
* Add tests

Bug: T380654
Change-Id: I1aff53c7a5782c1333ed4c16639dfc660802931c
2024-11-25 14:22:15 +00:00
physikerwelt b758ae9d70 Extend MathML test coverage
Render all formulae from Wikipedia and make sure no errors
(that end up as wikimedia production errors in logstash)
are thrown.
Check that no merror tags are generated for the manual page
that intends to cover the full spectrum.
Currently, some merror tags are generated, which we ignore
for this commit.

Change-Id: Ifecbd8a1b0afabaa2f818e9241add92a9508bae9
2024-11-25 10:43:13 +00:00
physikerwelt e0acf58460
Move cancel callbacks to texutil
Currently, information regarding individual LaTeX
macros is distributed in various files. This is the
first to attempt to collect declarative information
regarding tex macros in the texutil.json file.
As a proof of concept we start with only the cancel
macros.

* Adjust texutil tests so that whitespaces are allowed
  in the payload

Change-Id: Iba2dfd5293ad96d8d8e4e2f555c8df9d1ae4d6ca
2024-11-22 21:43:31 +01:00
physikerwelt 6a46f2813c
Add tests for AmsMappings
Change-Id: Ia4fbba3cda087b17587a953a6c01c6fae2fe2b64
2024-11-21 23:01:09 +01:00
physikerwelt d68c302b71
Add tests for BaseMappings
Change-Id: I017815230c2709ef5933256ba430b5284022637f
2024-11-21 22:37:45 +01:00
jenkins-bot 44243ad466 Merge "Overwrite spacing for divide" 2024-11-14 09:13:21 +00:00
jenkins-bot fb4e72d64c Merge "Treat ! as operator" 2024-11-14 09:13:19 +00:00
jenkins-bot 0bfd22b57b Merge "Don't stretch delimiters and operators when used as literals" 2024-11-14 09:11:45 +00:00
jenkins-bot 5fbcff7819 Merge "Treat colon as operator" 2024-11-10 21:43:02 +00:00
physikerwelt 758f9c987a
Overwrite spacing for divide
This overwrite should be removed once this is the
default in all browsers.

Bug: T375337
Change-Id: I5ab133f0368ed6eef94b0a87281bb9129fca406c
2024-11-10 16:45:23 +01:00
physikerwelt 5cde747b49
Treat ! as operator
Bug: T375935
Change-Id: Iec8e69d28fa3cc32b2c2e87f81707b9fd7af5576
2024-11-09 08:05:22 +01:00
physikerwelt aee95695b8
Don't stretch delimiters and operators when used as literals
* Adjust tests

Bug: T375959
Change-Id: I02de8244b73c4b98a1467011a0035df059917c13
2024-11-09 08:04:24 +01:00
physikerwelt fcb667f733
Treat colon as operator
Bug: T375974
Change-Id: Ia553e77a04edfee12fa0f236375d67a88eefee67
2024-11-09 06:33:07 +01:00
jenkins-bot a7f8306d18 Merge "Remove menclose in cancel rendering" 2024-11-08 07:27:47 +00:00
physikerwelt cc0a214f56
Remove menclose in cancel rendering
Chrome and similar browsers do not support the
menclose tag. This change introduces a css polyfill
suggested in

https://github.com/w3c/mathml-core/issues/245#issuecomment-2410676518

but keeps the mencose rendering since FF does not
support the polyfill

https://bugzilla.mozilla.org/show_bug.cgi?id=1929800

Bug: T376829
Change-Id: I860e2f2f9bf9eef8eeba35b0999ec50175fdfc4b
2024-11-08 07:58:08 +01:00
physikerwelt 775fec5450
Treat \operatorname as a valid operator for limits
* Extend logic for checking for valid operators
* Add tests

Bug: T365170
Change-Id: I4d3762e3258c78ac5fae8b923f12aabcd2175f3d
2024-11-06 23:04:13 +01:00
physikerwelt 63b47f21ef
Add mathfraktur rendering for chrome
Chrome and similar browsers do not support the
mathvariant attribute that can be used to change
math fonts conveniently. Like for mathcal there is
a table that can be used to translate from latin
to mathfraktur chars.

Bug: T378433
Change-Id: Id8c3e121ed104ba3f08329b4151a7e3bec699754
2024-10-29 11:30:51 +01:00
physikerwelt dab5364b31
Use cell based table rendering
* Add hline search in matrix construction:
** This avoids a second scan later for the cost of some
   memory overhead
* Parse | in array column specification
* Add CSS based table lines as done by TMML, cf.
https://github.com/w3c/mathml-core/issues/245

Bug: T377167
Change-Id: I6e29b47b1731638ea9b06de3006ce2834e4f0c68
2024-10-29 05:48:34 +01:00
Andre Klapper 5c6bc704a2 Use explicit nullable type on parameter arguments (for PHP 8.4)
Implicitly marking parameter $... as nullable is deprecated in PHP
8.4. The explicit nullable type must be used instead.

Bug: T376276
Change-Id: Idcd0b50c1c01a33c4cabeed3e31828f77c3f6443
2024-10-26 15:15:30 +02:00
Umherirrender 7038c68f13 Use namespaced classes
Changes to the use statements done automatically via script
Addition of missing use statement done manually

Change-Id: I4cf7903b9700e6366bdf349f99ffd4a04da0c087
2024-10-20 09:27:34 +02:00
jenkins-bot 9c9c20e09e Merge "Use munder instead of msub for large operators" 2024-10-16 12:38:21 +00:00
jenkins-bot 188d13ca64 Merge "Squash literals in operatornames" 2024-10-16 12:18:09 +00:00
jenkins-bot 3c4141423e Merge "Add missing apply after operatorname" 2024-10-16 11:32:32 +00:00
jenkins-bot b236403991 Merge "Use the same formatting for align as MathJax" 2024-10-16 08:56:42 +00:00
physikerwelt 87632766e0 Squash literals in operatornames
Chains of single letter mi elements are rendered with no
space but one mi element with multiple letters gets
space. For example, the operator log will be translated
to <mi>log</mi> rather than <mi>l</mi><mi>o</mi><mi>g</mi>
as done by wikitexvc.

* Squash literals into single element, iff they don't
contain commands

Following the implementation of the literal rendering
it seems that all literals with special behaviour have
a command.

Bug: T375861
Change-Id: I97adf5f5132180503cbeb59d32fdb8d45b08aaa7
2024-10-14 16:02:17 +00:00
physikerwelt 9a27d92c09 Add missing apply after operatorname
* Reapply the logic of \log rendering to \operatorname
* Deduplicate applyFunctionDetection

Note this still does not solve the rendering problem for
operator names with more than one letter as these generate
mrow elements with single letters. Those are not rendered
with space in FF.

Bug: T375861
Change-Id: I913d865b49d5894a63c8b9d244768f9bb1df4e28
2024-10-14 16:01:56 +00:00
physikerwelt 87f0315812
Use the same formatting for align as MathJax
* Copy the default mtable attributes from MathJax
* Adjust the test

Bug: T348791
Bug: T375317
Change-Id: I274577e320056c1ac3a1f74cbc61941184afd61e
2024-10-14 17:59:19 +02:00
physikerwelt ec44827976
Use munder instead of msub for large operators
* Add new class to identify what a (large) operator is
* Add some IDE hints about what methods exist in texutil
* Add tests for operators in display and block style

Bug: T375907
Change-Id: If734f194cd8fa30efaf6d8c8d89f85e3e1c96276
2024-10-13 21:13:56 +02:00
physikerwelt 602043027d
Implement basic column info parsing
* For each letter l c or r that is found in the
  column spec the respective mtable alignment
  information is passed
* if the align information is given externally
  the info will still be ignored

Bug: T376838
Change-Id: I3113f933502df2109b066959e4d001736dbae6e6
2024-10-13 00:55:57 +02:00
physikerwelt ca10252923
Add \| to list of special operators
Bug: T376546
Change-Id: Ibf57c995c2381fea095600c31ce6432a1e8fd4fd
2024-10-05 23:00:34 +02:00
physikerwelt 0e9d89b03c
Fix: Add missing latex length units
Reorder according to
http://latexref.xyz/Units-of-length.html

Bug: T375295
Change-Id: Iab54bcd3f91e0e473c34869418a1e587c2518c0c
2024-09-27 14:00:44 +02:00
physikerwelt ff1536d1f9
Ignore length specifications after linebreaks
In LaTeX line breaks in matrix elements
have an optional argument that controls
the vertical spacing between the current
and the next line. For example,

{\begin{aligned}a\\[6pt] b\end{aligned}}

generates a 6pt space.

This was never implemented and ignored by
mathoid.
The native MathML implementation is unaware
of the optional argument and just prints it
to the next line.

* This commit ignores the input on the grammar
side.

Bug: T375295
Change-Id: I08996129beca9ad852d23f28d7136c982707aea1
2024-09-22 20:22:52 +02:00
physikerwelt c9f7d9131f
Simplify parsing of mediawiki_function_names
Just convert mediawiki_function_names to the respective \operatorname construct.

Bug: T375274
Change-Id: Ie374524dbdf6a753063172fb88e6f60e91b9212e
2024-09-21 00:57:23 +02:00
physikerwelt db81c96062
Fix heuristic that adds bold-italic
As indicated in the comment the code intents
to add "additional italic mathvariant
when bold already". However, effectively it
always added an additional -italic when
any mathvariant was given.

* Only add '-italic' if mathvariant is 'bold'

Bug: T375244
Change-Id: Iafb375753a98ff41c3d076819288345a9e2efb0c
2024-09-20 08:59:27 +02:00
jenkins-bot 3652e8697e Merge "Make native MathML rendering default" 2024-09-17 10:46:54 +00:00
physikerwelt 8cce9d88c1
Make native MathML rendering default
* Add native to default valid modes.
* Remove old Mathoid mode from the default valid modes.
* Set native as the default choice, replacing Mathoid.
* Adjust fallback mechanism.

Bug: T373705
Change-Id: Ie6412623577e3f954c1302417d1b1b667f88863e
2024-09-17 11:21:03 +02:00
thiemowmde cd4ce78d31 Make use of actual @dataProviders in tests
Instead of manually crafted $this->testCase properties.

Also make use of the dedicated PHPUnit feature to mark as test as
passed. While assertTrue( true ) is a very common hack it can be
confusing.

Change-Id: Ic071bf561929c2a79537111bee18631865f91366
2024-08-31 11:49:04 +00:00
Umherirrender 419ce56d27 Add missing documentation to class properties
Add doc-typehints to class properties found by the PropertyDocumentation
sniff to improve the documentation and to remove the exclusion of the
sniff.
The activated sniff avoids that new code is missing doc-typehints or
real-typehints.

Change-Id: Id7fcfd086cdbb3f040091e1d1a81472e7a524091
2024-08-31 11:48:46 +00:00
Umherirrender 3e37c4e5a0 tests: Remove unused class properties from AllText
Change-Id: Id1864671a653777d6957593eddf65398eaad183b
2024-08-25 14:19:37 +02:00
thiemowmde 10e2e17bb1 Remove unused return values from MMLTestUtil
Just removing unused code that never did anything. Note this is only
in a test. As long as all tests still succeed this can't really cause
any problems, I believe.

Change-Id: I272803353eed9de0ecf98c55b75710df16da2c44
2024-08-12 08:50:22 +02:00
Fomafix 363abd4afb Use overrideConfigValue instead of setMwGlobals
Change-Id: Id53db757cf0c2f0601cc34a9403edf3bbb1f7298
2024-07-24 16:22:59 +00:00
Umherirrender 049a747143 Use namespaced classes
Changes to the use statements done automatically via script
Addition of missing use statement done manually

Change-Id: Ifcc9113bc1d2cf79d21871abe7652d7ed8dde20a
2024-06-09 18:48:28 +02:00