Commit graph

851 commits

Author SHA1 Message Date
Arlo Breault 0c88ab1abd Use Parsoid's extension API's getExternalLinkAttribs
Depends-On: I31a8c6a9bb2741899d5445c3457fd424e283397b
Change-Id: Iaf8531a37e8d9d3ce1bece9ab3086e5967dca08f
2024-03-04 18:00:04 -05:00
jenkins-bot 4b0aa6c502 Merge "Revert "Filter out null external link attributes"" 2024-02-16 16:19:19 +00:00
Gergő Tisza b5f8605406 Revert "Filter out null external link attributes"
This reverts commit 760641e180.

Reason for revert: it was a quick fix, has been fixed properly in core
instead in I907c22ef070616d81b9a50b0e807a7b8f78b59b5.

Bug: T357668
Change-Id: I4ec440c1e326419a8be5457b79c5374316755a53
2024-02-16 15:34:54 +00:00
Arlo Breault 4d19d19f1d Fix matching external link rel
Introduced in I8d7bdf1bccc869b4dc17058a5822ef34968471e6

Change-Id: I52a8a993fbdd4058d40f4aeac3df37e90e686f3e
2024-02-15 21:24:59 -05:00
Gergő Tisza 760641e180 Filter out null external link attributes
Follows up If4880e4e0b3cd2056521d44baf261ed848511bcd.

Bug: T357668
Change-Id: Ifec733a923f193b72eaba9a1e604ad4e56c0aef2
2024-02-15 21:24:59 +00:00
libraryupgrader 466e3ce2ec build: Updating dependencies
composer:
* mediawiki/mediawiki-phan-config: 0.12.1 → 0.14.0

npm:
* grunt-banana-checker: 0.11.0 → 0.11.1

Change-Id: I2204fa77216852b0bf7ac4fa06d307c71a9cc848
2024-02-10 18:27:20 +00:00
libraryupgrader b1416cfc76 build: Updating npm dependencies
* eslint-config-wikimedia: 0.25.0 → 0.26.0
* grunt-eslint: 24.0.1 → 24.3.0

Change-Id: I274a7f1547729a741965b467ba3ba8fa3bc525e2
2024-02-09 05:25:38 +00:00
Alexander Mashin 754b722c56 Set target to $wgExternalLinkTarget
Set hyperlink 'target' attribute to $wgExternalLinkTarget.

In addition, set the 'rel' attribute according to the
$wgNoFollowLinks, $wgNoFollowDomainExceptions
and $wgNoFollowNsExceptions settings (bug T186241).

Bug: T356730
Change-Id: If4880e4e0b3cd2056521d44baf261ed848511bcd
2024-02-06 16:09:32 +07:00
Translation updater bot 0cf105323f Localisation updates from https://translatewiki.net.
Change-Id: I56a48cbfc7c34de3044b02a364e967159c19bd20
2024-02-05 08:49:52 +01:00
Translation updater bot 3f7960b7e9 Localisation updates from https://translatewiki.net.
Change-Id: I2ea9ff0830523a1da7f83c400bf71674a6b2985d
2024-01-28 16:06:59 +01:00
James D. Forrester fd6cd0530f build: Update MediaWiki requirement to 1.42
All extensions in the MediaWiki tarball are expected to track MediaWiki's release directly.

Change-Id: I5df892bb548071abe6b64374692d90cc5e1d1436
2024-01-12 14:11:36 -05:00
Subramanya Sastry 655ea71656 Use the namespaced versions of some class names (vs aliases)
Change-Id: Idc350cfc4ece2eaa73f8cd2a0a97b839d4caf37e
2024-01-02 13:50:14 -06:00
Translation updater bot 590c939e9b Localisation updates from https://translatewiki.net.
Change-Id: I2bac810a0a86a0762b51cabef0b23b61901eb560
2023-12-22 17:46:09 +01:00
Translation updater bot d70c486cfb Localisation updates from https://translatewiki.net.
Change-Id: I27ffb77a17a6529bd7ad0018cd64fe37bc856af1
2023-12-04 09:04:29 +01:00
Umherirrender 4113b90e4c build: Run stylelint for less file
Since b2113e01 a less file exists

Change-Id: I77bbbb2dbbc9dba3ce5858fe5e0732e11ba803e5
2023-11-28 20:53:38 +01:00
jenkins-bot 927a41a770 Merge "Temporarily disable tests involving data-mw-i18n output" 2023-10-17 21:27:36 +00:00
Subramanya Sastry 66ec96d6b1 ParsoidImageMap: use wfMessage to localize description types
* The previously failing Parsoid test now passes.

Bug: T311523
Depends-On: Id7d9e82ee4ff20a79ba1a5b2433fa29bc5f76e68
Change-Id: I03115b91fd781b72f0bf2c66cb6c18963a772dab
2023-10-09 12:21:35 -05:00
Subramanya Sastry be9aed5e13 Add a test to verify correct behavior of localized desc types
* Parsoid currently fails this and the failing test has been
  added to the known failure list. A follow-up patch will fix it.

Change-Id: Ic788340ec073b401e3e921339250a2678ea038da
2023-10-09 12:20:08 -05:00
Umherirrender 9b9ef62a4c Remove null fallback from DOMElement::getAttribute
Also set @phan-var to handle nullable parentNode
DOMNode::$parentNode is documented as nullable in php8.1
DOMElement::getAttribute is documented to return string in php8.1
Reported by phan running under php8.1

Change-Id: Ia4abd7bf03bc52d7d4ba2c69738bb90c55d01a2b
2023-10-06 20:08:08 +02:00
C. Scott Ananian 5deb04029e Temporarily disable tests involving data-mw-i18n output
These will be updated in I84296d802382131b47fda097878df43e2f6f46ff
but we need to break a cyclic dependency.

Change-Id: I1842447492361fd9eb870b2573eaa50c51cf24fc
2023-10-06 12:58:18 -04:00
Subramanya Sastry 87731b7e09 Add NOTES.md with a note about the migration of the Parsoid code.
Change-Id: I2698db2fec66dde5eff9e74b71b7fbc2662c22f2
2023-09-27 13:57:58 -05:00
Subramanya Sastry 04c293d759 Enable Parsoid integrated tests
* This replaces the standalone tests that we ran for the Parsoid
  implementation while it lived in the Parsoid repo.

* There is no benefit running html2wt (and hence html2html) tests
  at this point since html2wt simply uses data-mw information.

Change-Id: I9435267f654eb07bcb1b5733986667a8617f1fbd
2023-09-27 12:46:00 -05:00
Subramanya Sastry d9a7fea019 Move Parsoid implementation of ImageMap from Parsoid repo
* There have been no changes to the code except for:
  - class is now called ParsoidImageMap with a matching file name
  - the namespace is changed to MediaWiki\Extension\ImageMap.
  - adding phan directives to deal with Parsoid's DOM proxies
    which phan doesn't seem to be see here.

* Parsoid's SiteConfig extension registration code simply overwrites
  the extConfig array for a tag name. So, keeping the config and
  implementation identical ensures that no matter which version of
  code is registered (based on load order), we get the same behavior.

* Once this rolls out on the next train, we can remove the code
  from Parsoid.

* Future patches might refactor the two implementations to extract
  common functionality or merge code into a single file.

Change-Id: I6cffa4420d2daa70174fa926d5c7a4d983792969
2023-09-19 16:21:40 -05:00
Subramanya Sastry 7a2d263b39 Sync up ImageMap repo with Parsoid
This now aligns with Parsoid commit d76d47b9b1accf2548dc1645c812c309dd84540e

Change-Id: I63ea3d08e8dd2727dec89878f0d8f5f27d9c0de1
2023-09-19 15:29:50 -05:00
Translation updater bot f23c942ee9 Localisation updates from https://translatewiki.net.
Change-Id: I66398b8124a9437aaff6e97236e74bf4c295e228
2023-09-18 08:43:38 +02:00
jenkins-bot 8081cb31f5 Merge "Replace some moved Title class uses, now MediaWiki\Title\Title" 2023-08-19 12:33:00 +00:00
gerritbot d3b897ffa1 Replace some moved Title class uses, now MediaWiki\Title\Title
Bug: T321681
Change-Id: I181ab0a62d32ddcab818b48f2d0301b0374a54d9
2023-08-19 12:02:23 +00:00
jenkins-bot b2116e1121 Merge "build: Update MediaWiki requirement to 1.41" 2023-08-19 10:15:49 +00:00
James D. Forrester 2b82aea178 build: Update MediaWiki requirement to 1.41
All extensions in the MediaWiki tarball are expected to track MediaWiki's release directly.

Change-Id: I4d99a3c5fe9ada4c52efa911626eb2c41cf057cb
2023-08-19 13:24:11 +08:00
James D. Forrester 9ae9428df0 build: Update MediaWiki requirement to 1.41
All extensions in the MediaWiki tarball are expected to track MediaWiki's release directly.

Change-Id: Iee3f421a9fa0f7f2a0f7b57ce73043fc1d23ec54
2023-08-19 13:24:01 +08:00
Translation updater bot de0e7a147c Localisation updates from https://translatewiki.net.
Change-Id: Id47412f39377982b88c2bfe373a6687b398c1841
2023-08-17 12:10:09 +02:00
Translation updater bot 2a62e9dd4e Localisation updates from https://translatewiki.net.
Change-Id: Ibc99066c3bb55b4a7931283a56d9dc6f2df66d0c
2023-07-24 09:38:06 +02:00
Translation updater bot 000ccb97b0 Localisation updates from https://translatewiki.net.
Change-Id: I1d0149239f6a5ad93c4ffb11b7bdc495bcacc7a4
2023-06-12 13:07:34 +02:00
libraryupgrader a641766c5b build: Updating grunt-banana-checker to 0.11.0
Change-Id: I0a57907645b3fce4a228d0fc05e2c8f4a829251b
2023-06-01 15:13:13 +00:00
Arlo Breault 7e342a416c Fix description link icon positioning
Bug: T329364
Follows-Up: I20130fd39135dfd5074590ee9c2b6e01693384e4
Change-Id: I9400a6ac607c5170c0aa26ee3a2bf8d9217c19e4
2023-05-31 15:12:35 -04:00
Translation updater bot ba6a6cd75e Localisation updates from https://translatewiki.net.
Change-Id: I9bef60493a602808f166515d349e2851aa8e540b
2023-05-31 08:20:21 +02:00
Arlo Breault 1a8f86e41b Sync up ImageMap repo with Parsoid
This now aligns with Parsoid commit db0772cd77d89ea166bf6ea162f9d223264a6f50

Change-Id: I263043f284542ff866f633ad8177ab3d072ca679
2023-05-25 13:52:17 -04:00
jenkins-bot bf1ab0a995 Merge "Add resource for thumb magnify links" 2023-05-25 16:29:49 +00:00
jenkins-bot 7416c17cda Merge "Add back description links when !$wgParserEnableLegacyMediaDOM" 2023-05-25 16:28:37 +00:00
Arlo Breault 96c60d44ca Add resource for thumb magnify links
Bug: T329413
Depends-On: Id46d1b2ab1af3baebff13e10f1485f3cfd9a4b37
Change-Id: Idec1b8dc1c742ca6ea3b24f3b14738c2d1f5b01d
2023-05-25 16:09:06 +00:00
Arlo Breault b2113e0154 Add back description links when !$wgParserEnableLegacyMediaDOM
The approach taken here is the same as in core for magnify links on
thumbs in Id46d1b2ab1af3baebff13e10f1485f3cfd9a4b37

The gist is that resource attributes are added on the mw-file-element so
that the necessary url is present in the html.  A class is also added to
the wrapper element that designates where the link should be positioned.
Finally, a script adds the link which styles in appropriately.

Bug: T329364
Depends-On: Id46d1b2ab1af3baebff13e10f1485f3cfd9a4b37
Change-Id: I20130fd39135dfd5074590ee9c2b6e01693384e4
2023-05-22 15:22:42 +00:00
Mark A. Hershberger 2d9633abc6 Add generic MW editorconfig
Change-Id: Iccdfd5af7cabbb08677c8c93a03f6838d5928584
2023-05-12 15:09:10 +00:00
libraryupgrader 454cbe9a5c build: Updating eslint-config-wikimedia to 0.25.0
Change-Id: I10eaf510555c78a4349a5e599d4dbd7369b20c43
2023-05-05 05:45:22 +00:00
libraryupgrader e5e2e42370 build: Updating dependencies
composer:
* mediawiki/mediawiki-phan-config: 0.12.0 → 0.12.1

npm:
* grunt-eslint: 24.0.0 → 24.0.1

Change-Id: I0613a705766269abbd83aadaf41e531aac9e7cc3
2023-04-29 05:43:28 +00:00
Arlo Breault 6d83c5bc21 Fix adding titles when caption isn't visible
This was added in Ic0169d3914c5ce442b063f4bbbb6493966dbb302 and it
looks wrong on a few levels: the format isn't captured, and only
mw:File is emitted now.

Change-Id: I5aff7b53348696c485ef5683f6aab7aaafac4973
2023-04-27 13:34:16 +00:00
Arlo Breault 5f132d85a8 Update parsertests with new media classes
Depends-On: Ifd4001e312a5fa4b7beaad63ba8c4e79e3201b9b
Change-Id: I771296865ec101d4af05f4dbbe194f01df3d72a6
2023-04-26 13:15:07 -04:00
Arlo Breault f3f0aa89ea Disable tests to break circular dependency
Needed-By: Ifd4001e312a5fa4b7beaad63ba8c4e79e3201b9b
Change-Id: Ifc17fdf530af515b066de706ca5e69e118fd1c5b
2023-04-20 16:30:55 -04:00
libraryupgrader 53806fe0ad build: Updating npm dependencies
* eslint-config-wikimedia: 0.22.1 → 0.24.0
* grunt: 1.5.3 → 1.6.1

Change-Id: I80e4f86f6369e171a35e5815400785ccdd64293f
2023-03-15 12:20:27 +00:00
C. Scott Ananian a4d5daa43f Sync up ImageMap repo with Parsoid
This now aligns with Parsoid commit 15cf6010f1342a67282d0e6ace4b1ef1eb2bbc47

Change-Id: Id096a272733cc2452d41a7f4b8cb230b8cfc6f62
2023-03-13 13:53:31 -04:00
libraryupgrader 6212138174 build: Updating mediawiki/mediawiki-codesniffer to 41.0.0
Change-Id: I3ca9fba483cc10680b4689fb5dc63cd098290cef
2023-03-12 03:54:53 +00:00