Commit graph

1391 commits

Author SHA1 Message Date
Kunal Mehta 97a8fe1bef Don't use @deprecated for parameters
Makes Doxygen think the whole function is deprecated,
switched them to "@param $var type deprecated"

Change-Id: I1536396258ee62c5bf81a5eb0542656d6d754818
2013-11-23 18:17:36 +00:00
Translation updater bot 24988e8de9 Localisation updates from https://translatewiki.net.
Change-Id: Ib36102d111ceeb68d38cda9ab1094acf95fc1a79
2013-11-23 10:46:21 +00:00
Krenair c0b6a0b6ae Don't send rollback notification if nothing changed
Bug: 56574
Change-Id: If727161560ee07482293e8c012b8ba90bb5df505
2013-11-23 06:36:56 +00:00
Kunal Mehta 6ee8570c80 Check supposed revision being reverted is on the same page
Bug: 57474
Change-Id: Idec054930dd20a01ec9d5132cce25378914629fc
2013-11-22 22:20:45 -08:00
theopolisme fc7e18ba8e Mention: notify correctly if there is no section title
If a user is mentioned in an area that does not have a section
title (for example, the lead section of a talk page), use the new
'notification-mention-nosection' message, to avoid an awkward and
incorrect "[[Page#|]]".

Bug: 52507
Change-Id: I40628b76c460c79008053222c9780bb23549731d
2013-11-22 21:31:45 -06:00
jenkins-bot b487bb5c86 Merge "Allow custom 'diff' values to be set" 2013-11-21 21:55:49 +00:00
Translation updater bot 9702d8dbca Localisation updates from http://translatewiki.net.
Change-Id: Ib83042970a314f1aca02537d911cbd498047de01
2013-11-20 20:42:20 +00:00
Translation updater bot 1f5cf20df8 Localisation updates from http://translatewiki.net.
Change-Id: I472b7eeefd20495c1fafbc8799f9cebf3d9b15ec
2013-11-19 20:14:51 +00:00
Kunal Mehta 93b1011ac9 Allow custom 'diff' values to be set
So we can link to multiple edits at once. This should not
change any existing behavior since 'prev' is used if nothing
is set.

Change-Id: If79e041d1443d8360abdf60b513ce8c7c0c7e1f8
2013-11-19 18:44:01 +00:00
Translation updater bot 40ea204cdc Localisation updates from http://translatewiki.net.
Change-Id: If4a4a40304f422afd74b08c9cb507c4d241431da
2013-11-18 20:37:30 +00:00
Translation updater bot e8a2974963 Localisation updates from http://translatewiki.net.
Change-Id: I90c310d5a8b569fcb8acbcfb5a6d88a6461b4200
2013-11-17 20:24:44 +00:00
Translation updater bot a4f976b622 Localisation updates from http://translatewiki.net.
Change-Id: Ia4370de59f6ccf2a1165528e3eea07d41f84ba13
2013-11-15 20:24:43 +00:00
Translation updater bot eacf539600 Localisation updates from http://translatewiki.net.
Change-Id: I390b9cd1dafb763a8236f190a0ede43cb1a6e38f
2013-11-13 20:21:44 +00:00
Translation updater bot a65a810c8a Localisation updates from http://translatewiki.net.
Change-Id: Icb9e39aa7b5a96ecae870925cb18013f28091760
2013-11-12 20:30:03 +00:00
Translation updater bot 2123deb969 Localisation updates from http://translatewiki.net.
Change-Id: Ib8be9d236c12547174a19e67a7a30b16bdbafc5d
2013-11-11 20:18:36 +00:00
jenkins-bot ba9e8fcfab Merge "Avoid PHP warning in strripos()" 2013-11-10 20:32:35 +00:00
Translation updater bot 990c8d78d1 Localisation updates from http://translatewiki.net.
Change-Id: I17953db507e6e2943262f07226b85da1f37ade87
2013-11-10 20:27:50 +00:00
jenkins-bot 4b4e955ae7 Merge "ext.echo.overlay: Unbreak removal logic" 2013-11-10 02:46:46 +00:00
Translation updater bot 1829d6b510 Localisation updates from http://translatewiki.net.
Change-Id: Ic4a5f6bc35556c6577170a5bce65403941495a62
2013-11-09 19:10:20 +00:00
jenkins-bot d810a6f573 Merge "ext.echo.overlay: Various minor consistency fixes and cleanup" 2013-11-09 02:15:36 +00:00
jenkins-bot 4e26c56bd5 Merge "Remove exclusive module group to reduce HTTP request fragmentation" 2013-11-08 00:02:04 +00:00
Kunal Mehta f2c876c4b5 Disable DatabaseBase constructor
Broke in I094185585dc844ca4d2d8b629107b2ab8f9bef39

Change-Id: I9ef09cfef07906cc5034a56f9b27eccd79f0d4ad
2013-11-07 15:51:46 -08:00
Timo Tijhof c1f022ecae Remove exclusive module group to reduce HTTP request fragmentation
Cache groups should only be used when it is worth to have the
module(s) in a separate request. Echo is relatively small and
stable in terms of cache combination, not worth it to force
its modules to be in a separate http request as all other modules.

Change-Id: I198b5664d662c93c593d048efcfaf4aac765a6b9
2013-11-07 23:16:44 +00:00
Translation updater bot efc9f7a649 Localisation updates from http://translatewiki.net.
Change-Id: Ia946cb76878bb9c738ea34aa8469766d9e4e120b
2013-11-07 20:20:29 +00:00
Translation updater bot 1ba6ec068f Localisation updates from http://translatewiki.net.
Change-Id: I8af2b2b008093b6384c7a49a3256c746a0e7be92
2013-11-06 20:47:17 +00:00
Translation updater bot 05e4f5f01b Localisation updates from http://translatewiki.net.
Change-Id: I00a2bc4ed41fbc2484b0a6d67335ec354f11ef3d
2013-11-05 21:07:09 +00:00
bsitu 18cf0985df Avoid PHP warning in strripos()
bug: 56586
Change-Id: I9c70e28ca7495893f5a34a3f5ec301815de35e2c
2013-11-05 11:03:55 -08:00
jenkins-bot 55f40efe9d Merge "ext.echo.overlay: Only build the 'mark all as read' button if it's used" 2013-11-05 00:23:02 +00:00
Kunal Mehta a026ba880f Fatal error: Cannot use object of type EchoEvent as array at EventLogging.php
Bug: 56521
Change-Id: I180728022886b6a2ba96b0da79299ec342547b3a
2013-11-04 20:36:34 +00:00
Translation updater bot a971b9e9c6 Localisation updates from http://translatewiki.net.
Change-Id: I6e4c191a013c7c1bf8745aaeb57c705b44607a93
2013-11-04 19:58:53 +00:00
Translation updater bot 2c24a633a2 Localisation updates from http://translatewiki.net.
Change-Id: I6d4397133f226e9b6a53237b3e4756bfe2d037d3
2013-11-03 19:55:10 +00:00
jenkins-bot af3d8c30eb Merge "ext.echo.alert: Restore orange background on Monobook" 2013-11-02 23:27:59 +00:00
Translation updater bot dfccfce0e8 Localisation updates from http://translatewiki.net.
Change-Id: Ie55b857c84b5a0e025193ab8e3768ab87762e545
2013-11-02 19:56:40 +00:00
MatmaRex be1cbc4e60 ext.echo.overlay: Unbreak removal logic
Apparently three wrongs make a right: hiding the overlay still worked.

* '#pt-notifications a' click event handler was not correctly checking
  for events comig from inside the overlay due to a missing dot before
  class name
  * But if it were correctly checking, it would not be hiding the
    overlay pokey (just its body) due to a copy-paste error
* Instead the clicks were handled by the 'body' click event handler,
  which did not correctly check for events coming from
  '#pt-notifications a'

I made things right again. The user-facing behavior is the same.

Change-Id: I02aba0e25ba4d81b234b327f120e0e2ff13d117c
2013-11-01 22:38:42 +01:00
MatmaRex c6b65f674a ext.echo.overlay: Various minor consistency fixes and cleanup
Change-Id: Id3b0f4fd7253282b190d6b2ed5fc78b714295e96
2013-11-01 22:15:08 +01:00
MatmaRex 4c8fd7843b ext.echo.overlay: Only build the 'mark all as read' button if it's used
Otherwise a new copy will be created every time the user opens and closes
the popup, and jQuery will hold on to each one forever (because it has
events bound), leaking a minuscule amount of memory.

Change-Id: I70c713be839f826fc27d07b04260c166f9052020
2013-11-01 20:23:05 +01:00
jenkins-bot 18c9faaf10 Merge "Unbreak the unit tests" 2013-11-01 08:22:35 +00:00
Hashar 692f594ba1 Merge "Actually run all the unit tests." 2013-11-01 08:15:38 +00:00
Kunal Mehta 61f1754d14 Unbreak the unit tests
Not all installations will have a user with the id of 2,
like jenkins. At some point User::getOption is called, which
requires loading the user from the database, except it
doesn't exist. At which point the user id is reset to 0,
so it becomes an anonymous user, breaking the test.

Since the MediaWiki test runner automatically
creates a test user, we can safely assume that there is
a user with the id 1.

The other failure was due to that $wgUser may not
always be 127.0.0.1. The test now directly just
calls $wgUser to avoid issues if another test has
altered the global state.

Change-Id: Iacf904d04f1ff5aaf584cb98c3083ef6d7d89cea
2013-11-01 08:13:11 +00:00
Kunal Mehta 86ce24c6d6 Actually run all the unit tests.
Change-Id: Ia411cc32f0d0ac17ce43cbe20be17773cad055a7
2013-11-01 04:31:12 +00:00
Translation updater bot 8b0eebe115 Localisation updates from http://translatewiki.net.
Change-Id: I2b76d590196ad09e4cad5607926e4946ac73fa1a
2013-10-31 20:21:05 +00:00
Translation updater bot 5617f2eb03 Localisation updates from http://translatewiki.net.
Change-Id: Ia53c60700d5f13904cf498b8b146ac4626bfce57
2013-10-30 19:30:44 +00:00
bsitu 974abfa034 Suppressed agent name should be hidden in API
bug: 56230

Change-Id: I7cac877ef0ff44a3f64828ae37ced874b720ad27
2013-10-30 11:53:06 -07:00
jenkins-bot a1388d0096 Merge "Remove class constant variable reference from Echo.php" 2013-10-29 05:10:07 +00:00
Translation updater bot 76ce9fb0e5 Localisation updates from http://translatewiki.net.
Change-Id: I23656a0cb33a0119bee8d6fb078a5e9e8fe180f1
2013-10-28 20:09:55 +00:00
Translation updater bot 03e37abed5 Localisation updates from http://translatewiki.net.
Change-Id: I15d3db9bd9955922d0401e169bb86cdf5f3d1eab
2013-10-27 20:01:39 +00:00
MatmaRex 0d39b70b45 Remove full stop from 'echo-new-messages' message
It should not have a full stop – it's used in the personal menu
(top-right corner of pages), which additionally some skins like
Monobook display in all lowercase.

Updated qqq.

Change-Id: I224a9fc0226ac769eb878cc5d3a7e6d8ebfa7548
2013-10-27 15:37:03 +01:00
MatmaRex dc1443f57f ext.echo.alert: Restore orange background on Monobook
Core styles for Monobook include high-specificity background: transparent;
rule for #p-personal li a, we need to match it to set our background.

Also change hover behavior: switch to a deeper orange instead of
default white, similarly to how the badge already behaves.

Partially reverts I682182fe.

Bug: 56214
Change-Id: I9f343264c395ecf09c1e34e03d208ec2119fb622
2013-10-27 15:30:22 +01:00
Translation updater bot ef99d1c279 Localisation updates from http://translatewiki.net.
Change-Id: Ic3e7804b3cac658481a0ab5b0f1e83f0e182e601
2013-10-26 19:21:22 +00:00
Translation updater bot 9a4830b713 Localisation updates from http://translatewiki.net.
Change-Id: I8da2ae0388a7ce968b374a51274fcf80b60ae603
2013-10-25 18:48:46 +00:00