Commit graph

7183 commits

Author SHA1 Message Date
jenkins-bot eb84e56e65 Merge "Never underline the badge" 2013-06-14 23:04:13 +00:00
Erik Bernhardson 052a4818f6 Rename index for sqlite support
SQLite requires unique index names across the full database.  A previous
patch I9b6468221ba6fe501b15c563f3301694262eec65 renamed the index in
echo.sql but forgot to apply the same change to existing databases. This
resolves that mistake.

Change-Id: Ibb629149afd9f4ca55cac613124fce42500aa8f9
2013-06-14 13:14:21 -07:00
jenkins-bot f5a8f1dcc8 Merge "Add overlay hook for user scripts." 2013-06-14 17:57:29 +00:00
Matthew Flaschen ecf7f1f261 Add overlay hook for user scripts.
Bug: 48502
Change-Id: I720d4fe65a6501b552dbef21cb258c027dc18867
2013-06-13 21:27:26 -04:00
Erik Bernhardson 68a4587460 Repairs necessary for echo to support Sqlite
Sqlite's lack of an 'ALTER TABLE CHANGE' statement has prevented echo from
supporting sqlite, and by relation has prevented Echo's unit tests from
running within the foundations jenkins CI environment.  This patch detects
if the database is currently an sqlite database and applies a specially
formulated patch that performs a rename/copy/delete operation to get
the equivilient of an 'ALTER TABLE CHANGE' command. Additionally renames
one index to have a more unique echo-specific name.

Bug: 41987
Change-Id: I9b6468221ba6fe501b15c563f3301694262eec65
2013-06-13 14:34:33 -07:00
jenkins-bot e1be0ace4a Merge "(bug 47666) All system messages should have sender = -1" 2013-06-13 21:09:48 +00:00
jenkins-bot 750cb30c47 Merge "Some more adjustment to timestamp in user timezone" 2013-06-13 20:36:16 +00:00
Translation updater bot 7071f0ca1e Localisation updates from http://translatewiki.net.
Change-Id: I357cc925323acbfdc2f5f3ce49300ac56b17374e
2013-06-13 19:30:01 +00:00
bsitu 12fa60fa23 Some more adjustment to timestamp in user timezone
* The timestamp used for loading more should always use UTC timestamp since
  that's the format saved in the database

Change-Id: I249725a6972b95dddd9074ffe08343b1a805c111
2013-06-13 11:32:06 -07:00
jenkins-bot a334ca1350 Merge "LIMIT is not a supported DatabaseBase::update option" 2013-06-13 17:24:21 +00:00
kaldari d43e19cb51 Adding diff link to talk page notifications for email
We'll also be adding diff links for the flyout and archive, but
not in this change.

Bug: 48183
Change-Id: Iacd269a489c93b4fc4d28306915658fad372f50d
2013-06-12 23:36:07 -07:00
bsitu 09c531a11f (bug 47666) All system messages should have sender = -1
Change-Id: I0f7458b0e76c600c6bb383bd320b483adfd76d98
2013-06-12 19:26:57 -07:00
kaldari 0fd7915801 Switching to short date headers based on user prefs (and timezone)
This change will allow people to switch between 'May 10' and
'10 May' as requested in bug 47211. It also now corrects for the
user's timezone settings.

Bug: 47211

Change-Id: I7c5eae52857fac2d82ff1cb0b10864a1e1b30b6a
2013-06-12 17:45:40 -07:00
jenkins-bot aa5771bceb Merge "Remove quote around javascript object property name" 2013-06-12 21:59:10 +00:00
jenkins-bot 8d02205b16 Merge "Preventing FOUC on Special:Notifications page" 2013-06-12 21:20:23 +00:00
kaldari 1bfe147708 Preventing FOUC on Special:Notifications page
To prevent flash of unstyled content.

Bug: 49496
Change-Id: I6a7bf510256a84ef7ad0ec9cd03d1ccae1fe149c
2013-06-12 14:10:56 -07:00
bsitu 0947cfda34 Update mention notification threshold from 300 to 100
Change-Id: Iab02b076e4463d61a2986f16f1a756c48ecde0a6
2013-06-12 13:59:02 -07:00
bsitu 01e244c8a3 Remove quote around javascript object property name
Change-Id: I5cc7f4179066ab694a67d4c578ed4a562f533ade
2013-06-12 10:51:55 -07:00
kaldari 0558ab1571 Calling functions explicitly due to context
When I changed mw.echo.special.initialize to be called as a
callback from $( document ).ready(), rather than being called
explicitly from the closure, it changed the context, which got
assigned to _this. This broke some of the function calls.

Change-Id: I602a58a82ee91646901d0ab1c8b7bb4b22b3437a
2013-06-11 18:01:41 -07:00
jenkins-bot 0f62158d03 Merge "Don't run mw.echo.special.initialize until DOM is ready" 2013-06-11 21:24:43 +00:00
kaldari 902ce9cc04 Don't run mw.echo.special.initialize until DOM is ready
To fix rare race condition in Safari

Change-Id: I2ae556ff6e44f291e761d2937203a3376f4a3177
2013-06-11 14:20:08 -07:00
Translation updater bot adc5068158 Localisation updates from http://translatewiki.net.
Change-Id: Id52377dd92b94aa2495cef47b30766cde1c55425
2013-06-11 20:53:05 +00:00
jenkins-bot dc6e8394fc Merge "Add clickthrough eventlogging to Echo" 2013-06-11 17:53:00 +00:00
bsitu 6ffc1cac4b Add clickthrough eventlogging to Echo
Change-Id: I3d05d1aeca92f9a0265a522cc5027ae18394c5b4
2013-06-11 10:46:41 -07:00
jenkins-bot 8d358ac16b Merge "(bug 49142) Notifications Productivity A/B Test" 2013-06-11 00:24:23 +00:00
jenkins-bot fea4484b68 Merge "Database updates for respecting oversight within Echo" 2013-06-11 00:01:02 +00:00
bsitu 7c19d0243f (bug 49142) Notifications Productivity A/B Test
Change-Id: I209a55bc78fc307603710296b75ebe774ebdcbac
2013-06-10 15:22:27 -07:00
jenkins-bot 738d816a6c Merge "Fix some JS issues" 2013-06-10 21:57:13 +00:00
Erik Bernhardson f38ce97efd Database updates for respecting oversight within Echo
Provides the first step of adding and populating a new database field
for Echo oversight deployment.  The new field is populated via a
maintenance script and Event::loadFromRow will accept both new and old
results.  Everything will still run when the 2 now unused fields are
later dropped from the db.

Bug: 48059
Change-Id: I24d4b61a061f94ed9aaaa6087f33b2ab37f773cd
2013-06-10 14:52:18 -07:00
Translation updater bot ff0c344eac Localisation updates from http://translatewiki.net.
Change-Id: I522175bbee0f3dabd3c98fd635b8471f534c9b9c
2013-06-10 07:24:22 +00:00
Amir E. Aharoni 5631117ca2 Never underline the badge
If link underlining is on, then the number in the badge
will be underlined. This is probably never needed, even
if the user wants to underline regular links.
Set text-decoration to none in all cases.

Change-Id: Ifaca38a8f0a6a3c8df39502a3da582f639ec6333
2013-06-07 19:44:20 -07:00
jenkins-bot e4640e4d0a Merge "Echo: Better support for non-default skins, as well as no Javascript" 2013-06-07 18:37:40 +00:00
Derk-Jan Hartman c638d44190 Echo: Better support for non-default skins, as well as no Javascript
This provides some rudimentary styling support to make Echo usable
with the Modern skin.
It also fixes the Notifications special page so it is styled
correctly in Modern, CologneBlue, or with Javascript turned off.
Also some more tweaks for Monobook skin.
Retiring the 'feedback' link from the special page, per PM.

Bug: 47932
Change-Id: I633a93a78f5a78d0642a3a059fa6f7208f99cec4
2013-06-07 11:36:19 -07:00
bsitu 7862266326 $wgOut->getContext()->getTitle() may return null
We should just check if it's null before using it as a title object

Change-Id: Ieaf7adb3fccc62c79a6eaad5650840cc5411873e
2013-06-06 13:46:52 -07:00
Krenair 745330367b Fix some JS issues
Brought up by Krinkle in Icebfe86b (PS4):
    * 'ok' and 'err' properties of Api are deprecated, use promise interface
    * Use 'api' instead of 'Api'
    * $( '<a>' ) instead of $( '<a/>' )
    * Expected space after 'function' keyword

Change-Id: I0199db902174551bcf9269edafb1fef1df118b13
2013-06-06 00:09:28 +01:00
jenkins-bot 5ae087d7c9 Merge changes Iedbe3404,I65fdc6d9
* changes:
  Link to any heading not just a main heading
  Better detection of multiple changes in a document
2013-06-05 18:07:31 +00:00
Translation updater bot fffb6c99e5 Localisation updates from http://translatewiki.net.
Change-Id: If20eb9c7f3f91d1a8fb5aa33ba59b7ed77a4ca04
2013-06-04 09:16:32 +00:00
Translation updater bot 13c15e7f68 Localisation updates from http://translatewiki.net.
Change-Id: I6c7336738d0b4d15855a088ac81709749ad23211
2013-06-03 18:23:53 +00:00
Translation updater bot 786cf40d00 Localisation updates from http://translatewiki.net.
Change-Id: I39ff25313cf0eecc7797fc1252cb5e8042aea6a1
2013-06-03 11:42:33 +00:00
kaldari 5ca8b8f1c7 Suppressing underline on hover for notification badge
Change-Id: I663c5f0d1f03bc8159579892a7d313a535ec48d3
2013-05-30 15:45:16 -07:00
jenkins-bot 64159dade0 Merge "(bug 47912) Visiting talk page should mark talk notif as read" 2013-05-30 18:46:37 +00:00
bsitu 71f250e0c6 (bug 47912) Visiting talk page should mark talk notif as read
This needs some more manual testing and adding unit testing

Change-Id: Iadfe3cf7927d5318f89ba17f067000f9399060af
2013-05-29 20:43:57 -07:00
Erik Bernhardson aaaa177f2f Tooltips for echo notification settings
Bug: 47094
Change-Id: I3556aafe90d5f9a42f0774e783adb06991bc5088
2013-05-29 16:13:12 -07:00
Translation updater bot d2da9d79c1 Localisation updates from http://translatewiki.net.
Change-Id: I5598c4f3e4137784180a95093e606a4783630639
2013-05-29 08:35:37 +00:00
Erik Bernhardson 9bcb5cc94c Link to any heading not just a main heading
Echo's detection of section links was limited to the main heading that have
==Foo==, with exactly two ==.  This updates the regexp patterns involved to
correctly detect(and hence, link) to sub sections if thats where the edit was
made.

Bug: 48484
Change-Id: Iedbe3404ec265a7f2183629b463a3d672dc9098e
2013-05-28 12:07:17 -07:00
Translation updater bot 5a8eb4f855 Localisation updates from http://translatewiki.net.
Change-Id: Ic1b5de3be7210fa2fdfa12a1f684d59f00ac0998
2013-05-28 06:44:28 +00:00
Translation updater bot 2398851f18 Merge "Localisation updates from http://translatewiki.net." 2013-05-26 08:49:12 +00:00
Translation updater bot 47d057bd2b Localisation updates from http://translatewiki.net.
Change-Id: I4a5c8c0dc34b63f72e7df48192953c8e263c842b
2013-05-26 08:41:00 +00:00
bsitu e50f5a55a6 (bug 48821) Echo badge count always lags by 1
This bug was introduced during fixing the implicit database transaction,
the badge count logic happens before the transaction completes on idle,
moving the badge count code to only after a successful notification creation
should solve the issue

Change-Id: Ia564ed0d386e7cf2da1af3d23ae83d71ad472df5
2013-05-25 19:44:09 -07:00
Translation updater bot 3c64b1d2e2 Localisation updates from http://translatewiki.net.
Change-Id: I19e8e400f4fa0c3d50cd328a416ba2d26cd69593
2013-05-25 08:23:26 +00:00