wikimedia/mediawiki-extensions-Echo
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Echo synced 2024-11-23 23:44:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

Calling functions explicitly due to context

Browse source 
When I changed mw.echo.special.initialize to be called as a
callback from $( document ).ready(), rather than being called
explicitly from the closure, it changed the context, which got
assigned to _this. This broke some of the function calls.

Change-Id: I602a58a82ee91646901d0ab1c8b7bb4b22b3437a
This commit is contained in:
kaldari 2013-06-11 18:01:41 -07:00
parent 0f62158d03
commit 0558ab1571
1 changed files with 6 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
modules/special/ext.echo.special.js
View file

@ -11,8 +11,7 @@
* Initialize the property in special notification page.
*/
'initialize': function() {
var _this = this,
skin = mw.config.get('skin');
var skin = mw.config.get('skin');
// Convert more link into a button
$( '#mw-echo-more' )
@ -22,14 +21,14 @@
.addClass( 'ui-button-blue' )
.click( function( e ) {
e.preventDefault();
if ( !_this.processing ) {
_this.processing = true;
_this.loadMore();
if ( !mw.echo.special.processing ) {
mw.echo.special.processing = true;
mw.echo.special.loadMore();
}
}
);
_this.notcontinue = mw.config.get( 'wgEchoNextContinue' );
_this.header = mw.config.get( 'wgEchoDateHeader' );
mw.echo.special.notcontinue = mw.config.get( 'wgEchoNextContinue' );
mw.echo.special.header = mw.config.get( 'wgEchoDateHeader' );
// Set up each individual notification with eventlogging, a close
// box and dismiss interface if it is dismissable.