Commit graph

920 commits

Author SHA1 Message Date
jenkins-bot aa5771bceb Merge "Remove quote around javascript object property name" 2013-06-12 21:59:10 +00:00
jenkins-bot 8d02205b16 Merge "Preventing FOUC on Special:Notifications page" 2013-06-12 21:20:23 +00:00
kaldari 1bfe147708 Preventing FOUC on Special:Notifications page
To prevent flash of unstyled content.

Bug: 49496
Change-Id: I6a7bf510256a84ef7ad0ec9cd03d1ccae1fe149c
2013-06-12 14:10:56 -07:00
bsitu 0947cfda34 Update mention notification threshold from 300 to 100
Change-Id: Iab02b076e4463d61a2986f16f1a756c48ecde0a6
2013-06-12 13:59:02 -07:00
bsitu 01e244c8a3 Remove quote around javascript object property name
Change-Id: I5cc7f4179066ab694a67d4c578ed4a562f533ade
2013-06-12 10:51:55 -07:00
kaldari 0558ab1571 Calling functions explicitly due to context
When I changed mw.echo.special.initialize to be called as a
callback from $( document ).ready(), rather than being called
explicitly from the closure, it changed the context, which got
assigned to _this. This broke some of the function calls.

Change-Id: I602a58a82ee91646901d0ab1c8b7bb4b22b3437a
2013-06-11 18:01:41 -07:00
jenkins-bot 0f62158d03 Merge "Don't run mw.echo.special.initialize until DOM is ready" 2013-06-11 21:24:43 +00:00
kaldari 902ce9cc04 Don't run mw.echo.special.initialize until DOM is ready
To fix rare race condition in Safari

Change-Id: I2ae556ff6e44f291e761d2937203a3376f4a3177
2013-06-11 14:20:08 -07:00
Translation updater bot adc5068158 Localisation updates from http://translatewiki.net.
Change-Id: Id52377dd92b94aa2495cef47b30766cde1c55425
2013-06-11 20:53:05 +00:00
jenkins-bot dc6e8394fc Merge "Add clickthrough eventlogging to Echo" 2013-06-11 17:53:00 +00:00
bsitu 6ffc1cac4b Add clickthrough eventlogging to Echo
Change-Id: I3d05d1aeca92f9a0265a522cc5027ae18394c5b4
2013-06-11 10:46:41 -07:00
jenkins-bot 8d358ac16b Merge "(bug 49142) Notifications Productivity A/B Test" 2013-06-11 00:24:23 +00:00
jenkins-bot fea4484b68 Merge "Database updates for respecting oversight within Echo" 2013-06-11 00:01:02 +00:00
bsitu 7c19d0243f (bug 49142) Notifications Productivity A/B Test
Change-Id: I209a55bc78fc307603710296b75ebe774ebdcbac
2013-06-10 15:22:27 -07:00
jenkins-bot 738d816a6c Merge "Fix some JS issues" 2013-06-10 21:57:13 +00:00
Erik Bernhardson f38ce97efd Database updates for respecting oversight within Echo
Provides the first step of adding and populating a new database field
for Echo oversight deployment.  The new field is populated via a
maintenance script and Event::loadFromRow will accept both new and old
results.  Everything will still run when the 2 now unused fields are
later dropped from the db.

Bug: 48059
Change-Id: I24d4b61a061f94ed9aaaa6087f33b2ab37f773cd
2013-06-10 14:52:18 -07:00
Translation updater bot ff0c344eac Localisation updates from http://translatewiki.net.
Change-Id: I522175bbee0f3dabd3c98fd635b8471f534c9b9c
2013-06-10 07:24:22 +00:00
Amir E. Aharoni 5631117ca2 Never underline the badge
If link underlining is on, then the number in the badge
will be underlined. This is probably never needed, even
if the user wants to underline regular links.
Set text-decoration to none in all cases.

Change-Id: Ifaca38a8f0a6a3c8df39502a3da582f639ec6333
2013-06-07 19:44:20 -07:00
jenkins-bot e4640e4d0a Merge "Echo: Better support for non-default skins, as well as no Javascript" 2013-06-07 18:37:40 +00:00
Derk-Jan Hartman c638d44190 Echo: Better support for non-default skins, as well as no Javascript
This provides some rudimentary styling support to make Echo usable
with the Modern skin.
It also fixes the Notifications special page so it is styled
correctly in Modern, CologneBlue, or with Javascript turned off.
Also some more tweaks for Monobook skin.
Retiring the 'feedback' link from the special page, per PM.

Bug: 47932
Change-Id: I633a93a78f5a78d0642a3a059fa6f7208f99cec4
2013-06-07 11:36:19 -07:00
bsitu 7862266326 $wgOut->getContext()->getTitle() may return null
We should just check if it's null before using it as a title object

Change-Id: Ieaf7adb3fccc62c79a6eaad5650840cc5411873e
2013-06-06 13:46:52 -07:00
Krenair 745330367b Fix some JS issues
Brought up by Krinkle in Icebfe86b (PS4):
    * 'ok' and 'err' properties of Api are deprecated, use promise interface
    * Use 'api' instead of 'Api'
    * $( '<a>' ) instead of $( '<a/>' )
    * Expected space after 'function' keyword

Change-Id: I0199db902174551bcf9269edafb1fef1df118b13
2013-06-06 00:09:28 +01:00
jenkins-bot 5ae087d7c9 Merge changes Iedbe3404,I65fdc6d9
* changes:
  Link to any heading not just a main heading
  Better detection of multiple changes in a document
2013-06-05 18:07:31 +00:00
Translation updater bot fffb6c99e5 Localisation updates from http://translatewiki.net.
Change-Id: If20eb9c7f3f91d1a8fb5aa33ba59b7ed77a4ca04
2013-06-04 09:16:32 +00:00
Translation updater bot 13c15e7f68 Localisation updates from http://translatewiki.net.
Change-Id: I6c7336738d0b4d15855a088ac81709749ad23211
2013-06-03 18:23:53 +00:00
Translation updater bot 786cf40d00 Localisation updates from http://translatewiki.net.
Change-Id: I39ff25313cf0eecc7797fc1252cb5e8042aea6a1
2013-06-03 11:42:33 +00:00
kaldari 5ca8b8f1c7 Suppressing underline on hover for notification badge
Change-Id: I663c5f0d1f03bc8159579892a7d313a535ec48d3
2013-05-30 15:45:16 -07:00
jenkins-bot 64159dade0 Merge "(bug 47912) Visiting talk page should mark talk notif as read" 2013-05-30 18:46:37 +00:00
bsitu 71f250e0c6 (bug 47912) Visiting talk page should mark talk notif as read
This needs some more manual testing and adding unit testing

Change-Id: Iadfe3cf7927d5318f89ba17f067000f9399060af
2013-05-29 20:43:57 -07:00
Erik Bernhardson aaaa177f2f Tooltips for echo notification settings
Bug: 47094
Change-Id: I3556aafe90d5f9a42f0774e783adb06991bc5088
2013-05-29 16:13:12 -07:00
Translation updater bot d2da9d79c1 Localisation updates from http://translatewiki.net.
Change-Id: I5598c4f3e4137784180a95093e606a4783630639
2013-05-29 08:35:37 +00:00
Erik Bernhardson 9bcb5cc94c Link to any heading not just a main heading
Echo's detection of section links was limited to the main heading that have
==Foo==, with exactly two ==.  This updates the regexp patterns involved to
correctly detect(and hence, link) to sub sections if thats where the edit was
made.

Bug: 48484
Change-Id: Iedbe3404ec265a7f2183629b463a3d672dc9098e
2013-05-28 12:07:17 -07:00
Translation updater bot 5a8eb4f855 Localisation updates from http://translatewiki.net.
Change-Id: Ic1b5de3be7210fa2fdfa12a1f684d59f00ac0998
2013-05-28 06:44:28 +00:00
Translation updater bot 2398851f18 Merge "Localisation updates from http://translatewiki.net." 2013-05-26 08:49:12 +00:00
Translation updater bot 47d057bd2b Localisation updates from http://translatewiki.net.
Change-Id: I4a5c8c0dc34b63f72e7df48192953c8e263c842b
2013-05-26 08:41:00 +00:00
bsitu e50f5a55a6 (bug 48821) Echo badge count always lags by 1
This bug was introduced during fixing the implicit database transaction,
the badge count logic happens before the transaction completes on idle,
moving the badge count code to only after a successful notification creation
should solve the issue

Change-Id: Ia564ed0d386e7cf2da1af3d23ae83d71ad472df5
2013-05-25 19:44:09 -07:00
Translation updater bot 3c64b1d2e2 Localisation updates from http://translatewiki.net.
Change-Id: I19e8e400f4fa0c3d50cd328a416ba2d26cd69593
2013-05-25 08:23:26 +00:00
Erik Bernhardson 1d7b766754 Better detection of multiple changes in a document
Detects changes to different parts of the document as independent from each
other. Refactored parser passes all tests the previous parser passed plus
a number of new tests which fail with the original parser.

Change-Id: I65fdc6d9f922cbe9ff684332945def3776c70d30
2013-05-24 16:37:00 -07:00
Erik Bernhardson 59c5bc4c8d LIMIT is not a supported DatabaseBase::update option
LIMIT on an UPDATE statement is not standard SQL and is not supported by
DatabaseBase::update.

Change-Id: Ibb3b85548b42457dcc1163968152ee65570da25b
2013-05-24 11:40:40 -07:00
Translation updater bot 60344c84db Localisation updates from http://translatewiki.net.
Change-Id: I096c19e153c7c5be79c3afb670d0dfd97534843a
2013-05-24 08:25:39 +00:00
kaldari 43d95d153e Slightly reducing badge and alert sizes
Change-Id: If3c93582dbbdcab14b10ad9fe2926dcc94186756
2013-05-23 11:59:20 -07:00
jenkins-bot d2702cb1e9 Merge "Adding explicit prefix so we don't have to have an exception in prefs" 2013-05-23 17:51:23 +00:00
jenkins-bot 3b96815e40 Merge "Switch to using our own badge instead of jQuery.badge" 2013-05-23 17:42:47 +00:00
kaldari f9481040d5 Switch to using our own badge instead of jQuery.badge
With this change we will no longer be relying on JS for the badge
functionality. This will prevent the flash of unstyled content,
and allow wikis to locally override the styling (since the unread
class is now applied immediately).

I also went ahead and made the badge styling more closely match the
talk page message alert styling per Vibha.

Also removed the old full link optional behavior since we weren't
using it, and it would have been a pain to maintain.

Bug: 48165
Bug: 48001
Change-Id: Ie85d66afd5181d487d0bb2776ae14b121ea50d88
2013-05-23 10:34:47 -07:00
Translation updater bot 9ed354551c Localisation updates from http://translatewiki.net.
Change-Id: I9c92ddc2054b79d1c6f6c4050f2ac8fbebac0b90
2013-05-23 05:40:02 +00:00
kaldari 9f77b4ab3e Adding explicit prefix so we don't have to have an exception in prefs
If we add an explicit prefix (similar to what the Gadgets extension
does), we won't have to have a special handler for checkmatrix options
in Preferences::filterDataForSubmit().

Depends on core change I4049b666

Change-Id: Ic8420b896bc013840eb3a32420a49f6719f30610
2013-05-22 13:19:08 -07:00
jenkins-bot 108d525159 Merge "Copy tweaks to Echo Notification Emails" 2013-05-22 19:53:46 +00:00
jenkins-bot 021a9213be Merge "(bug 48521) Echo should not implicitly commit other transaction" 2013-05-22 19:37:41 +00:00
Translation updater bot bc64c5a3d0 Localisation updates from http://translatewiki.net.
Change-Id: I1369339b7e5139f64c00ecbbe03c4e899435f8ce
2013-05-22 07:49:04 +00:00
jenkins-bot f997fda13a Merge "Add EventLogging to capture Echo preference change" 2013-05-22 00:46:55 +00:00