Commit graph

1111 commits

Author SHA1 Message Date
Kunal Mehta a026ba880f Fatal error: Cannot use object of type EchoEvent as array at EventLogging.php
Bug: 56521
Change-Id: I180728022886b6a2ba96b0da79299ec342547b3a
2013-11-04 20:36:34 +00:00
Translation updater bot a971b9e9c6 Localisation updates from http://translatewiki.net.
Change-Id: I6e4c191a013c7c1bf8745aaeb57c705b44607a93
2013-11-04 19:58:53 +00:00
Translation updater bot 2c24a633a2 Localisation updates from http://translatewiki.net.
Change-Id: I6d4397133f226e9b6a53237b3e4756bfe2d037d3
2013-11-03 19:55:10 +00:00
jenkins-bot af3d8c30eb Merge "ext.echo.alert: Restore orange background on Monobook" 2013-11-02 23:27:59 +00:00
Translation updater bot dfccfce0e8 Localisation updates from http://translatewiki.net.
Change-Id: Ie55b857c84b5a0e025193ab8e3768ab87762e545
2013-11-02 19:56:40 +00:00
MatmaRex be1cbc4e60 ext.echo.overlay: Unbreak removal logic
Apparently three wrongs make a right: hiding the overlay still worked.

* '#pt-notifications a' click event handler was not correctly checking
  for events comig from inside the overlay due to a missing dot before
  class name
  * But if it were correctly checking, it would not be hiding the
    overlay pokey (just its body) due to a copy-paste error
* Instead the clicks were handled by the 'body' click event handler,
  which did not correctly check for events coming from
  '#pt-notifications a'

I made things right again. The user-facing behavior is the same.

Change-Id: I02aba0e25ba4d81b234b327f120e0e2ff13d117c
2013-11-01 22:38:42 +01:00
MatmaRex c6b65f674a ext.echo.overlay: Various minor consistency fixes and cleanup
Change-Id: Id3b0f4fd7253282b190d6b2ed5fc78b714295e96
2013-11-01 22:15:08 +01:00
MatmaRex 4c8fd7843b ext.echo.overlay: Only build the 'mark all as read' button if it's used
Otherwise a new copy will be created every time the user opens and closes
the popup, and jQuery will hold on to each one forever (because it has
events bound), leaking a minuscule amount of memory.

Change-Id: I70c713be839f826fc27d07b04260c166f9052020
2013-11-01 20:23:05 +01:00
jenkins-bot 18c9faaf10 Merge "Unbreak the unit tests" 2013-11-01 08:22:35 +00:00
Hashar 692f594ba1 Merge "Actually run all the unit tests." 2013-11-01 08:15:38 +00:00
Kunal Mehta 61f1754d14 Unbreak the unit tests
Not all installations will have a user with the id of 2,
like jenkins. At some point User::getOption is called, which
requires loading the user from the database, except it
doesn't exist. At which point the user id is reset to 0,
so it becomes an anonymous user, breaking the test.

Since the MediaWiki test runner automatically
creates a test user, we can safely assume that there is
a user with the id 1.

The other failure was due to that $wgUser may not
always be 127.0.0.1. The test now directly just
calls $wgUser to avoid issues if another test has
altered the global state.

Change-Id: Iacf904d04f1ff5aaf584cb98c3083ef6d7d89cea
2013-11-01 08:13:11 +00:00
Kunal Mehta 86ce24c6d6 Actually run all the unit tests.
Change-Id: Ia411cc32f0d0ac17ce43cbe20be17773cad055a7
2013-11-01 04:31:12 +00:00
Translation updater bot 8b0eebe115 Localisation updates from http://translatewiki.net.
Change-Id: I2b76d590196ad09e4cad5607926e4946ac73fa1a
2013-10-31 20:21:05 +00:00
Translation updater bot 5617f2eb03 Localisation updates from http://translatewiki.net.
Change-Id: Ia53c60700d5f13904cf498b8b146ac4626bfce57
2013-10-30 19:30:44 +00:00
bsitu 974abfa034 Suppressed agent name should be hidden in API
bug: 56230

Change-Id: I7cac877ef0ff44a3f64828ae37ced874b720ad27
2013-10-30 11:53:06 -07:00
jenkins-bot a1388d0096 Merge "Remove class constant variable reference from Echo.php" 2013-10-29 05:10:07 +00:00
Translation updater bot 76ce9fb0e5 Localisation updates from http://translatewiki.net.
Change-Id: I23656a0cb33a0119bee8d6fb078a5e9e8fe180f1
2013-10-28 20:09:55 +00:00
Translation updater bot 03e37abed5 Localisation updates from http://translatewiki.net.
Change-Id: I15d3db9bd9955922d0401e169bb86cdf5f3d1eab
2013-10-27 20:01:39 +00:00
MatmaRex 0d39b70b45 Remove full stop from 'echo-new-messages' message
It should not have a full stop – it's used in the personal menu
(top-right corner of pages), which additionally some skins like
Monobook display in all lowercase.

Updated qqq.

Change-Id: I224a9fc0226ac769eb878cc5d3a7e6d8ebfa7548
2013-10-27 15:37:03 +01:00
MatmaRex dc1443f57f ext.echo.alert: Restore orange background on Monobook
Core styles for Monobook include high-specificity background: transparent;
rule for #p-personal li a, we need to match it to set our background.

Also change hover behavior: switch to a deeper orange instead of
default white, similarly to how the badge already behaves.

Partially reverts I682182fe.

Bug: 56214
Change-Id: I9f343264c395ecf09c1e34e03d208ec2119fb622
2013-10-27 15:30:22 +01:00
Translation updater bot ef99d1c279 Localisation updates from http://translatewiki.net.
Change-Id: Ic3e7804b3cac658481a0ab5b0f1e83f0e182e601
2013-10-26 19:21:22 +00:00
Translation updater bot 9a4830b713 Localisation updates from http://translatewiki.net.
Change-Id: I8da2ae0388a7ce968b374a51274fcf80b60ae603
2013-10-25 18:48:46 +00:00
jenkins-bot fc41b4a613 Merge "Update to latest revision of Echo schema" 2013-10-25 05:41:22 +00:00
Kunal Mehta 18b09b5daa Update to latest revision of Echo schema
This patch updates Echo to revision 6081131 of Schema:Echo, adding a 'rev_id'
field and the code to populate it. The patch also increments the logging
version identifier to 1.5.

Bug: 46045
Change-Id: I4ac1a25c306b0e0983a3490a29fe3dc4aa4bfc6f
2013-10-25 05:40:05 +00:00
Translation updater bot 566521b23f Localisation updates from http://translatewiki.net.
Change-Id: I7fc6301b62faddb0e87be4d2a8c20a937718ff5c
2013-10-24 20:47:11 +00:00
bsitu 71e27f4b7a Remove class constant variable reference from Echo.php
This is causing fatal error in update.php

bug: 55469
Change-Id: Ib0a354addd44542f7ec4eda427c0b530f33e6c12
2013-10-23 12:31:35 -07:00
Translation updater bot 40b7601e62 Localisation updates from http://translatewiki.net.
Change-Id: I6cf0794a80b9788416ec0897fa564253be745a9f
2013-10-23 19:00:52 +00:00
Translation updater bot 229ce7d0b7 Localisation updates from http://translatewiki.net.
Change-Id: I142241edeb4ca2ffcb237fc0cc2a4a2a73b93cee
2013-10-22 19:18:39 +00:00
Translation updater bot e45be76e34 Merge "Localisation updates from http://translatewiki.net." 2013-10-21 19:46:40 +00:00
Translation updater bot 04da164ead Localisation updates from http://translatewiki.net.
Change-Id: I707d9d96ab38db04039026a5b44ccc44e233978d
2013-10-21 19:37:42 +00:00
jenkins-bot 301dd193b8 Merge "Remove "Talk:" prefix from "You have new messages"" 2013-10-21 19:25:40 +00:00
Kunal Mehta 790f4bee9e Remove "Talk:" prefix from "You have new messages"
Bug: 49324
Change-Id: I51d9fc5c891d4489fcb5bce74b0428575f1df7f6
2013-10-21 11:56:20 -07:00
Translation updater bot 19bad23827 Localisation updates from http://translatewiki.net.
Change-Id: I1370e8abcb4287ef37456b2d7ff0edf8937438ad
2013-10-20 21:44:47 +00:00
jenkins-bot 1b44c4bdc1 Merge "EchoBasicFormatter::formatFragment returns a Message object" 2013-10-20 14:50:42 +00:00
Kunal Mehta 52fab9c515 EchoBasicFormatter::formatFragment returns a Message object
Change-Id: I28228f904c4364a1e4c1c1a637bf78f506003eb6
2013-10-20 02:32:30 -07:00
Kunal Mehta 8f77ba2028 Remove duplicate "global $wgUser"
Change-Id: I857d09ba3a115a4e042d4c95550ac77f0211c34f
2013-10-20 01:29:00 -07:00
Kunal Mehta f31c605360 Replace wfMessage calls with $this->msg
Change-Id: I600af0721c15828d0a11b36438231b09e4148728
2013-10-19 00:58:38 -07:00
Translation updater bot 61a07a4554 Localisation updates from http://translatewiki.net.
Change-Id: Ie21649a0ceb6f8ea88711827f3017ecbc0059389
2013-10-18 19:16:05 +00:00
Translation updater bot 0024b000ff Localisation updates from http://translatewiki.net.
Change-Id: Idcac5b658813c7d7e41c586683d38f72e6a56353
2013-10-17 19:33:09 +00:00
Translation updater bot ad1bb66d61 Localisation updates from http://translatewiki.net.
Change-Id: Iee9f8d5e3061a550d75e5afa38751937086f2472
2013-10-16 21:43:54 +00:00
jenkins-bot de93be2b47 Merge "Revert "Notification overlay is partially hidden in RTL language"" 2013-10-16 17:33:31 +00:00
Bartosz Dziewoński 4ad3cb4674 Revert "Notification overlay is partially hidden in RTL language"
Ugly workaround for bug 55779. Let's not do this.

This reverts commit 67bcecff5d.

Bug: 55629
Change-Id: I5f5503aa1d1f7c93b11bf82cfcd73370a991783c
2013-10-16 09:49:09 +00:00
bsitu b9a0a339c8 Add new method to process a param in escaped format
Change-Id: Ie777d7838b83d6109adf3ea8a71dd19240d8b6f5
2013-10-15 15:38:57 -07:00
Translation updater bot 08c5421a10 Localisation updates from http://translatewiki.net.
Change-Id: I91ade67ccad14292d83fc9afba84af4dfb719d4f
2013-10-15 20:52:47 +00:00
jenkins-bot 2ba05992be Merge "Notification overlay is partially hidden in RTL language" 2013-10-15 15:59:28 +00:00
Translation updater bot 1cf63dc37b Localisation updates from http://translatewiki.net.
Change-Id: I7b842d01a4aacb33f27a7022773a67eba6e3ca68
2013-10-14 09:28:51 +00:00
jenkins-bot dd6caea6b4 Merge "Native digits on 'mw-echo-overlay-title-text'" 2013-10-13 20:06:09 +00:00
Ebrahim Byagowi 88937d21c1 Native digits on 'mw-echo-overlay-title-text'
Change-Id: Icdd52ea0267ffbaa0e103070655735eff8423ca1
2013-10-13 19:34:03 +00:00
Translation updater bot c49e289614 Localisation updates from http://translatewiki.net.
Change-Id: Iafbe56f807eb1edb524b017d46cd06a63fd4cd27
2013-10-13 19:27:29 +00:00
Translation updater bot aff602ecdd Localisation updates from http://translatewiki.net.
Change-Id: I1250216a02e127c20a33ef0812431f99bb8aeba3
2013-10-12 18:41:21 +00:00