Commit graph

1378 commits

Author SHA1 Message Date
Umherirrender 6af1473ca6 Replace deprecated wfReadOnly()
Bug: T283978
Change-Id: I5c796a0473599c71848b6079874bc7a969ee6f88
2022-02-11 23:39:06 +01:00
Umherirrender ffeee975a4 Replace deprecated User::newFromIdentity with UserFactory
Moved the factory deeper into the code right before the one usage it
still needed a full user object

Narrow done method arguments from User to UserIdentity
and use the identity directly

Change-Id: Ic118f23ef504c7fda892480df61ea68c10915f78
2022-02-11 20:35:49 +00:00
Umherirrender f21d2a5088 build: Remove unneeded phan suppression
Bug: T290624
Change-Id: Ie0209c72863aae8ac020a09e625f0c4613decca5
2022-02-11 20:57:34 +01:00
Siddharth VP d983f99f49 Exclude dynamic namespaces for page-linked-title muted list
The form UI currently allows selecting Special/Media pages, even though these notifications are not applicable on those pages.

Also:
- Update some comments regarding LoadUserOptions hook
- Remove $titleFactory as MultiTitleFilter doesn't require it any longer

Change-Id: I74f7b0091cb5f47c34a54958656e2bce20a394ec
2022-01-29 04:51:06 +00:00
Umherirrender 9bf6ceb738 Replace deprecated JobQueueGroup::singleton()
Change-Id: I298d8507f4ec706c235087b726b7b230ed5e9ac6
2022-01-25 22:24:53 +01:00
jenkins-bot a8af58f362 Merge "Parse section titles in notifs as if they weren't at the start of line" 2022-01-24 05:43:44 +00:00
jenkins-bot 302d272480 Merge "Allow overriding section title presentation in subclasses" 2022-01-24 05:42:12 +00:00
jenkins-bot ef3c4ff4e3 Merge "Avoid double-escaping in notification watch links" 2022-01-21 17:08:30 +00:00
jenkins-bot cc111b95bf Merge "Make JsonSerializable PHP 8.1 compatible" 2022-01-21 13:01:50 +00:00
Gergő Tisza 7a9bb5b7f2
Avoid double-escaping in notification watch links
Bug: T270156
Change-Id: I6973b6112fbb5caf409de168844ae2af20117bd7
2022-01-21 01:25:22 -08:00
Gergő Tisza e7248ea1ff
Make JsonSerializable PHP 8.1 compatible
Bug: T299695
Change-Id: If7d21100e7e20d8467685ae7515304cefabe4796
2022-01-21 01:18:18 -08:00
jenkins-bot ceda28121f Merge "Adjust doc for EchoNotification::readTimestamp" 2022-01-21 08:11:26 +00:00
Bartosz Dziewoński 3493317d79 Parse section titles in notifs as if they weren't at the start of line
The section titles are wikitext extracted from inside heading markup
like `== … ==`, so start-of-line markup like `*` should not be parsed.

Bug: T299572
Change-Id: Ie3995b943e5fe20ad86041d6be755f14f32eb01e
2022-01-21 00:07:53 +01:00
Bartosz Dziewoński f66c4283e9 Allow overriding section title presentation in subclasses
Change-Id: Idb3a87fd18330f90a8cdc1276994d54288e17b28
2022-01-20 23:50:47 +01:00
Kosta Harlan ac17edf21c EchoHooks: Don't call saveSettings in LocalUserCreated
$user->saveSettings() happens in AuthManager after the LocalUserCreated
hook finishes running.

Bug: T199393
Change-Id: I1e1826c9f304d7b6c8f3663196a48267a0af0bae
2022-01-12 19:21:53 +01:00
Umherirrender 8e974de839 Adjust doc for EchoNotification::readTimestamp
And simplify the null check
Fix tests to provide null and not the empty string

Change-Id: Ic0f2dc09525f1542c7e62da97ac0f3fe936ff67e
2022-01-05 20:29:03 +01:00
Alexander Vorwerk ce7532b212 Replace usages of deprecated wfWikiID()
The global function wfWikiID() is deprecated since 1.35 and it's usages
should be replaced with WikiMap::getCurrentWikiId().

Bug: T298059
Change-Id: Ia8cbc992eb80ee6d531cf11bdf2bc06181bce8b0
2021-12-21 02:01:11 +00:00
jenkins-bot 194b946b38 Merge "Specify that watchlist emails are only sent once per page" 2021-12-14 18:48:22 +00:00
Pppery cf1acd5048 Specify that watchlist emails are only sent once per page
Bug: T203941
Change-Id: I2a19b06dbddd927a0f9c046301abc698c2494b8d
2021-12-12 13:35:12 -05:00
jenkins-bot af28444bae Merge "Avoid using User::getOption() method" 2021-12-10 13:22:40 +00:00
vladshapik a3c55f6272 Avoid using User::getOption() method
Replace User::getOption() with UserOptionsLookup::getOption() since this method will be hard-deprecated.

Bug: T296083
Change-Id: I0ecdc63b0344bc4c24196cc5edb3d02b6a7ed615
2021-12-10 13:37:45 +01:00
Tim Starling 7dbc05fd8b Use the LinksUpdateComplete hook
* Use LinksUpdateComplete instead of the unusual hook
  LinksUpdateAfterInsert, which I want to deprecate.
* Fix the fixme regarding revert detection in link events. It's not
  pretty but I confirmed that it works with undo and rollback.

Bug: T297011
Change-Id: Ic0092a55e85a3db78db98f1a3dfdce74a7fa2b29
2021-12-08 16:23:14 +11:00
Tim Starling f79412202c Avoid LinksUpdate public properties
Access to these public properties will soon be deprecated.

Bug: T296895
Change-Id: I73575e654717aa2c49057c3b57c8eda1fc8da1e0
2021-12-08 16:23:14 +11:00
Cole White fea3813907 Pass entire response object to response attribute
Fixes mapper parsing errors in Logstash because most other producers
generate the response field as an object.

Bug: T239458
Change-Id: I95436dce23efde7f4aa460007187a7544cc36462
2021-12-01 01:31:53 +00:00
jenkins-bot e605f56df7 Merge "Construct title from RC title params" 2021-11-26 22:10:59 +00:00
Legoktm 1cf14cd87a Revert "Add echo-cross-wiki-notifications to DefaultUserOptions"
This reverts commit 617e22564f.

Reason for revert: Disabled cross-wiki notifications for everyone.

Bug: T296270
Change-Id: Ic770b18b11d0a7280f6e205b0593d7088f5ac725
2021-11-23 19:29:32 +00:00
Kunal Mehta 2cfe757af4 Suppress SecurityCheck-DoubleEscaped in DiscussionParser
For now, to get phan/CI to pass again.

Change-Id: Ie69da3fd2b2b5463e9d22f0d77d10ddf6dfb3c72
2021-11-23 11:24:29 -08:00
Kosta Harlan 8cbab216a9 Construct title from RC title params
If the page is deleted, we won't be able to find it (easily) in
WatchlistChangePresentationModel. Luckily there's support for using
backup data for constructing the title; we just need to pass along the
DBKey and namespace data in the extra params for the event.

Bug: T286192
Change-Id: I8e46de9599a213d9c22ce7bbedefa00528887f59
2021-11-03 15:47:50 +01:00
Umherirrender 617e22564f Add echo-cross-wiki-notifications to DefaultUserOptions
Without the default the preference is never deleted from the database,
even it was disabled by the user.

Bug: T291748
Change-Id: Id7c79d8e8f0de4f1d3d624a16fc3783fbded7f49
2021-10-26 20:28:57 +00:00
Reedy 4814d14b85 Update comment about AbuseFilterVariableHolder
Change-Id: I81f71179ce7af081bedf1ed36bdb1aed80f9a08f
2021-10-14 21:38:55 +01:00
jenkins-bot 19369c1e04 Merge "Revert "Use namespaced CentralAuthSessionProvider"" 2021-10-07 19:55:30 +00:00
Urbanecm 055ee16c1c Revert "Use namespaced CentralAuthSessionProvider"
This reverts commit 393aace621.

Reason for revert: namespacing reverted in I1d358d178a3999e82e7a25e17851c3cf60d7ddaa.

Change-Id: If4f7ddf51cbd63dc782e61b389b3f45effc13299
2021-10-07 19:29:20 +00:00
TChin ceeba5efe6 Replace deprecated Title::newFromIDs
Bug: T291288
Change-Id: I259d3f8d4c4fc7cd8ce008f3e63d1208c2b002b7
2021-10-01 16:22:36 -04:00
Alexander Vorwerk 393aace621 Use namespaced CentralAuthSessionProvider
Change-Id: I56fbd065cbb4f1f0c882759e8a5d6d0ffb4dcec1
2021-09-29 22:28:47 +02:00
Umherirrender 58fb5c28a7 Implement MessageLocalizer in EchoEventPresentationModel
Change-Id: I759a4797ec143f9434d2aa00c84fd8021eda6ccb
2021-09-27 20:32:52 +02:00
Alexander Vorwerk 89dec69155 Avoid using MWNamespace
The MWNamespace class has been deprecated in favor of the NamespaceInfo
service. All methods in the MWNamespace should be replaced with the
equivalent methods of the NamespaceInfo service.

Bug: T291389
Change-Id: I396c50c7537b21b2f88dd9433180a8317c5c27f3
2021-09-26 16:40:27 +02:00
Umherirrender a0cb29f1a2 Check for empty strings in markasread query param
explode always returns an array with one item, even for the empty string
Filter out every possible empty string

Change-Id: I0cf0794c0f3e0eedab7e5626e973d8458b28e46a
2021-09-20 22:57:17 +02:00
Umherirrender 76227585f9 Avoid non-namespaced aliases for Wikimedia\Rdbms namespace
Change-Id: Ic924c72cb06d09bebd42272f204c3666ce62844b
2021-09-18 20:06:54 +02:00
libraryupgrader 43efb95e8b build: Updating composer dependencies
* mediawiki/mediawiki-phan-config: 0.10.6 → 0.11.0
* php-parallel-lint/php-parallel-lint: 1.3.0 → 1.3.1

Change-Id: If2e235fb97c0d39c3c14ba7c423ef45f5c0013d0
2021-09-08 23:40:19 +00:00
James D. Forrester a47a421696 Alter use of deprecated methods to ones called 'Primary'
This extension already depends on MW 1.37, so all these methods exist.

Bug: T254646
Depends-On: I9a90b4f74eb65cd9e20ae9faa6d1949be96543c0
Change-Id: Iebfdd33d3a967c87fbf87382a010a01da5cd4fc8
2021-09-03 17:46:20 -07:00
jdlrobson bd02290724 You have talk page messages item should never have icon
talk-alert copies the mytalk link but does not disable the icon.
In future this will cause an unexpected icon to appear on the
message bar which is not wanted.

Change-Id: Icd585ad846275a140eb08edf99e1b27257484941
2021-09-03 19:22:12 +00:00
jenkins-bot d94e62fde5 Merge "Push: Make default notification options mirror web if push is enabled" 2021-08-29 03:57:37 +00:00
jenkins-bot 7e9565cba1 Merge "Fix camelCase of getUserEnabledEventsBySections" 2021-08-23 20:48:28 +00:00
Matěj Suchánek 628122e155 Fix camelCase of getUserEnabledEventsBySections
Change-Id: I14b6750f7f3cc5334e3143f0e85ca033681b4e35
2021-08-20 17:03:28 +00:00
Matěj Suchánek 6cd82d25a7 Make DEFAULT_SECTION a constant
Change-Id: I565f1e127cfffcbdad8fe5f6cb81a71bf86136f8
2021-08-20 18:59:34 +02:00
jenkins-bot 31a5ab4e7b Merge "Parse messages in hook onSkinTemplateNavigationUniversal" 2021-08-20 08:06:48 +00:00
Umherirrender 6c3dc7449f Parse messages in hook onSkinTemplateNavigationUniversal
Using 'text' in skins must provide a string,
not a message (see Skin->makeLink)
Avoid also global state by using the SkinTemplate as ContextSource for
the message

Change-Id: Ie736487023d7aeb31cdb1829ba59adeb0ba2b022
2021-08-20 00:44:31 +02:00
Umherirrender b4617bfa31 Use EchoEventPresentationModel::msg inside models
Avoid global state for the message

Change-Id: I0a961aeed9c352ebbe24d07f0986cdac2c457e37
2021-08-20 00:39:39 +02:00
jenkins-bot 5cfc33d546 Merge "Add notifiertypes parameter to ApiEchoNotifications" 2021-08-19 05:06:57 +00:00
jenkins-bot fa5a623be0 Merge "Move isBundleExpandable to EchoAttributeManager" 2021-08-19 02:02:46 +00:00