build: Updating composer dependencies

* mediawiki/mediawiki-phan-config: 0.10.6 → 0.11.0
* php-parallel-lint/php-parallel-lint: 1.3.0 → 1.3.1

Change-Id: If2e235fb97c0d39c3c14ba7c423ef45f5c0013d0

composer.json

@@ -1,10 +1,10 @@
 {
 	"require-dev": {
 		"mediawiki/mediawiki-codesniffer": "37.0.0",
-		"mediawiki/mediawiki-phan-config": "0.10.6",
+		"mediawiki/mediawiki-phan-config": "0.11.0",
 		"mediawiki/minus-x": "1.1.1",
 		"php-parallel-lint/php-console-highlighter": "0.5.0",
-		"php-parallel-lint/php-parallel-lint": "1.3.0"
+		"php-parallel-lint/php-parallel-lint": "1.3.1"
 	},
 	"scripts": {
 		"test": [

includes/DiscussionParser.php

@@ -210,7 +210,7 @@ abstract class EchoDiscussionParser {
 				$found = true;
 			}
 		}
-		if ( $found === false ) {
+		if ( !$found ) {
 			return [ 'section-title' => '', 'section-text' => '' ];
 		}
 

includes/EchoDbFactory.php

@@ -1,7 +1,7 @@
 <?php
 
 use MediaWiki\MediaWikiServices;
-use Wikimedia\Rdbms\LoadBalancer;
+use Wikimedia\Rdbms\ILoadBalancer;
 
 /**
  * Database factory class, this will determine whether to use the main database
@@ -54,7 +54,7 @@ class MWEchoDbFactory {
 
 	/**
 	 * Get the database load balancer
-	 * @return LoadBalancer
+	 * @return ILoadBalancer
 	 */
 	protected function getLB() {
 		// Use the external db defined for Echo
@@ -68,7 +68,7 @@ class MWEchoDbFactory {
 	}
 
 	/**
-	 * @return LoadBalancer
+	 * @return ILoadBalancer
 	 */
 	protected function getSharedLB() {
 		if ( $this->sharedCluster ) {

includes/api/ApiEchoMute.php

@@ -78,8 +78,6 @@ class ApiEchoMute extends ApiBase {
 
 		if ( $changed ) {
 			$this->userOptionsManager->setOption(
-				// Phan does not understand dieWithError() - T240141
-				// @phan-suppress-next-line PhanTypeMismatchArgumentNullable
 				$user,
 				$mutelistInfo['pref'],
 				$this->serializePref( $ids, $mutelistInfo['type'] )

includes/formatters/EchoModelFormatter.php

@@ -8,7 +8,6 @@ class EchoModelFormatter extends EchoEventFormatter {
 	/**
 	 * @param EchoEventPresentationModel $model
 	 * @return array
-	 * @suppress SecurityCheck-DoubleEscaped
 	 */
 	protected function formatModel( EchoEventPresentationModel $model ) {
 		$data = $model->jsonSerialize();

includes/formatters/EventPresentationModel.php

@@ -113,6 +113,7 @@ abstract class EchoEventPresentationModel implements JsonSerializable {
 		global $wgEchoNotifications;
 		// @todo don't depend upon globals
 
+		// @phan-suppress-next-line PhanTypeArraySuspiciousNullable
 		$class = $wgEchoNotifications[$event->getType()]['presentation-model'];
 		return new $class( $event, $language, $user, $distributionType );
 	}

includes/special/NotificationPager.php

@@ -17,6 +17,7 @@ class NotificationPager extends ReverseChronologicalPager {
 	}
 
 	public function formatRow( $row ) {
+		// @phan-suppress-previous-line PhanPluginNeverReturnMethod LSP violation
 		throw new Exception( "This pager does not support row formatting. " .
 			"Use 'getNotifications()' to get a list of EchoNotification objects." );
 	}