wikimedia/mediawiki-extensions-Echo
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Echo synced 2024-11-12 09:26:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

Parse messages in hook onSkinTemplateNavigationUniversal

Browse source 
Using 'text' in skins must provide a string,
not a message (see Skin->makeLink)
Avoid also global state by using the SkinTemplate as ContextSource for
the message

Change-Id: Ie736487023d7aeb31cdb1829ba59adeb0ba2b022
This commit is contained in:
Umherirrender 2021-08-20 00:44:31 +02:00
parent ed4a80422d
commit 6c3dc7449f
1 changed files with 2 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
includes/EchoHooks.php
View file

@ -1030,9 +1030,6 @@ class EchoHooks implements RecentChange_saveHook {
$msgFormattedCount = EchoNotificationController::formatNotificationCount( $msgCount );
$alertFormattedCount = EchoNotificationController::formatNotificationCount( $alertCount );
$msgText = wfMessage( 'echo-notification-notice', $msgCount );
$alertText = wfMessage( 'echo-notification-alert', $alertCount );
$url = SpecialPage::getTitleFor( 'Notifications' )->getLocalURL();
// HACK: inverted icons only work in the "MediaWiki" OOUI theme
@ -1113,7 +1110,7 @@ class EchoHooks implements RecentChange_saveHook {
$links['notifications']['notifications-alert'] = [
'href' => $url,
'text' => $alertText,
'text' => $skinTemplate->msg( 'echo-notification-alert', $alertCount )->text(),
'active' => ( $url == $title->getLocalURL() ),
'link-class' => $alertLinkClasses,
'data' => [
@ -1126,7 +1123,7 @@ class EchoHooks implements RecentChange_saveHook {
$links['notifications']['notifications-notice'] = [
'href' => $url,
'text' => $msgText,
'text' => $skinTemplate->msg( 'echo-notification-notice', $msgCount )->text(),
'active' => ( $url == $title->getLocalURL() ),
'link-class' => $msgLinkClasses,
'data' => [