Commit graph

1653 commits

Author SHA1 Message Date
Matthias Mullie 58e1c765d6 Improve signature detection
Previously, there were a couple of hacks in play.
It was also not picking up ~~~ (signature without timestamp)
And it relied an a nasty regular expression which, although
based on Parser, may some day get out of date.
And it relied heavily on a specific signature format, which
isn't guaranteed (it's an i18n msg)

This patch changes the approach: it will use a very simple
regex to match links, and will send those through Parser to
generate the signature anew. My reasoning is that that should
be exactly the same as what Echo just received (should've
also gone through parser)

Biggest discomfort of this approach is that it's much stricter.
It should still match whatever it generated from a ~~~ or ~~~~,
but no longer the e.g. not-real signatures we were doing in
our tests. Also had to update our tests, because signatures
change depending on anon. So I had to generate all the users.
And fix some of the signature formats used in the tests.

Bug: T75426
Bug: T87852
Bug: T75366
Bug: T78424
Change-Id: Ibeff36397129fdd5d376f3668a23a45f9a014525
2015-02-05 20:45:19 +01:00
Erik Bernhardson 2578c37d6c Bug: Fails signature detection with extra long signature
There were two different circumstances that could trigger echo's signature
detection to fail: multibyte characters in signature, and signatures near
$wgMaxSigChars limit that expanded past the limit due to wfEscapeWikiText().

This patch adjusts to use mb_substr to appropriatly handle the multibyte
characters, and adds a couple extra charactesr to $wgMaxSigChars to allow
for wfEscapeWikiText().  This isn't perfect, but a stricter implementation
would require much more work than i think we should spend here.

Bug: 73426
Change-Id: Ic51c2bc2a08600f188db13a9a0537f1321c9a655
2014-12-03 11:33:39 -08:00
Erik Bernhardson 4549a312cc Bug: parenthesis are allowed in namespaces
Bug: 73366
Change-Id: I7304046cfa7eda6356b2c61e716d76330cf1ee56
2014-11-13 11:52:06 -08:00
Translation updater bot 262a3a1587 Localisation updates from https://translatewiki.net.
Change-Id: Id49a10474f350144264f06ad8dcea42da66f8708
2014-11-12 21:50:59 +01:00
Translation updater bot 20b207efc3 Localisation updates from https://translatewiki.net.
Change-Id: Ida94b464554472c51bfbce99ab6a8e70d330e09d
2014-11-11 22:11:18 +01:00
Cmcmahon bf9773e6ed QA update for single quote preference
Change-Id: I35d22c47abd78a588f622b9b7cd07444c345db5a
2014-11-10 14:21:28 -07:00
Cmcmahon 6468f8e575 QA update quotes for string interpolation
Change-Id: Ic74333eea147183f407ffbe2b5319bb4683b5833
2014-11-10 14:14:52 -07:00
jenkins-bot 704049f360 Merge "QA: rubocop updates" 2014-11-10 17:51:17 +00:00
Cmcmahon 1ac73fa54b QA: rubocop updates
Change-Id: I580ec597dbb0d1dcd0830233995f94bc27d10278
2014-11-10 10:50:10 -07:00
Translation updater bot f50a641cc7 Localisation updates from https://translatewiki.net.
Change-Id: Ic3b4dabdcdbf53168735e6746a9ca4f5bc6b0a27
2014-11-09 21:50:15 +01:00
Translation updater bot 5e3370a542 Localisation updates from https://translatewiki.net.
Change-Id: I053b9ae4c77fb1d36b3097f7a906567b3a475e44
2014-11-08 22:17:34 +01:00
jenkins-bot e34ed8c61e Merge "QA: rubocop config updated to baseline again" 2014-11-07 21:21:23 +00:00
Cmcmahon 0bfd18dbc7 QA: rubocop config updated to baseline again
Change-Id: Ic399ef9bb681cfed25b0b775b0c430e338f11bd3
2014-11-07 14:19:31 -07:00
Translation updater bot 0ca69f2c44 Merge "Localisation updates from https://translatewiki.net." 2014-11-07 21:17:16 +00:00
Cmcmahon af6e1756c6 QA: update rubocop todo to baseline
Change-Id: Ia22d5ab6e15fb79fd2a27f6fa1b41864f7a09307
2014-11-07 14:11:54 -07:00
Translation updater bot a06556da80 Localisation updates from https://translatewiki.net.
Change-Id: I0c291da4a9d23f893d967831e278ca0fdba5cec0
2014-11-07 22:10:43 +01:00
Cmcmahon 227906b1f5 QA: update ruby gems
Change-Id: I1666058af0de35ac611eac0e284fa190bcf55966
2014-11-07 14:03:57 -07:00
Translation updater bot 32ff462db3 Localisation updates from https://translatewiki.net.
Change-Id: Ica057e02ddcc46c5ed58a0545929dbab5046a15b
2014-11-06 21:49:38 +01:00
jenkins-bot 36cd2c5ad5 Merge "Remove 'uselang' parameter hack which is no longer needed" 2014-11-05 21:53:30 +00:00
Kunal Mehta bf37b5261d Remove 'uselang' parameter hack which is no longer needed
ApiMain now has a 'uselang' parameter

Change-Id: Ifefc8aa09e51391ad2cf9c33beaf47848ed1f399
2014-11-05 13:34:42 -08:00
Translation updater bot 71fae902e3 Localisation updates from https://translatewiki.net.
Change-Id: Ic4a7cca21262e98b589dacd9520df30b03983f13
2014-11-05 21:42:10 +01:00
Translation updater bot 449b1b075c Localisation updates from https://translatewiki.net.
Change-Id: Id6848fc00a88d67d5ae98cbef5746a9d4593b309
2014-11-04 23:26:54 +01:00
jenkins-bot a784331871 Merge "Add i18n for API module help" 2014-11-04 00:08:12 +00:00
Translation updater bot 8d9fdc3a85 Localisation updates from https://translatewiki.net.
Change-Id: I5bde0dc863d28e70e4a4213bddf3ec4c8f26aa47
2014-11-02 21:57:54 +01:00
Translation updater bot c7c3f680d5 Localisation updates from https://translatewiki.net.
Change-Id: Id73d3d2d26d350196495d159155e4ff3573a179a
2014-10-29 22:05:24 +01:00
Brad Jorsch 09c881e1a0 Add i18n for API module help
MediaWiki core change I04b1a384 added support for i18n of API module
help. This takes advantage of that while still maintaining backwards
compatibility with earlier versions of MediaWiki.

Once support for MediaWiki before 1.25 is dropped, the methods marked
deprecated in this patch may be removed.

Change-Id: I67395aff48185f3e09da31b51a08aa2541fe6a17
2014-10-29 16:37:38 -04:00
Translation updater bot 9780f3b608 Localisation updates from https://translatewiki.net.
Change-Id: I53bb02d3fd6d1ca861ef4e3f18314f398fdcda87
2014-10-28 15:15:25 +01:00
Translation updater bot 46b9e78dc1 Localisation updates from https://translatewiki.net.
Change-Id: Ia45ebefcf5bcdd50a65b682401044ca997e23058
2014-10-27 20:10:09 +01:00
jenkins-bot 2946919a03 Merge "Limit Echo mentions to 20 users" 2014-10-27 15:40:38 +00:00
jenkins-bot ffe55d81b4 Merge "I-2. Change the default number of Flow Messages in the flyout" 2014-10-27 14:50:19 +00:00
Translation updater bot ea9d729758 Localisation updates from https://translatewiki.net.
Change-Id: I2307c0748992e6c0f3913e2ec85a7b56c530f62e
2014-10-26 21:07:39 +01:00
jenkins-bot d24b803a25 Merge "Bug: Detect classes within the special directory" 2014-10-24 23:12:38 +00:00
Erik Bernhardson 830e7c4e4f Bug: Detect classes within the special directory
Change-Id: I317b58bfae1c8a79a933949293e7bec29b613460
2014-10-24 16:11:09 -07:00
Translation updater bot 182f3286e0 Localisation updates from https://translatewiki.net.
Change-Id: I78844c9d1b4353d428acc4569df8839fae5ed481
2014-10-24 22:19:11 +02:00
Kunal Mehta c2c3aba65f Capitalize class name properly
Change-Id: I980062dee776a2653ab74d392731af01b81889bc
2014-10-24 12:16:37 -07:00
jenkins-bot 2b9386450b Merge "Hygiene: autogenerate $wgAutoloadFiles lines" 2014-10-24 08:03:02 +00:00
Translation updater bot a7b46d40d2 Merge "Localisation updates from https://translatewiki.net." 2014-10-23 21:30:09 +00:00
jenkins-bot c5559da8cb Merge "Detect signature using Title class" 2014-10-23 21:25:37 +00:00
Translation updater bot 9aaadb6781 Localisation updates from https://translatewiki.net.
Change-Id: I0eb84b75e0f439c1b6d8c47c2f4bc4d00ba414e2
2014-10-23 23:23:01 +02:00
Erik Bernhardson e69c63813e Hygiene: autogenerate $wgAutoloadFiles lines
Change-Id: I4f4d9f9d1c9dde0471611271ceb1ae074d19df72
2014-10-23 12:09:33 -07:00
Translation updater bot c7b9326633 Localisation updates from https://translatewiki.net.
Change-Id: Iea5a32c6739cff8bae15e99f155ec113872d893e
2014-10-22 22:02:23 +02:00
jenkins-bot cbb0dd732d Merge "Add UserMerge support" 2014-10-21 20:08:45 +00:00
Željko Filipin 57241c6867 Prepare repository for running RuboCop after every push to Gerrit
For now ignoring all problems.

Bug: 69245
Change-Id: I0e411fba725ecd9aea0ef9d40a145efb62bbf0fa
2014-10-21 12:59:54 +02:00
Translation updater bot 973e21cbfe Localisation updates from https://translatewiki.net.
Change-Id: Ib1511b38cadbf8a420d20ade665e55816045a26f
2014-10-20 22:25:05 +02:00
jenkins-bot d495389a1c Merge "Use MailAddress::newFromUser()" 2014-10-20 17:25:11 +00:00
Translation updater bot 3d91ac75a4 Localisation updates from https://translatewiki.net.
Change-Id: Iee9a14896bf4b7e772725caf5c55f3dc29035d99
2014-10-19 22:05:05 +02:00
Translation updater bot 1688269aff Localisation updates from https://translatewiki.net.
Change-Id: Iee7638b8b30ed07c863929a1fe0ad7be5939691f
2014-10-17 21:14:46 +02:00
Kunal Mehta fae2556494 Add UserMerge support
Depends on Id1726673 in UserMerge to allow specifying
a custom database object to use.

Bug: 67766
Change-Id: Iceb4b8d2fd53c50ed00a4aab9bc374f4bb716466
2014-10-17 10:08:59 -07:00
jenkins-bot b6ea35e743 Merge "SpecialNotifications: Use a constant" 2014-10-16 05:16:13 +00:00
jenkins-bot eb89852cc6 Merge "Remove unused global" 2014-10-16 05:16:11 +00:00