Commit graph

7317 commits

Author SHA1 Message Date
Translation updater bot 3ed0741b2c
Localisation updates from https://translatewiki.net.
Change-Id: If0fa27a35108a75d73f1684524c947a7ca2de607
2024-12-09 08:21:39 +01:00
jenkins-bot 87af9edafa Merge "Clean up dead or unnecessarily complex code" 2024-12-07 14:19:48 +00:00
jenkins-bot 3f173be4fc Merge "Add azerbaijani special page aliases" 2024-12-07 10:33:22 +00:00
Matěj Suchánek 2daec3b970 Clean up dead or unnecessarily complex code
Change-Id: I94d25adb5b6c6b4f82a6458828d6dbb8fc88c4c3
2024-12-07 11:24:11 +01:00
jenkins-bot 26f98f35d6 Merge "DiscussionParser: Update some deprecated User methods" 2024-12-07 10:23:13 +00:00
Translation updater bot 179c55469f
Localisation updates from https://translatewiki.net.
Change-Id: Ib3c55de3a02a979bbe09529f113a171c3df0f36e
2024-12-06 08:17:01 +01:00
jenkins-bot 40b62cfa7f Merge "Make ThankYouEditTest better test updates in web request mode" 2024-12-05 22:06:42 +00:00
Aaron Schulz 135087430b Make ThankYouEditTest better test updates in web request mode
CLI mode assertions will be enabled once core is updated in order
to avoid circular CI dependencies.

Rename getEditCount() to getPostSaveEditCount() and always add 1
to the count ahead of I50aa9fe9387c9b7b7ff97dfd39a2830bce647db8.
It will be off by 1 in CLI mode before that gets merged, which is
not likely to matter since most edits are via web requests. Even
edits through jobs are wrapped in the same DBO_TRX transactions as
web-requests for WMF sites since we use an HTTP-based job runner.

Change-Id: I33d94c1c54bc266c74c980ef1c73fd99a55c268e
2024-12-05 18:12:01 +00:00
Translation updater bot 53ebba998c
Localisation updates from https://translatewiki.net.
Change-Id: Ic75d4ee4e2af6a4e1bff586e2f7957d5de507202
2024-12-04 08:22:08 +01:00
Translation updater bot aab50fd742
Localisation updates from https://translatewiki.net.
Change-Id: Ibf8fc11b8e589ff1641282bff9a24c9cf21df460
2024-12-03 08:16:33 +01:00
Nemoralis ec5b894f1c Add azerbaijani special page aliases
Bug: T381048
Change-Id: I37246ef37ac60f50097d5d0d73e49f68f9bb34fd
2024-12-03 00:01:00 +04:00
jenkins-bot 28962b985e Merge "prefs: Remove trailing full stop from message" 2024-12-02 15:48:34 +00:00
Translation updater bot 5e5216040b
Localisation updates from https://translatewiki.net.
Change-Id: I786024a98025a5aa8f4a08ea7d08fa810cf0536c
2024-12-02 08:21:54 +01:00
libraryupgrader 2befcd258d build: Updating jsdoc to 4.0.4
Change-Id: I104e750cd5ee6fa1ea80d38b7508900fe79ff27a
2024-12-02 01:13:36 +00:00
Reedy 153c5753c9 prefs: Remove trailing full stop from message
More consistent

Change-Id: I53227c090e997653caaa18b81461b9cffcf91ffc
2024-12-01 00:20:07 +00:00
Translation updater bot c39878c78c
Localisation updates from https://translatewiki.net.
Change-Id: I369abb0a351efd3b89dcca61844fa5875858582c
2024-11-29 08:31:04 +01:00
Tim Starling 105f2a3845 Fix installer error when the task is run a second time
Fix task idempotency. Check if a table exists before running the schema
patch.

Bug: T352113
Change-Id: If6f0930ea327df35fe118d4a08993c6383f9d579
2024-11-28 14:54:42 +11:00
jenkins-bot 441ca70fbf Merge "selenium: Replace Node.js Assert library with WebdriverIO Expect library" 2024-11-27 12:16:19 +00:00
Translation updater bot 95a84c8447
Localisation updates from https://translatewiki.net.
Change-Id: I540949da7a8849f7dcc582c8cf05d1afbfccc0bb
2024-11-26 08:16:30 +01:00
Translation updater bot e962ab70d8
Localisation updates from https://translatewiki.net.
Change-Id: Ic605597ebea08237fec6980c89b381c3ebe83e5f
2024-11-25 08:23:14 +01:00
jenkins-bot 4897e2f2a6 Merge "Move addWiki.php special case to an installer task" 2024-11-22 10:38:32 +00:00
Željko Filipin 23ac1201a5 selenium: Replace Node.js Assert library with WebdriverIO Expect library
Assertions from Expect library are more readable that assertions from Assert library.

Bug: T325740
Change-Id: I8c31444538670e1500574415cec3a4d54d3798b4
2024-11-21 14:20:21 +01:00
jenkins-bot 30921ae5fe Merge "DiscussionParser: Don't construct Users with invalid names" 2024-11-21 12:24:57 +00:00
jenkins-bot c532845d48 Merge "DiscussionParserTest: Add some test case names" 2024-11-21 10:47:12 +00:00
jenkins-bot 4786e85782 Merge "SeenTime: Actually use an in-process cache" 2024-11-21 08:13:21 +00:00
Translation updater bot 7cd9f81828
Localisation updates from https://translatewiki.net.
Change-Id: I4afccc558aa24b9bdcb6caff717971fb7cb3411c
2024-11-21 08:21:45 +01:00
Bartosz Dziewoński 39be79c1b0 SeenTime: Actually use an in-process cache
It doesn't work if every call to cache() returns
a different CachedBagOStuff :')

I found this thanks to log warnings I saw locally:

  SQLBagOStuff.WARNING: Duplicate get():
  "mediawiki:echo:seen:alert:time:1" fetched 2 times
  SQLBagOStuff.WARNING: Duplicate get():
  "mediawiki:echo:seen:message:time:1" fetched 2 times

Change-Id: I9a920de88275c1297942b064cc635d5c25424fd2
2024-11-21 03:00:19 +01:00
Bartosz Dziewoński b2da91b940 DiscussionParser: Update some deprecated User methods
Change-Id: I3be893af4abf579ca50360312bb1b157ef01e63f
2024-11-20 20:04:45 +00:00
Bartosz Dziewoński 124162fee4 DiscussionParser: Don't construct Users with invalid names
The comment said "don't validate the username - anon (IP) is fine!"
– but it also allowed invalid names, not just IPs, and those are not
really fine.

Also add more test cases and remove some unused test code.

Bug: T380242
Change-Id: Id98f14a0663f33eb5e45045bcd2df6a1e1f52de6
2024-11-20 21:04:34 +01:00
Tim Starling 3a45c2600b Move addWiki.php special case to an installer task
Bug: T352113
Depends-On: Ie7c466012d8d5644b1398452e3077416ab0270c5
Change-Id: I752edd8daaebb91a4bd9a7797747ade96d537526
2024-11-20 11:00:45 +11:00
Bartosz Dziewoński 09daeb5ba2 DiscussionParserTest: Add some test case names
PHPUnit will display them if the tests fail.

Change-Id: Iff695d801819e13c238929912433e6a97e14ec54
2024-11-19 23:58:21 +01:00
Translation updater bot 0a50bd16cd
Localisation updates from https://translatewiki.net.
Change-Id: I2653f400f40a3285e8af73a0f428382cb5cb1ca9
2024-11-19 08:17:44 +01:00
Translation updater bot cc0d2c1451
Localisation updates from https://translatewiki.net.
Change-Id: I2550e63d1156e143318e50e5973c085e500cbe36
2024-11-18 08:23:42 +01:00
Translation updater bot 4821d45e60
Localisation updates from https://translatewiki.net.
Change-Id: I374c9eb3e05586ffe7793c2d719bbccd0b00e0ff
2024-11-15 08:44:50 +01:00
jenkins-bot 149727038d Merge "Disallow anonymous non-IP agents, handle truncated names" 2024-11-14 16:19:19 +00:00
jenkins-bot eab588bcf0 Merge "selenium: Delete tests disabled more than two years ago" 2024-11-14 12:05:58 +00:00
Matěj Suchánek 11b9e66f9f Disallow anonymous non-IP agents, handle truncated names
Why:
* Echo stores agents by their user id or by the name if the user
  is not registered. This works for IPs since the "event_agent_ip"
  field has limit of 39 bytes (32× [0-9A-F] + 7× colon for IPv6).
* However, it's possible to hold a user identity that is not
  an IP address, but the user name has not been or cannot be
  registered (e.g., external users). Echo wouldn't validate this
  and would attempt to insert the user name into "event_agent_ip",
  possibly causing silent truncation and data corruption.

What:
* Do not let events with such agents be saved. For now, log an
  error in the production. Wikibase, the only known source of this
  problem, has already been fixed.
* In runtime, replace every possibly corrupted user name with
  a placeholder to avoid unexpected null values and exceptions
  in production.

Bug: T367638
Change-Id: Ic2bd218b10651d13da9e9aea54dd2d668a33d946
Depends-On: I03b4367355dc5a3fc0c14aad5fdf19fbcd0caa3d
Depends-On: I92eb93983e81708b289e9f7d837884d539dade0b
2024-11-14 11:44:19 +01:00
jenkins-bot eff1de4fdf Merge "Explicitly call DeferredUpdates::tryOpportunisticExecute() in ThankYouEditTest" 2024-11-12 17:32:54 +00:00
Translation updater bot dc0ff7e07d
Localisation updates from https://translatewiki.net.
Change-Id: Ieaa5e8290eef38220c526a8f8e6c9a183f5a0172
2024-11-12 08:17:49 +01:00
Translation updater bot 7a0b8d27e0
Localisation updates from https://translatewiki.net.
Change-Id: I8c0d71ced10918fa8e332e6e27f115f5e60990e2
2024-11-11 08:22:34 +01:00
Aaron Schulz 88ab531e17 Explicitly call DeferredUpdates::tryOpportunisticExecute() in ThankYouEditTest
Change-Id: I423f9a856fddab30e691d78cbcd0b70a292e3916
2024-11-07 12:16:46 -08:00
Translation updater bot 6b09de87db
Localisation updates from https://translatewiki.net.
Change-Id: Id8b159f2163e4a70dfc7ba95bd992e1c87c3a735
2024-11-07 08:18:37 +01:00
Translation updater bot 921cfcc165
Localisation updates from https://translatewiki.net.
Change-Id: I5a97aaa588ff592af366897959996853adb4dfb0
2024-11-06 08:22:19 +01:00
Translation updater bot f8a1081bb9
Localisation updates from https://translatewiki.net.
Change-Id: I04b96d365ede126a1eedafa8d8961722f5e9df6f
2024-11-05 08:32:28 +01:00
jenkins-bot 07a52928f8 Merge "Handle hidden revisions in user page edit notification" 2024-11-04 19:12:38 +00:00
Translation updater bot 9c3b3a8384
Localisation updates from https://translatewiki.net.
Change-Id: I9e4e7ccf22f89b1c4209491f3639417284db543e
2024-11-04 08:21:32 +01:00
libraryupgrader 60a7af8ab1 build: Updating mediawiki/mediawiki-codesniffer to 45.0.0
Change-Id: I5399cbf72f728c4453e3dba08f97645e69a6c282
2024-11-02 07:16:27 +00:00
Ammarpad b80f4294b5 Handle hidden revisions in user page edit notification
Bug: T378799
Change-Id: Ie68e024625c640f46e6af21a2829b33fbd57ec8a
2024-11-01 09:31:17 +01:00
jenkins-bot e6a51beca1 Merge "Avoid event insertion if possible" 2024-10-30 15:06:30 +00:00
Željko Filipin 6db6e95252 selenium: Delete tests disabled more than two years ago
Bug: T280652
Change-Id: I9bdff690e3a8dc0d04c093dad7603cfdd3737a50
2024-10-28 17:52:47 +01:00