mediawiki-extensions-Discus.../includes
Thiemo Kreuz 1e0d2d93b3 Add missing out-of-index guard to CommentUtils
I found this error in our logstash. I was not able to find an
existing Phabricator ticket.

Note how line #348 extracts the last element from the
$siblings array. It uses the function end() there, which
returns false in case the array is empty. $siblings[0] can't
do this but yields an error.

An alternative is to use reset(), which can return false as
well. But that's not really better. Especially not better
readable, I would argue.

Change-Id: Ic90cd2392ede15078ba0d5b4d67b8dc5d05f9bf7
2021-02-09 12:27:41 +01:00
..
Hooks Move Hooks to HookUtils 2021-02-01 22:35:11 +00:00
ApiDiscussionTools.php Include 'false' results in 'transcludedfrom' API response 2020-10-22 22:25:35 +02:00
ApiDiscussionToolsEdit.php New error message when the page doesn't exist 2021-01-27 16:41:03 +01:00
CommentFormatter.php Move Hooks::addReplyLinks to CommentFormatter 2021-02-01 22:35:04 +00:00
CommentItem.php CommentItem/HeadingItem: Make more constructor args required 2021-01-08 20:45:29 +00:00
CommentModifier.php Ability to add new discussion sections 2021-01-12 20:15:28 +00:00
CommentParser.php Truncate user generated part of IDs to 80 characters 2021-02-03 15:04:58 +00:00
CommentUtils.php Add missing out-of-index guard to CommentUtils 2021-02-09 12:27:41 +01:00
Data.php build: Updating mediawiki/mediawiki-codesniffer to 32.0.0 2020-10-29 10:53:01 +00:00
HeadingItem.php Move ID->title logic into HeadingItem 2020-11-05 16:10:39 +00:00
ImmutableRange.php ImmutableRange: Guard against appending empty fragments 2020-11-16 19:22:26 +00:00
NodeFilter.php CommentParser.php: Use tree walking instead of XPath 2020-07-15 16:40:50 +00:00
ThreadItem.php De-indent multi line comments when fetching comment bodies 2020-11-22 21:49:08 +00:00
TreeWalker.php Base TreeWalker implementation on PHPDOM 2020-11-19 23:45:42 +00:00