mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools
synced 2024-11-24 16:34:21 +00:00
1e0d2d93b3
I found this error in our logstash. I was not able to find an existing Phabricator ticket. Note how line #348 extracts the last element from the $siblings array. It uses the function end() there, which returns false in case the array is empty. $siblings[0] can't do this but yields an error. An alternative is to use reset(), which can return false as well. But that's not really better. Especially not better readable, I would argue. Change-Id: Ic90cd2392ede15078ba0d5b4d67b8dc5d05f9bf7 |
||
---|---|---|
.. | ||
Hooks | ||
ApiDiscussionTools.php | ||
ApiDiscussionToolsEdit.php | ||
CommentFormatter.php | ||
CommentItem.php | ||
CommentModifier.php | ||
CommentParser.php | ||
CommentUtils.php | ||
Data.php | ||
HeadingItem.php | ||
ImmutableRange.php | ||
NodeFilter.php | ||
ThreadItem.php | ||
TreeWalker.php |