Commit graph

4018 commits

Author SHA1 Message Date
Ed Sanders df7d101cd2 Use decodeURI for comment ID searches as well as heading searches
Bug: T356199
Change-Id: I8d366c706692caf89a2af9f11c14a9aad9422b7c
2024-02-02 17:34:26 +00:00
Translation updater bot 6feddf4938 Localisation updates from https://translatewiki.net.
Change-Id: I2346f70e62b7c62d4d38ec4afd83631760dd0599
2024-02-02 08:53:19 +01:00
Ed Sanders 8b99c1fbbe Add more search methods to findNewestRevisionsByHeading
In production, indexing the full history of every page will take
too long, so we can't rely on being able to find the target heading
text in the history of the current page.

When this search fails, fall back to the following searches:
* The heading appears in the current revision of a sub-page
* The heading appears anywhere on the wiki, but only once

Bug: T356276
Change-Id: I90e92cb9c85aaf6fb2355f842450981bbe6abf2d
2024-02-01 18:32:36 +00:00
Translation updater bot 4bb3ae7d1f Localisation updates from https://translatewiki.net.
Change-Id: Id0a4cfbe24def17ad1bf866655a1472e47ef3a41
2024-02-01 09:01:39 +01:00
Translation updater bot 6408fe3a41 Localisation updates from https://translatewiki.net.
Change-Id: Ie3796fb8ba5676d97c7e0f82ff0efa0d30c82e63
2024-01-31 08:28:59 +01:00
David Lynch 7b941aae1c Add an exception for ConvenientDiscussions-style permalinks
Bug: T349653
Change-Id: I775774084bb8abf2bc99475b426d581bed306306
2024-01-30 16:44:30 -06:00
David Lynch c4bbf8756a decodeURI fragments before sending them to discussiontoolsfindcomment
Section titles containing non-ASCII characters were being passed through
URL-encoded, resulting in no results being found.

Bug: T356199
Change-Id: Iac56ee434a37baf3d170aec992d2f2d8679b6f1f
2024-01-30 14:14:18 -06:00
Ed Sanders 8069585489 CommentParser: Ignore generated timestamp links
This will be present in parser cache output and can
sometimes be mistaken for user page links.

Bug: T356142
Change-Id: I800b23d8466f72affcadfa336aab07abf7f8d79e
2024-01-30 10:29:36 +00:00
Translation updater bot 150736016b Localisation updates from https://translatewiki.net.
Change-Id: Ia9a84ce398a630d8f0c9354e20a99f5b6e83abeb
2024-01-30 09:38:57 +01:00
Translation updater bot 83d8cd4aea Localisation updates from https://translatewiki.net.
Change-Id: I29f301a8f72ef1501c364ca30ca061f3f9eef232
2024-01-28 16:06:15 +01:00
David Lynch 87c8a26483 Require is still required to load CommentTarget
Follow-up to d647870dca.

Change-Id: I63dbedbbd156a8b1619849170eac9dc6da262ddd
2024-01-23 14:58:23 -06:00
Ed Sanders d647870dca Use ve.init.mw.targetFactory.create()
Change-Id: Ie30d813ba933e03e9c712f78eac155a41052d4b0
2024-01-23 19:42:10 +00:00
Umherirrender 94a5c86ceb Stop writing to tablesUsed in tests
Bug: T351733
Change-Id: I4e8feb7f60b45bb7fe5259d72ee29d964caefdfd
2024-01-20 12:27:39 +01:00
Translation updater bot 443653e521 Localisation updates from https://translatewiki.net.
Change-Id: I18c4b24f4b0c5c3d8e40ab8878a1677112d3020a
2024-01-19 09:16:45 +01:00
C. Scott Ananian e2fbc0704c Remove TemporaryParsoidHandlerParserCacheWriteRatio hack
This was originally supposed to be released before MW 1.40.

Bug: T355375
Change-Id: I9cf0631ebb25db5ad7cf1c3c1011fc40c33c9891
2024-01-18 19:23:36 -05:00
C. Scott Ananian e2c9ca37b0 Use Parsoid HTML to drive notifications
This reuses the existing comment parser code in HookUtils and makes the
DataUpdatesHooks and EventDispatcher code consistent.

Bug: T354792
Change-Id: I58a71b26b3f47898a68a29098a8105ee844403dd
2024-01-18 19:23:13 -05:00
Translation updater bot 99bae67a4b Localisation updates from https://translatewiki.net.
Change-Id: Ie14b988d0ac50d7eb246f0431b6f3638a04c46bf
2024-01-18 09:25:15 +01:00
jenkins-bot 184cd048f1 Merge "Refactor CommentFormatter->addTopicContainer()" 2024-01-18 01:16:07 +00:00
jenkins-bot 55daf9b617 Merge "Re-enable: "Temporarily disable isPreview in Parsoid's rendering""" 2024-01-17 19:47:11 +00:00
jenkins-bot 095502a73e Merge "Comment-not-found toast not showing when enablePermalinksFrontend==false" 2024-01-17 19:45:20 +00:00
Subramanya Sastry 3f2f5dd237 Re-enable: "Temporarily disable isPreview in Parsoid's rendering""
This reverts commit 1cf6000d18.

Reason for revert: Want to do another round of visual diff testing
on wikitech as an anonymous user. Will revert this after test is done.

Change-Id: Ic3facb7ecd9c932be348d47d6a38cff71cd7e1db
2024-01-17 18:02:16 +00:00
Translation updater bot 73bb8f997b Localisation updates from https://translatewiki.net.
Change-Id: I87fc32b3ab8d91f04ac96f4b4df711242c51cc11
2024-01-17 08:37:10 +01:00
David Lynch d74eccad34 Comment-not-found toast not showing when enablePermalinksFrontend==false
results[ 0 ] would be undefined, causing a later JS error before the
toast could be shown.

Bug: T355165
Change-Id: Ia591a1e4db0acfa377201c355938a32f680393ce
2024-01-16 11:13:18 -06:00
Translation updater bot e2b0ebe4ee Localisation updates from https://translatewiki.net.
Change-Id: I353ed0624d0eacdce616bec6adc39bfc82831b45
2024-01-16 08:25:34 +01:00
Translation updater bot b754509c8d Localisation updates from https://translatewiki.net.
Change-Id: Id01adbf082130a48fb2860550664c6d01a2fcf6c
2024-01-15 08:24:13 +01:00
James D. Forrester e0fa5168fa extension.json: Drop RL targets definitions, no longer honoured
Bug: T328497
Change-Id: I0b6639e6e08373c5425a8035761d9a0b73e0e7d7
2024-01-12 08:44:20 -05:00
Translation updater bot 9467f10ed8 Localisation updates from https://translatewiki.net.
Change-Id: Iceabbd2c07cb2be4af29bd2939ce8505f640c703
2024-01-12 09:00:06 +01:00
Ed Sanders c076f170c4 Update TODO documentation around parsing
Change-Id: I14fb4874fdc3e97418b5f41665334e122c17d862
2024-01-10 18:29:40 +00:00
Translation updater bot 317b293b3d Localisation updates from https://translatewiki.net.
Change-Id: I0a2fa0bb3ea449822742fd7e32ee912a1908c7f0
2024-01-10 08:32:46 +01:00
Translation updater bot 8863c80f91 Localisation updates from https://translatewiki.net.
Change-Id: Ie52085f12002555ad6c59695e25fc40092430cea
2024-01-09 08:59:28 +01:00
jenkins-bot 91c5151575 Merge "controller: Use replyWidgetPromise when opening new topic tool" 2024-01-08 21:15:24 +00:00
jenkins-bot 088a4c9d43 Merge "CommentController/ReplyWidget: Document events" 2024-01-08 21:15:23 +00:00
jenkins-bot 1f0a6b9f80 Merge "CommentController#showAndFocus: Use replyWidgetPromise" 2024-01-08 20:50:45 +00:00
Translation updater bot 56db888a0a Localisation updates from https://translatewiki.net.
Change-Id: I1e4c4859d91d453a9908c8a39767e321765c1e0e
2024-01-08 09:15:21 +01:00
Ed Sanders 4f217f4dab controller: Use replyWidgetPromise when opening new topic tool
This prevents an exception being thrown if you open the
new topic tool when a reply widget is still loading.

Change-Id: I17da48ddf91394d05cc82613ce5517f1e176750b
2024-01-05 16:20:30 +00:00
Ed Sanders b6ebb5db56 CommentController/ReplyWidget: Document events
Also rename CommentController#teardown to onReplyWidgetTeardown,
and NewTopicController#clear(Storage) to onReplyWidgetClear(Storage).

Change-Id: Ib1dd50ca69aac6f1836674d1a6aefa2402844c57
2024-01-05 16:20:30 +00:00
Ed Sanders 811dce7bf7 CommentController#showAndFocus: Use replyWidgetPromise
We shouldn't assume callers of this method have waited
for the replyWidget to be built.

Bug: T354292
Change-Id: Ic66b4f04b8786b07f520e329adda37efcf498dad
2024-01-05 15:26:19 +00:00
Translation updater bot 555cfcc622 Localisation updates from https://translatewiki.net.
Change-Id: Ie8d555bd837f0c58109aee0796a66febdc543b91
2024-01-05 09:12:31 +01:00
Bartosz Dziewoński 91d7cdb704 Remove "Read as wiki page" feature on mobile talk pages
Bug: T280417
Change-Id: I8f24531cbe1b6bb3f434c91a9523b0a11110d8e6
2024-01-04 19:34:48 +01:00
Translation updater bot 650253f046 Localisation updates from https://translatewiki.net.
Change-Id: Id62de6475ff9f281fef80878d191567136ed7d8b
2024-01-04 09:55:33 +01:00
Translation updater bot d00fd7d665 Localisation updates from https://translatewiki.net.
Change-Id: I54d3c943b5bbbcc550c4af4fbc3cfc74c75f6a4a
2024-01-03 08:34:23 +01:00
Translation updater bot fb69ea608b Localisation updates from https://translatewiki.net.
Change-Id: I1b1d1f01e86d479822e9061914315db96d7fc522
2024-01-02 10:15:59 +01:00
jenkins-bot a608bff9f8 Merge "tests: Fix tests when LiquidThreads is also installed" 2023-12-31 07:16:05 +00:00
Translation updater bot db3e7ec069 Localisation updates from https://translatewiki.net.
Change-Id: I6b2bde2b1acaf4dcd0761d06cd5759949d25abf1
2023-12-28 14:49:45 +01:00
Umherirrender 6f487698cc tests: Fix tests when LiquidThreads is also installed
Change-Id: Ica43e90fb3e48ddd20ad2b4130fb3a5efb3a4696
2023-12-27 23:07:24 +01:00
Translation updater bot 719cee1436 Localisation updates from https://translatewiki.net.
Change-Id: If4112b6f17ced30829506df41529778ec677a02e
2023-12-26 14:42:43 +01:00
Novem Linguae 3436e2d9e9 Refactor CommentFormatter->addTopicContainer()
To get ready for the subtopic subscriptions feature, this patch
separates the code that adds the topic container from the code
that adds the subscribe button.

The idea is that in the future, an H3 would need a subscribe
button, but not a topic container. Whereas an H2 would need both.

Bug: T275943
Change-Id: I6a82773ed200dcb4083ac38a4d41838f639c097e
2023-12-24 13:34:30 -08:00
Translation updater bot 631cd8352b Localisation updates from https://translatewiki.net.
Change-Id: I60f5e8277e8bd6651f9254cc9a673a4018b791fb
2023-12-22 17:45:48 +01:00
Translation updater bot e3e4b57f3f Localisation updates from https://translatewiki.net.
Change-Id: Iee2ecc8f25aa3f92395a2abe70a52303bedb60a5
2023-12-21 19:45:13 +01:00
jenkins-bot 6ff126eab5 Merge "CommentFormatter: Do not add wrapper if the heading has attributes" 2023-12-20 17:17:18 +00:00