Commit graph

1592 commits

Author SHA1 Message Date
Bartosz Dziewoński ae920b831f Change which nodes are ignored at the beginning of comments again
While working on T270009, I noticed that <style> and <link> nodes
are treated differently, which seemed weird. Rewrite this again,
hopefully this is the last time.

The changed test cases also involve <area> and <input> nodes,
and the new results make more sense to me.

Bug: T264116
Change-Id: I3af90c84768a4b3dc53446927f4dba6f72175a2f
2020-12-14 21:33:50 +01:00
Bartosz Dziewoński 6c7a0ca9a2 Fix trying to insert start/end markers in impossible locations
Bug: T270009
Bug: T266288
Change-Id: I962128e7d9290e7b5eb49bfdb5847fd17714bae1
2020-12-14 21:09:56 +01:00
Ed Sanders ccf6f33c40 Disable reply links on mobile
Bug: T270088
Change-Id: I003b0c6adea8496c95596e40a2bf4bb63906a464
2020-12-14 18:52:47 +00:00
jenkins-bot b491d52c03 Merge "Debug: Introduce "vote" debug mode" 2020-12-14 17:39:50 +00:00
Translation updater bot fef3b95858 Localisation updates from https://translatewiki.net.
Change-Id: I3afc31f6fb698f2e0e51c2d5fa9448bdc5ea5e14
2020-12-14 08:41:33 +01:00
jenkins-bot 5f2684a8d0 Merge "Debug: Fix signature range higlighting" 2020-12-14 01:55:18 +00:00
jenkins-bot 1f2d106f37 Merge "ThreadItem.js: Fix documentation comment" 2020-12-14 01:53:58 +00:00
libraryupgrader 7706c391d2 build: Updating ini to 1.3.8
* https://npmjs.com/advisories/1589

Change-Id: Ib9e37417481fc0f430d60c8f0d183b374329a86b
2020-12-13 01:47:22 +00:00
Ed Sanders 633cc9a7b3 Debug: Introduce "vote" debug mode
Bug: T269163
Change-Id: Ie8da7acf3660a6d30b92d7803d87ad51a3275369
2020-12-12 13:21:48 +00:00
Ed Sanders 43443971a0 ThreadItem.js: Fix documentation comment
Change-Id: I2b0207eb5f3689845daf5e6dd293a59d2ec890b2
2020-12-12 12:58:16 +00:00
Ed Sanders 15cb419f56 Debug: Fix signature range higlighting
Change-Id: Ieb5af739bb98761d8473edb87f1eb752dc386ea1
2020-12-12 12:56:54 +00:00
Ed Sanders a082535e02 Fix styling of error/captcha MessageWidgets
Change-Id: I592c1a08238dc46ee342672be29a8070b495f3dd
2020-12-11 16:27:07 +00:00
Translation updater bot 369920ec54 Localisation updates from https://translatewiki.net.
Change-Id: I982fb4472ae6dc66be79c5170205e9f7efaea808
2020-12-11 08:35:13 +01:00
Translation updater bot 3f3d7a39c0 Localisation updates from https://translatewiki.net.
Change-Id: I00cccfcb269cf09093490fb75e34a7f4e1e2dc2a
2020-12-10 08:34:36 +01:00
libraryupgrader 794ad7d492 build: Updating mediawiki/mediawiki-phan-config to 0.10.5
Change-Id: I3e53748bad5447b1a7a07e1f48600b1f522aa63c
2020-12-10 05:21:03 +00:00
Ed Sanders fb0cc01ff8 Skip over empty inline templates (e.g. tracking templates)
Bug: T269036
Change-Id: I15e56041c1f1ecb85e9e368a9fbb07882438bf8d
2020-12-09 18:51:41 +00:00
Translation updater bot a672cdb1b0 Localisation updates from https://translatewiki.net.
Change-Id: I572c27aa32784d3073913808681b2e13ee92b6e8
2020-12-09 08:41:41 +01:00
jenkins-bot 2a955ab735 Merge "Handle category links like comments (rendering-transparent nodes)" 2020-12-08 21:44:56 +00:00
Bartosz Dziewoński 8c9230fa10 Handle category links like comments (rendering-transparent nodes)
Bug: T269036
Change-Id: Id4321ad09907b5030881456c93da90a39bdfdd75
2020-12-08 21:39:16 +00:00
Translation updater bot 2265478d22 Localisation updates from https://translatewiki.net.
Change-Id: Ic4d18a15ed55c5314486ece2948e66cb75b806d0
2020-12-08 08:21:08 +01:00
Translation updater bot 57018853ef Localisation updates from https://translatewiki.net.
Change-Id: Ia5a888cf693dba4faab7fc28ac77727e76ee8028
2020-12-07 08:44:24 +01:00
libraryupgrader 5c9db663e3 build: Updating mediawiki/mediawiki-codesniffer to 34.0.0
Change-Id: I2045b7a8672f482ab685d8af47cf69076d3ac2d7
2020-12-06 05:45:21 +00:00
Bartosz Dziewoński 113ad01d5e Consistent use of isBlockElement() in JS code
(Consistent compared to our PHP code)

Change-Id: I4aba6f22cc7da2da30ccd6346e4390b14bd347af
2020-12-05 22:48:34 +01:00
jenkins-bot 54f13b11a0 Merge "Tweak colors and timing of the highlight on posted comments" 2020-12-05 01:49:53 +00:00
Translation updater bot 3e8936e9c1 Localisation updates from https://translatewiki.net.
Change-Id: I02c1cc6ea196839f4a8ab2538c6dd6d3dd93baed
2020-12-04 08:33:00 +01:00
Translation updater bot b306c6eb58 Localisation updates from https://translatewiki.net.
Change-Id: I25c51784accba6b1b84672e8e06a4426274db4a8
2020-12-03 08:32:16 +01:00
Ed Sanders b71376a183 Trim signatures when added on a new line
Bug: T269188
Change-Id: I48d394020b8780ff93d97747d45009c37c071b53
2020-12-02 20:18:42 +00:00
Translation updater bot 77504a68fd Localisation updates from https://translatewiki.net.
Change-Id: I0a86f00faca9bc940a0d1802915ddfdb9d2bbe2e
2020-12-02 08:32:14 +01:00
Bartosz Dziewoński b92ae47e00 Tweak colors and timing of the highlight on posted comments
* Use a slightly different color
* Use 'mix-blend-mode: multiply' when available to avoid fading
  the text color
* Add fade-in animation and make fade-out animation slower

Bug: T268994
Change-Id: I210ed4fd55c3dc184d13daf915fa93bee3699ad5
2020-12-01 23:44:39 +01:00
Bartosz Dziewoński 7c01e20e47 Add postEdit notification
Per T267595#6656121

Bug: T268994
Change-Id: I2c47fc36ff6515b1f5f5e6bfd11f41eec9c1cd86
2020-12-01 21:43:39 +00:00
Translation updater bot 4f0c999553 Localisation updates from https://translatewiki.net.
Change-Id: I7b56ec45c0d0edf9fc35b7098973631e912469be
2020-12-01 08:23:01 +01:00
Translation updater bot 9c8e1df5d1 Localisation updates from https://translatewiki.net.
Change-Id: I179ab99bf8469406ef7af03d0757decfd15c5db6
2020-11-30 08:46:28 +01:00
Translation updater bot 8b6070fd22 Localisation updates from https://translatewiki.net.
Change-Id: Ic435ec2f63aebb6d5f0864979d80afb19a6d50ea
2020-11-27 08:30:02 +01:00
jenkins-bot d52f6334ea Merge "Show keyboard shortcuts in button tooltips" 2020-11-26 18:12:03 +00:00
jenkins-bot 019307660e Merge "Don't include the logged in user in local suggestions" 2020-11-26 18:08:46 +00:00
Ed Sanders 1871c70378 Show keyboard shortcuts in button tooltips
Bug: T264913
Change-Id: I3c5b248f7c7b0ef381baab84fe98d4ba0cefd35a
2020-11-26 19:06:17 +01:00
Bartosz Dziewoński 366dc2387e Add tests covering it.wp unsigned comment template
Bug: T268178
Bug: T268589
Change-Id: Icd353275b3b8191eddbff4d72984a8c2c8e6cdd6
2020-11-25 02:08:03 +01:00
Bartosz Dziewoński 0fc71f60cd Skip to the end of the paragraph if it's just text, too
We've recently decided that we want to "extend" comments until
the end of the paragraph (e36dc8e78a,
d0ae6c4e44).

However, we still had this special case that did the opposite: it
ensured that if a comment ended in the middle of a text node, the
comment would not be extended to the end of the node. Remove it.

Note the change in the test file signatures-funny-formattedreply.html,
which actually covered this case specifically.

Change-Id: Id1384bb0c6e1a5f0c70f55efcb4caa240f230f07
2020-11-25 00:48:53 +01:00
jenkins-bot 48a9c8bd97 Merge "Add method to strip trailing hyphens from comment bodies" 2020-11-23 17:46:43 +00:00
jenkins-bot aa0e89e3cf Merge "Skip end marker "forward" until a block tag is reached" 2020-11-23 17:00:34 +00:00
jenkins-bot c87f6ef031 Merge "De-indent multi line comments when fetching comment bodies" 2020-11-23 16:20:54 +00:00
Ed Sanders d0ae6c4e44 Skip end marker "forward" until a block tag is reached
The end marker is skipped forward until an open or close
block tag is reached. In tree traversal terms this means
moving either to the next sibling, or the parent (to skip
over close tags).

Bug: T256033
Change-Id: Iaa2c588698790d576ac4f9ecc126f58a082ef6b3
2020-11-23 15:08:29 +00:00
Translation updater bot 93a11bb016 Localisation updates from https://translatewiki.net.
Change-Id: Ice5dbcaf0ba528c4e2a5f6a52e29c8ec1f599857
2020-11-23 08:39:00 +01:00
jenkins-bot 7467e89da4 Merge "Fix displaying reply links after posting a reply with dtenable=1" 2020-11-22 23:02:21 +00:00
jenkins-bot 4eed14b4e7 Merge "Fix client-side IDs for indistinguishable comments" 2020-11-22 22:38:57 +00:00
Ed Sanders 296c2e88f3 Add method to strip trailing hyphens from comment bodies
Change-Id: I04e1fe5940f857448d8c4b2beecc32a40c9696e8
2020-11-22 21:49:09 +00:00
Ed Sanders 15696f141c De-indent multi line comments when fetching comment bodies
Change-Id: Iaacd227ce2185f4fe2b29463a33b038de7aadb7e
2020-11-22 21:49:08 +00:00
libraryupgrader db6838a267 build: Updating npm dependencies
* grunt-stylelint: 0.15.0 → 0.16.0
* stylelint-config-wikimedia: 0.10.1 → 0.10.3
  The following rules are failing and were disabled:
  * unit-disallowed-list

Change-Id: Iab814dccab72d4c4f98a901f0368f579b3cf424e
2020-11-22 01:20:32 +00:00
jenkins-bot cac72e1c99 Merge "Fix start node for comments following headings" 2020-11-20 18:22:34 +00:00
jenkins-bot 31879880f9 Merge "Base TreeWalker implementation on PHPDOM" 2020-11-20 18:22:32 +00:00