wikimedia/mediawiki-extensions-DiscussionTools
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools synced 2024-09-24 02:48:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Debug: Fix signature range higlighting

Browse source 
Change-Id: Ieb5af739bb98761d8473edb87f1eb752dc386ea1
This commit is contained in:
Ed Sanders 2020-12-12 12:50:14 +00:00
parent a082535e02
commit 15cb419f56
1 changed files with 17 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

33
modules/dt.debug.js
View file

@ -8,22 +8,23 @@ var
highlighter.markThreads( threads );
// TODO: Use comment.signatureRanges to mark up signatures/timestamps
comments.forEach( function ( comment ) {
var signature, emptySignature, node, match;
comment.signatureRanges.forEach( function ( signatureRange ) {
var signature, emptySignature, node, match;
node = comment.range.endContainer;
match = parser.findTimestamp( node, timestampRegexps );
if ( !match ) {
return;
}
signature = parser.findSignature( node )[ 0 ];
emptySignature = signature.length === 1 && signature[ 0 ] === node;
// Note that additional content may follow the timestamp (e.g. in some voting formats), but we
// don't care about it. The code below doesn't mark that due to now the text nodes are sliced,
// but we might need to take care to use the matched range of node in other cases.
highlighter.markTimestamp( parser, node, match );
if ( !emptySignature ) {
highlighter.markSignature( signature );
}
node = signatureRange.endContainer;
match = parser.findTimestamp( node, timestampRegexps );
if ( !match ) {
return;
}
signature = parser.findSignature( node )[ 0 ];
emptySignature = signature.length === 1 && signature[ 0 ] === node;
// Note that additional content may follow the timestamp (e.g. in some voting formats), but we
// don't care about it. The code below doesn't mark that due to now the text nodes are sliced,
// but we might need to take care to use the matched range of node in other cases.
highlighter.markTimestamp( parser, node, match );
if ( !emptySignature ) {
highlighter.markSignature( signature );
}
} );
} );