wikimedia/mediawiki-extensions-DiscussionTools
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools synced 2024-11-24 16:34:21 +00:00
Code Issues Packages Projects Releases Wiki Activity
971 commits 147 branches 0 tags 125 MiB
Commit graph

971 commits

This branch
This branch
All branches
Author SHA1 Message Date
Bartosz Dziewoński 8c9230fa10 Handle category links like comments (rendering-transparent nodes) 
Bug: T269036
Change-Id: Id4321ad09907b5030881456c93da90a39bdfdd75
 2020-12-08 21:39:16 +00:00
Bartosz Dziewoński 113ad01d5e Consistent use of isBlockElement() in JS code 
(Consistent compared to our PHP code)

Change-Id: I4aba6f22cc7da2da30ccd6346e4390b14bd347af
 2020-12-05 22:48:34 +01:00
jenkins-bot 54f13b11a0 Merge "Tweak colors and timing of the highlight on posted comments" 2020-12-05 01:49:53 +00:00
Translation updater bot 3e8936e9c1 Localisation updates from https://translatewiki.net. 
Change-Id: I02c1cc6ea196839f4a8ab2538c6dd6d3dd93baed
 2020-12-04 08:33:00 +01:00
Translation updater bot b306c6eb58 Localisation updates from https://translatewiki.net. 
Change-Id: I25c51784accba6b1b84672e8e06a4426274db4a8
 2020-12-03 08:32:16 +01:00
Ed Sanders b71376a183 Trim signatures when added on a new line 
Bug: T269188
Change-Id: I48d394020b8780ff93d97747d45009c37c071b53
 2020-12-02 20:18:42 +00:00
Translation updater bot 77504a68fd Localisation updates from https://translatewiki.net. 
Change-Id: I0a86f00faca9bc940a0d1802915ddfdb9d2bbe2e
 2020-12-02 08:32:14 +01:00
Bartosz Dziewoński b92ae47e00 Tweak colors and timing of the highlight on posted comments 
* Use a slightly different color
* Use 'mix-blend-mode: multiply' when available to avoid fading
  the text color
* Add fade-in animation and make fade-out animation slower

Bug: T268994
Change-Id: I210ed4fd55c3dc184d13daf915fa93bee3699ad5
 2020-12-01 23:44:39 +01:00
Bartosz Dziewoński 7c01e20e47 Add postEdit notification 
Per T267595#6656121

Bug: T268994
Change-Id: I2c47fc36ff6515b1f5f5e6bfd11f41eec9c1cd86
 2020-12-01 21:43:39 +00:00
Translation updater bot 4f0c999553 Localisation updates from https://translatewiki.net. 
Change-Id: I7b56ec45c0d0edf9fc35b7098973631e912469be
 2020-12-01 08:23:01 +01:00
Translation updater bot 9c8e1df5d1 Localisation updates from https://translatewiki.net. 
Change-Id: I179ab99bf8469406ef7af03d0757decfd15c5db6
 2020-11-30 08:46:28 +01:00
Translation updater bot 8b6070fd22 Localisation updates from https://translatewiki.net. 
Change-Id: Ic435ec2f63aebb6d5f0864979d80afb19a6d50ea
 2020-11-27 08:30:02 +01:00
jenkins-bot d52f6334ea Merge "Show keyboard shortcuts in button tooltips" 2020-11-26 18:12:03 +00:00
jenkins-bot 019307660e Merge "Don't include the logged in user in local suggestions" 2020-11-26 18:08:46 +00:00
Ed Sanders 1871c70378 Show keyboard shortcuts in button tooltips 
Bug: T264913
Change-Id: I3c5b248f7c7b0ef381baab84fe98d4ba0cefd35a
 2020-11-26 19:06:17 +01:00
Bartosz Dziewoński 366dc2387e Add tests covering it.wp unsigned comment template 
Bug: T268178
Bug: T268589
Change-Id: Icd353275b3b8191eddbff4d72984a8c2c8e6cdd6
 2020-11-25 02:08:03 +01:00
Bartosz Dziewoński 0fc71f60cd Skip to the end of the paragraph if it's just text, too 
We've recently decided that we want to "extend" comments until
the end of the paragraph (e36dc8e78a,
d0ae6c4e44).

However, we still had this special case that did the opposite: it
ensured that if a comment ended in the middle of a text node, the
comment would not be extended to the end of the node. Remove it.

Note the change in the test file signatures-funny-formattedreply.html,
which actually covered this case specifically.

Change-Id: Id1384bb0c6e1a5f0c70f55efcb4caa240f230f07
 2020-11-25 00:48:53 +01:00
jenkins-bot 48a9c8bd97 Merge "Add method to strip trailing hyphens from comment bodies" 2020-11-23 17:46:43 +00:00
jenkins-bot aa0e89e3cf Merge "Skip end marker "forward" until a block tag is reached" 2020-11-23 17:00:34 +00:00
jenkins-bot c87f6ef031 Merge "De-indent multi line comments when fetching comment bodies" 2020-11-23 16:20:54 +00:00
Ed Sanders d0ae6c4e44 Skip end marker "forward" until a block tag is reached 
The end marker is skipped forward until an open or close
block tag is reached. In tree traversal terms this means
moving either to the next sibling, or the parent (to skip
over close tags).

Bug: T256033
Change-Id: Iaa2c588698790d576ac4f9ecc126f58a082ef6b3
 2020-11-23 15:08:29 +00:00
Translation updater bot 93a11bb016 Localisation updates from https://translatewiki.net. 
Change-Id: Ice5dbcaf0ba528c4e2a5f6a52e29c8ec1f599857
 2020-11-23 08:39:00 +01:00
jenkins-bot 7467e89da4 Merge "Fix displaying reply links after posting a reply with dtenable=1" 2020-11-22 23:02:21 +00:00
jenkins-bot 4eed14b4e7 Merge "Fix client-side IDs for indistinguishable comments" 2020-11-22 22:38:57 +00:00
Ed Sanders 296c2e88f3 Add method to strip trailing hyphens from comment bodies 
Change-Id: I04e1fe5940f857448d8c4b2beecc32a40c9696e8
 2020-11-22 21:49:09 +00:00
Ed Sanders 15696f141c De-indent multi line comments when fetching comment bodies 
Change-Id: Iaacd227ce2185f4fe2b29463a33b038de7aadb7e
 2020-11-22 21:49:08 +00:00
libraryupgrader db6838a267 build: Updating npm dependencies 
* grunt-stylelint: 0.15.0 → 0.16.0
* stylelint-config-wikimedia: 0.10.1 → 0.10.3
  The following rules are failing and were disabled:
  * unit-disallowed-list

Change-Id: Iab814dccab72d4c4f98a901f0368f579b3cf424e
 2020-11-22 01:20:32 +00:00
jenkins-bot cac72e1c99 Merge "Fix start node for comments following headings" 2020-11-20 18:22:34 +00:00
jenkins-bot 31879880f9 Merge "Base TreeWalker implementation on PHPDOM" 2020-11-20 18:22:32 +00:00
Translation updater bot d8434d6d7f Localisation updates from https://translatewiki.net. 
Change-Id: Iebf59ccd1d5f6c0f43dda77df0b9c9966b86faee
 2020-11-20 09:17:42 +01:00
libraryupgrader 59009a8f26 build: Updating mediawiki/mediawiki-phan-config to 0.10.4 
Change-Id: Ia27150524a70272eff6582f8827259bec3b45511
 2020-11-20 03:18:36 +00:00
Ed Sanders 44a1bbcc59 Fix start node for comments following headings 
The general rule is that comments start after their preceding
thread item, but when that is a heading we should skip past
the entire <h[1-6]> node to avoid making section edit links
part of the first comment.

Bug: T267988
Change-Id: Ia7f1b27e0a69a9aab7c7da743bf8549479304096
 2020-11-19 23:48:30 +00:00
Ed Sanders 763ce88021 Base TreeWalker implementation on PHPDOM 
For consistency with other DOM implementations.

Change-Id: I20447d880ccd3b70b6694b36ea2f63dd0c42fa84
 2020-11-19 23:45:42 +00:00
Translation updater bot 980e88f040 Localisation updates from https://translatewiki.net. 
Change-Id: I7992bce0f63c30dd858566cb2796761685c1ee2f
 2020-11-19 09:10:03 +01:00
Bartosz Dziewoński d0b6904bae Fix client-side IDs for indistinguishable comments 
Bug: T268093
Change-Id: I198b090904e3ae5f2e214b457233d61cb77802af
 2020-11-18 20:08:21 +01:00
Bartosz Dziewoński c17a076382 Fix displaying reply links after posting a reply with dtenable=1 
Bug: T267847
Change-Id: Ifb59cb942b673d9abcab563e6bc27fa1f6d5e9d7
 2020-11-18 19:29:04 +01:00
Translation updater bot 3b9ba82436 Localisation updates from https://translatewiki.net. 
Change-Id: I420f142f243db8fca5d5562d5a3a120e935bfbe8
 2020-11-18 08:56:02 +01:00
jenkins-bot 62bc99bdde Merge "Use Parsoid DOMCompat/DOMUtils in CommentFormatter" 2020-11-17 18:05:52 +00:00
jenkins-bot cbb34e1e62 Merge "Improve highlighter styling" 2020-11-17 10:34:00 +00:00
jenkins-bot 36bd857b81 Merge "Group comment warnings in DOM so they don't break alternate colours" 2020-11-17 10:33:59 +00:00
jenkins-bot 6c8d14e88a Merge "Highlighter: Fix check for comment warnings" 2020-11-17 10:33:58 +00:00
Translation updater bot 30300a7555 Localisation updates from https://translatewiki.net. 
Change-Id: I92393057e84f3fb03c6048e66f5a427f4223e4d4
 2020-11-17 08:42:17 +01:00
Ed Sanders e2f93727d4 Improve highlighter styling 
Change-Id: Ie2982d1f8da217cad2fe7080137c39900451c591
 2020-11-16 23:34:26 +00:00
Ed Sanders 2328a3cad0 Group comment warnings in DOM so they don't break alternate colours 
Change-Id: I0516a57a30a59ee6eac0ad2f23f05ad83c396391
 2020-11-16 23:32:56 +00:00
Ed Sanders 4d0498853d Highlighter: Fix check for comment warnings 
This was causing the highlighter to not alternate colours.

Change-Id: I9bb95e02ae91967c696f026198efb27d4d8414d4
 2020-11-16 23:18:05 +00:00
Ed Sanders a87d60228f Don't include the logged in user in local suggestions 
Bug: T267680
Change-Id: I1b2d185de390b73e1b389fc4139735069e7a65dc
 2020-11-16 22:48:21 +00:00
Ed Sanders 32cd64ec6a Use Parsoid DOMCompat/DOMUtils in CommentFormatter 
As CommentFormatter no longer needs HTMLFormatter, remove
the inheritance and make addReplyLinks a static method.

Testing locally this is marginally slower, going from 2.55s
to 2.9s for the CommentFormatterTest case.

Bug: T266317
Bug: T267973
Change-Id: If69749cae678a1647a138d782a32032189f55cec
 2020-11-16 22:28:07 +00:00
Ed Sanders 7d349808c2 ImmutableRange: Guard against appending empty fragments 
This triggers a PHP warning.

Change-Id: I5ccb204287d55b38fadcef8cc846400a277e8491
 2020-11-16 19:22:26 +00:00
Ed Sanders b03165fcce Compare node positions using upward traversal 
A TreeWalker ends up walking potentially every single subsequent
node in the document looking for a target node. Instead use upwards
traversal to find a common ancestor, then sibling traversal to
compare document order.

This makes calling cloneContents on every comment on a 300k talk page
significantly faster, going from >30s to 500ms locally.

Change-Id: I28a2b8c11d4098d9bc44d19b98e19ccc02273098
 2020-11-16 19:22:10 +00:00
jenkins-bot 5a5b2e61f1 Merge "ImmutableRange: Avoid doing expensive TreeWalker computation twice" 2020-11-15 14:43:01 +00:00