wikimedia/mediawiki-extensions-DiscussionTools
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools synced 2024-09-24 10:58:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "ImmutableRange: Avoid doing expensive TreeWalker computation twice"

Browse source
This commit is contained in:
jenkins-bot 2020-11-15 14:43:01 +00:00 committed by Gerrit Code Review
parent 5937226f5f 6f2ada2bb4
commit 5a5b2e61f1
1 changed files with 4 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
includes/ImmutableRange.php
View file

@ -435,14 +435,9 @@ class ImmutableRange {
$tw->currentNode = $boundaryPointB[0];
$AFollowsB = $tw->nextNode();
if ( $AFollowsB ) {
switch ( $this->computePosition( $boundaryPointB, $boundaryPointA ) ) {
case 'after':
return 'before';
case 'before':
return 'after';
}
// Swap variables
[ $boundaryPointB, $boundaryPointA ] = [ $boundaryPointA, $boundaryPointB ];
}
$ancestor = $boundaryPointB[0]->parentNode;
@ -467,11 +462,11 @@ class ImmutableRange {
}
if ( CommentUtils::childIndexOf( $child ) < $boundaryPointA[1] ) {
return 'after';
return $AFollowsB ? 'before' : 'after';
}
}
return 'before';
return $AFollowsB ? 'after' : 'before';
}
}