wikimedia/mediawiki-extensions-DiscussionTools
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools synced 2024-11-24 16:34:21 +00:00
Code Issues Packages Projects Releases Wiki Activity
1897 commits 147 branches 0 tags 125 MiB
Commit graph

1897 commits

This branch
This branch
All branches
Author SHA1 Message Date
Bartosz Dziewoński 8b426c7e5c Fix placeholder headings causing exceptions in getTranscludedFrom() 
Follow-up to 8de940b587.

Change-Id: Iddf045105fac6ab8cdaa933fd2abcf6dbbd37d42
 2022-01-11 23:24:45 +00:00
Ed Sanders 272b6595f5 Docs: Illustrate range overlaps in comment 
Change-Id: If6f5d83719b8d078cd13327c0b9cbaef03f87508
 2022-01-11 17:28:25 +00:00
Bartosz Dziewoński 72b9c2c6f5 Ignore some invisible nodes when looking for comment frames 
Reimplement getFullyCoveredSiblings() using compareRanges(), which
checks basically the same thing, but works better and I like it more.

Bug: T297034
Change-Id: I33dc1d088bdee984064315290e378bfbfa830b10
 2022-01-11 17:01:53 +00:00
Bartosz Dziewoński 8d51ce32b6 Test cases for adding replies outside of frames 
Bug: T297034
Change-Id: Ida57b2638d3434c9b47b120942348ebfe0f96d37
 2022-01-11 17:01:47 +00:00
jenkins-bot 7e61125c23 Merge "Work around a Safari bug causing shadows to remain when the popup is removed" 2022-01-11 16:14:15 +00:00
Bartosz Dziewoński 8de940b587 Improve detecting transcluded comments again 
Previously: 569db3603c (2020-06).

Unfortunately we've found cases where the previous implementation
doesn't work correctly, resulting in comments being added to the wrong
pages or page corruption.

Bug: T289873
Bug: T298051
Change-Id: Id867b3005ebc46906d6df852a525fcaec9e6b19b
 2022-01-11 16:07:44 +00:00
Bartosz Dziewoński 492dbd7847 Fix inserting comment start markers when they're outside of any wrappers 
Comment boundaries are stored as a DOM parent node plus a child index.
Because of that, inserting anything into the DOM before a comment –
such as another comment's start/end markers – would cause us to insert
subsequent comments' markers into the wrong places.

This issue didn't affect many pages, because usually any parent node
would have just one comment in it. Only pages with comment boundaries
outside of any wrappers (directly inside the root node) were broken.

Just process the list in reverse to fix this.

Bug: T298096
Change-Id: Iccffc36b71e9fcf3d72c4db2b9459d39042f7a2d
 2022-01-11 16:07:37 +00:00
jenkins-bot a627011ddf Merge "Use new wikipage.watchlistChange hook" 2022-01-10 22:21:17 +00:00
jenkins-bot dc944461d0 Merge "Test case for several bugs from it.wp" 2022-01-10 17:27:05 +00:00
jenkins-bot ef13ceb9aa Merge "Fix some typos in doc comments" 2022-01-10 16:50:14 +00:00
jenkins-bot f474a3d37c Merge "Fix collapsing whitespace in button section divider" 2022-01-10 16:10:57 +00:00
Translation updater bot d02dda298d Localisation updates from https://translatewiki.net. 
Change-Id: Ibd621cb877ff8944b07fda3c7c61651838904a7e
 2022-01-10 08:11:13 +01:00
Ed Sanders 9e98d72281 Fix collapsing whitespace in button section divider 
Caused by inline-flex. These aren't used anywhere yet.

Change-Id: Ib9d407090d088e7c87112c22a3d8ae5bab5250c3
 2022-01-09 00:42:25 +00:00
jenkins-bot e9155afea6 Merge "Filter username suggestions to accounts with edits" 2022-01-08 01:33:33 +00:00
Ed Sanders c3d54ec8a5 Fix styling of reply links when reply tool is open 
To better support adding more links to the buttons group:
* Only disable the 'reply' link when the reply tool is open,
  not all links in the button group. If future links need
  to be disabled (e.g. 'edit') they can be done on a per-case
  basis.
* Add a 'separator' class for adding more links.
* Don't hide 'reply' link when in use. This feature was added
  very early on (I03a98495) and a long time before we started
  greying-out all reply links when the tool was open (I3bb5ad8e7).
  It would also lead to a strange display if there were
  other links in the button group. Instead change the link to
  black to indicate it is in use.

Change-Id: I23cc8d305d1d1c323cb69081749443f6e19de6a4
 2022-01-07 17:09:15 +00:00
Translation updater bot 5499af93f7 Localisation updates from https://translatewiki.net. 
Change-Id: Ia465af262bd63abae989394d3a393459edd20b93
 2022-01-06 08:31:32 +01:00
Bartosz Dziewoński d24b04ee71 Test case for several bugs from it.wp 
Servers as another test case for partially transcluded comments,
and a test case for comment start markers placed outside of
paragraphs.

Bug: T298051
Bug: T298096
Change-Id: Id07d2f57708c037578cb653c83848490c9a15fc6
 2022-01-05 23:17:51 +00:00
Translation updater bot b380e78e18 Localisation updates from https://translatewiki.net. 
Change-Id: Ia12de7b226c044f50f3906bc44654865c36e824a
 2022-01-05 08:16:02 +01:00
Translation updater bot 3de877c326 Localisation updates from https://translatewiki.net. 
Change-Id: Idff87a7583b0dedb5ec2515aa94c4f0359f5f631
 2022-01-04 08:27:42 +01:00
Translation updater bot 600ff273c5 Localisation updates from https://translatewiki.net. 
Change-Id: Ie7f900b80f0a5cef57dcfad2d97ad5081c5d30e2
 2022-01-03 08:11:04 +01:00
Translation updater bot 61eb0556f1 Localisation updates from https://translatewiki.net. 
Change-Id: I513540f1d1cf171b06b31757002b1a51f3bcc76b
 2021-12-31 09:42:03 +01:00
Translation updater bot 67d7331fe2 Localisation updates from https://translatewiki.net. 
Change-Id: Iac910389c864b74bd9dfc7ab23ab940ec84d9334
 2021-12-30 09:37:39 +01:00
jenkins-bot d297faf9ff Merge "Fix closing the new topic tool hint" 2021-12-29 16:51:56 +00:00
Translation updater bot 8f568bb0d3 Localisation updates from https://translatewiki.net. 
Change-Id: Ia6a13e585506dea820062817cb689308053348d5
 2021-12-27 09:29:59 +01:00
Bartosz Dziewoński 95c7824056 Fix closing the new topic tool hint 
Bug: T298224
Change-Id: I32494990dd8e3bb8ffa2af097bc1f6400687c823
 2021-12-23 19:59:33 +01:00
Translation updater bot 0e82a944c9 Localisation updates from https://translatewiki.net. 
Change-Id: Id2eb11ae435417f634963169d6b756de86605468
 2021-12-23 08:37:59 +01:00
Ed Sanders 423983f26e Filter username suggestions to accounts with edits 
Bug: T294774
Change-Id: I7346a7986d7caba473d31151495bb2263e43ca44
 2021-12-22 23:57:15 +00:00
Translation updater bot a47775e591 Localisation updates from https://translatewiki.net. 
Change-Id: I4edadf5dc5a8693b3248e30b8e11a030d42f4ad3
 2021-12-22 08:34:06 +01:00
jenkins-bot 4c783d7b64 Merge "Replace usages of deprecated wfWikiID()" 2021-12-21 20:26:54 +00:00
Ed Sanders 238a6b49b4 Use new wikipage.watchlistChange hook 
Bug: T294254
Depends-On: I88af8585e8fc75f77ebef867d267199aeb2c6592
Change-Id: Ic7201de567329b5752dcf52602602030d7c347f0
 2021-12-21 13:00:48 +00:00
Translation updater bot 92a40190d8 Localisation updates from https://translatewiki.net. 
Change-Id: I89bd3309c596a9467bf6d1bed4e59728b0bacc7a
 2021-12-21 08:11:55 +01:00
Alexander Vorwerk 397dc2cea5 Replace usages of deprecated wfWikiID() 
The global function wfWikiID() is deprecated since 1.35 and it's usages
should be replaced with WikiMap::getCurrentWikiId().

Bug: T298059
Change-Id: Ie878a5479b7427e9ffab7d7f92ee2802997e3161
 2021-12-21 01:45:54 +00:00
Ed Sanders 8c6fadeb65 Remove getHeading from HeadingItem (JS) 
This matches the PHP implementation and was only used in
one place (when fetching authors in new topic tool).

Change-Id: I9d9e774616112e8dc6ab4919846e3abecc24553d
 2021-12-21 01:33:50 +00:00
jenkins-bot 793c8e990e Merge "Implement getSubscribableHeading/isSubscribable in JS and use" 2021-12-20 21:49:03 +00:00
jenkins-bot 6c1550b66e Merge "Better document {Object} types" 2021-12-20 21:38:09 +00:00
Bartosz Dziewoński 95780b0fab Fix some typos in doc comments 
Change-Id: I0f6c78e49e4eb30549f313d1a48f28a648cbd3f3
 2021-12-20 22:24:03 +01:00
Ed Sanders be9a9aa2a9 Implement getSubscribableHeading/isSubscribable in JS and use 
Bug: T298037
Change-Id: Ifbec49f6da51527f9634fda74b4fb4788a4a015e
 2021-12-20 17:29:43 +00:00
Ed Sanders 2e1241289c Better document {Object} types 
Change-Id: Ibfaf2ded443301c68552dbf98a1897a50bda9ef5
 2021-12-20 17:25:54 +00:00
Ed Sanders 640638b1dc ReplyWidget: Document all methods 
Change-Id: Iab509a7605c3b8e25bcc20fb7176fed23409aed4
 2021-12-20 15:59:47 +00:00
Ed Sanders fe18f5ba22 Controller: Use 'this' in $.each as intended 
Change-Id: Icd507d6726ca391fc39e5d89429e0eed35ba9873
 2021-12-20 15:59:47 +00:00
Ed Sanders ebd37369ce Controller: Document private methods 
Change-Id: I6f5fb0c282c0dc15e175ae278006d918601ccdda
 2021-12-20 15:59:46 +00:00
Translation updater bot e5036c83b4 Localisation updates from https://translatewiki.net. 
Change-Id: I84ef5e7400ca1e996f9ce086e56980347f590301
 2021-12-20 08:21:04 +01:00
libraryupgrader 99dda222ec build: Updating mediawiki/mediawiki-phan-config to 0.11.1 
Change-Id: Ife9812d74b86ddb2f6ba4f5a9b9eafbef0f86bce
 2021-12-20 07:00:31 +00:00
Umherirrender d32dcfbb3c Use ParserOptions::newFromAnon instead of ParserOptions::newCanonical 
ParserOptions::newCanonical is deprecated.

Change-Id: I26667c9102c37d962ceaa81c082566819b503744
 2021-12-18 20:15:02 +01:00
jenkins-bot 9d73ed5dfb Merge "Add beta preference discussiontools-betaenable to DefaultUserOptions" 2021-12-17 18:32:59 +00:00
jenkins-bot fb16305135 Merge "Show a hint on legacy interface when arriving from new topic tool hint" 2021-12-17 17:30:39 +00:00
jenkins-bot e568c62f85 Merge "Show a hint on the new topic tool to explain that it's new" 2021-12-17 17:30:37 +00:00
Bartosz Dziewoński 4242b848d8 Work around a Safari bug causing shadows to remain when the popup is removed 
Bug: T297266
Change-Id: Id6c4c140d8e49ad995dbabeb95ef0e41aabba024
 2021-12-17 17:57:54 +01:00
jenkins-bot a351710e8f Merge "Test cases for partially transcluded comments" 2021-12-17 16:48:09 +00:00
jenkins-bot be07ec8cfc Merge "Add Range::compareBoundaryPoints" 2021-12-17 16:48:04 +00:00