Commit graph

3514 commits

Author SHA1 Message Date
Tim Starling ef7213a3d3 Clean up ApiDiscussionToolsPageInfo hack
Treat non-talk pages as empty ContentThreadItemSet objects, instead of
returning early from execute().

Exclude non-talk pages even if only the rev_id is specified.

If both rev_id and title are specified, use the title from the
database.

Bug: T325477
Bug: T325598
Change-Id: I3947ac94bb7c9a3d24b73c95f0df2cf847c955f2
2022-12-21 00:57:34 +00:00
Translation updater bot 075593343d Localisation updates from https://translatewiki.net.
Change-Id: I40a8ce11c927c0586881b6d641c5d5f59315ee76
2022-12-20 09:29:25 +01:00
jenkins-bot 477917e7e7 Merge "Only preload getPageData if there's thread data for the page" 2022-12-19 10:08:58 +00:00
David Lynch 013872ae22 Only preload getPageData if there's thread data for the page
This should avoid hitting the API if the DT JS is loaded off of talk
pages. At worst, if this is overly restrictive, later calls should still
load it when someone actually interacts with a reply widget.

Bug: T325477
Change-Id: If898dd4a21f1d2620c5a1e79908647070c441854
2022-12-19 03:03:02 -06:00
jenkins-bot 0a5397b4b5 Merge "Emergency: discussiontoolspageinfo return empty response in non-talk ns" 2022-12-19 08:55:49 +00:00
Translation updater bot 248f1e754c Localisation updates from https://translatewiki.net.
Change-Id: I0b76b5c79cbcf69b8cf2a6b8a1f1fe982425e3dd
2022-12-19 09:03:50 +01:00
Amir Sarabadani 00f5ba5db4 Emergency: discussiontoolspageinfo return empty response in non-talk ns
Bug: T325477
Change-Id: Ia7c8cca8051c800646c0f403065589f682d1ff17
2022-12-19 08:57:43 +01:00
David Lynch fcb6468805 a/b test anonymous ID was being reset because of cookie prefixes
Bug: T321961
Change-Id: Ie37d0dbefaf10bf48c32461cd7d5d1b4c7882725
2022-12-16 14:45:07 -06:00
Translation updater bot 92f31745c4 Localisation updates from https://translatewiki.net.
Change-Id: Iaf79a984603dff3f14813e356b84647748d6368c
2022-12-16 08:46:48 +01:00
David Lynch 0db7b997f3 Log an event when the lede button is clicked
Bug: T314596
Change-Id: Ifb5c9eb3cfac8b217546d4945e6f39ce38251e1e
2022-12-15 11:27:26 -06:00
Translation updater bot 9cc104cb88 Localisation updates from https://translatewiki.net.
Change-Id: I698db4062d0449b9e26a20244464b59727973fde
2022-12-15 11:35:42 +01:00
jenkins-bot 459554b18c Merge "Use new stable API for subtitle modification" 2022-12-14 04:09:58 +00:00
jenkins-bot 05e717f3ef Merge "VisualEnhancements: in some languages put an arrow by the reply button" 2022-12-13 19:47:12 +00:00
daniel a6a12730fc Don't write to parser cache from maintenance script
The parser cache for parsoid output isn't yet ready for full load.
Don't flood it when running batch operations.

Change-Id: I77f3de30b0500f0e5c593f4d31dceef7720f848e
2022-12-13 16:26:03 +00:00
Translation updater bot 9fd313fb38 Localisation updates from https://translatewiki.net.
Change-Id: Ie39a2262a390c2234c884a9b37346ca81e51e3b6
2022-12-13 08:16:50 +01:00
David Lynch c706562ce9 VisualEnhancements: in some languages put an arrow by the reply button
New config: DiscussionTools_visualenhancements_reply_icon_languages

Config is set up with a provide_default merge strategy so we can remove
items from it quickly if need be.

Bug: T323537
Change-Id: Ib748897a2162bb233000f7364e30b268932f4c4a
2022-12-13 00:11:08 -06:00
Jon Robson fbd951906a Use new stable API for subtitle modification
Bug: T324876
Depends-On: Id8436324e2ae2fd9f488b65b3b7bfc19611870d1
Change-Id: I4b178f67b6718fa9a84827e1804ec4eb1483f735
2022-12-13 01:13:29 +00:00
Translation updater bot cc91a40738 Localisation updates from https://translatewiki.net.
Change-Id: I2a0a2d66f1e2a467d62c0ec946fbad5a92f4353a
2022-12-12 08:22:17 +01:00
Translation updater bot 8cb138133f Localisation updates from https://translatewiki.net.
Change-Id: I21e25c8b787fc680b3ab724218d098b4a021a559
2022-12-09 08:45:59 +01:00
jenkins-bot beded3d29d Merge "Add 'collapsible-headings-collapsed' body class" 2022-12-09 01:34:09 +00:00
jenkins-bot ae323bf5e9 Merge "Deemphasize "Learn more about this page" link" 2022-12-08 17:03:35 +00:00
Translation updater bot 7d826422c2 Localisation updates from https://translatewiki.net.
Change-Id: I12df288cfe2dd0aecfcc29d7105060105049d2fb
2022-12-08 08:28:47 +01:00
Bartosz Dziewoński fda9f159f5 Deemphasize "Learn more about this page" link
* Increase selector specificity to make it work
* Tweak colors, they were lighter than intended
* Use color rather than opacity on text to avoid making it blurry
  (opacity disables subpixel rendering)

Bug: T324702
Change-Id: Ie32a7481ea90b983cd33e6eae981d47db8612c9f
2022-12-07 22:13:55 +01:00
Ed Sanders c2dc05b085 Add 'collapsible-headings-collapsed' body class
Used by MobileFrontend in I78cfb22fbe7d to prevent sections from
auto-expanding.

Bug: T321618
Bug: T322628
Change-Id: I6dafd5b9cb170bfa57f185849db6450162173399
2022-12-07 16:51:22 +00:00
Translation updater bot 529e83fce6 Localisation updates from https://translatewiki.net.
Change-Id: I34554806317ea686163a6ab722d02df48da46af9
2022-12-07 08:13:09 +01:00
Translation updater bot 05dcc05f89 Localisation updates from https://translatewiki.net.
Change-Id: I8724b4d5b6a9bab70746dbfe86b836a446ae544e
2022-12-06 08:51:59 +01:00
Francois Pignon de107bb6a8 Optimize some jQuery selectors
Bug: T324523
Change-Id: I57a86f3f29cd33e93db31338420af15fdb3113b9
2022-12-05 23:56:09 +00:00
daniel 683edf3947 Track parsoid render reason.
Call ParserOptions::setRenderReason to allow us to track why we render
and in particular, why we write to the parser cache.

Change-Id: If42f802f4cf2da39b06cbb8a30c4dc7d9a663001
2022-12-05 20:54:55 +01:00
jenkins-bot 984f804f17 Merge "Don't collapse the lede section when it has comments" 2022-12-05 19:04:37 +00:00
jenkins-bot 8a6bc91f46 Merge "Consider MediaWiki:Talkpageheader message when adding "Learn more" button" 2022-12-05 19:04:35 +00:00
Translation updater bot fa974c5af4 Localisation updates from https://translatewiki.net.
Change-Id: I02409ec6cd31c3abadcd1f8387b30b3ae4d11e2f
2022-12-05 08:33:22 +01:00
jenkins-bot e27e5ac55e Merge "Clear pageDataCache whenever re-initializing" 2022-12-02 11:58:45 +00:00
jenkins-bot 8111d66fbb Merge "CommentController: Fix 'discussiontoolscompare' polling not stopping" 2022-12-02 11:58:43 +00:00
Bartosz Dziewoński a2a06d0316 Reverse default sorting on Special:TopicSubscriptions
Bug: T324245
Change-Id: I87c43bda9a40fdf66c3f4f2d8bc66e211107a557
2022-12-01 22:18:18 +01:00
Bartosz Dziewoński 7dc35aa3ad CommentController: Fix 'discussiontoolscompare' polling not stopping
The .always() callback can be called after .teardown(), and would
previously restart the polling.

Bug: T313096
Change-Id: I6e4c0f7d47e13bd4a259282a508afcdf0c1bd949
2022-12-01 21:12:37 +00:00
Bartosz Dziewoński 37fda5e181 Clear pageDataCache whenever re-initializing
Bug: T323661
Change-Id: Ia080f4a8e79551bd16a1ce96f6851a76159d8da7
2022-12-01 21:49:08 +01:00
David Lynch 51ed8a21f6 Avoid error building threaditemshtml if there's an empty final section
If the final content on a page is a heading, there would be an error as
we tried to access nextSibling on a non-existent node.

Also tidies up the case where there's an empty section that's not the
final section. It would have `othercontent` set to an empty string,
which was pointless -- the empty `replies` field is sufficient.

Bug: T321317
Change-Id: Ia58e97214e715c1f6b02c2e045d13f2df7393b80
2022-12-01 11:44:28 -06:00
jenkins-bot 64e5c91970 Merge "Hide buttons for print media" 2022-12-01 15:14:33 +00:00
jenkins-bot db1aa31eed Merge "Remove dd overflow hack" 2022-12-01 15:04:09 +00:00
Translation updater bot c6547e253b Localisation updates from https://translatewiki.net.
Change-Id: I7aaa2dd3afd76c7b9c832de2693cc213f79fad96
2022-12-01 08:15:24 +01:00
Bartosz Dziewoński b4475801fd Don't collapse the lede section when it has comments
Bug: T324139
Change-Id: I14e1dae0fef4177f5a6a223bc9b663e99c9f741c
2022-11-30 20:25:22 +01:00
Ed Sanders 7ab0c69f39 Remove support for data-mw-comment
Can be merged once I85ee8e6ed6 has been deployed long enough
for all the caches to have been purged.

Change-Id: Ic9773c2e45a4aa796cb6bca52e58d7db1016a977
2022-11-30 18:31:02 +00:00
jenkins-bot 337d0938f3 Merge "Remove some redundant PHPDoc comments" 2022-11-30 16:47:12 +00:00
Translation updater bot 38218039fa Localisation updates from https://translatewiki.net.
Change-Id: I57761a97b969bbc484eb7155ce314bb9bbcee264
2022-11-30 08:52:51 +01:00
jenkins-bot 61b63139b9 Merge "Follow-up be012ced: tests: Provide some basic direct tests for CommentUtils::getTitleFromUrl" 2022-11-29 22:21:05 +00:00
James D. Forrester 7017acaf1d Follow-up be012ced: tests: Provide some basic direct tests for CommentUtils::getTitleFromUrl
Change-Id: Idb44d7890b05e0d9d90fdabe46f295b80996f60c
2022-11-29 15:43:18 -05:00
jenkins-bot 5a524d0fa3 Merge "Track events for the new comment notice" 2022-11-29 19:40:32 +00:00
jenkins-bot a1c1816359 Merge "Ignore negative page scroll values on iOS" 2022-11-29 18:51:55 +00:00
Bartosz Dziewoński e72f58ca78 Remove some redundant PHPDoc comments
Inspired by this Wikitech-l discussion:
https://lists.wikimedia.org/hyperkitty/list/wikitech-l@lists.wikimedia.org/thread/NWXPNHRNLEVXHSWX33H473OAWQP6CDOA/

To keep this simple for now, I am only removing redundant PHPDoc
comments on constructors, and only when all the documentation for
parameters completely duplicates type hints.

More could be done, but that can happen later when we have better
tooling. Redundant comments on constructors that take a dozen services
are by far the most annoying for me and I want them gone now.

Change-Id: I86cbf7d6e48035cfa06f780c8fb1b02e68709a0c
2022-11-29 18:47:18 +00:00
Bartosz Dziewoński 74fbe19838 Consider MediaWiki:Talkpageheader message when adding "Learn more" button
We also need to move the code to the other hook to avoid adding it twice now.

Bug: T324046
Change-Id: I186d15f6e6537b47b019c9707d7ae8ef080f4ae2
2022-11-29 18:46:40 +00:00