wikimedia/mediawiki-extensions-DiscussionTools
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools synced 2024-11-28 02:00:57 +00:00
Code Issues Packages Projects Releases Wiki Activity
2851 commits 11 branches 4 tags 127 MiB
Commit graph

2851 commits

This branch
This branch
All branches
Author SHA1 Message Date
jenkins-bot 6e00c904cf Merge "Add test cases for T313093" 2022-11-24 14:00:42 +00:00
jenkins-bot eb9631164d Merge "Place replies outside transclusions, disallow replying to transcluded comments" 2022-11-24 14:00:40 +00:00
jenkins-bot b155d12e8e Merge "Add test case for T313100" 2022-11-24 14:00:37 +00:00
jenkins-bot e1a1023f3e Merge "highlighter: Fix double-escaping of popup notifications" 2022-11-24 13:48:45 +00:00
Translation updater bot 68d17126fb Localisation updates from https://translatewiki.net. 
Change-Id: Ia628f80859c557edc8a130bd53bd65c8b7d3a3e9
 2022-11-24 08:17:09 +01:00
Bartosz Dziewoński 7dd4855979 Fix Phan failure due to core changes in Action 
Caused by I8188172aeb7ec775eeb2060a1e163112e9e5ed66.

Change-Id: Ieafc280c76b20e4efbe23cf3e2b193a4a6490b50
 2022-11-23 11:27:54 +00:00
Translation updater bot d1e995430f Localisation updates from https://translatewiki.net. 
Change-Id: I5967d648c3af40d44379186f9e6e3c2dfdb15539
 2022-11-23 08:32:09 +01:00
jenkins-bot fc446b31b9 Merge "Dedupe ApiDiscussionToolsTrait::parseRevision and HookUtils::parseRevisionParsoidHtml" 2022-11-22 08:53:23 +00:00
jenkins-bot 7d06b61347 Merge "ApiDiscussionToolsTrait: PageInfo & Compare don't need HTML for editing" 2022-11-22 08:51:57 +00:00
Translation updater bot 6f4438fac3 Localisation updates from https://translatewiki.net. 
Change-Id: If3944f4ff8d224464598f403adcc92f3f5622fe8
 2022-11-22 08:33:34 +01:00
Bartosz Dziewoński 3042148bfe Dedupe ApiDiscussionToolsTrait::parseRevision and HookUtils::parseRevisionParsoidHtml 
After recent changes (I101c1e84739a2ac1f562f2f7bdc4b8f53d9f3b23 and
Ifbde590ccb6bf3203a2f664cb0d8a73b8d507b78) these methods became
basically the same.

Change-Id: Iedc201e798a5a34713296b20b97ae6cc8b991b66
 2022-11-21 21:01:19 +00:00
Derick Alangi 672ca86016 ApiDiscussionToolsTrait: PageInfo & Compare don't need HTML for editing 
ApiDiscussionToolsPageInfo and ApiDiscussionToolsCompare in direct parsoid
or VRS modes tries to fetch HTML using VisualEditor thus stashing the
HTML gotten which we don't want, we only need it for viewing in these cases.

This seems like something that was/is already happening in RESTBase. So for
APIs in DiscussionTools that need the HTML for viewing, just get it from
parser cache and not stash it.

Bug: T323357
Change-Id: I101c1e84739a2ac1f562f2f7bdc4b8f53d9f3b23
 2022-11-21 16:29:13 +01:00
Bartosz Dziewoński 9601fde487 HookUtils::parseRevisionParsoidHtml doesn't need HTML for editing 
Bug: T323357
Change-Id: Ifbde590ccb6bf3203a2f664cb0d8a73b8d507b78
 2022-11-21 13:37:16 +01:00
Translation updater bot 1eba2b1286 Localisation updates from https://translatewiki.net. 
Change-Id: I343ee7936e82899d57d73521a16ea8f865f48b6c
 2022-11-21 08:15:51 +01:00
Bartosz Dziewoński e0be640c35 Don't add lede button if mobile DiscussionTools not enabled 
Bug: T323341
Change-Id: I60d93a3e72918d303a45b2a75f4fa549aea8d917
 2022-11-18 15:55:54 +01:00
Bartosz Dziewoński 86ffa41af7 highlighter: Fix double-escaping of popup notifications 
Bug: T323351
Change-Id: Iaa69ccd944114f2a7ff88e01b6e58d70d38cac89
 2022-11-18 14:56:36 +01:00
jenkins-bot 06aa46df34 Merge "Don't run OutputPageBeforeHTML for the talkpageheader" 2022-11-18 09:26:10 +00:00
Translation updater bot 08aaa41148 Localisation updates from https://translatewiki.net. 
Change-Id: I52c8b0089e47ecaa8b3f78d2930c584c3632c6ad
 2022-11-18 09:18:09 +01:00
David Lynch 714830f615 Don't run OutputPageBeforeHTML for the talkpageheader 
Ideally this would just not run the hook for any interface messages, but
that condition isn't obviously available.

Bug: T316175
Change-Id: Ibd354eb7a0fb7a316dcbf09e64b80f2d9b4008c8
 2022-11-17 21:15:51 -06:00
Translation updater bot 4b79d1f02b Localisation updates from https://translatewiki.net. 
Change-Id: Ice8787da2a93b817db2a905f77ab050547143de4
 2022-11-17 08:26:55 +01:00
Bartosz Dziewoński 4cebf20e76 CommentFormatter: Fix condition for lede button to consider table of contents 
(Also fix some related CSS that was accidentally moved in
Ie5198e902ec3fa7a7eba56cef6c6f0ef71ef7314)

Bug: T323241
Change-Id: I1fa67965a1b6b827c500a9de63f5b5295bee840d
 2022-11-16 22:18:11 +01:00
jenkins-bot 1a35468eb3 Merge "CommentFormatter: Fix condition for lede button to consider new wrappers" 2022-11-16 21:09:04 +00:00
jenkins-bot 954dc520b7 Merge "Make "Add topic" button sticky" 2022-11-16 19:06:30 +00:00
Ed Sanders b132522fa9 Make "Add topic" button sticky 
Bug: T316175
Change-Id: Ie5198e902ec3fa7a7eba56cef6c6f0ef71ef7314
 2022-11-16 12:23:34 +00:00
Bartosz Dziewoński 0432eaf1e3 CommentFormatter: Fix condition for lede button to consider new wrappers 
Bug: T323171
Change-Id: I3125f98e57bf410f19ece07b8376c92ae619d0ea
 2022-11-15 23:39:45 +01:00
Bartosz Dziewoński 46d766f30d Remove override for Minerva hiding .tmbox, no longer needed 
Depends-On: Ifb0316256bdec5008acc48544ddd3e2bf71b6d41
Bug: T257394
Change-Id: I7b442d2e009f631ec8ac183f4767ffcc1e94954c
 2022-11-15 11:26:08 +01:00
Translation updater bot e89a879f34 Localisation updates from https://translatewiki.net. 
Change-Id: I1a47aa36c78d6f5765e7dfd44a953faa0f63af61
 2022-11-15 08:23:59 +01:00
Bartosz Dziewoński 82069f7db5 Add test cases for T313093 
Change-Id: I045be8da8fc144846312ce84b9e79d65c3d5b2b4
 2022-11-14 19:17:34 +01:00
Bartosz Dziewoński 469b7720af Place replies outside transclusions, disallow replying to transcluded comments 
Bug: T313100
Change-Id: I3993c96ec8d3d0add33d779860d158327985107d
 2022-11-14 19:17:18 +01:00
Bartosz Dziewoński 065c7d8f2d Add test case for T313100 
(Also README corrections)

Change-Id: I037155ba1b775511273a78a85b34c29f3319a9a6
 2022-11-14 19:16:43 +01:00
jenkins-bot 5092498bb5 Merge "Tweak mobile styles for no-JS compatibility" 2022-11-14 15:29:42 +00:00
jenkins-bot 0ade11d299 Merge "Remove some unused CSS" 2022-11-14 15:29:27 +00:00
jenkins-bot 0655cdbf56 Merge "Move visualenhancements metadata and some buttons outside of <h2>" 2022-11-14 15:29:12 +00:00
Bartosz Dziewoński 310323b561 Tweak mobile styles for no-JS compatibility 
Bug: T321430
Change-Id: I0f20750995d89c0bb4be9a70e594326f15a6de0b
 2022-11-14 15:01:35 +01:00
Bartosz Dziewoński f27d173852 Remove some unused CSS 
No longer needed since the "Subscribe" button was moved elsewhere
(2960853088).

Change-Id: I758469c6883fe6056dc3859b5b5d43d98771b518
 2022-11-14 14:57:13 +01:00
Translation updater bot 053c21b08a Localisation updates from https://translatewiki.net. 
Change-Id: Ief79949c2310656ba427c487477ed77efb3a73aa
 2022-11-14 08:10:18 +01:00
jenkins-bot bbdc49f87a Merge "persistRevisionThreadItems: Print time taken" 2022-11-11 18:45:25 +00:00
Translation updater bot f6bdb9df81 Localisation updates from https://translatewiki.net. 
Change-Id: I03f701c46fbb0e4a4aba05a2483b0b9335c234d9
 2022-11-11 08:40:46 +01:00
Bartosz Dziewoński 08e1073f58 ThreadItemStore: Handle race conditions when finding/inserting outside of transaction 
Bug: T322701
Change-Id: Icea63dd562c1812a372f3a947ba1244e72d07a16
 2022-11-10 23:33:24 +00:00
Bartosz Dziewoński 04cfffe323 Move visualenhancements metadata and some buttons outside of <h2> 
We wrap a `<div>` tag around the `<h2>`, and move some elements there.
The markup is inspired by and compatible with my proposal for T13555.

The "ext-discussiontools-init-section" class is moved to the `<div>`.

A small patch is needed in MobileFrontend to preserve the section
collapsing functionality: I11bff21e81046898ca63f3f432797129fa70ad88.

The following elements are now outside of `<h2>`:
* Metadata bar
* Subscribe button
* Ellipsis menu (only shown on mobile)

The following elements are sadly still inside of `<h2>`:
* Subscribe links (only shown on desktop)
* Section edit links from MediaWiki core
Trying to move them mucks up the CSS too much. I hope we can resolve
this later as a part of the work on T13555.

Depends-On: I11bff21e81046898ca63f3f432797129fa70ad88
Bug: T314714
Change-Id: I0bbdcfa02c334858737855349d7a35746de1d8f2
 2022-11-10 23:35:40 +01:00
Ed Sanders e0855e4f41 Make virtual keyboard detection into a body class 
This allows it to be re-used for other features, such as the
upcoming floating "Add topic" button.

Add some support for Android, although not used in this patch.

Change-Id: Ibd1e1ee087ac607c88a7402d0422c633700d1992
 2022-11-10 23:30:53 +01:00
Ed Sanders 8cd239b0b4 Move ...-replylink-open class to <body> 
This allows elements outside the page container to respond to it.

Change-Id: Id880ada0e24cb803e7b992284a1a95950f3da36f
 2022-11-10 23:30:10 +01:00
Ed Sanders 79521f89cf Add button to reveal lede section on mobile 
Bug: T312309
Depends-On: I9c3035c9dbe7545a05efb2286dffe0145d3557b4
Change-Id: I9d74914ddbcc9def74e85106a68574a807b0b731
 2022-11-10 22:10:04 +00:00
Bartosz Dziewoński d8325ac9b8 CommentFormatterTest: Fix PHP 8.1 deprecation warning 
Change-Id: I1913eff29e884be4eb6177b9aa8e29fe297560c7
 2022-11-10 23:03:06 +01:00
Translation updater bot 92432eaa06 Localisation updates from https://translatewiki.net. 
Change-Id: I978818a4665506b3dbf311d1b2bb0b83403e434d
 2022-11-10 08:12:01 +01:00
jenkins-bot f0c1f483cb Merge "CommentFormatterTest: Make desktop and mobile separate test cases" 2022-11-09 08:06:13 +00:00
Translation updater bot dd249c4b96 Localisation updates from https://translatewiki.net. 
Change-Id: I39d9496c15753078550303c347393d5ec4ef9fb5
 2022-11-09 08:57:39 +01:00
Bartosz Dziewoński 9cde62957f CommentFormatterTest: Make desktop and mobile separate test cases 
This is a better way than a loop in the test code.

When using DISCUSSIONTOOLS_OVERWRITE_TESTS, if both desktop and mobile
cases fail, both will be updated now. Previously the first failed
assertion would stop the test after only updating one file.

Change-Id: I4ce6f45b047e02c9f00024a9e5057adcb0e28047
 2022-11-09 02:44:30 +01:00
Bartosz Dziewoński 7b5a8cea11 persistRevisionThreadItems: Print time taken 
Change-Id: Ide002b26740815ef0db3351a0e7e8c498010d164
 2022-11-09 00:18:42 +01:00
jenkins-bot af6f6e6149 Merge "Disable "Share feedback..." links by default" 2022-11-08 22:04:08 +00:00