Commit graph

1331 commits

Author SHA1 Message Date
Bartosz Dziewoński 5103e651be Add tests for CommentFormatter::postprocessTopicSubscription
Change-Id: Ief9648b8805fadcc170c54b627eb669cc8b907b6
2021-04-21 11:57:25 +00:00
Bartosz Dziewoński 0b82162149 CommentFormatter: Fix regexp in topic subscription postprocessing
The regexps needs to be non-greedy, otherwise it could swallow up a
large chunk of the page (up to the next comment).

I noticed this when adding tests for this code, in the 'unclosed-font'
test case (Ief9648b8805fadcc170c54b627eb669cc8b907b6).

Change-Id: I5f67a9599b0cb07bdd53abeebac9ada221181b66
2021-04-21 11:57:21 +00:00
Bartosz Dziewoński 228b81fab9 Move implementation of subscribe buttons to CommentFormatter
Change-Id: Iad59ea047ed12bb34b483a94f443b39de6985bd3
2021-04-21 11:57:17 +00:00
Bartosz Dziewoński 1957c340b9 Remove unused variable
Change-Id: Ia4ad464b765c67aea27092a161d28ad1d890e96a
2021-04-21 11:57:11 +00:00
jenkins-bot 69fc17db81 Merge "Rename CommentFormatter::addReplyLinks" 2021-04-21 11:50:42 +00:00
Bartosz Dziewoński 4bbfe6cb5d Rename CommentFormatter::addReplyLinks
Bug: T280351
Change-Id: I0d7627d63407e11cca6091f78e4d440eec6efa91
2021-04-21 11:24:03 +00:00
Translation updater bot b7cef26b08 Localisation updates from https://translatewiki.net.
Change-Id: I9e0508b77cbbe7c7faf73a089215e07c39a1a4a8
2021-04-21 08:52:24 +02:00
Bartosz Dziewoński dcd898ed6d CommentFormatter: Add 'ext-discussiontools-section' class instead of overwriting
Bug: T280433
Change-Id: I3746913b7212f252a1632db01e77e53038719cb5
2021-04-19 23:47:53 +02:00
jenkins-bot f5c6cb0b81 Merge "Remove <header> tags around headings for compat with MobileFrontend" 2021-04-19 16:38:32 +00:00
Bartosz Dziewoński a3f665e816 Remove <header> tags around headings for compat with MobileFrontend
We added it because the initial designs for the subscribe action were
much easier to implement like this, and topic "containers" (T269950)
would have required it.

However, the latest design of the subscribe action will not need it
(T279149), and topic containers are still very far away, so let's
remove it for now.

Bug: T280433
Change-Id: I21a23e9bea43f24d265750926fbd62b99038d3f1
2021-04-19 17:47:43 +02:00
Translation updater bot d1a5c9c428 Localisation updates from https://translatewiki.net.
Change-Id: I5b591c95ac0746691620fc7f2f5c76fad368006e
2021-04-19 08:50:20 +02:00
jenkins-bot ab41904d91 Merge "Migrate cookie hack users to beta feature" 2021-04-16 12:23:41 +00:00
jenkins-bot 58fc1753fe Merge "Include comment names in 'transcludedfrom' API response" 2021-04-16 11:30:22 +00:00
Translation updater bot 36e8e81b1b Localisation updates from https://translatewiki.net.
Change-Id: I37879d2c2980471d96f6f6480bb45428e228b0e3
2021-04-16 09:50:14 +02:00
jenkins-bot ef7073b8fd Merge "Simplify how warnings for IDs equal to legacy IDs are avoided" 2021-04-15 23:31:45 +00:00
jenkins-bot 49e23bf683 Merge "Fire the 'wikipage.content' hook on previews" 2021-04-15 20:51:02 +00:00
jenkins-bot 9d3a640930 Merge "Hooks: Use WebRequest::getRawVal where possible" 2021-04-15 19:56:50 +00:00
Translation updater bot 21bc7dd2cb Localisation updates from https://translatewiki.net.
Change-Id: I6eafd087075298887bc16b65d7a5072a27365e64
2021-04-15 08:43:13 +02:00
Timo Tijhof 269514f533 Hooks: Use WebRequest::getRawVal where possible
The 'dtenable' does not appear to take user-provided content that
requires language normalization. In general getRawVal should be used,
or if it's user input that needs normalization, use getText(). Perhaps
one day we'll alias or deprecate getVal (which is currently an odd
mid-way hybrid, most closely to getText; originally created for
EditPage.php textareas).

Change-Id: I8364c84f8c4f700da6e208df2e87c29bf254d685
2021-04-15 02:30:12 +00:00
Bartosz Dziewoński 2352fefb58 Migrate cookie hack users to beta feature
Bug: T277783
Change-Id: I455cab2acd0729b1c117b65cc1ede0ad9eb651cf
2021-04-14 20:36:32 +02:00
jenkins-bot 5938e97250 Merge "Don't allow query and cookie hacks to enable topic subscriptions" 2021-04-14 09:06:06 +00:00
Translation updater bot ea2493cd80 Localisation updates from https://translatewiki.net.
Change-Id: I0d9bcb55c3c440fb2a6889fb40edf4d14fcba17f
2021-04-14 08:38:07 +02:00
Bartosz Dziewoński 9420f22e9d Don't allow query and cookie hacks to enable topic subscriptions
We can't allow it, because the required database tables may not exist
yet (T280082).

This is meant to be temporary until we complete DBA review and the
tables are created.

Bug: T280082
Change-Id: I8f947b779c6829763d3413931c6d354e6f7aee4d
2021-04-14 00:08:52 +02:00
Translation updater bot 8097e52ec4 Localisation updates from https://translatewiki.net.
Change-Id: Ic5a8b8a6d5f79681261fbb511285aadd48a45b24
2021-04-13 09:20:16 +02:00
Bartosz Dziewoński 3e319251f0 Fix check for your own talk page on subpages
Bug: T279604
Change-Id: I955a602ffb39f2443de9a3b165d8105ea3762058
2021-04-12 17:06:02 +02:00
Ed Sanders a555db7892 Topic subscriptions: Don't register notification type/group unless enabled
Bug: T279671
Change-Id: If3c46b992654c40daeeccaf8a3dcedde680c8404
2021-04-12 15:04:43 +00:00
Ed Sanders f3422f40a6 Disable topic subscriptions API when feature is unavailable
Bug: T279671
Change-Id: Ib5a233329e7e6697c198bc0ae10c770282fd9470
2021-04-12 15:04:07 +00:00
Ed Sanders f6c9508001 Create constants for feature strings
Change-Id: I2d7bf18faf6345a4816c2ebef9744c4e6f62cc40
2021-04-12 14:40:51 +00:00
Ed Sanders 23a490deca Topic subscriptions: Don't generate events when feature is unavailable
Bug: T279671
Change-Id: I8f57b2a1885619db868f25ea68208c2fad5fc040
2021-04-12 14:40:27 +00:00
Ed Sanders 6cafd7735d Topic subscriptions: Only check for events on talk pages
Change-Id: Ic2b7536baea58fb4868cec6f477e72bd8b717e3a
2021-04-12 14:40:13 +00:00
Translation updater bot bd9c3c7be7 Localisation updates from https://translatewiki.net.
Change-Id: I9986e5878c26c1879ce04bb580a3812b560f2ab8
2021-04-12 08:37:30 +02:00
Translation updater bot 6c09c491e3 Localisation updates from https://translatewiki.net.
Change-Id: I7f311ddb9fd895ad852e81486d8dfaf4f1d039de
2021-04-09 08:58:14 +02:00
Bartosz Dziewoński 6bf75b4752 Fire the 'wikipage.content' hook on previews
We already fire it after saving the reply/topic.

Bug: T279141
Change-Id: I4ecbea877035f61d9642dded9ca54e5bff795099
2021-04-08 21:38:45 +02:00
Ed Sanders bbd664e167 build: Update eslint-config-wikimedia to 0.20.0
Change-Id: I5e692c55576a7b34703856b4292d21fcdec92117
2021-04-08 14:02:16 +01:00
Translation updater bot e4eeeb49ad Localisation updates from https://translatewiki.net.
Change-Id: I9bd151e527f8f6357af381e199d543ac0ded17aa
2021-04-08 08:39:59 +02:00
Bartosz Dziewoński bfe6a36514 Include comment names in 'transcludedfrom' API response
As of 7ad6328223, we also use this data
to check whether comments exist on the page, not only whether they're
transcluded.

Follow-up to 42ce942c86.

Bug: T275821
Bug: T273413
Change-Id: I95eb85354e7b84cc10ab703d28315d0667696f4c
2021-04-07 22:46:36 +02:00
Translation updater bot 96f1e746e9 Localisation updates from https://translatewiki.net.
Change-Id: If7a70b6754175ffb4b61d287d9fa16ad3bc670b1
2021-04-07 08:51:30 +02:00
jenkins-bot 282f14afe8 Merge "Make sourcemodetoolbar preference available" 2021-04-06 23:44:44 +00:00
Bartosz Dziewoński 18cbae137f Make sourcemodetoolbar preference available
Change-Id: Icc8e254453ee2b2d74e4890744ec7f4512197627
2021-04-06 23:36:09 +00:00
Ed Sanders 0a39c11914 Echo wiring for topic subscriptions
Depends-On: I60818d57552946857077dee93b0adb036621b791
Change-Id: I7e0996843cdd70141e19d5c7ce66122204efa1b7
2021-04-06 23:28:28 +02:00
Ed Sanders eb7e682d2f Topic subscription front end
Bug: T276996
Change-Id: Ifb62c04c2a0ea8399749b22021d6a1c5a079bf94
2021-04-06 23:28:28 +02:00
Ed Sanders 0bf7539eb9 Topic subscription action API
Bug: T264885
Change-Id: Ie4ddbcef8769c124039a72f544702c9a88bc49eb
2021-04-06 21:25:24 +00:00
David Lynch 86be6f83da Service to interact with topic subscriptions
Bug: T264885
Change-Id: Ie9592de655f50e1d0cf02a7f795b5203398a9696
2021-04-06 21:25:13 +00:00
David Lynch 5b8646f73f Create table for topic subscriptions
Bug: T264885
Change-Id: I92d0362eac80ae1ae70839e26e2c084003862a5f
2021-04-06 21:24:53 +00:00
jenkins-bot f702e094a8 Merge "Remove compatibility code for 'data-mw-comment-start' change" 2021-04-06 13:48:19 +00:00
Translation updater bot f880c2d2c5 Localisation updates from https://translatewiki.net.
Change-Id: I40980237a1ad3f19ff94aca18fc988b66faec42f
2021-04-06 12:02:04 +02:00
jenkins-bot 9bf9977369 Merge "Fix switching interface getting stuck after failing to switch" 2021-04-03 12:59:21 +00:00
Translation updater bot 1837ffe8a5 Localisation updates from https://translatewiki.net.
Change-Id: Ib8139cc4519c71dc7bdf35fbd4ceb8faa045be91
2021-04-02 09:48:37 +02:00
Translation updater bot addf8ce9a9 Localisation updates from https://translatewiki.net.
Change-Id: Ib9b5a12d9c7caaf9afd67fc47dd8d843b94c7900
2021-04-01 08:37:13 +02:00
Ed Sanders 4c27187500 Make the source mode toolbar a user preference feature
Bug: T275950
Change-Id: I099af342f378215c68092d165dd88de1807d29d2
2021-03-31 22:40:53 +02:00