Commit graph

3547 commits

Author SHA1 Message Date
jenkins-bot 344fe433ca Merge "Remove parser cache splitting ('dtreply' option)" 2021-10-19 15:57:06 +00:00
jenkins-bot fbcb6d50a5 Merge "Define documentable types in eslintrc instead of inline" 2021-10-18 21:31:02 +00:00
Translation updater bot cdc4954fe2 Localisation updates from https://translatewiki.net.
Change-Id: I8e7b9700691394c145c8feb867925ed1dc9873c2
2021-10-18 15:19:56 +02:00
Ed Sanders f4c12e120a Define documentable types in eslintrc instead of inline
These types can be passed a parameters to any file without
creating a dependency, so it makes more sense to allow
the globally.

Change-Id: I5504465fd997b46547642e7046993b370b85586e
2021-10-17 14:38:39 +01:00
jenkins-bot aa8ed1d469 Merge "Remove redundant checks" 2021-10-14 16:02:32 +00:00
Bartosz Dziewoński d83816f508 Remove redundant checks
The info in wgDiscussionToolsFeaturesEnabled already includes a check
for user options.

Change-Id: I01377e647b1dd5d06b67d1e0c7ee6940f1617066
2021-10-13 21:59:47 +02:00
jenkins-bot 3df2f3c623 Merge "modifier: Handle empty nodes in appendSignature()" 2021-10-13 17:26:56 +00:00
jenkins-bot e5f8b1fe47 Merge "Replace marker comment with limit report data" 2021-10-12 15:20:13 +00:00
jenkins-bot a56d1a0a98 Merge "Re-enable wikitext paste conversion in source mode" 2021-10-12 15:19:45 +00:00
jenkins-bot 906cbe2d75 Merge "Compatibility with Microsoft Edge's translation feature" 2021-10-12 13:52:22 +00:00
Ed Sanders 7f16b7a4c2 TopicSubscriptions: Rename 'actions' column and unframe button
Bug: T273342
Change-Id: Ifd18551e0d89e5c0d4cebd022afebb9a31e2619b
2021-10-12 14:06:57 +01:00
Ed Sanders 7550bb4395 TopicSubscriptions: Hide broken "Topic" sort
This doesn't sort by the topic name, but the hidden
sub_id field, leading to a confusing order.

Bug: T273342
Change-Id: I6146abf05544d40c9ef0d2e8c58d020e5a5fa8a2
2021-10-12 14:04:59 +01:00
Alexander Vorwerk 0935bb1271 MediaWikiTestCase -> MediaWikiIntegrationTestCase
MediaWikiTestCase has been renamed to MediaWikiIntegrationTestCase in 1.34.

Bug: T293043
Change-Id: I485c5c5f0376ab60cdec49e934c6e7eea8c9feb5
2021-10-12 00:40:27 +02:00
Bartosz Dziewoński 8c6928aacf modifier: Handle empty nodes in appendSignature()
Bug: T292664
Change-Id: I0003528076e3981d639d337affcccbf394f59224
2021-10-11 22:17:46 +02:00
libraryupgrader b0c8621973 build: Updating ansi-regex to 5.0.1
* https://npmjs.com/advisories/1002401 (CVE-2021-3807)

Additional changes:
* eslint: Added `wikimedia/mediawiki` profile (T262222).
* composer.json: Updated phpcs command in composer test (T280592).
* composer.json: Added phpcs command to scripts (T280592).

Change-Id: I39276efa5a6991f6216992840c497ae9d3b5fd7d
2021-10-09 07:08:30 +00:00
Bartosz Dziewoński 384fc2aa8d Re-enable wikitext paste conversion in source mode
The current experience (implemented in T282789) is unobtrusive and
maybe even helpful.

This reverts commit 35e97c24fe.

Bug: T281009
Change-Id: I0514e8f8960600edf12b51fff6de305e46cf8c34
2021-10-09 03:38:11 +02:00
Translation updater bot 0dd0fc0013 Localisation updates from https://translatewiki.net.
Change-Id: I7c1b1d49bca753a6a99c361cb42f1f0bc124403d
2021-10-08 09:20:45 +02:00
Ed Sanders 605e7322b8 eslint: Lint root folder with server rules
Change-Id: I372eef293983bff0c79ad8aa0da1c7e5d07b1e44
2021-10-07 17:37:52 +01:00
Ed Sanders 02642e48dd Fix linting on i18n key order
Change-Id: Id30b228f2aaa710f75086b6b64ffda5726d59a8e
2021-10-07 17:37:51 +01:00
Bartosz Dziewoński 695a966a41 Remove unused non-parser-cache mode
Change-Id: Ief9f4153898b09a1ce15ccfdc8656dfad4642269
2021-10-07 17:59:10 +02:00
Bartosz Dziewoński dbb8b00ec7 Remove parser cache splitting ('dtreply' option)
Bug: T280599
Change-Id: I08b52874d575619308b5b83a39acfb6353c5b7b5
2021-10-07 17:59:10 +02:00
Bartosz Dziewoński e3af0bc65b Replace marker comment with limit report data
We always do our processing in the parser now, so we don't need the
marker comment to detect whether we've already processed the page.

Bonus: include the time taken by our processing in the limit report.

Bug: T291831
Change-Id: Ife7ddffbad1b1495b004739212002a98fdebe6c0
2021-10-07 17:59:10 +02:00
jenkins-bot f8bd39adbf Merge "Add Special:TopicSubscriptions" 2021-10-07 14:53:59 +00:00
Translation updater bot 52b3ba2ef7 Localisation updates from https://translatewiki.net.
Change-Id: Ie1271d0521feb36a397089f9ecd123406b6a7b63
2021-10-07 09:02:46 +02:00
Bartosz Dziewoński 59cba79c85 Compatibility with Microsoft Edge's translation feature
Bug: T292675
Change-Id: I7bc4dded7fdd522167d473dce4843d666c6e88fd
2021-10-06 21:01:10 +00:00
Bartosz Dziewoński a0dc12ab56 Add Special:TopicSubscriptions
Bug: T273342
Change-Id: If96a0df1efbf5cadfb6bf2bf8f7ad5c9c90ea142
2021-10-06 20:06:01 +00:00
Translation updater bot b0ce65736e Localisation updates from https://translatewiki.net.
Change-Id: Ic9c6f2aec7b1a75c160dc701a6b11cd65f2069f6
2021-10-06 09:28:17 +02:00
jenkins-bot c7d82f4ddc Merge "Remove uppercase of first character of auprefix" 2021-10-05 20:57:58 +00:00
jenkins-bot c4f94d0202 Merge ""Reply ... in one click" -> "Reply ... with one click"" 2021-10-05 19:22:43 +00:00
Bartosz Dziewoński 11566e4b27 Allow more flexible overrides for the terms-of-use messages
Bug: T284097
Change-Id: Ibacd9397a40ffcc8a8127ec543cb2f7300ce5464
2021-10-05 17:58:37 +02:00
jenkins-bot 1a67ab6d74 Merge "Make reply links more robust so Google Translate won't break us" 2021-10-05 13:53:03 +00:00
Translation updater bot bbf98c00a4 Localisation updates from https://translatewiki.net.
Change-Id: I9a0584c3b7e17e6d7dc078cd57951824b34317da
2021-10-05 08:29:31 +02:00
David Lynch 4211494ed7 Make reply links more robust so Google Translate won't break us
Normal link: `<a>reply</a>`

Google Translate: `<a><font><font>reply</font></font></a>`

Using jQuery's `closest` method to make sure we go up if the event
target isn't the data-mw-comment element should avoid problems.

Bug: T245563

Change-Id: I19ffb9a5b91617b98b0f00e4d185c01bcde093b0
2021-10-05 01:07:36 -05:00
Ed Sanders 9b19b32fc0 Compress emptystate.svg with svgo
14k -> 9k

Change-Id: Iec26b332627d8084f511edfbb69505b045ab6939
2021-10-04 12:56:20 +01:00
Ed Sanders f140e725a9 "Reply ... in one click" -> "Reply ... with one click"
"in" suggests that the "one click" fully encapsulates the
process of replying, and would probably be better used with
a timeframe, e.g. "Reply in one minute".

Change-Id: Iff323c3bc88959f3a0e6ea5b2f0a4174da5e8e21
2021-10-04 12:52:47 +01:00
Translation updater bot cfc4f8b7a3 Localisation updates from https://translatewiki.net.
Change-Id: I112c8dbfa82b89348f9d89443bd460bb6519dbb7
2021-10-04 08:55:44 +02:00
Translation updater bot cdf089b20c Localisation updates from https://translatewiki.net.
Change-Id: Ice11be400a9d4893eb5fad9367bdda296047b7f4
2021-10-01 09:29:49 +02:00
Translation updater bot 0ddcdb8a5b Localisation updates from https://translatewiki.net.
Change-Id: I35c68af690b6662ce9b4b2815200ed0bd4bb72ca
2021-09-30 08:57:24 +02:00
Umherirrender f42ea2ee44 Add beta preference discussiontools-betaenable to DefaultUserOptions
Without the default the preference is never deleted from the database,
even it was disabled by the user.

Bug: T291748
Change-Id: I239bfac1a221cc0a4cebf938d0438f5a8a859935
2021-09-29 10:36:13 +02:00
Translation updater bot 2e18a49315 Localisation updates from https://translatewiki.net.
Change-Id: I2c05926cc8d035728ec2fb99ca2e06b72fa5fc32
2021-09-29 09:01:43 +02:00
jenkins-bot 268b704b48 Merge "Add a link to preferences within the Reply and New Discussion Tools" 2021-09-28 16:34:59 +00:00
jenkins-bot 162cc03e6a Merge "Clarify the references to talk pages in notification preferences (#2)" 2021-09-28 14:57:55 +00:00
Bartosz Dziewoński 4be0751517 Fix almost all errors codes being logged as http-0
Follow-up to b52699ad35.

Bug: T290514
Change-Id: If82f10c58872d990b9dfa7cbdc9b784454a5fa46
2021-09-28 13:14:29 +02:00
Bartosz Dziewoński 7126d0f656 Clarify the references to talk pages in notification preferences (#2)
Bug: T286954
Change-Id: I8f351bf277c7acfaff37fe36eefce6768c3a04c6
2021-09-28 11:53:56 +02:00
Translation updater bot 57f6b6ddd3 Localisation updates from https://translatewiki.net.
Change-Id: Ibaabb077e6a7bbeefbd078797d19353311de7df1
2021-09-28 08:18:41 +02:00
Bartosz Dziewoński ca8781a3a0 Add a link to preferences within the Reply and New Discussion Tools
Bug: T291002
Change-Id: Id99f77d3a181aedd23305b7afa61a0a3fb6dabb7
2021-09-27 21:52:07 +00:00
Bartosz Dziewoński c1f4668806 Change CommentParser and ImmutableRange to use offsets in codepoints instead of bytes
The PHP DOM extension measures lengths and offsets in Unicode codepoints.
Our PHP code used UTF-8 bytes, causing some offsets to be slightly off.
Now it mostly uses Unicode codepoints as well (we're forced to use bytes
in a few places, because preg_match returns offsets in bytes).

In practice, this had no visible effect to the user. It caused the
markers `<span data-mw-comment-end="..."></span>` to be placed at
the end of their container instead of the correct position when the
timestamp contained multibyte characters (e.g. "ź" in Polish); but
the correct position is usually at the end of the container anyway.

In the test cases, the only difference is placing these markers before
a trailing line break inside `<p>...</p>` tags rather than before it.

The patch also accidentally fixes another bug, where element nodes
with no children (mostly <img>) were incorrectly excluded when calling
cloneContents(), because they were treated as if they were text nodes.

Change-Id: Iccdccf1078598f4b62cab96225e9c85a4c0e93ee
2021-09-27 19:04:16 +00:00
jenkins-bot 408bbc62a3 Merge "Change the "Watch this page" label to distinguish it from topic subscriptions" 2021-09-27 17:26:14 +00:00
jenkins-bot 118b958f8b Merge "Use MediaWiki's new section edit summary if the user didn't modify it" 2021-09-27 17:11:32 +00:00
Translation updater bot f6c5a0f804 Localisation updates from https://translatewiki.net.
Change-Id: If332718d4ded6e55b5bbb9a01caedc1d3547727c
2021-09-27 08:34:44 +02:00