Commit graph

1933 commits

Author SHA1 Message Date
Ed Sanders 54471b5037 UsernameCompletion: Disable fragment auto-select
This causes the username to be selected on mobile, when
we want to place the cursor after it.

Bug: T294616
Change-Id: I29012ecd04cd553bf78ffff477babafacfeabb31
2021-11-02 23:35:29 +00:00
Translation updater bot 11d4c397bf Localisation updates from https://translatewiki.net.
Change-Id: I8487db1a4c2d0ccbc8529f69748b40c6fee01461
2021-11-02 08:06:51 +01:00
Ed Sanders 9b902bc46a UsernameCompletion: Fix limit parameter
`this.limit` is never set, which mean the API default of 10
was used.

The client limit is actually `defaultLimit` which is set to 8.
Double this so we can filter blocked users and still probably
have some results.

Change-Id: I8184fa0ce1527280f4503bcf638372421287f51a
2021-11-01 17:25:15 +00:00
Ed Sanders 62bc24cb86 UsernameCompletion: Filter out users with indefinite sitewide blocks from API results
Such users will never be able to reply to you on most pages,
so we shouldn't suggest pinging them. The may be able to reply
on their own user talk page, but in that case they will be
included in localUsers.

In the best case they just clog up your search results, in the
worst case they are offensive names which haven't yet been hidden.

Bug: T294783
Change-Id: I2445ed6dc98c10f8580b2c36106dd3e98bb876d6
2021-11-01 17:25:01 +00:00
Translation updater bot 5006e938fb Localisation updates from https://translatewiki.net.
Change-Id: I72ea77f58b2e3e6ed0b7cb8520ffea2fa89eddca
2021-11-01 09:33:31 +01:00
Amir E. Aharoni cc865692f1 Remove "successfully" from a message
This word is usually unnecessary in messages. See
https://www.mediawiki.org/wiki/Localisation#Avoid_jargon_and_slang

Change-Id: I54a11d4e18365209ff198a45e5e3c1c20e8353c4
2021-10-31 10:16:12 +02:00
jenkins-bot 10111ea872 Merge "Generate form tokens in the client to prevent double posting" 2021-10-29 22:32:47 +00:00
Ed Sanders 19a9070a59 Add dependency on mediawiki.user, required by logger.js
For the method mw.user.generateRandomSessionId

Change-Id: I7b3b6fdf7200ae2f580bb5eeb1bd25ca380a5800
2021-10-29 15:05:19 +01:00
Translation updater bot ff9512178f Localisation updates from https://translatewiki.net.
Change-Id: Ia9ac49eba82e57f4f2a0892034c5c79907b0cc03
2021-10-29 08:21:41 +02:00
Ed Sanders 6022982eb9 Generate form tokens in the client to prevent double posting
Store used tokens in session storage.

Bug: T286409
Change-Id: I88c81689d9cf3447f6cc77c849a84d52c8b2c0db
2021-10-29 00:17:14 +01:00
jenkins-bot 37397e1769 Merge "Logging for new comments" 2021-10-28 21:54:38 +00:00
David Lynch df47f9fda3 Logging for new comments
Bug: T286076
Change-Id: Ic78a49aedcb03d160d74ba3fa9660f3583f0e568
2021-10-28 21:50:23 +00:00
jenkins-bot 5bccc9452c Merge "TopicSubscriptions: Rename 'actions' column and unframe button" 2021-10-28 21:05:43 +00:00
jenkins-bot 93e7f10e68 Merge "TopicSubscriptions: Hide broken "Topic" sort" 2021-10-28 21:05:40 +00:00
jenkins-bot 9a8e33369b Merge "Allow more flexible overrides for the terms-of-use messages" 2021-10-28 15:05:16 +00:00
Translation updater bot e4b305d529 Localisation updates from https://translatewiki.net.
Change-Id: Ia009a206a0deb01dd820c4e48573763f1a457724
2021-10-28 08:27:39 +02:00
jenkins-bot 950d442501 Merge "Add [reply] link brackets during postprocessing after parser cache" 2021-10-27 16:42:23 +00:00
jenkins-bot 9ea6eaf459 Merge "Move body classes code to BeforePageDisplay hook" 2021-10-27 16:42:21 +00:00
Translation updater bot 4a5b1874f7 Localisation updates from https://translatewiki.net.
Change-Id: Iace040cd46e1f089d1a0dc9c874a9563ee99bdbd
2021-10-27 08:22:01 +02:00
Bartosz Dziewoński 98bba62e5d Add [reply] link brackets during postprocessing after parser cache
This should avoid them showing up in unexpected contexts where parser
output is used (e.g. API T292345, search T294168, action=render).

Also rename some variables to be directionality-neutral.

Bug: T292345
Bug: T294168
Change-Id: Ibcac44ee10f0842e205d9dd9a7f3a935ce0c690b
2021-10-26 19:55:09 +00:00
Bartosz Dziewoński 884d1f6ec6 Move body classes code to BeforePageDisplay hook
Seems like a better place and it avoids duplication.

Change-Id: I26643c42cb7aa19cf0dfae449347f2fec2f8bc61
2021-10-26 17:42:39 +02:00
Translation updater bot 7ee34804ac Localisation updates from https://translatewiki.net.
Change-Id: I1c265dce272bac7dd92e625ff763c416a6a25586
2021-10-26 08:17:12 +02:00
Ed Sanders f0149541b0 Update watchlist checkbox when main watchstar is changed
Bug: T294122
Change-Id: If50d5596fd86ed273658a275c9b3be31f39eaad7
2021-10-25 15:27:04 +01:00
Translation updater bot c805edb7f0 Localisation updates from https://translatewiki.net.
Change-Id: If4c239af117de94c36a8fd594b6671f50f77dcb8
2021-10-25 08:51:19 +02:00
libraryupgrader 8bac47f4fb build: Updating mediawiki/mediawiki-codesniffer to 38.0.0
Change-Id: I2a4206a563fe6ab548243b05c000035032b233f5
2021-10-24 02:15:38 +00:00
jenkins-bot 0b3a0c1367 Merge "Rephrase 'apierror-discussiontools-commentname-ambiguous'" 2021-10-23 19:33:29 +00:00
jenkins-bot e5822fa037 Merge "Fix phrasing of 'tag-discussiontools-edit' message (unused)" 2021-10-23 13:17:12 +00:00
Bartosz Dziewoński 6fb376a11a Rephrase 'apierror-discussiontools-commentname-ambiguous'
I think API error messages should be impersonal. Also clarify which
parameter must be provided.

Change-Id: I43ab66fddbd0c7f9948a6e2859d621a45d3f34ba
2021-10-22 17:18:54 +02:00
Bartosz Dziewoński c4e08d7736 Fix phrasing of 'tag-discussiontools-edit' message (unused)
A tag described as "Edit comment" doesn't make sense grammatically.
It should be in past tense, "Edited comment". (Another option could
be a noun, "Comment edit", but that seems less clear.)

Change-Id: I32cf6e533b4b98b5206dd3c74abdf5168f1f2e37
2021-10-22 17:16:07 +02:00
Bartosz Dziewoński 8c626a18ed Replace "Learn more" links with descriptive links in talk page empty states
Also, add a link to 'discussiontools-emptystate-desc-self-anon'.

Bug: T288741
Change-Id: Ibc4b5c46f146502d2eab6dc36eddef7dc22e5b5d
2021-10-21 23:17:59 +00:00
Bartosz Dziewoński 588a8825b2 Add {{GENDER:}} hint to empty state messages for user talk pages
The markup has no effect in English, but it helps reassure translators
that it will work if they need to provide multiple grammatical forms
in their language (or remind them that they do).

It also lets us test this functionality even when testing in English.

Bug: T292636
Change-Id: I093e9a1e0e8e3e9a1808220ab12831fdf8dbc108
2021-10-21 23:17:48 +00:00
jenkins-bot 109f0df289 Merge "ImmutableRange: Port over changes from upstream" 2021-10-21 13:59:17 +00:00
Ed Sanders ff46f37b56 ImmutableRange: Port over changes from upstream
* Explode boundary point tuples passed to computePosition
* Note that we won't use previousSibling instead of array_reverse
* Simplify logic using xor

Change-Id: I927256e31b5e441aade91b4fd0d83d8f0d89afbe
2021-10-21 12:42:27 +01:00
Translation updater bot e19c19fcbe Localisation updates from https://translatewiki.net.
Change-Id: Ic464863942b73b9f0ceb13015249b87263542ad5
2021-10-21 08:21:37 +02:00
Translation updater bot eaa2fb5c5c Localisation updates from https://translatewiki.net.
Change-Id: I7192db6b21ba983357c3738cb271e554fef6cce6
2021-10-20 08:36:44 +02:00
jenkins-bot 4d633e42ca Merge "Remove unused non-parser-cache mode" 2021-10-19 15:57:08 +00:00
jenkins-bot 344fe433ca Merge "Remove parser cache splitting ('dtreply' option)" 2021-10-19 15:57:06 +00:00
jenkins-bot fbcb6d50a5 Merge "Define documentable types in eslintrc instead of inline" 2021-10-18 21:31:02 +00:00
Translation updater bot cdc4954fe2 Localisation updates from https://translatewiki.net.
Change-Id: I8e7b9700691394c145c8feb867925ed1dc9873c2
2021-10-18 15:19:56 +02:00
Ed Sanders f4c12e120a Define documentable types in eslintrc instead of inline
These types can be passed a parameters to any file without
creating a dependency, so it makes more sense to allow
the globally.

Change-Id: I5504465fd997b46547642e7046993b370b85586e
2021-10-17 14:38:39 +01:00
jenkins-bot aa8ed1d469 Merge "Remove redundant checks" 2021-10-14 16:02:32 +00:00
Bartosz Dziewoński d83816f508 Remove redundant checks
The info in wgDiscussionToolsFeaturesEnabled already includes a check
for user options.

Change-Id: I01377e647b1dd5d06b67d1e0c7ee6940f1617066
2021-10-13 21:59:47 +02:00
jenkins-bot 3df2f3c623 Merge "modifier: Handle empty nodes in appendSignature()" 2021-10-13 17:26:56 +00:00
jenkins-bot e5f8b1fe47 Merge "Replace marker comment with limit report data" 2021-10-12 15:20:13 +00:00
jenkins-bot a56d1a0a98 Merge "Re-enable wikitext paste conversion in source mode" 2021-10-12 15:19:45 +00:00
jenkins-bot 906cbe2d75 Merge "Compatibility with Microsoft Edge's translation feature" 2021-10-12 13:52:22 +00:00
Ed Sanders 7f16b7a4c2 TopicSubscriptions: Rename 'actions' column and unframe button
Bug: T273342
Change-Id: Ifd18551e0d89e5c0d4cebd022afebb9a31e2619b
2021-10-12 14:06:57 +01:00
Ed Sanders 7550bb4395 TopicSubscriptions: Hide broken "Topic" sort
This doesn't sort by the topic name, but the hidden
sub_id field, leading to a confusing order.

Bug: T273342
Change-Id: I6146abf05544d40c9ef0d2e8c58d020e5a5fa8a2
2021-10-12 14:04:59 +01:00
Alexander Vorwerk 0935bb1271 MediaWikiTestCase -> MediaWikiIntegrationTestCase
MediaWikiTestCase has been renamed to MediaWikiIntegrationTestCase in 1.34.

Bug: T293043
Change-Id: I485c5c5f0376ab60cdec49e934c6e7eea8c9feb5
2021-10-12 00:40:27 +02:00
Bartosz Dziewoński 8c6928aacf modifier: Handle empty nodes in appendSignature()
Bug: T292664
Change-Id: I0003528076e3981d639d337affcccbf394f59224
2021-10-11 22:17:46 +02:00