Commit graph

2453 commits

Author SHA1 Message Date
Bartosz Dziewoński df22a66e42 topicsubscription: Reduce code duplication
Rather than making our own ThreadItem objects from scratch,
reuse those used by the rest of the code.

Change-Id: I67f5ea3ad26baffe51b66d0c75467ac00185dd0a
2022-06-20 19:02:46 +02:00
Ed Sanders d59d5e14f9 CommentFormatter: Escape user input in generated comment
Currently the only user input in a headingItem name is the username
which can't contain a '>', so the regex can't break, but this is
fragile, and we should always do our own escaping.

Change-Id: I14e5ae2dc1e9ad7639e61b5471aa9ce270137960
2022-06-20 12:09:02 +01:00
Translation updater bot c757398293 Localisation updates from https://translatewiki.net.
Change-Id: Ie3e7699ae7e84abc0b8dddf4c1228f5703164ce4
2022-06-20 08:16:44 +02:00
jenkins-bot 9058467403 Merge "ReplyWidgetVisual: Pass in memory-wrapped store to VE" 2022-06-17 22:26:06 +00:00
jenkins-bot 6c3f056904 Merge "Translate special page alias into Polish" 2022-06-17 13:31:30 +00:00
jenkins-bot 39401c4b6b Merge "ReplyWidgetVisual: Handle VE surface 'cancel' event" 2022-06-17 13:24:13 +00:00
Ed Sanders af5b9a9b46 ReplyWidgetVisual: Pass in memory-wrapped store to VE
We switched to our memory-wrapped store everywhere outside the
VE surface, but not in the VE surface itself.

Change the way we construct MemoryStorage objects so that they can
be constructed from a specific mw.SafeStorage instance.

Ensure MemoryStorage's cache is populated with initial storage object
data, and that the cache is copied over when we create derivative
objectes.

Bug: T310438
Change-Id: I652428f114dc5169195887cb8ca719ae196bb76f
2022-06-17 14:05:54 +01:00
Msz2001 64cd38c053 Translate special page alias into Polish
Change-Id: Ieac259d5cf48f786cd24f54fc40683fa254828b6
2022-06-16 10:07:17 +00:00
Translation updater bot 20c151db49 Localisation updates from https://translatewiki.net.
Change-Id: I4ea5220f0b847cf6982b5c99169569862e701c0c
2022-06-16 09:24:24 +02:00
Ed Sanders 7befd4a8fc Use new function signature for Target#initAutosave
Depends-On: I6ab00c089c9ae1a8bb05ce9405f1f1f2fd0915ca
Change-Id: I23eb131082260540d2cf5e2cad92c9514333862d
2022-06-15 23:49:49 +00:00
jenkins-bot 80173ed010 Merge "Convert more self:: to static::" 2022-06-15 19:42:57 +00:00
Bartosz Dziewoński 9eb200024e ReplyWidgetVisual: Handle VE surface 'cancel' event
Since change I29f6af4cc7c71a63a6d1bafc53d16b9abd1b60ec, VisualEditor
handles the Escape key to emit a 'cancel' event. We need to listen to
this event to allow Escape to close our editor when the surface is
focussed, in addition to the existing handling for the Escape key.

Change-Id: I8c0f2678d104a76d6a223aca9b57123b9f587ac7
2022-06-15 21:09:06 +02:00
jenkins-bot 90e1a3fbb6 Merge "Move placeholder heading level (99) to a constant" 2022-06-15 15:48:36 +00:00
Translation updater bot 7b1a5129cc Localisation updates from https://translatewiki.net.
Change-Id: Ibc66a40e8dbfa4d04c9ed1fca66187a9b9eb4d88
2022-06-15 08:41:20 +02:00
Ed Sanders 1f002f812f Convert more self:: to static::
These are from patches that were already in progress before
we did the first run of conversions.

Change-Id: Id883e693a518130cfcc80bfd0f2874cbd9593446
2022-06-14 22:53:00 +01:00
Ed Sanders 0ad9b4c6b2 Move placeholder heading level (99) to a constant
Change the HeadingItem constructor to take a 'null' headingLevel
and store this internally with the constant. Change the JSON
serializer to convert this back to null.

Change-Id: I27508eed75d94b99c5189548919309f8da7deb75
2022-06-14 22:51:49 +01:00
Translation updater bot 5da21d1b82 Localisation updates from https://translatewiki.net.
Change-Id: I6017df2176682f4693c4dca3e8845d6afd18465e
2022-06-14 08:48:02 +02:00
Translation updater bot 3800ab27e3 Localisation updates from https://translatewiki.net.
Change-Id: Ie474e844dacf4a7909cb43b29fcbb294675ac7db
2022-06-13 08:27:56 +02:00
jenkins-bot 901d822765 Merge "Clarify subject placeholder wording" 2022-06-11 22:44:31 +00:00
Ed Sanders c2535e26dc MemoryStorage: Setup this.data before calling parent constructor
The parent constructor may trigger read/writes in the future
so this.data should always exist as early as possible.

Change-Id: I79a795a26c4ce1381d2a0b15329f7df1d6ab77ca
2022-06-10 15:10:01 +01:00
Translation updater bot e8b16f67b1 Localisation updates from https://translatewiki.net.
Change-Id: I1ef4c49042b48914a2abfe01c33dcc2969fded47
2022-06-10 08:49:31 +02:00
jenkins-bot cb17181fa4 Merge "Prefer late static binding over self::" 2022-06-09 16:29:48 +00:00
Ed Sanders af54bae2ec Prefer late static binding over self::
While in many cases the class will never be sub-classed, it's easier
just to always use static:: and not worry about predicting which
classes might have problems in the future.

Change-Id: I23072a1701b5acf62bb3379a877de97627d8fcf3
2022-06-09 15:12:48 +01:00
Translation updater bot bd07028c47 Localisation updates from https://translatewiki.net.
Change-Id: I7073ccaa7227e285bf33f05e06c2ab066933418f
2022-06-09 08:16:30 +02:00
jenkins-bot 636ff45a75 Merge "TagHooks: Make static method for obtaining DiscussionTools tags" 2022-06-08 11:18:42 +00:00
Translation updater bot 277c5200e9 Localisation updates from https://translatewiki.net.
Change-Id: I737cdc50a7050395e1929e5de0ae9842785474e1
2022-06-08 08:26:56 +02:00
Ed Sanders c96c076a4e Follow-up I46a58f6a: Add missing test runner
Change-Id: I17438cf55959d146265f3aafa5940f7fe0de19e1
2022-06-07 16:09:04 +01:00
jenkins-bot 9dedb23512 Merge "Show createpage preference only when feature is available" 2022-06-07 12:52:09 +00:00
Bartosz Dziewoński bc77963180 Revert "Localisation updates from https://translatewiki.net."
This reverts commit 790ef19cd3.

Reason for revert: Removed some qqq messages, breaks CI testing.

Change-Id: I43d75beb775abebb263f957cd1c28dc9d84f7ec4
2022-06-07 12:39:38 +00:00
na1307 edb276e047
Show createpage preference only when feature is available
Bug: T310053
Change-Id: I13262ecbe2d2c45c0ffb8706da17bc806ab2a5b7
2022-06-07 18:59:15 +09:00
Translation updater bot 790ef19cd3 Localisation updates from https://translatewiki.net.
Change-Id: Ib6f5b118c7fc6772197df8ae303304e49092d13b
2022-06-07 10:00:44 +02:00
jenkins-bot b6abc80c35 Merge "Add preference for offering new topic tool when creating new talk pages" 2022-06-06 23:01:40 +00:00
Ed Sanders ab05e4e24f Add test coverage for ApiDiscussionToolsPageInfo::getThreadItemsHtml
Change-Id: I46a58f6a2ec5f0e1b750c67e85d27081f5fab544
2022-06-06 18:40:30 +01:00
David Lynch b4f829e5ca PageInfo threaditemshtml: include content before the first heading
Fake a placeholder heading for this, unless the first heading is already
a placeholder.

Bug: T304856
Change-Id: Icc12712f77e0c14139b289bec8cc3e0cb4834a43
2022-06-06 18:39:22 +01:00
David Lynch f668ee4989 PageInfo threaditemshtml: For empty headings, include their non-reply content
Bug: T304856
Change-Id: Ifbb7a843ce8a7d52a1b51d9fe16869e2f3ccbf1b
2022-06-06 18:37:59 +01:00
Bartosz Dziewoński e0f231b892 Add preference for offering new topic tool when creating new talk pages
Depends-On: I46a8eaf331e86de0c8c94f0f60bdc4b5be6dd83a
Bug: T297990
Change-Id: Iaf6677affe5d0b7f6047bce55c0a575286c8e676
2022-06-06 17:09:50 +00:00
Translation updater bot e192dc59d1 Localisation updates from https://translatewiki.net.
Change-Id: Ie982060c0d234a7472bca9c5f67412343a632809
2022-06-06 09:25:37 +02:00
Ed Sanders 32e306f6e1 Hide icon in anon warning below tablet width
Bug: T307709
Change-Id: I800153cabc1ba14fd249c106d57162fd0cd9dbe1
2022-06-03 16:33:26 +01:00
Kosta Harlan bf161db768
TagHooks: Make static method for obtaining DiscussionTools tags
Bug: T309839
Change-Id: I30697ca56d4aa346151c4d31850f545d32399305
2022-06-03 12:46:16 +02:00
Translation updater bot 77ce5171fb Localisation updates from https://translatewiki.net.
Change-Id: Ia5eff7dfe6e3ead92dcd06a75d838a42c19db04d
2022-06-03 08:57:30 +02:00
EpicPupper 1f9abe6278 Clarify subject placeholder wording
Bug: T297974
Change-Id: I64e19358aec7c422b9b947b6d1d9f5b4fc8412ad
2022-06-03 00:12:48 +00:00
jenkins-bot f460ce39bc Merge "Add attributes for Minerva click tracking" 2022-06-02 15:29:50 +00:00
jenkins-bot 5e6583428f Merge "Disable (instead of hiding) preferences that would have no effect" 2022-06-02 09:29:14 +00:00
Translation updater bot 71ae39010f Localisation updates from https://translatewiki.net.
Change-Id: I0c2aeb56e6cc5d3ef86fe063ed3ede225dee6a8e
2022-06-02 08:14:08 +02:00
Bartosz Dziewoński 02ced052db Disable (instead of hiding) preferences that would have no effect
Keeping them visible avoid the page shifting unpleasantly,
and makes it easier to find the option you're looking for.

Change-Id: I1e37d5d11c5a19beb799346f4e9842e836224d3a
2022-06-01 21:36:30 +02:00
Translation updater bot 57b6f2c29f Localisation updates from https://translatewiki.net.
Change-Id: I2c91e039f32e1a735a90d948624c8dda0970b536
2022-06-01 08:20:33 +02:00
Ed Sanders c8570b95f9 Fix CSS selector after upstream changes to CompletionWidget
Bug: T307712
Depends-On: Ie590eb6b6c38531b959eadc1fcd5ba108180fdc8
Change-Id: Id39e680cbea54d77f061936c8876ecf7ed28e8b2
2022-05-31 20:39:39 +00:00
jenkins-bot 2dde6572f5 Merge "ThreadItem.js: Only search CommentItem's for authors" 2022-05-31 20:22:56 +00:00
Ed Sanders 0f0e8fca9a ThreadItem.js: Only search CommentItem's for authors
If the thread contains a sub-heading, this would add
'undefined' to the list of local authors.

Change-Id: I696c56d07f30c6de2550e5f89b8cefcb3c17a259
2022-05-31 20:16:42 +00:00
Translation updater bot ef1d40f9fa Localisation updates from https://translatewiki.net.
Change-Id: I730d5caa4333ebc0a5fffb6dbab7687cf702b7da
2022-05-31 08:08:07 +02:00