wikimedia/mediawiki-extensions-DiscussionTools
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools synced 2024-11-28 02:00:57 +00:00
Code Issues Packages Projects Releases Wiki Activity
2825 commits 11 branches 4 tags 127 MiB
Commit graph

2825 commits

This branch
This branch
All branches
Author SHA1 Message Date
Bartosz Dziewoński 3a0b05f564 Allow replying to some comments with accidental complex transclusions 
When a comment almost exactly matches the range of an
accidental complex transclusion consisting only of
pages from the 'Template' namespace and wikitext fragments,
I think we can safely allow replying to the comment.

Even if this turns out to be incorrect in some cases,
the failure will be more graceful after the changes in T313100:
instead of potentially duplicating contents from a template,
the worst case now is that the reply will appear in the wrong
place (at the end of the transclusion).

Bug: T313093
Change-Id: Ie8da09d74a652d893fd8c3e2435ef6cb70fad64a
 2022-11-14 19:17:36 +01:00
Bartosz Dziewoński 82069f7db5 Add test cases for T313093 
Change-Id: I045be8da8fc144846312ce84b9e79d65c3d5b2b4
 2022-11-14 19:17:34 +01:00
Bartosz Dziewoński 469b7720af Place replies outside transclusions, disallow replying to transcluded comments 
Bug: T313100
Change-Id: I3993c96ec8d3d0add33d779860d158327985107d
 2022-11-14 19:17:18 +01:00
Bartosz Dziewoński 065c7d8f2d Add test case for T313100 
(Also README corrections)

Change-Id: I037155ba1b775511273a78a85b34c29f3319a9a6
 2022-11-14 19:16:43 +01:00
jenkins-bot 5092498bb5 Merge "Tweak mobile styles for no-JS compatibility" 2022-11-14 15:29:42 +00:00
jenkins-bot 0ade11d299 Merge "Remove some unused CSS" 2022-11-14 15:29:27 +00:00
jenkins-bot 0655cdbf56 Merge "Move visualenhancements metadata and some buttons outside of <h2>" 2022-11-14 15:29:12 +00:00
Bartosz Dziewoński 310323b561 Tweak mobile styles for no-JS compatibility 
Bug: T321430
Change-Id: I0f20750995d89c0bb4be9a70e594326f15a6de0b
 2022-11-14 15:01:35 +01:00
Bartosz Dziewoński f27d173852 Remove some unused CSS 
No longer needed since the "Subscribe" button was moved elsewhere
(2960853088).

Change-Id: I758469c6883fe6056dc3859b5b5d43d98771b518
 2022-11-14 14:57:13 +01:00
Translation updater bot 053c21b08a Localisation updates from https://translatewiki.net. 
Change-Id: Ief79949c2310656ba427c487477ed77efb3a73aa
 2022-11-14 08:10:18 +01:00
jenkins-bot bbdc49f87a Merge "persistRevisionThreadItems: Print time taken" 2022-11-11 18:45:25 +00:00
Translation updater bot f6bdb9df81 Localisation updates from https://translatewiki.net. 
Change-Id: I03f701c46fbb0e4a4aba05a2483b0b9335c234d9
 2022-11-11 08:40:46 +01:00
Bartosz Dziewoński 08e1073f58 ThreadItemStore: Handle race conditions when finding/inserting outside of transaction 
Bug: T322701
Change-Id: Icea63dd562c1812a372f3a947ba1244e72d07a16
 2022-11-10 23:33:24 +00:00
Bartosz Dziewoński 04cfffe323 Move visualenhancements metadata and some buttons outside of <h2> 
We wrap a `<div>` tag around the `<h2>`, and move some elements there.
The markup is inspired by and compatible with my proposal for T13555.

The "ext-discussiontools-init-section" class is moved to the `<div>`.

A small patch is needed in MobileFrontend to preserve the section
collapsing functionality: I11bff21e81046898ca63f3f432797129fa70ad88.

The following elements are now outside of `<h2>`:
* Metadata bar
* Subscribe button
* Ellipsis menu (only shown on mobile)

The following elements are sadly still inside of `<h2>`:
* Subscribe links (only shown on desktop)
* Section edit links from MediaWiki core
Trying to move them mucks up the CSS too much. I hope we can resolve
this later as a part of the work on T13555.

Depends-On: I11bff21e81046898ca63f3f432797129fa70ad88
Bug: T314714
Change-Id: I0bbdcfa02c334858737855349d7a35746de1d8f2
 2022-11-10 23:35:40 +01:00
Ed Sanders e0855e4f41 Make virtual keyboard detection into a body class 
This allows it to be re-used for other features, such as the
upcoming floating "Add topic" button.

Add some support for Android, although not used in this patch.

Change-Id: Ibd1e1ee087ac607c88a7402d0422c633700d1992
 2022-11-10 23:30:53 +01:00
Ed Sanders 8cd239b0b4 Move ...-replylink-open class to <body> 
This allows elements outside the page container to respond to it.

Change-Id: Id880ada0e24cb803e7b992284a1a95950f3da36f
 2022-11-10 23:30:10 +01:00
Ed Sanders 79521f89cf Add button to reveal lede section on mobile 
Bug: T312309
Depends-On: I9c3035c9dbe7545a05efb2286dffe0145d3557b4
Change-Id: I9d74914ddbcc9def74e85106a68574a807b0b731
 2022-11-10 22:10:04 +00:00
Bartosz Dziewoński d8325ac9b8 CommentFormatterTest: Fix PHP 8.1 deprecation warning 
Change-Id: I1913eff29e884be4eb6177b9aa8e29fe297560c7
 2022-11-10 23:03:06 +01:00
Translation updater bot 92432eaa06 Localisation updates from https://translatewiki.net. 
Change-Id: I978818a4665506b3dbf311d1b2bb0b83403e434d
 2022-11-10 08:12:01 +01:00
jenkins-bot f0c1f483cb Merge "CommentFormatterTest: Make desktop and mobile separate test cases" 2022-11-09 08:06:13 +00:00
Translation updater bot dd249c4b96 Localisation updates from https://translatewiki.net. 
Change-Id: I39d9496c15753078550303c347393d5ec4ef9fb5
 2022-11-09 08:57:39 +01:00
Bartosz Dziewoński 9cde62957f CommentFormatterTest: Make desktop and mobile separate test cases 
This is a better way than a loop in the test code.

When using DISCUSSIONTOOLS_OVERWRITE_TESTS, if both desktop and mobile
cases fail, both will be updated now. Previously the first failed
assertion would stop the test after only updating one file.

Change-Id: I4ce6f45b047e02c9f00024a9e5057adcb0e28047
 2022-11-09 02:44:30 +01:00
Bartosz Dziewoński 7b5a8cea11 persistRevisionThreadItems: Print time taken 
Change-Id: Ide002b26740815ef0db3351a0e7e8c498010d164
 2022-11-09 00:18:42 +01:00
jenkins-bot af6f6e6149 Merge "Disable "Share feedback..." links by default" 2022-11-08 22:04:08 +00:00
Ed Sanders b4eb7fc9ad Disable "Share feedback..." links by default 
Will still be enabled on WMF wikis for now.

Bug: T322494
Change-Id: Ic0b79fdf459d4949d7604f5a213cb1851ca30901
 2022-11-08 21:58:39 +00:00
jenkins-bot d1911e4f11 Merge "ThreadItemStore: Fix setting parent IDs when parent already existed" 2022-11-08 19:01:42 +00:00
jenkins-bot c83bad9de8 Merge "Embed pageThread JSON in jsConfigVars instead of infusing HTML" 2022-11-08 18:59:48 +00:00
jenkins-bot c0e757c716 Merge "ABtest for mobile, logged out users" 2022-11-08 18:41:38 +00:00
jenkins-bot 811c32c518 Merge "ABtest for mobile, logged in users" 2022-11-08 18:41:23 +00:00
jenkins-bot fd167a4a8f Merge "LanguageDataTest: Set 'UsePigLatinVariant' => false" 2022-11-08 18:27:22 +00:00
Bartosz Dziewoński dac09416fd LanguageDataTest: Set 'UsePigLatinVariant' => false 
MediaWiki default changed in Ia80ad33cbf5e311fa8b84bd765a8df8d156f4c38.

Change-Id: Ib1eb4b218c89d2a6ce8b82aeec2ee19aca8ff4a9
 2022-11-08 18:13:36 +00:00
Ed Sanders a00131a18f Embed pageThread JSON in jsConfigVars instead of infusing HTML 
Bug: T322651
Depends-On: I86d461756398780dc24949013f35b7730a481052
Change-Id: I85ee8e6ed6eba97b94f4e4c415fbc5286c234cce
 2022-11-08 16:20:39 +00:00
Translation updater bot cb5190763e Localisation updates from https://translatewiki.net. 
Change-Id: I8a4860562561706da2b2f13548c3ea43e6576e6c
 2022-11-08 08:20:53 +01:00
jenkins-bot 0251155359 Merge "Topic subscription feature is unavailable if Echo is not installed" 2022-11-08 03:11:14 +00:00
Bartosz Dziewoński 759e6b757a ThreadItemStore: Fix setting parent IDs when parent already existed 
Bug: T322599
Change-Id: I697de586fb3c1b1901f434f6fbef501cec3164df
 2022-11-08 01:38:41 +01:00
Ed Sanders 317b8244dd Move username completion tool after special character tool in toolbar 
Bug: T322455
Change-Id: I19bfe4500850512411615b326b07ba0a47dcfd5f
 2022-11-07 13:01:11 +00:00
Ed Sanders d6160c76fa Topic subscription feature is unavailable if Echo is not installed 
Bug: T322498
Change-Id: I072e9363fceb4beae820b7742dec4249b4f58905
 2022-11-07 12:28:45 +00:00
Translation updater bot 45790f67e9 Localisation updates from https://translatewiki.net. 
Change-Id: Ia946f410c0f13711fde16a77503aaa24f24a9805
 2022-11-07 08:33:57 +01:00
Reedy 253531fff4 .phan/config.php: Fix string interpolation 
Bug: T314096
Change-Id: Ia65d6a598bdeb5abfbab6fc8c7a8f7ed0a600061
 2022-11-05 10:45:01 -06:00
Translation updater bot dd8c1d1d13 Localisation updates from https://translatewiki.net. 
Change-Id: I1bb17c2d13e6f057c8e07b8464199779424cd2f8
 2022-11-04 09:02:26 +01:00
jenkins-bot 98285f3b27 Merge "ThreadItemStore: Update existing rows if possible rather than insert+delete" 2022-11-03 14:12:49 +00:00
Translation updater bot 9227fedbf6 Localisation updates from https://translatewiki.net. 
Change-Id: Ic2dde7dcb15cbc1d1e0fb4b195a8c5f8b79b9189
 2022-11-03 08:24:32 +01:00
Bartosz Dziewoński c4c455c550 ThreadItemStore: Update existing rows if possible rather than insert+delete 
Bug: T321121
Change-Id: I678b093aef95febb33cf4b0140b0625ef3241779
 2022-11-03 00:53:19 +01:00
jenkins-bot 140939b3dd Merge "Avoid unsafe wrapping of Message::parse() into paragraph" 2022-11-02 18:37:29 +00:00
jenkins-bot de789ecf84 Merge "Tweak mobile "Read as wiki page" button placement" 2022-11-02 09:17:57 +00:00
jenkins-bot 0d24c4881a Merge "Revert "Add config to separate out visualenhancements on mobile"" 2022-11-02 09:17:53 +00:00
Translation updater bot 35955e8d79 Localisation updates from https://translatewiki.net. 
Change-Id: I93183531c7d248fdcb4bf551811c5dbbeb9a9f50
 2022-11-02 08:38:01 +01:00
Timo Tijhof 18e523281c Avoid unsafe wrapping of Message::parse() into paragraph 
Bug: T322173
Change-Id: I8405a33129ab17edcb7a02440146684170f1c0a7
 2022-11-02 00:19:46 +00:00
Bartosz Dziewoński c53b44d1bc Revert "Add config to separate out visualenhancements on mobile" 
No longer needed.

This reverts commit d5161bf086.

Bug: T318868
Change-Id: I909266903271cecba050d171a3ec66ef0a12b8a9
 2022-11-01 21:09:37 +00:00
jenkins-bot 422e9aabf2 Merge "Use PHP 7.4 property types" 2022-11-01 10:32:37 +00:00