wikimedia/mediawiki-extensions-DiscussionTools
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools synced 2024-11-28 10:11:45 +00:00
Code Issues Packages Projects Releases Wiki Activity
2748 commits 11 branches 4 tags 128 MiB
Commit graph

2748 commits

This branch
This branch
All branches
Author SHA1 Message Date
jenkins-bot 2e28320eb2 Merge "ThreadItemStore: Fix updates for identical revision timestamps" 2022-10-24 23:57:07 +00:00
jenkins-bot 095277b40c Merge "ThreadItemStoreTest: Add test for identical revision timestamps" 2022-10-24 23:57:05 +00:00
jenkins-bot 11d10e9e64 Merge "ThreadItemStoreTest: Use a consistent ordering for the output" 2022-10-24 16:23:30 +00:00
jenkins-bot f85f7fde10 Merge "ThreadItemStore: Remove long comment no one is ever going to read" 2022-10-24 16:22:24 +00:00
jenkins-bot 0db489b3e7 Merge "EventDispatcher: Remove reference to $wgWMESchemaEditAttemptStepOversample" 2022-10-24 12:48:27 +00:00
jenkins-bot c728f35e3a Merge "logger: Also log VisualEditorFeatureUsage events via Metrics Platform" 2022-10-24 12:48:25 +00:00
Translation updater bot 391635e50a Localisation updates from https://translatewiki.net. 
Change-Id: Ie2230fff48657f24fc64d8c91c3eed534679d6c5
 2022-10-24 08:22:36 +02:00
jenkins-bot 341b180a66 Merge "Don't insert reply tool outside <section> on mobile" 2022-10-22 02:39:44 +00:00
jenkins-bot a0daa9b788 Merge "Add test case for <section> wrappers on mobile" 2022-10-22 02:39:40 +00:00
jenkins-bot ea1a30c703 Merge "Retry without RESTBase when the page/revision seems to be missing" 2022-10-21 20:47:05 +00:00
Bartosz Dziewoński d2df103803 Don't insert reply tool outside <section> on mobile 
Bug: T319148
Change-Id: I7db0ef1980f4997b77593f3d43d35886ecd8a4ae
 2022-10-21 01:20:13 +02:00
Bartosz Dziewoński 0116bed3ad Add test case for <section> wrappers on mobile 
Bug: T319148
Change-Id: Ic8e29a8a5626b2dee1c258fec18a9b016ecae06b
 2022-10-21 01:20:13 +02:00
Bartosz Dziewoński 8c9a7c451e Retry without RESTBase when the page/revision seems to be missing 
Bug: T315688
Change-Id: I2ec0fa20cc1ee36fc521441ac00c5515dc66a37c
 2022-10-20 23:06:16 +00:00
jenkins-bot d5bbe213cb Merge "Remove oldid from URL when refreshing page" 2022-10-20 22:44:58 +00:00
Ed Sanders 7364214ea6 Remove oldid from URL when refreshing page 
Code mostly copied from VE, but ported to native URL object.

Change-Id: I3e780f33df548c59741b7ae3b5dfb33f657d24a3
 2022-10-20 22:02:10 +00:00
jenkins-bot 38bc9bba60 Merge "Separate out mobile init from controller.js" 2022-10-20 21:57:35 +00:00
jenkins-bot c049f07055 Merge "ReplyLinksController: Skip empty reply buttons container" 2022-10-20 14:35:34 +00:00
Translation updater bot a04c6001a7 Localisation updates from https://translatewiki.net. 
Change-Id: I37824c52ed0372f9589319ef147cbf74aada6677
 2022-10-20 08:31:18 +02:00
Bartosz Dziewoński 33f4006713 ThreadItemStore: Fix updates for identical revision timestamps 
Use revision IDs to break the tie, consistently with MediaWiki (see
RevisionStore::getRelativeRevision) instead of assuming that the
revision we're processing now is somehow both older *and* newer than
the other one (the mind boggles how that ever made sense to me).

Change-Id: I9f1a07124301a36be68578d908353b72f0442c00
 2022-10-20 02:37:47 +02:00
Bartosz Dziewoński c922e1babd ThreadItemStoreTest: Add test for identical revision timestamps 
discussiontools_item_pages row itp_id=5 has incorrect
itp_oldest_revision_id. It should point to the older of the two
revisions with the same time, but it points to the newer one.
discussiontools_item_revisions row is missing.

Depends-On: I56f0e161e5438d5f77b7d53d4db7411f90f97d05
Change-Id: I61ed42515891a84729455a7a32c98276c7cacd40
 2022-10-20 02:36:40 +02:00
Bartosz Dziewoński ed23ff1ad7 ThreadItemStoreTest: Use a consistent ordering for the output 
In preparation for changes affecting how the data is stored (T321121).

Change-Id: I1d6edeb016431dd33e50cfbea1533a92b056a2a7
 2022-10-20 01:49:19 +02:00
Bartosz Dziewoński 91aeaabe83 ThreadItemStore: Remove long comment no one is ever going to read 
I should have just put that in a commit message rather than source code.

Change-Id: Ia5c06c91c21b0b5da1ed578369825a3870c48833
 2022-10-20 01:49:19 +02:00
jenkins-bot 4935197c66 Merge "logger: Use wgWMESchemaVisualEditorFeatureUseSamplingRate config variable" 2022-10-19 19:09:24 +00:00
Func 3cbab3b789 ReplyLinksController: Skip empty reply buttons container 
For preview parsing, the span containers are empty.

Not sure why not strip the container along with all generated
contents, but this should be the easiest fix.

Bug: T321185
Change-Id: I9afb2d0f543b79dbac8a652236fe55284de542a8
 2022-10-19 23:14:27 +08:00
Translation updater bot a86c0f71db Localisation updates from https://translatewiki.net. 
Change-Id: If855f1474efb38d012d534ab211a30f9bd275690
 2022-10-19 08:19:44 +02:00
jenkins-bot f953953c9b Merge "Fire wikipage.content hook on edit notices" 2022-10-18 16:19:57 +00:00
jenkins-bot 3c53a489cf Merge "CommentFormatter: Always add the overflow menu" 2022-10-18 16:16:42 +00:00
jenkins-bot 66780457e4 Merge "Add 'wpTextbox1' to parameters that disable new topic tool" 2022-10-18 15:47:21 +00:00
jenkins-bot b2d0b45c76 Merge "Fix parsing of non-English titles in JS tests" 2022-10-18 08:22:33 +00:00
Translation updater bot cbbdcd1e80 Localisation updates from https://translatewiki.net. 
Change-Id: Ib6cc5c6b6eaa47d99780852a4bcbd5be2a378342
 2022-10-18 08:22:22 +02:00
Bartosz Dziewoński 1d6ba985be Fix parsing of non-English titles in JS tests 
Same issue as b68832ace0 in PHP.

Change-Id: Ide6ebc47929b597e6dc23df696d87bb3130ce276
 2022-10-17 17:10:53 +02:00
Ed Sanders 481b687c35 Follow-up I394f02912: Use existing class API to move button away from sticky header 
Bug: T318474
Change-Id: Iab3a817e305d48e922499aad3620d93cf8aa165e
 2022-10-17 14:49:36 +01:00
jenkins-bot 2b427fdef3 Merge "Re-enable fixed JS parser tests" 2022-10-17 07:48:33 +00:00
Translation updater bot 5c01293740 Localisation updates from https://translatewiki.net. 
Change-Id: Iba9bb117a383e8c5cfb3a2f74563216d2802b66e
 2022-10-17 08:21:04 +02:00
Bartosz Dziewoński 4b38d72c2e Re-enable fixed JS parser tests 
The changes from I39f9b994ce5636d70fea2e935a7c87c7d56dcb26 also make
most of the broken tests pass again.

Change-Id: I165f36235b47dee4bcef115e518bc1e81d2f83a5
 2022-10-15 20:24:09 +00:00
jenkins-bot a9191c49b8 Merge "Ship HTML test files for JS using 'packageFiles' instead of 'templates'" 2022-10-14 16:53:38 +00:00
jenkins-bot bf1b17d34a Merge "Autogenerate list of files for JS test module instead of maintaining it by hand" 2022-10-14 16:53:36 +00:00
Ed Sanders d0cd0e57a1 Separate out mobile init from controller.js 
Change-Id: I2dfafc1d816c5cae97fd51bc11de9aefbdd73ee8
 2022-10-14 17:38:19 +01:00
jenkins-bot c5b0e2717a Merge "Rewrite persistRevisionThreadItems" 2022-10-14 16:36:47 +00:00
jenkins-bot f09d91a29c Merge "ThreadItemStore: Move some work in insertThreadItems() outside transactions" 2022-10-14 16:36:45 +00:00
jenkins-bot d7cf6adb0a Merge "Log page/revision IDs when the page/revision seems to be missing" 2022-10-14 16:34:45 +00:00
jenkins-bot 19e64cd8ee Merge "Use ParsoidOutputAccess when RESTBase is not set up (WMF private wikis)" 2022-10-14 16:34:15 +00:00
Translation updater bot 0c03b7ef52 Localisation updates from https://translatewiki.net. 
Change-Id: Ieefd70d7274587c8c1a8a6c8e30867468f7d4b9d
 2022-10-14 08:41:43 +02:00
Msz2001 cf58427165 Translate: Special page names into Polish 
Change-Id: I5c50ad6f611e013c0a9f5a0f4531a6065a5f12b6
 2022-10-13 12:13:47 +00:00
Translation updater bot c765c4124d Localisation updates from https://translatewiki.net. 
Change-Id: I8cb221848836ee33ae4561de5ca3973e764557b8
 2022-10-13 08:08:33 +02:00
jenkins-bot a8bf67c4e9 Merge "Fix '?dtenable=1' on mobile" 2022-10-13 00:00:01 +00:00
Ed Sanders cdad0cc260 Fix '?dtenable=1' on mobile 
isFeatureEnabledForOutput already checks if the mobile flag is enabled,
but it also respects the dtenable=1 override.

Change-Id: I95035281bf301b22c1a9ef4c06ec54cdd0cbc85c
 2022-10-12 23:53:12 +00:00
Bartosz Dziewoński 361283a332 Ship HTML test files for JS using 'packageFiles' instead of 'templates' 
We originally used 'templates' because it seemed like an obvious
choice for HTML files, and because 'packageFiles' requires extra code
to include anything that isn't a .js or .json file.

However, the templates are expected to be HTML fragments rather than
whole documents, and they are parsed in a particular way that takes a
lot of code to clean up (which we needed to do, because we use the
same test files for testing PHP code).

I tried doing it in the 'packageFiles' way, and the extra code doesn't
seem that bad in comparison after all. Moreover, the 'templates'
mechanism (when used the intended way) feels vaguely deprecated in
favor of Vue.js, and I'd rather move away from it.

This makes the tests faster too (probably mostly thanks to the removal
of the clean up code) – on my machine they go from 1800ms to 1500ms.

(Simplify linearWalk tests, as we no longer need to do weird things
with document fragments to get consistent outputs in PHP and JS.)

Change-Id: I39f9b994ce5636d70fea2e935a7c87c7d56dcb26
 2022-10-12 22:45:41 +00:00
Bartosz Dziewoński f9903401a6 Autogenerate list of files for JS test module instead of maintaining it by hand 
Depends-On: I223f63aab132444833aad7d7c162b27c9e93991c
Change-Id: Ib869b66d9f9155163ad9e0475e5e8a69dac9f55a
 2022-10-12 22:41:41 +00:00
jenkins-bot 4b3794f610 Merge "testUtils.js: Fix selector for old parser tests" 2022-10-12 17:24:04 +00:00