wikimedia/mediawiki-extensions-DiscussionTools
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools synced 2024-11-24 16:34:21 +00:00
Code Issues Packages Projects Releases Wiki Activity
2776 commits 147 branches 0 tags 125 MiB
Commit graph

2776 commits

This branch
This branch
All branches
Author SHA1 Message Date
jenkins-bot 169b4c74ad Merge "ThreadItemSet.newFromAnnotatedNodes needs to wait to compute names" 2022-09-20 16:46:51 +00:00
na1307 1c1d7b3c5d
Add Korean special page aliases 
Change-Id: I87c827d6f113b7d8d46eb60a6cd65ad6c679587c
 2022-09-20 17:01:54 +09:00
Translation updater bot 855eef1c2a Localisation updates from https://translatewiki.net. 
Change-Id: I23ddaa79e5f7982a6008bea4d234730841a7504f
 2022-09-20 08:33:56 +02:00
David Lynch 9ee2301f1e ThreadItemSet.newFromAnnotatedNodes needs to wait to compute names 
Computing the name, for headings, requires determining the oldest
comment. This must not be done before all the replies are added to the
thread.

Follow-up to e24550fae9. It was
already *technically* incorrect before then because it was generating
the name based on the first comment in the thread, but that was only
not the oldest in very unusual cases so it was fine. That commit caused
the thread summary to be cached when first requested, however, which
made future requests for oldest/newest comment and authors to be
incorrect.

Bug: T318057
Change-Id: If0bd6caf88e72cd3f91e7f0633c40b445f5e2246
 2022-09-19 14:13:51 -05:00
jenkins-bot 82f107af7e Merge "Add @covers CommentUtils to tests that use it" 2022-09-19 16:57:18 +00:00
jenkins-bot b594a99a12 Merge "Use margin to position comment marker to avoid Chrome bug" 2022-09-19 16:57:16 +00:00
jenkins-bot 77514eb01f Merge "Replace VisualEditor ParsoidHelper with ParsoidClient" 2022-09-19 16:33:13 +00:00
Bartosz Dziewoński 2679fa3b04 Replace VisualEditor ParsoidHelper with ParsoidClient 
Depends-On: I21c4a8cd86f8d085e75a601ed6d2509dedd75d42
Change-Id: I9533d7c05047c2d873c8c6ee5944df965e3b379d
 2022-09-19 18:00:14 +02:00
Translation updater bot 3695b13fd7 Localisation updates from https://translatewiki.net. 
Change-Id: I37764caac2b80d143fbb93a79c6f96d8603758f1
 2022-09-19 08:24:20 +02:00
Ed Sanders 0265d401c2 Add @covers CommentUtils to tests that use it 
Change-Id: I35d2d0d75bfdbe17fe186eb5cfb47a850a9d6f6a
 2022-09-16 13:22:43 +02:00
Ed Sanders fcdabc5fcc Only filter code coverage at the class level 
Many methods are covered indirectly, and using method-level
@covers filters means these are reported as not being covered.

Change-Id: I94eb3e8c48209ff0b6bfc09e18c93555bb167e8f
 2022-09-15 14:08:30 +02:00
Translation updater bot 80590f1457 Localisation updates from https://translatewiki.net. 
Change-Id: I9e536b12107bbae4940c0b6bcf4498db047fbfe2
 2022-09-15 09:54:53 +02:00
Translation updater bot 35fa4a5dd9 Localisation updates from https://translatewiki.net. 
Change-Id: I664e5e348cc171c62d3ddcb92abd8cd264fe1e2f
 2022-09-14 10:31:29 +02:00
Ed Sanders 39502b4f9a Use margin to position comment marker to avoid Chrome bug 
Bug: T317135
Change-Id: I627d92fabaa9d9e477279041d3c40a7c6bfe37c8
 2022-09-14 10:01:53 +02:00
Ed Sanders 516ea4a970 Tweak topic container margins on desktop 
Bug: T314449
Change-Id: I021dbd33f211fcdc5ef2fea1d99212df772053b4
 2022-09-14 09:59:39 +02:00
David Lynch 968250bb02 Add mw.track call when comment setup fails 
Bug: T310390
Change-Id: I6df98032469931276ea096a008fdf8f63893dff5
 2022-09-14 01:23:07 -05:00
Func 8820940dfd PreferenceHooks: Avoid referring to the field of disabled feature 
The GlobalPreferences extension would remove disabled fields from
the form, avoid referring to it in the disable-if param.

Bug: T317526
Change-Id: I6ec177a1f20855c90eb4ea17bb6625c75e5b9617
 2022-09-13 09:32:09 +00:00
Translation updater bot 93713ffab4 Localisation updates from https://translatewiki.net. 
Change-Id: Ica2690ef08200f5df41df3d900d33029688f4d3a
 2022-09-13 09:25:54 +02:00
Translation updater bot 840a796c26 Localisation updates from https://translatewiki.net. 
Change-Id: I4328c68d619d6ad0bd1f6b36e4c4bcb8e4d0a81d
 2022-09-12 08:11:25 +00:00
jenkins-bot f152ca001d Merge "Reduce size of topic headings to 18px on mobile" 2022-09-10 11:53:39 +00:00
jenkins-bot 639ad57914 Merge "Suppress top border of first section on mobile" 2022-09-10 11:53:37 +00:00
Ed Sanders 9af812720c Reduce size of topic headings to 18px on mobile 
Also reduce spacing around headings and meta bar.

Bug: T311612
Change-Id: I40e01caea22c6b89122a29f87282e4147961f6a7
 2022-09-10 12:46:34 +01:00
Ed Sanders 7a579fd67b Suppress top border of first section on mobile 
The :first-child that would usually do this doesn't work
due to the hidden .mf-section-0.

Change-Id: I772414f563543f6a39ec61e87a9c46cb3ef6690d
 2022-09-10 12:44:32 +01:00
jenkins-bot 183fba9171 Merge "Update mw:tocplace CSS hack" 2022-09-09 21:12:43 +00:00
Translation updater bot 6fb0d36946 Localisation updates from https://translatewiki.net. 
Change-Id: I640502c4b71f8903cbbb6656ae376d21dcb35c6e
 2022-09-09 10:10:02 +02:00
Translation updater bot 4ef027ce2e Localisation updates from https://translatewiki.net. 
Change-Id: I6f1637b3baf50c35ec4067a249f47b966d821912
 2022-09-08 09:59:07 +02:00
Translation updater bot 88f8e534eb Localisation updates from https://translatewiki.net. 
Change-Id: Ibfbc00a012fa42346c80de99e440ceb55ba42b1b
 2022-09-07 09:54:37 +02:00
jenkins-bot 936883572c Merge "CommentFormatter: Fix TOC info being repeated for subsections" 2022-09-06 22:23:51 +00:00
jenkins-bot 0632bfc92e Merge "Refactor thread summary getters" 2022-09-06 22:17:26 +00:00
jenkins-bot 014ff9f8da Merge "Hooks: Inject VisualEditorParsoidClientFactory to ParsoidHelper" 2022-09-06 21:28:24 +00:00
Bartosz Dziewoński d7b6100c28 CommentFormatter: Fix TOC info being repeated for subsections 
(And don't display it for empty top-level sections)

Bug: T309463
Change-Id: Icc69a248bca0be4945e07051e667b87af28927f7
 2022-09-06 23:19:13 +02:00
Ed Sanders e24550fae9 Refactor thread summary getters 
Replace getThreadSummary with individual getters that call
calculateThreadSummary once.

Change-Id: Ie8a8b4d7cb5121847b78dbc20bca2c8d48c7d857
 2022-09-06 23:19:13 +02:00
Derick Alangi 5168005373 Hooks: Inject VisualEditorParsoidClientFactory to ParsoidHelper 
Since it will be made a required field in VE, just inject it.

Change-Id: If682af406c0fc7a9eca106eb3ebd95e6c14baddd
 2022-09-06 21:15:13 +01:00
Ed Sanders 09d9b179f7 Content*Item: Use more specific Content*Item classes within functions 
We can't use these is class method function signatures, but we
can use within the functions themselves.

Change-Id: Ic24e47d6647226172a3bfacd81398d26143d98e4
 2022-09-06 20:00:55 +00:00
jenkins-bot 23a5647ff4 Merge "Hooks: Remove injecting MainConfig to ParsoidHelper" 2022-09-06 17:53:11 +00:00
Translation updater bot 43f4a50df6 Localisation updates from https://translatewiki.net. 
Change-Id: Id5c3838eb4214ca68b08eed30e8e7b0ad67ede75
 2022-09-06 09:39:24 +02:00
jenkins-bot 1c624210f4 Merge "Table of contents style tweaks" 2022-09-05 21:43:06 +00:00
Derick Alangi c1c1cee267 Hooks: Remove injecting MainConfig to ParsoidHelper 
Will fallback to MainConfig gotten from services in VisualEditor.
VE will remove this complete soon.

Depends-On: I787c0afb227308aab56770d14d62e08eb0084a6c
Change-Id: I4b9e7362a1bf1b4f224c8c652d40851a18c19824
 2022-09-05 14:36:25 +01:00
Ed Sanders 5c7cf02457 Table of contents style tweaks 
* Make "X comments" appear on a new line deliberately
* Remove parentheses around "X comments"

Bug: T309463
Change-Id: I803eee9db59c633f129f15e436242a12bcc627f0
 2022-09-05 12:57:31 +01:00
jenkins-bot f5b7f72a38 Merge "Inject services into API classes" 2022-09-05 11:44:04 +00:00
Translation updater bot c09f2f1a10 Localisation updates from https://translatewiki.net. 
Change-Id: I0f7690590d449b31ec07a933d2243648e18c22c5
 2022-09-05 10:10:33 +02:00
jenkins-bot cb4eb9f9e9 Merge "ReplyWidget: Ignore pending updates after tearing down" 2022-09-03 20:23:22 +00:00
jenkins-bot 2ce1822484 Merge "Use cheaper getRawVal/getCheck instead of getVal where possible" 2022-09-03 05:33:08 +00:00
Thiemo Kreuz 62ddb8bceb Use cheaper getRawVal/getCheck instead of getVal where possible 
getVal/getText can be expensive because they do Unicode normalization.
We can skip this when we know we aren't going to do anything meaningful
with the value anyway.

Change-Id: I9d939a44df6b67bcd8429096d89600ce1566ca39
 2022-09-03 05:27:20 +00:00
Bartosz Dziewoński 9b317c6f22 ReplyWidget: Ignore pending updates after tearing down 
When using ReplyWidgetVisual, this would just crashes in #getValue.

When using ReplyWidgetPlain, if the timing is right, this might update
our auto-save after the value was cleared in the teardown code,
breaking the way we restore the reply after showing new comments.

Bug: T316074
Change-Id: I23c5f17a6ff9a6ec9c73a176e4cc60e3ad96e7f1
 2022-09-03 06:55:42 +02:00
jenkins-bot f8b5ada93d Merge "Remove clear:both from topic containers" 2022-09-03 00:25:27 +00:00
Bartosz Dziewoński 14b01e101a Only hold on to a Config instead of ConfigFactory when injecting 
The config is currently unused in some classes, but this is okay since
it might be used in the future.

Change-Id: Ie25fc52cc5d3476c9445e182975d229991316bd3
 2022-09-03 00:39:51 +02:00
Bartosz Dziewoński dc07d802a9 Inject services into API classes 
This replaces the remaining uses of MediaWikiServices::getInstance()
in API classes.

Change-Id: I5f602a7e7b5a21a7d40023571018604528ea8edb
 2022-09-03 00:23:41 +02:00
Ed Sanders 664d5d041a Fix fetching of oldest comment in a thread 
The implementation in Parser doesn't descend into sub-thread.
Re-use the getThreadSummary method in ThreadItem and traverse
the thread properly.

Bug: T298617
Change-Id: I318d9012eb83f37ccbe463923524ef2e9f995ced
 2022-09-01 21:22:09 +00:00
Translation updater bot 01ae9bf8f9 Localisation updates from https://translatewiki.net. 
Change-Id: I2a531dc12f2a77ff84f9f4089af399f3e06bd5bb
 2022-09-01 18:34:59 +00:00