jenkins-bot
32d9ef573a
Merge "CommentParser: Avoid using a dynamic undeclared property"
2022-03-10 00:22:16 +00:00
jenkins-bot
76478dda26
Merge "Move signatureScanLimit to a constant in JS"
2022-03-10 00:22:14 +00:00
jenkins-bot
bd43c2a139
Merge "Add test case for fake headings using wikitext ;
"
2022-03-10 00:17:49 +00:00
jenkins-bot
dfcb2f4fc7
Merge "Fix highlighting of comments when reloading"
2022-03-09 22:44:48 +00:00
jenkins-bot
456041cf6c
Merge "ImmutableRange: Add @property annotations for magic props"
2022-03-09 14:58:59 +00:00
jenkins-bot
e991910343
Merge "CommentParser: Fix redundant uses of getHeadlineNodeAndOffset()"
2022-03-09 14:57:45 +00:00
Ed Sanders
457f6eb7d1
Fix highlighting of comments when reloading
...
The CommentController stores a list of the new comments that
triggered the reload warning. Just highlight all the comments
in this list, as we always reload to the revision we got from
the same API call.
Bug: T303261
Change-Id: I960f3cf33e25004bad6ab6df907121a87555aaf4
2022-03-09 14:47:03 +00:00
Translation updater bot
77071a5bdd
Localisation updates from https://translatewiki.net .
...
Change-Id: I6a28bb912f771944f9c6261fe6e8858c6af76174
2022-03-09 08:09:25 +01:00
Bartosz Dziewoński
8529a33f29
CommentModifier: Micro optimization to avoid copying
...
It has no noticeable effect on the runtime of tests.
Change-Id: Ia4a20ba9667f3b772f960331c61f5aad857bf6cd
2022-03-08 23:30:15 +00:00
Bartosz Dziewoński
4c29304484
CommentParser: Avoid using a dynamic undeclared property
...
Change-Id: Iefa8dea83bc0d31b9c6b3509189eeaa652dd9ea0
2022-03-08 23:30:11 +00:00
Bartosz Dziewoński
08c79142fb
ImmutableRange: Add @property annotations for magic props
...
Phan can analyze them now and reports some issues with types.
* Add some assertions on types where we're sure that we're using an
Element or non-null, but Phan can't prove it
* Fix incorrect type hints on getFullyCoveredSiblings() and
getCoveredSiblings(), luckily it was harmless
Change-Id: I8cc12450378efa7434c4d66882378b715edd4a70
2022-03-08 23:29:40 +00:00
Bartosz Dziewoński
eb1fe7a8fb
CommentParser: Fix redundant uses of getHeadlineNodeAndOffset()
...
We call CommentUtils::getHeadlineNodeAndOffset() before constructing
the HeadingItem in CommentParser, so the range's startContainer
is always the headline node.
Change-Id: I2afb6ba9100e785cd91f31d82f4cea59fa8b5443
2022-03-08 23:29:34 +00:00
Bartosz Dziewoński
0e576216b2
CommentUtils: Fix confusing types in getIndentLevel()
...
Change-Id: I548cf4ad54e92c22da64caf53ee028a906cd3b62
2022-03-08 23:29:15 +00:00
Bartosz Dziewoński
584f6a020c
Use tagName
rather than nodeName
when we know the node is an element
...
`tagName` is only defined on Element, and it returns its tag name.
`nodeName` is defined on Node, and it returns the tag name for Elements,
and a string like '#text' or '#document-fragment' for other types.
We were using both, which made it harder to reason about what types
we're dealing with.
Change-Id: I8e621e5872bdf78c84ec553cfbfcdbf0192f0589
2022-03-08 23:29:05 +00:00
Bartosz Dziewoński
063174e71c
Use instanceof
for checking for text/element nodes in PHP
...
It is friendlier for static analysis tools like Phan, which can't
infer anything from the `->nodeType === …` checks, and we were already
using it in most places.
Fix newly revealed Phan failures (and one unneeded suppression).
Change-Id: Id789f05e16a210f7ba22ca7514587c392fac0741
2022-03-08 23:28:39 +00:00
jenkins-bot
1f7ff387a7
Merge "New topic: skip tabbing into the mode tabs until you've focused the body"
2022-03-08 23:18:37 +00:00
jenkins-bot
4b2f9ede8e
Merge "Use MessageWidget's showClose option"
2022-03-08 22:41:39 +00:00
Bartosz Dziewoński
4134a80fdc
Fix handling of disabled 'mobileformat'
...
Boolean parameters must be omitted completely if they're false.
Bug: T303262
Change-Id: Icc1bb4f557ce4de137f3e40b186074190f194dea
2022-03-08 14:00:22 +01:00
Translation updater bot
f1d1f1c5f7
Localisation updates from https://translatewiki.net .
...
Change-Id: Iea92d1e30030cda4d6124a814dc9fa663babb796
2022-03-08 09:01:34 +01:00
jenkins-bot
738e5461f8
Merge "Fix logic for finding the oldest comment in a bundle"
2022-03-08 02:23:57 +00:00
Ed Sanders
039d8e21e4
Fix logic for finding the oldest comment in a bundle
...
Follow-up to Ifba218871122901031a891034e709b886fc406da.
Bug: T302014
Change-Id: If1572a3ff13e922d86c0eca3d252cb196d329ea7
2022-03-08 02:13:54 +00:00
Ed Sanders
6869112aad
Use MessageWidget's showClose option
...
Change-Id: I81292bd84ce6feefdb852f6a636109f68e55291d
2022-03-08 01:25:22 +00:00
Translation updater bot
4460cd7fa9
Localisation updates from https://translatewiki.net .
...
Change-Id: Ifd2b7bb0429512a523a1a764dc625d9ba3f15cd6
2022-03-07 08:10:54 +01:00
Reedy
524c8edf5c
Use namespaced EventLogging class
...
Change-Id: Ic9f11b12edb5da08c2f4b31bea2a6517737ee6af
2022-03-06 16:10:40 +00:00
Bartosz Dziewoński
b2ee19b441
Remove check for CDATA nodes
...
Added in 76289cdf73
,
should no longer be needed since we switch to Parsoid's
HTML parser in 3e6ab2c4d2
.
Change-Id: Ic0b7ed8089b71f2338e604f68d547759e069f0b2
2022-03-04 22:14:41 +01:00
jenkins-bot
d478371db3
Merge "Highlight new comments when refreshing"
2022-03-04 21:09:40 +00:00
jenkins-bot
80d0d6c78b
Merge "Show error message as soon as we detect the parent comment has been deleted"
2022-03-04 21:09:37 +00:00
jenkins-bot
a03db698db
Merge "Don't show auto-save notifications when dynamically updating the page"
2022-03-04 21:09:35 +00:00
jenkins-bot
0c93b16c21
Merge "Poll for new comments in the section you are replying in"
2022-03-04 21:09:32 +00:00
Bartosz Dziewoński
0030f4cb9b
Disable the biggest JS modifier test cases temporarily
...
Bug: T303074
Change-Id: I9bd284feb4ede27aadf99904fd230d9bfd778351
2022-03-04 20:22:11 +00:00
Translation updater bot
6b7ea63d24
Localisation updates from https://translatewiki.net .
...
Change-Id: I9767b557af29d5d7345252d7a411a5667ef057e2
2022-03-04 08:29:18 +01:00
Ed Sanders
4f91a0b883
Highlight new comments when refreshing
...
Bug: T300215
Change-Id: I72655e05dccbe96f9dfa4ccca4e91b3edf133d97
2022-03-04 00:40:29 +00:00
Ed Sanders
487be9e202
Show error message as soon as we detect the parent comment has been deleted
...
Bug: T300504
Change-Id: I654422f7931f50503e51500508aea728adf327a1
2022-03-04 00:40:29 +00:00
Ed Sanders
d619308098
Don't show auto-save notifications when dynamically updating the page
...
Bug: T302327
Depends-On: If94e603458a385ba6eb15c4e29144f72e3ad12ca
Change-Id: I28f965137b986d00ac7a020ca93d8dc5195f5d4f
2022-03-04 00:40:29 +00:00
Ed Sanders
da49448f43
Poll for new comments in the section you are replying in
...
Bug: T300504
Change-Id: I3a887ab2f5260bb4893a3d680103c9d8ec767f45
2022-03-04 00:40:29 +00:00
Bartosz Dziewoński
0c59779126
CommentItem: Fix warning when the comment is empty
...
Bug: T302927
Change-Id: I5e92a71327e9563adb2427da62647a21244b803c
2022-03-03 19:35:11 +00:00
Translation updater bot
6e75e580a9
Localisation updates from https://translatewiki.net .
...
Change-Id: Ib2946e8d66499a2f9f609c328055e88026ae6841
2022-03-03 08:22:32 +01:00
jenkins-bot
3c91a800ed
Merge "Improve detecting already signed comments"
2022-03-02 14:14:13 +00:00
jenkins-bot
094b77b4bb
Merge "Handle reply/topic preview entirely server-side"
2022-03-02 14:13:59 +00:00
Translation updater bot
88132fbd99
Localisation updates from https://translatewiki.net .
...
Change-Id: I78c1dc54b1ddeecdf8c23243dad8f6b3a358ef95
2022-03-02 09:36:54 +01:00
Ed Sanders
1032db4878
Move (auto) topic subscription initialisation to separate file
...
Bug: T302805
Change-Id: Ia901cba731233719dd1d5916eb5211a551d34091
2022-03-01 21:27:08 +00:00
Ed Sanders
c70c1e76f3
Only bind page-level handlers once
...
Raise scope of pageThreads variable (renamed from `result`)
so we don't have to re-bind when it is updated, and use a
flag to ensure we only bind the handlers once.
Bug: T302810
Change-Id: I0a5b122b8e3f656f28f3dd4fa6aca8e7839be06b
2022-03-01 21:26:36 +00:00
Ed Sanders
f5d4df12a9
Move highlightPublishedComment to highlighter.js
...
Bug: T302805
Change-Id: I429148b16f790e1d1f5cbbd84fc35139727b4402
2022-03-01 14:44:21 +00:00
Ed Sanders
ecbe75c453
Move highlighting methods to separate file
...
Bug: T302805
Change-Id: Ie4a8ea3f351015ab5bb4b817ef997cf6d77428da
2022-03-01 14:29:10 +00:00
Ed Sanders
b6136c9a58
Rename highlighter to debughighlighter
...
Change-Id: I8c3873fb345fee3687efb1632f3eae36c030f9cf
2022-03-01 14:20:18 +00:00
Translation updater bot
9dacb95803
Localisation updates from https://translatewiki.net .
...
Change-Id: I93d01180b749df1d70b9a9ceeb51babb9babe546
2022-03-01 14:32:40 +01:00
jenkins-bot
0dc293fc20
Merge "Warn when target comments in a link can't be found"
2022-02-28 23:24:15 +00:00
jenkins-bot
e15ccb8a07
Merge "Highlight all comments since the oldest in a thread bundle"
2022-02-28 23:24:12 +00:00
Bartosz Dziewoński
be74938855
Warn when target comments in a link can't be found
...
Links are generated to:
* Single comments, by a user or by a notification
* Potentially multiple comments (new comments since T),
usually just by notifications.
If in either case no comments are found to highlight, warn the
user so they get some visual feedback that the notification worked
as expected, but that the comment was just deleted since.
Bug: T301602
Change-Id: I090c904481cf6f3e9f964fa43b10001e75b0bc90
2022-02-28 21:58:59 +00:00
Ed Sanders
dc8b4e8d4f
Highlight all comments since the oldest in a thread bundle
...
For topic subscriptions, further restrict this to comments
in the same thread.
Bug: T302014
Change-Id: Ifba218871122901031a891034e709b886fc406da
2022-02-28 21:58:10 +00:00