wikimedia/mediawiki-extensions-DiscussionTools
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools synced 2024-09-23 18:38:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Fix logic for finding the oldest comment in a bundle"

Browse source
This commit is contained in:
jenkins-bot 2022-03-08 02:23:57 +00:00 committed by Gerrit Code Review
parent 4460cd7fa9 039d8e21e4
commit 738e5461f8
1 changed files with 7 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
includes/Notifications/DiscussionToolsEventTrait.php
View file

@ -72,10 +72,14 @@ trait DiscussionToolsEventTrait {
// * User talk page notifications are bundled per-page (so basically, always bundled).
// * Mention notifications are *never* bundled.
// Just pass the first comment in the bundle. The client has access to the comment
// Just pass the oldest comment in the bundle. The client has access to the comment
// tree and so can work out all the other comments since this one.
$firstEvent = $this->getBundledEvents()[ 0 ];
$params = [ 'dtnewcommentssince' => $firstEvent->getExtraParam( 'comment-id' ) ];
// This does not include the newest comment, $this->event, but we are looking
// for the oldest comment.
$bundledEvents = $this->getBundledEvents();
$oldestEvent = end( $bundledEvents );
$params = [ 'dtnewcommentssince' => $oldestEvent->getExtraParam( 'comment-id' ) ];
if ( $this->event->getExtraParam( 'subscribed-comment-name' ) ) {
// Topic notifications: Tell client to restrict highlights to this thread
$params[ 'dtinthread' ] = 1;