Commit graph

4090 commits

Author SHA1 Message Date
jenkins-bot 81433b0973 Merge "Fix static cache access" 2024-05-13 11:49:15 +00:00
Bartosz Dziewoński d91fea5df2 Revert "Localisation updates from https://translatewiki.net."
This reverts commit b0e39cb5c1.

Reason for revert: Trailing spaces causing build failures (T364727)

Change-Id: I42aa0820aa73e211e0362d6dd40b03d327a15caf
2024-05-13 11:29:29 +00:00
Translation updater bot b0e39cb5c1 Localisation updates from https://translatewiki.net.
Change-Id: I5e35cfcf925e05e0e228a137003dcb6a8b7059f1
2024-05-13 09:27:01 +02:00
Amir Sarabadani 320da37512 Fix static cache access
Currently, DT is making more than 30 exact queries back to back in every
request. It is clear the caching is completely broken.

It is because when the properties don't exist (majority of the cases),
it returns an empty array making the caching noop.

Tested in mwdebug1002 and it fixes the issue.

Bug: T364693
Change-Id: I182ae121999df1a04cfb7399bc49891587a37074
2024-05-12 18:23:41 +02:00
libraryupgrader 52ca3d408e build: Updating grunt-banana-checker to 0.12.0
Change-Id: I7c7aa4b43c6ececa055b011f1fd8d111e9c30e06
2024-05-10 03:48:35 +00:00
Translation updater bot fae27bf022 Localisation updates from https://translatewiki.net.
Change-Id: Ia3078d23501bc8d255efc6188aeb22c8a50a4e23
2024-05-09 09:38:23 +02:00
Translation updater bot 8c01e8bfb1 Localisation updates from https://translatewiki.net.
Change-Id: I5020be8531b30e0be64f5e80fcd82d54b48b6f62
2024-05-08 09:23:39 +02:00
Translation updater bot 64acb6b373 Localisation updates from https://translatewiki.net.
Change-Id: I290a1e69dfd546f8ac62f55ffbc132de89f9e621
2024-05-07 09:22:33 +02:00
Translation updater bot 30fd85efb9 Localisation updates from https://translatewiki.net.
Change-Id: I301411aa12c4427e942c812aebf0496928e87bcd
2024-05-06 09:25:34 +02:00
libraryupgrader e394dc7d4d build: Updating composer dependencies
* mediawiki/minus-x: 1.1.1 → 1.1.3
* php-parallel-lint/php-parallel-lint: 1.3.2 → 1.4.0

Change-Id: I6ad38345831f049a508288af043839d221201787
2024-05-06 05:16:37 +00:00
wfan 2b41719f96 Migrate MediaWiki.discussiontools.addReplyLinks to statslib
Bug: T359463
Change-Id: I93f7872818a27e5a5aac6ed4c44302bdc78b0613
2024-05-05 13:59:04 +00:00
jenkins-bot da1af07768 Merge "Use user_properties.up_value with string in database query" 2024-05-02 22:04:38 +00:00
jenkins-bot 5689650a6a Merge "Replace $.extend with Object.assign" 2024-05-02 21:42:02 +00:00
Umherirrender 186e79d41b Use user_properties.up_value with string in database query
The field up_value is a varbinary and should be provided as string,
not all rdbms implicit converts int/strings

Change-Id: Ideb28ad9cc475dad84d0f7dc45a0f3c286f4487c
2024-05-02 23:25:20 +02:00
Ed Sanders 1e0aa2171f Replace $.extend with Object.assign
Change-Id: Id559ab68451a1d767e92ed17b1ef0832a5f243af
2024-05-02 16:49:43 +01:00
Ed Sanders 2dd73f935c JSDoc: {Mixed} -> {any}
Change-Id: I78bdc1ec8767dca05e979d8c6ebfed72573acc6f
2024-05-02 10:36:24 +01:00
Ed Sanders 501046f38c Trim whitespace from truncated heading titles in IDs
Bug: T356196
Change-Id: Iddcda0cee624fda7f78a05e0a3d70eaee2635da9
2024-05-01 14:20:12 +01:00
Translation updater bot 687284939c Localisation updates from https://translatewiki.net.
Change-Id: Id02593aa083f78769839f9d447f342f02dba98e0
2024-05-01 09:22:05 +02:00
jenkins-bot 28a529b31d Merge "CommentController: Delay polling on error" 2024-04-30 20:03:09 +00:00
jenkins-bot dcb8d7175b Merge "ApiDiscussionToolsCompare: Show nice error for deleted revisions" 2024-04-30 20:03:06 +00:00
jenkins-bot af74638d08 Merge "ApiDiscussionToolsCompare: Deduplicate 'from'/'to' param handling" 2024-04-30 20:02:59 +00:00
jenkins-bot 3c4b5364f2 Merge "Prefer short arrow functions" 2024-04-30 16:57:37 +00:00
jenkins-bot 8b9a813b11 Merge "Clean up handling of <span class="mw-headline">" 2024-04-30 16:48:56 +00:00
jenkins-bot 9f7de3e917 Merge "Remove the "offset" from getHeadlineNodeAndOffset()" 2024-04-30 16:48:54 +00:00
jenkins-bot 60031336b9 Merge "Remove unused styles for .mw-ui-icon" 2024-04-30 16:48:52 +00:00
jenkins-bot aec14751dc Merge "Fix signature check not to look at the content of previous section" 2024-04-30 16:34:58 +00:00
jenkins-bot 3c4c018a2b Merge "Add more test cases for isSingleCommentSignedBy()" 2024-04-30 16:33:38 +00:00
Bartosz Dziewoński ede626faa2 Remove unused styles for .mw-ui-icon
The mobile site no longer uses the .mw-ui-icon class.

Change-Id: I212c743997839eeca63a23bf618436787af32fa4
2024-04-29 18:55:43 +02:00
Translation updater bot 9935ffe481 Localisation updates from https://translatewiki.net.
Change-Id: I0cc0acbf764b5b6bba33af7b5cc7064afb430ec0
2024-04-29 09:23:10 +02:00
Translation updater bot 82eb045f07 Localisation updates from https://translatewiki.net.
Change-Id: Iacef5eef18aa06ba446629d7795586bee74601d7
2024-04-26 09:48:08 +02:00
Bartosz Dziewoński 1bfd97580e CommentController: Delay polling on error
Use exponential backoff.

Bug: T362814
Change-Id: I436a700de3b89abbfa1f991bcf6dc7aa52008cbd
2024-04-26 04:56:34 +02:00
Bartosz Dziewoński b8a28d6cfc ApiDiscussionToolsCompare: Show nice error for deleted revisions
Bug: T362814
Change-Id: Iecc3e3737fcc82a79e699fe0bc00f373ecabf0c2
2024-04-26 03:54:31 +02:00
Bartosz Dziewoński f3e96a72fa ApiDiscussionToolsCompare: Deduplicate 'from'/'to' param handling
Change-Id: I0351228f50e9ea5a599d11b37f684b8e66553a83
2024-04-26 03:54:05 +02:00
Bartosz Dziewoński 67bad433dc Fix signature check not to look at the content of previous section
It needs to only look at the end of the added comments, and ignore
whatever is going on at the beginning, since the only thing it really
cares about is a functioning "Reply" button at the end.

Bug: T363285
Change-Id: Ia337be754deda741617d1343972f3e0a21c41b05
2024-04-25 23:15:18 +02:00
Bartosz Dziewoński 5def2227a2 Add more test cases for isSingleCommentSignedBy()
Inspired by the discussion at T363285, document some more intended
behaviors from 0ecc8a4c05.

Change-Id: Id190318a98563f4064c20477bc17e929dd59d74a
2024-04-25 22:09:40 +02:00
Translation updater bot 1130ab2491 Localisation updates from https://translatewiki.net.
Change-Id: I0ae20abc8ddc7c73c4700a72771740ea46e7704b
2024-04-25 09:17:39 +02:00
Translation updater bot 94c7467722 Localisation updates from https://translatewiki.net.
Change-Id: Ie39d1793f03615f4f6a13795621e5422e22c7c47
2024-04-24 09:18:42 +02:00
Translation updater bot 7b849b5210 Localisation updates from https://translatewiki.net.
Change-Id: I34938c66d2f58389d077080c84650e1e867f87f5
2024-04-23 09:28:22 +02:00
Translation updater bot f3e596a8f0 Localisation updates from https://translatewiki.net.
Change-Id: I6a2a7a641492a8e7b8ea31d98f9f8d83be29048e
2024-04-22 09:28:08 +02:00
Bartosz Dziewoński 3cffe1190e Clean up handling of <span class="mw-headline">
The PHP code should never see a `<span class="mw-headline">` node
since MediaWiki change If04d72f427ec3c3730e757cbb3ade8840c09f7d3,
but we have to support it for our old integration tests (T363031).

Improve code comments to explain this and move the handling to
one place, so that it can be deleted more easily in the future.

Follow-up to 08f61b2609.

Change-Id: I5ab9d3373a6911c1456c30d844b66576b278a1b5
2024-04-20 00:16:45 +00:00
Bartosz Dziewoński 7445294b3b Remove the "offset" from getHeadlineNodeAndOffset()
Since c6cd20f682 the offset is always 0.

Change-Id: I9c1c8230f897d8bb287ca47056f5fa9fb187d060
2024-04-20 00:34:32 +02:00
jenkins-bot 1f7d23e3d7 Merge "Remove unnecessary IIFE" 2024-04-19 22:12:34 +00:00
Bartosz Dziewoński d4c5aebd8f Prefer short arrow functions
When an arrow function body contains just a single `return` statement,
the braces can be omitted.

(Changes are mostly made by `grunt eslint --fix`, with only some line
breaks added by hand.)

Change-Id: I37f259f87085c8d20ed09cfa58a8456dd36cdc38
2024-04-20 00:08:51 +02:00
jenkins-bot 83d0eb5a23 Merge "Prefer arrow functions for callbacks" 2024-04-19 22:05:36 +00:00
Ed Sanders f509f91c71 Remove unnecessary IIFE
Change-Id: I1f23cd134d830afdf4d6afee5f1a399743c9eaa6
2024-04-19 12:34:28 +01:00
Ed Sanders a74c00ba8c Prefer arrow functions for callbacks
This allows us to remove our `this` bindings.

Change-Id: Ie8c8c38d36af8a033b5181870c39f8981a57b939
2024-04-19 12:34:23 +01:00
Translation updater bot e5a26f2111 Localisation updates from https://translatewiki.net.
Change-Id: I11fc74d8c7f9509f12ddef96ee007d4f8d65714d
2024-04-19 09:46:23 +02:00
Translation updater bot 0c123b0999 Localisation updates from https://translatewiki.net.
Change-Id: I7110d1160c56fe7e1fa5f4519b3b8fc168fd30a7
2024-04-18 09:20:21 +02:00
jenkins-bot 56b21c9032 Merge "Remove workaround for T357812" 2024-04-17 15:22:35 +00:00
jenkins-bot 03a3c4b42c Merge "Remove DTSUBSCRIBELINK cached HTML compat" 2024-04-17 15:22:33 +00:00