Wrapping the test mainly to avoid that declared vars or functions
bleed into other tests.
Includes lint auto-fixes
Change-Id: Ia4577f7496ddecf4985525de674ade46f53e03a6
This is just a minor optimization. The keys should now all follow
the schema for Reference Previews in this extension.
I'm not touching the `popups-prefs-conflicting-gadgets-info` key.
That one was not copied over to this codebase and IMO we could
really remove it for the reasons in that comment.
Bug: T355194
Change-Id: I1948cf0aaca4d0ab3676bac806c7287568db8712
It's not making much sense to have the things merged in seprate
files IMO. I'll try to merge what's needed for the init to see
what could be delayed and lazy loaded.
Bug: T361670
Change-Id: Ia0bc9b68bbd9cfeed385520a868fe8726f7aa872
Just some random variables I renamed. Mostly writing out what's
shortened. In some minor cases moving declarations a bit so they
are closer to the usage.
More stuff to follow.
Bug: T382232
Change-Id: I2b372f65e548074366652caf477b897fea2eeb0a
This reverts commit 91316d49c2.
Reason for revert: Caused T380977 when Remex was given math
content to normalize.
Change-Id: I6d7585a990322b5c8e2a6886b9cd05a556c501ad
In I3b82aea975ed84c7410e57e19e83c508554e1b05, it was determined that
this edge case is not going to be supported.
Change-Id: Ia2ea80fc55af9f1e7e9a475afd730315ae6715cd
If the ref generated HTML contains attributes such as data-parsoid or
about, the string comparison fails, and two references that have the
same content end up being seen as different.
This patch filters out data-parsoid and about attributes from the
generated HTML.
Bug: T380152
Change-Id: I4c201c469d21ff9cb54f746386ce53b8d636361d
It can happen that an error is reported multiple times for a given
reference. In this case, we only display one.
We still display different errors if a reference contains multiple
different errors. This behaviour is differs from the legacy parser's
(so, in this case, we add the category
cite-tracking-category-cite-diffing-error), but not from the legacy
parser's desired behaviour, as hinted by the various comments and TODO
in this area.
Bug: T380153
Change-Id: I9b3d5cbd086fc72c66a2afbae8f92297681989ce
The type hints added in I3e0df790ff9db2fa630f82408a7254a359fe61ca
were sufficient to allow phan to detect that we were possibly passing
a null value in one instance. The other instance was a false positive.
Follows-Up: I3e0df790ff9db2fa630f82408a7254a359fe61ca
Change-Id: I3bacc2aff3d36719133554a8f70d50a3790b84e4
Tests are disabled until the next Parsoid tag.
The rearranged failure looks like it started in
Ifeb3b216e898bec1c3eb5917262820c5809fda45
Needed-By: I9a2f75ea137a8a10842191ad0ea3e92eab41202c
Change-Id: Ibf8656ab344ed79b3740f3b98e96ff4353375b62
There is only one child, so first/last element child are the same, but
it's a little less confusing to use 'first' here.
Follows-Up: Ifeb3b216e898bec1c3eb5917262820c5809fda45
Depends-On: I753bbbfaf99fb486384b0fa97de71159abb504b3
Change-Id: I65873c117cbd3e1d6efd82797c7b49bf707f5c3a
