Commit graph

742 commits

Author SHA1 Message Date
jenkins-bot 1f8c99aa72 Merge "Don't process references defined inside template-generated reflists" 2020-01-08 23:32:33 +00:00
jenkins-bot 70e53556a4 Merge "Make native selection over reference nodes visible" 2020-01-08 16:31:18 +00:00
WMDE-Fisch b74a88a3f9 Reduce indentation margin for book references
This should now roughly resemble 2nd level indentation for nested
list elements. CSS Janus should take care of RTL compatibily.

Bug: T239329
Change-Id: I2eb5b63033f558555b1d79faba82b5a774ddd934
2020-01-07 13:04:52 +01:00
Translation updater bot 40d3cb1e8c Localisation updates from https://translatewiki.net.
Change-Id: I62aafceebc2aa593c9d163fc9966e675dec9de79
2020-01-06 08:48:26 +01:00
Bartosz Dziewoński b475eca1b9 Don't process references defined inside template-generated reflists
As a result, the references are now treated like any other
template-generated reference, e.g. they can't be edited.

Previously they could be edited as if they weren't template-generated,
causing trouble. Editing them had no effect (changes would not be
saved), and copy-pasting them into another page resulted in
"substituted" content (template metadata was lost).

Bug: T209493
Change-Id: I4e75ccd57cd752a726653c725d8c29a09306e83b
2020-01-04 15:53:21 +01:00
Bartosz Dziewoński 52646d1a7c Make native selection over reference nodes visible
Bug: T241880
Change-Id: Ie712d4edc2ef49dd3b1f4ca186b2e2d539ab8659
2020-01-04 14:00:40 +01:00
Translation updater bot 94e47e5908 Localisation updates from https://translatewiki.net.
Change-Id: I689527e190c21c11c5efa605a4c8680f6ebb9a8c
2020-01-02 08:57:51 +01:00
Translation updater bot f888533855 Localisation updates from https://translatewiki.net.
Change-Id: I9f15597897901de8c682f335fc33bcdd04ac168b
2019-12-26 16:18:56 +01:00
Adam Wight 377cdb3b9f Less checkered error message style
We print error messages in red, bold, large text so that they stand
out from content.  "<code>" spans, which are prevalent in our messages,
were styled with black text by accident, this patch turns them red.

This should cause less annoyance on readers.

Change-Id: Ic911552909ecc5ace4be927cad5b835e1006355e
2019-12-20 10:58:56 +01:00
Translation updater bot aae8297f0f Localisation updates from https://translatewiki.net.
Change-Id: Ic8c6bd20bda69a653ee66c91b73119b8be13da68
2019-12-13 09:27:39 +01:00
jenkins-bot dfee9cc254 Merge "Add missing dot to "1.2." list numbering for extended refs" 2019-12-09 09:50:50 +00:00
Thiemo Kreuz d18c0871a8 Fix broken reference list numbering in Firefox
Same as Ib6e9de6.

We must reset the build-in "list-item" counter to make this code behave
sane in Firefox. It looks like this is even described in the CSS spec
and it is not Firefox having a bug, but Chrome being "clever" and not
following the spec.

Bug: T229307
Change-Id: I955786e2b68d087c819a962ded3c571946c61f78
2019-12-09 10:10:54 +01:00
Thiemo Kreuz fc1865780d Add missing dot to "1.2." list numbering for extended refs
All mock screenshots on
https://de.wikipedia.org/wiki/Wikipedia:Technische_W%C3%BCnsche/Topw%C3%BCnsche/Erweiterung_der_Einzelnachweise
show this extra dot.

Note the numbering scheme "1." and "1.1" (without the dot) was not a
mistake. It's not uncommon to only have the extra dot on the first
level.

However, I feel the scheme "1." and "1.1." might be a little more
consistent and less surprising.

Change-Id: I0dc467755926f82d88a48fb7594af0bde8bbee21
2019-12-09 09:55:32 +01:00
Translation updater bot f0d964260d Localisation updates from https://translatewiki.net.
Change-Id: I288c44b26a18d3fa46e9f71b6b5f7509bcd1fc1b
2019-12-09 09:33:57 +01:00
Translation updater bot 9f305e2a6f Localisation updates from https://translatewiki.net.
Change-Id: I7effa200ea4f8e680da12b65bfccb73e504bbbb1
2019-12-05 09:45:15 +01:00
Thiemo Kreuz 0f146cd56e Fix possibly broken reference list counters in Firefox
This patch applies a few closely related changes:

1. Instead of reusing and possibly messing with the existing
"mw-ref-linkback" counter, I start a new one.

2. I also gave both new counters better names, following the
"mw-ref-…" naming scheme.

3. We must reset the build-in "list-item" counter to make this code
behave sane in Firefox. It looks like this is even described in the
CSS spec and it is not Firefox having a bug, but Chrome being "clever"
and not following the spec.

Bug: T239787
Change-Id: Ib6e9de689129b7c2d50e3a1c720c0d2d5a0c0986
2019-12-04 12:13:13 +01:00
Translation updater bot 350bba502a Localisation updates from https://translatewiki.net.
Change-Id: I1fc295815f12480d430893e78e4d6d28d8261afd
2019-12-04 09:22:40 +01:00
Adam Wight 0f2c56e0ac Fix top-level reference numbering
This fixes a Firefox-only glitch where the CSS counter was messing
with the native list numbering. Example:
https://en.wikipedia.beta.wmflabs.org/wiki/Draft:Cut_the_Crap

Change-Id: I6e6514e73bcf6485402b6a61aa5202ebb83a6479
2019-12-03 12:32:29 +01:00
Thiemo Kreuz 13598ba11e Render nested references
Forked from Icd933fc983.

Bugs and unimplemented features are documented as TODOs in the parser test
fixtures.

Bug: T237241
Change-Id: I9427e025ea0bcf2fa24fd539a775429cc64767cc
2019-11-29 13:40:34 +01:00
Bartosz Dziewoński 54bdd85060 ve.ui.MWReferenceDialog: Avoid exception when destroying
Bug: T236949
Change-Id: I430415d4c0921103af0939d087c2d066cd57369f
2019-11-28 19:49:16 +01:00
Translation updater bot 683b4e3e6b Localisation updates from https://translatewiki.net.
Change-Id: I238c18b40b4d12376b6055efa0bc5b6eca278a59
2019-11-25 09:09:29 +01:00
Translation updater bot b01f9f67a4 Localisation updates from https://translatewiki.net.
Change-Id: Icf0e48075c50d682d4bdc4330be1816b65939de9
2019-11-22 09:13:52 +01:00
jenkins-bot d4928c86e6 Merge "Remove deprecated TargetWidget APIs" 2019-11-19 08:21:48 +00:00
Translation updater bot db46093f88 Localisation updates from https://translatewiki.net.
Change-Id: Iddb4f2159e29a6cc860569dc80df1285d11d21b8
2019-11-18 09:21:11 +01:00
Ed Sanders 2a222b61d0 Remove deprecated TargetWidget APIs
Change-Id: Ib7feb57ce19f2db47a41561281d51aebd063f408
2019-11-15 16:30:27 +00:00
Thiemo Kreuz 4619cb24f6 Track pageviews only on content page views, not edits
This code is typically not executed on special pages and such, so we
assume the isArticle check doesn't make much of a difference. The main
difference we are aware of is that this will exclude previews.

Bug: T214493
Change-Id: I5155329b8a549adbd3b17c1f1014bb8bbc6768f4
2019-11-14 11:15:34 +00:00
Translation updater bot 16b757b88d Localisation updates from https://translatewiki.net.
Change-Id: I8999b6b407545de2f28394322bb7798e27146632
2019-11-07 09:40:56 +01:00
Translation updater bot 3a1a89c364 Localisation updates from https://translatewiki.net.
Change-Id: Ie7c9f4a14ec0f6a6f1f7d6f71d5530a98f3ff916
2019-11-05 09:45:00 +01:00
Translation updater bot 85ce680bcb Localisation updates from https://translatewiki.net.
Change-Id: I6bf381a41aac07931c13cfed633c581141d7941b
2019-11-04 09:29:35 +01:00
Translation updater bot c5fe31f806 Localisation updates from https://translatewiki.net.
Change-Id: I87a0e2f2a758bcce1ec2d3bd2bfb45e18531a794
2019-10-31 09:27:15 +01:00
Translation updater bot 8305228ecd Localisation updates from https://translatewiki.net.
Change-Id: I1de9b607e7fd9a4656e4fa388461a4946ea89f2d
2019-10-28 16:33:03 +01:00
Adam Wight f6b5615e4b Stop sampling when Reference Previews is enabled
There are so few users with this configuration that we need to stop
sampling in order to get data.  Sampling is still in effect for
"baseline" users with the feature disabled.

We use separate schemas to simplify analytics on the two populations.

Bug: T214493
Change-Id: I16e4ed236e50e1e246ff28ff0dba3e52e4b56caf
2019-10-24 22:23:18 +02:00
Translation updater bot 08f1f80802 Localisation updates from https://translatewiki.net.
Change-Id: Ia842aab67c90f4bb055da8d3a3862324fd7aebbe
2019-10-24 10:41:28 +02:00
Translation updater bot 547b52a872 Localisation updates from https://translatewiki.net.
Change-Id: Ieeb1779556b68eab215c3b885ce3a6256eadfa3e
2019-10-23 09:52:34 +02:00
Translation updater bot f6e1e2026e Localisation updates from https://translatewiki.net.
Change-Id: I65f12f0e05a95c30ee86486487e8e707a7907c11
2019-10-21 09:58:20 +02:00
Translation updater bot ce4b86f7d8 Localisation updates from https://translatewiki.net.
Change-Id: I9508d5db2faa105a58df395629f62c380103d2d3
2019-10-16 20:38:18 +02:00
Translation updater bot c4e93b6c89 Localisation updates from https://translatewiki.net.
Change-Id: Icbd0368d8e1b53b0cf43411c7de2b29f082d0767
2019-10-16 10:38:53 +02:00
Translation updater bot b1eace5657 Localisation updates from https://translatewiki.net.
Change-Id: I06aee621c974e1e503442615f69aa2a7414d6807
2019-10-09 09:17:54 +02:00
Translation updater bot 959b57ac71 Localisation updates from https://translatewiki.net.
Change-Id: Ie14794768f1c3c6d680a96a41b0552fa10ebdc57
2019-10-08 09:31:59 +02:00
Translation updater bot 2205f82196 Localisation updates from https://translatewiki.net.
Change-Id: I645df905e96e01ff78e12ac212a63a3d3af49e62
2019-10-07 09:08:16 +02:00
jenkins-bot a9d30ab836 Merge "Baseline reference interaction tracking" 2019-10-04 09:45:10 +00:00
Volker E a759a1e58a Remove IE 6 & 7 specific hacks
Bug: T234582
Change-Id: I162d525208f8c9dfab6e316513825f046b0a223f
2019-10-03 18:51:47 -07:00
Adam Wight c12150082c Baseline reference interaction tracking
Collect EventLogging metrics for footnote and reference link
interactions, so that we can compare behavior with and without
Reference Previews enabled.

This tracking will be reverted once analysis is complete.

A mostly arbitrary sample rate of 1/1000 is hardcoded here.  This is
loosely based on the latest tuning of Popups sampling at 1/100,
divided by a conservative factor of 10 to ensure headroom.

The sample is skewed by skipping clients without sendBeacon support,
but we're avoiding the mw.track synchronous fallback, which injects an
image tag and introduces lag any time the user clicks external links
in the references.

Bug: T231529
Change-Id: Iad32b64114f88675eecbb01712418c968e3cf661
2019-10-01 10:23:31 +02:00
Translation updater bot 1463f47280 Localisation updates from https://translatewiki.net.
Change-Id: I7fe11bdb98aabdb1da3d78aacdcd4211ad87efbf
2019-10-01 09:24:33 +02:00
Translation updater bot a5ac0762bc Localisation updates from https://translatewiki.net.
Change-Id: Ib52cc84a1afd41200f5728e03cc98da62d33e59e
2019-09-30 09:18:16 +02:00
Translation updater bot 4a20cebbb9 Localisation updates from https://translatewiki.net.
Change-Id: Ibb878fce4b272b47920392b1dcd4d6478d189300
2019-09-26 09:13:05 +02:00
Translation updater bot dce416d150 Localisation updates from https://translatewiki.net.
Change-Id: I6352b52263bfeb774d577380d75b3537b6bc90ff
2019-09-25 09:22:30 +02:00
Translation updater bot 56f07c18b3 Localisation updates from https://translatewiki.net.
Change-Id: I6fe895898edf309b4dc9f5d490882d01a717d2e6
2019-09-24 09:56:07 +02:00
Translation updater bot 2b97f19305 Localisation updates from https://translatewiki.net.
Change-Id: Id30b05c0a33fb9d8b3cc01d9f3582ffa11ba031d
2019-09-23 09:24:33 +02:00
jenkins-bot 12c7fd7ac2 Merge "Citation needed template handling" 2019-09-21 19:10:48 +00:00
David Chan 94c6d46ded Fix tests to expect p-wrappers
The ve-mw change I0479116b51cc3135a992fdf36b8edfb2c44916ba removes the
stripping of solitary paragraph wrappers (which is moved into
ve.ce.Surface in VE core).

Depends-On: I0479116b51cc3135a992fdf36b8edfb2c44916ba
Change-Id: I2429b5291d8505d586cf4edc4cae9875f8abc347
2019-09-18 18:26:17 +00:00
Bartosz Dziewoński 1c4d5fd0de ve.ui.MWReference.init: Fix check for mobile target
This stopped working correctly after T218946, when we merged
MobileFrontendArticleTarget with its parent class MobileArticleTarget.

Bug: T233181
Change-Id: I9ec3f42508809431aef86157c20d8d6bb2fb12e5
2019-09-18 04:11:51 +02:00
Bartosz Dziewoński 80e6db1fde Temporarily remove tests
The ve-mw change I0479116b51cc3135a992fdf36b8edfb2c44916ba removes the
stripping of solitary paragraph wrappers (which is moved into
ve.ce.Surface in VE core). We can't merge it without removing the
failing tests here for a moment.

Change-Id: I8799d51958b966c99307f4c70546ea326e67385c
2019-09-17 22:42:42 +02:00
Translation updater bot a2c03ddb7e Localisation updates from https://translatewiki.net.
Change-Id: I1c9e8e5720b706acdabdc86f79bc07be654da668
2019-09-16 09:54:38 +02:00
Translation updater bot d43b6ce7f9 Localisation updates from https://translatewiki.net.
Change-Id: I3f5ecbde5fc36813d0ef6b262d4298fd3d9a63a0
2019-09-10 09:35:52 +02:00
Translation updater bot cea5741563 Localisation updates from https://translatewiki.net.
Change-Id: I0bec1135345d59e39304a01ea1d64885110aefbb
2019-09-09 09:24:57 +02:00
Translation updater bot a1bc17cd6e Localisation updates from https://translatewiki.net.
Change-Id: Icad3ddb63316931f355a956b4565cc96851e6f43
2019-09-04 10:11:55 +02:00
Translation updater bot 5c82129ec1 Localisation updates from https://translatewiki.net.
Change-Id: I1d7ab0539d4cacfbf4e715315978221ac200d611
2019-09-03 10:26:54 +02:00
Translation updater bot 994e5e89bc Localisation updates from https://translatewiki.net.
Change-Id: Ib698b560bc34c4aff0790f125d4c4de307c31a5d
2019-08-31 15:56:36 +02:00
Ed Sanders 659d461806 Citation needed template handling
Bug: T211243
Depends-On: I82124b24cc9edbbfc41dedc72452cbb583051cf8
Depends-On: Icfc39e350452da238d0e0c17cb2305c60d9ca16a
Change-Id: Ic443c1ae759a058673b71e47f09f2a7d219fc12e
2019-08-30 13:13:37 +01:00
Translation updater bot 7ed71a36b7 Localisation updates from https://translatewiki.net.
Change-Id: I00c4e7cdbc8dc1a2af15b975a775ef62356e8031
2019-08-30 10:02:39 +02:00
Translation updater bot 285e293fa1 Localisation updates from https://translatewiki.net.
Change-Id: I2355c18dac5574a95e1579bfa2479949802cb136
2019-08-27 11:03:11 +02:00
Translation updater bot 793d9e6151 Localisation updates from https://translatewiki.net.
Change-Id: I796a30d0981431845069be4a22174db57e100f9a
2019-08-25 10:29:30 +02:00
Translation updater bot 1ea0cb2f13 Localisation updates from https://translatewiki.net.
Change-Id: I759a7c581e2bdb42ed6fbb566c59cd0c348ffd1a
2019-08-23 09:47:32 +02:00
Translation updater bot 8e7b401a34 Localisation updates from https://translatewiki.net.
Change-Id: I6b06118055c9bd18ccd509fc76016f16c3ba9662
2019-08-21 10:01:44 +02:00
Translation updater bot ee8a1f74d6 Localisation updates from https://translatewiki.net.
Change-Id: I41423fe53e45aad4ea01de2eeaf87b4cd31afd53
2019-08-20 10:19:23 +02:00
Translation updater bot b83cf32383 Localisation updates from https://translatewiki.net.
Change-Id: Ie631a35d3ffd0fb605d6b4437c4a0e78c60f81f5
2019-08-14 09:12:29 +02:00
Translation updater bot 001753ec5f Localisation updates from https://translatewiki.net.
Change-Id: If10c751c1a378bd971f0eb9aacf794594953e3cf
2019-08-10 22:48:09 +02:00
Translation updater bot 1267e39ff1 Localisation updates from https://translatewiki.net.
Change-Id: Ide154bef58da09cc2f508b258d9a48e8423df257
2019-08-08 09:31:50 +02:00
Translation updater bot b3d8bef264 Localisation updates from https://translatewiki.net.
Change-Id: I95ea07e506adbed0ab20a472ba360cddc17595ba
2019-08-01 09:15:56 +02:00
Translation updater bot 650873c77a Localisation updates from https://translatewiki.net.
Change-Id: Ie516fd9b47ffc6d9d170cd143fd7704cf509c3b0
2019-07-29 09:14:02 +02:00
Translation updater bot 7a4f2dc7f3 Localisation updates from https://translatewiki.net.
Change-Id: Ic320fd6e19a6033c5be9fc2c4409201cd6b10dac
2019-07-24 22:28:26 +02:00
jenkins-bot 39b6dd00d7 Merge "Tracking for change events in citation-templates" 2019-07-22 21:32:02 +00:00
Translation updater bot 8604f48ea4 Localisation updates from https://translatewiki.net.
Change-Id: If723a7d49df24ced6fa830d88b3a7db09da14b61
2019-07-22 22:40:29 +02:00
David Lynch ba9b0c280b Tracking for change events in citation-templates
Bug: T221305
Change-Id: I4aa099ae1f7a6a2bb49b28c6d1452d077ffa61b7
2019-07-22 12:03:34 -05:00
Translation updater bot 52a404cc35 Localisation updates from https://translatewiki.net.
Change-Id: I55156b2b1ac53124a612d9b1be9f0423f34865e4
2019-07-18 08:52:52 +02:00
David Lynch eb37c893ea Extra tracking for VisualEditor's feature use
Bug: T221305
Change-Id: I1c681ec2da5fd7701d6c6b53f1f8a160dc885610
2019-07-08 11:04:52 -05:00
Translation updater bot e3e502e935 Localisation updates from https://translatewiki.net.
Change-Id: I47c46b7c78ed84b9246ed5e2f473473b1705a897
2019-07-07 22:38:08 +02:00
jenkins-bot dbf08269a6 Merge "Dialogs: Use close flag for close actions" 2019-07-02 19:01:35 +00:00
jenkins-bot 028a1828e0 Merge "Remove citefromid alias support" 2019-06-28 18:52:41 +00:00
Translation updater bot afcaf6fef9 Localisation updates from https://translatewiki.net.
Change-Id: Ia9579d616be7b871e76832dde09115bac8b7775a
2019-06-24 08:37:42 +02:00
Ed Sanders 6af3bc1fe4 Remove citefromid alias support
Change-Id: I20aa82a3fdc16897abcb36874c17be31d41fda43
2019-06-20 16:08:58 +01:00
Translation updater bot 5a1e6da148 Localisation updates from https://translatewiki.net.
Change-Id: Idcc0a16486605ab590e884012025265e1c26440f
2019-06-17 22:33:36 +02:00
Translation updater bot 8c150438ee Localisation updates from https://translatewiki.net.
Change-Id: I58d680d672d535c56c50282ffd4e01f3cf6c3e14
2019-06-16 22:35:29 +02:00
Translation updater bot 8517cb060c Localisation updates from https://translatewiki.net.
Change-Id: I10b9debec1a9d78660b7e75de0e47852c70b0971
2019-06-13 22:38:36 +02:00
Translation updater bot ced3252ea5 Localisation updates from https://translatewiki.net.
Change-Id: I4d3a616b4bd545cce10b060a116a1dc7a70a02b7
2019-06-10 22:53:57 +02:00
Ed Sanders d92e930bb6 Dialogs: Use close flag for close actions
Bug: T225021
Change-Id: I7915656896b502d6f2e19e38aae09d09d2bb8c49
Depends-On: I67b8474b0662f8dbc23c1b5ff883e3d4093bdbd4
2019-06-10 16:00:38 +01:00
Translation updater bot 44f1d91e2f Localisation updates from https://translatewiki.net.
Change-Id: I5758a4a40329d591ce6c5e788233659ac023d39a
2019-06-02 22:29:05 +02:00
Translation updater bot 5cf69a42ee Localisation updates from https://translatewiki.net.
Change-Id: I11ce3442806fc356ea339cc6c5b1d82490d1cd69
2019-05-30 22:52:57 +02:00
jenkins-bot 6c2ba09132 Merge "Remove dead extra comparison from VE JavaScript code" 2019-05-28 23:18:17 +00:00
Translation updater bot 66470a318e Localisation updates from https://translatewiki.net.
Change-Id: Ia66a31164fd94fd3db1a4d9bb8b9bc4d9eeba885
2019-05-23 23:06:16 +02:00
Translation updater bot c92f5cf602 Localisation updates from https://translatewiki.net.
Change-Id: Ib2456fd28329d1fc654fb2ad45d2eebfba7a9db4
2019-05-22 22:30:12 +02:00
Translation updater bot 23276790ae Localisation updates from https://translatewiki.net.
Change-Id: I259607c53cbe2d093de3c60100bc95fd109306b3
2019-05-20 22:28:31 +02:00
Thiemo Kreuz d622356a73 Remove dead extra comparison from VE JavaScript code
The first code snippet in this while already covers this case. The loop
will end the moment it can't find another parent any more.

This was found via
https://sonarcloud.io/project/issues?id=mediawiki-extensions-Cite&types=BUG
as a potential bug. After looking at the code I'm sure it's not one.

Change-Id: Id914252c88b27420dfa47dcc918fc58d9ee2a65d
2019-05-17 13:48:37 +00:00
Translation updater bot e834fbe25e Localisation updates from https://translatewiki.net.
Change-Id: Ic8de74a3c17cc3056a5a8d1e563b97b62ebfada2
2019-05-16 09:09:40 +02:00
Translation updater bot d32f5e0fcf Localisation updates from https://translatewiki.net.
Change-Id: Icae5f51f8f30b5fb857f7e2b64809556cc4f9450
2019-05-15 09:12:12 +02:00
Translation updater bot 0b423bbf7d Localisation updates from https://translatewiki.net.
Change-Id: Ife455e4cf5038cebb30702cca3ee5a54d414fe4f
2019-05-12 22:33:03 +02:00
Translation updater bot ccc25d094b Localisation updates from https://translatewiki.net.
Change-Id: Id6d87011739efc1e4742f68d1e8ebd74fa1bf894
2019-05-10 09:18:38 +02:00
Translation updater bot 7c8b492030 Localisation updates from https://translatewiki.net.
Change-Id: I05157c46b13124f87cc1b159057bb8d4cdce65a9
2019-05-06 09:03:29 +02:00
Translation updater bot becce25ed4 Localisation updates from https://translatewiki.net.
Change-Id: I794ccaac2d8c91b02a5e1ab23242963b8dd7908c
2019-04-30 22:17:32 +02:00