Commit graph

2676 commits

Author SHA1 Message Date
WMDE-Fisch 6dda36a1e7 Improve a11y support on backlinks
This changes the a11y support on the main backlinks by introducing the usage
of title and aria-labels. The support for these elements increased a lot since
the topic was first tackled and seems the appropriate way to go.

A new message was introduced for the link that will be set when directly
coming from a clicked refrence to emphasize that the can jump back to where
he came from.

Bug: T206323
Change-Id: Ifa56d41bcdb8100e19f29619796b62bb3c886d2f
2018-11-26 11:36:26 +01:00
Translation updater bot 0f3961df4e Localisation updates from https://translatewiki.net.
Change-Id: I703db0a48870ec600f2596bef7538b27f12ee569
2018-11-25 22:33:45 +01:00
Thiemo Kreuz (WMDE) 8760fe5e62 Rearrange Cite::listToText for performance
The two message are not needed in case there is only one element.
Since fetching messages is a little expensive, I feel it's worth
rearranging this code.

Or not, because it seems this method is never called with one
element only.

Change-Id: Ie915278b41f053afe0d14a29d2aec54c98e5185e
2018-11-21 18:16:55 +00:00
jenkins-bot 1fe6947693 Merge "Use \d shortcut in regular expressions" 2018-11-21 18:13:00 +00:00
jenkins-bot 7c7f258aac Merge "Remove unused parameter from two private Cite functions" 2018-11-21 18:03:30 +00:00
Thiemo Kreuz (WMDE) 436453e758 Use \d shortcut in regular expressions
This does not change anything, but is only for readability.

Change-Id: I7970df426246c16f5418665c9af069c13e0b9933
2018-11-21 17:59:42 +00:00
jenkins-bot ea5c84fdaf Merge "Use more specific type hints in PHPDoc tags" 2018-11-21 17:44:55 +00:00
Thiemo Kreuz (WMDE) 7c06347fc7 Simplify weirdly complex [\n\t ] regex
This change does have two consequences:

1. A few more whitespace characters act as separators. This should not
have any consequence in real life situations, and is mainly done to
make the code easier to read and less surprising.

2. Sequences of two or more whitespace characters previously resulted
in partly *empty* results. This was a potential source of errors. The
additional + fixes this.

Change-Id: Ib58326109c740dd0cbd05d8fddb4af2145f232fe
2018-11-21 17:33:25 +00:00
Thiemo Kreuz (WMDE) 0f76d79169 Use more specific type hints in PHPDoc tags
Change-Id: Ib0cf532fa51ddce135914edf357638a0862a200f
2018-11-21 18:19:25 +01:00
jenkins-bot 1bc1d1e075 Merge "Prefer "=== null" for consistency and readability" 2018-11-21 02:41:18 +00:00
jenkins-bot fd956ab507 Merge "ve.ui.MWReferencesListDialog: Disable 'Apply' button until changes are made" 2018-11-20 15:54:57 +00:00
jenkins-bot 7d7a38ad8f Merge "Add browser tests for linking the main backlink" 2018-11-20 14:41:17 +00:00
jenkins-bot 222b9ca593 Merge "Make arrows/carets links whenever we know where the user came from" 2018-11-20 12:42:21 +00:00
WMDE-Fisch 89deb7ca4c Add browser tests for linking the main backlink
This also includes putting the backling tests in their
own file due to the common setup needed.

Bug: T205271
Change-Id: Ica98c31bf0fddde9eb80f9c53b3dc089cb60e30c
2018-11-20 13:21:30 +01:00
Thiemo Kreuz (WMDE) 2b34dede6c Sanitize underscores as core does, to not create broken links
Core sanitizes link targets and removes double spaces and underscores.
But the corresponding id="…" attributes are not sanitized the same
way. This results in broken links. This patch is not perfect (two
references with name="a_b" and name="a__b" will conflict), but the
best solution I can think of at the moment.

Bug: T184912
Change-Id: I9dbc916ad99269517d84c8ffb8581628d44a9f4e
2018-11-20 13:07:35 +01:00
Thiemo Kreuz (WMDE) 30c6323e82 Prefer "=== null" for consistency and readability
Change-Id: I59a7d072ec859f59ff6692d7fa79708ec184322e
2018-11-20 11:48:19 +01:00
jenkins-bot 18a53d7666 Merge "Localisation updates from https://translatewiki.net." 2018-11-19 22:23:55 +00:00
Translation updater bot 2cf53b996b Localisation updates from https://translatewiki.net.
Change-Id: If314a6b7ad16b2470688cc32ced4a5560b773cbc
2018-11-19 22:11:05 +01:00
jenkins-bot e728ef92f8 Merge "Add browser test for highlighting of jump mark symbols" 2018-11-19 17:37:15 +00:00
jenkins-bot 7b18946a8b Merge "Add first browser test" 2018-11-19 17:37:14 +00:00
Thiemo Kreuz (WMDE) 2b3a62c26b Make arrows/carets links whenever we know where the user came from
I tried to arrange the new code in a way that it is compact, but still
readable. I think it's possible to arrange it even better, but browser
tests should be added first, in my opinion.

Bug: T205271
Change-Id: I1d579ef9d2787fc43c0a8bbf61c583f602dca5d4
2018-11-19 16:27:59 +00:00
jenkins-bot 8b97f74dc9 Merge "Highlight backreference jump marks by making them bold" 2018-11-19 16:24:24 +00:00
WMDE-Fisch 9c4620966f Add browser test for highlighting of jump mark symbols
Bug: T205270
Change-Id: Ieccf2c507dafac70d287eb0fa0fff051442205da
2018-11-19 16:08:49 +00:00
Andrew Kostka 626d9d4188 Add first browser test
This adds a test which checks if the extension appears on the
Special:Version page.

This is an initial step for adding more browser tests to check
changes done in I26fe41c328157233cc5b06d38d2ba0f7b036a853

Change-Id: I9a9d1cd2a25277f2c430f4e80b51b72c1621f91b
2018-11-19 16:08:42 +00:00
Thiemo Kreuz ee8da566e3 Highlight backreference jump marks by making them bold
The separate "ext.cite.a11y" module is kept for (temporary)
compatibility with cached HTML, and should be removed in about
a month.

Browser tests will be added in a separate patch.

Bug: T205270
Change-Id: I26fe41c328157233cc5b06d38d2ba0f7b036a853
2018-11-19 16:46:08 +01:00
Thiemo Kreuz (WMDE) a8da30d4fd Remove unused parameter from two private Cite functions
The iodea is to make the code simpler and easier to read. If no
code uses this feature, all it does is making the code unnecessary
complex.

Change-Id: I22747712a691443a29b57831d3a6926275ad986b
2018-11-19 16:28:24 +01:00
Translation updater bot 7ecdec713d Localisation updates from https://translatewiki.net.
Change-Id: I9cf5306d453310e154c2f49df23f1be6348200de
2018-11-18 22:48:21 +01:00
Translation updater bot 9deb4d476e Localisation updates from https://translatewiki.net.
Change-Id: Icd283ec309f0f89624a49eecf1b241396b36e24f
2018-11-17 22:19:38 +01:00
Bartosz Dziewoński fd19cd76c1 ve.ui.MWReferencesListDialog: Disable 'Apply' button until changes are made
Bug: T209660
Change-Id: I2c998cce812b63d1f5656ba38470a77ac5a0fd45
2018-11-16 00:49:08 +01:00
libraryupgrader 8cac9f4aee build: Updating mediawiki/mediawiki-codesniffer to 23.0.0
Change-Id: Ie7785a40557446e40db079b147610ba29b135ba4
2018-11-14 08:53:25 +00:00
Ed Sanders e0781b0c58 Fix typo in documentation
Change-Id: I25407db3025dace825afd0ca083eba4fc600955d
2018-11-13 23:42:35 +00:00
jenkins-bot 82c75661ee Merge "Remove obsolete aliases from closures" 2018-11-13 22:59:20 +00:00
Ed Sanders a589dbe636 Remove obsolete aliases from closures
Bug: T208951
Change-Id: Idd6bc36b116af81827b4440b4c8ec3da94e1486f
2018-11-13 14:43:45 -08:00
Translation updater bot 664b178c3d Localisation updates from https://translatewiki.net.
Change-Id: I6aae842e9a5d4a8a036ed6107222e9bc84ac57b9
2018-11-12 22:12:39 +01:00
Translation updater bot e61ab2c8f6 Localisation updates from https://translatewiki.net.
Change-Id: Iade9e083c123e608dfac57f8e27f4fbbf65e9932
2018-11-11 22:33:37 +01:00
Translation updater bot a9ae168208 Localisation updates from https://translatewiki.net.
Change-Id: Ib3be93269095ae9b86e407aab89d353b5530b56b
2018-11-10 22:28:03 +01:00
Translation updater bot 86bf110048 Localisation updates from https://translatewiki.net.
Change-Id: I0d4260c2bd9121a41ad9598f57edb6001748e186
2018-11-07 22:21:58 +01:00
Bartosz Dziewoński ec55fa3ce8 Use changed ve.dm.Selection interface
Bug: T208228
Bug: T208913
Change-Id: Ifb1a77a5f07b9e257c6e0477e23316f80c7a4791
2018-11-07 16:51:51 +01:00
Translation updater bot 774e301300 Localisation updates from https://translatewiki.net.
Change-Id: Ia5f2da9fb4166a5c53f681705ece9591b99f4b9c
2018-11-04 22:42:03 +01:00
Translation updater bot 5e9add6454 Localisation updates from https://translatewiki.net.
Change-Id: Ic2dc4045f2baa1467329bd4619f59e846a5118c4
2018-11-03 11:02:43 +01:00
Pipix 978816149c Convert HTTP Links To HTTPS
1 link to www.mediawiki.org is converted from http:// to https://

Bug: T189687
Change-Id: I24e08db41b4d46abea356cd05c37916f740a1d7a
2018-10-30 20:10:17 +08:00
Ed Sanders 4df9bf5f69 Fix wikitext paste test
Bug: T204007
Depends-On: I97a92512d7b114ed46bc48d3d416eebc86df13f7
Change-Id: I06177cb4428798f62b78f5dc48f545a6cb6884fc
2018-10-29 21:39:40 +00:00
Translation updater bot 9ee0d799a7 Localisation updates from https://translatewiki.net.
Change-Id: Ib0be56800d53b316fb4f473c8ab2940b5cac1dd7
2018-10-28 22:21:44 +01:00
Translation updater bot f99e841595 Localisation updates from https://translatewiki.net.
Change-Id: I98eea39834c94aa8c33b40af5a0ffd3440c2f38e
2018-10-27 22:59:39 +02:00
Translation updater bot 09964ca80d Localisation updates from https://translatewiki.net.
Change-Id: I1a74c35bbb16714cbe0777e6eb2305585644ccf7
2018-10-26 22:24:05 +02:00
James D. Forrester 05c006abd6 i18n: Use &lt; rather than <nowiki>< for security testing sanity
Change-Id: I260669a240b7c3a661928140ac2e540ffe064c35
2018-10-25 15:22:05 -07:00
Translation updater bot d7abcdea98 Localisation updates from https://translatewiki.net.
Change-Id: Ic6dc3591f9ec88fa6bc2d19d394811ad5f82c1fe
2018-10-25 22:38:41 +02:00
Translation updater bot 9ba05318fd Localisation updates from https://translatewiki.net.
Change-Id: Ibe1df91706b639030e79c205005d9cdcb5e20cf1
2018-10-18 22:34:07 +02:00
Translation updater bot c9ff3c836f Localisation updates from https://translatewiki.net.
Change-Id: I790e0207e282c378bb98d641c018c1bf907a74de
2018-10-16 22:17:17 +02:00
jenkins-bot 7d7756e53f Merge "Unstrip <ref> contents before comparing" 2018-10-15 16:25:42 +00:00