daniel
e954ecfe19
Fix UserIdentityValue constructor call in test
...
Change-Id: If905e442444d319114e86ce78007bdc6dbc9c9f2
Needed-By: I9925906d11e47efaec3c1f48d5cb3f9896a982c1
2021-03-25 15:13:15 +01:00
jenkins-bot
92ffc1a7ed
Merge "Don't directly instantiate PageEditStash"
2021-03-25 10:51:09 +00:00
Translation updater bot
bad4b1baba
Localisation updates from https://translatewiki.net .
...
Change-Id: I24e397e4e47e3182c810f056e4ceaa202717f844
2021-03-25 08:40:09 +01:00
Petr Pchelko
e92d74ad51
Don't directly instantiate PageEditStash
...
Needed-By: I7164b914299441bd0f82e764252c8b5d30b45fbe
Change-Id: Iab96a35be8f50fdbc66194bd8956d98b5b6b0032
2021-03-24 21:03:46 -06:00
DannyS712
db8d373a87
LazyVariableComputer: update parseNonEditWikitext documentation
...
Article::prepareContentForEdit is deprecated and being removed,
refer to WikiPage::prepareContentForEdit instead
Plus remove an extra line
Change-Id: Ie4438c710639a16557816b53510ce230d15d641c
2021-03-24 17:32:31 +00:00
Translation updater bot
4f8f420e2e
Localisation updates from https://translatewiki.net .
...
Change-Id: I53181de75750e17a88294a356c1ca25ab9c50ac2
2021-03-24 08:29:21 +01:00
Translation updater bot
5780e3549a
Localisation updates from https://translatewiki.net .
...
Change-Id: I12ea7fd4eb667b30ce35890fa0062625e4da6897
2021-03-22 08:35:17 +01:00
Daimona Eaytoy
8b81df4d16
Fix fatal when computing user_editcount for anons
...
UserEditTracker checks that the user is not anonymous, whereas
User::getEditCount() would just return null. This was not spotted by
tests because UserEditTracker is mocked.
Bug: T277859
Follow-up: I8a55bd5cb17bbc259ec36c40261058e0b46ee4a6
Change-Id: I05fb6cc780c80b72b3278e6dc670ed2025628ffb
2021-03-19 13:09:03 +01:00
jenkins-bot
fa8358ce0c
Merge "Replace RecentChange::getPerformer with RecentChange::getPerformerIdentity"
2021-03-18 14:15:11 +00:00
jenkins-bot
b23278d5a8
Merge "Apply proper visibility checks for recentchanges queries"
2021-03-18 10:03:54 +00:00
Vadim Kovalenko
85be3c57bc
Replace RecentChange::getPerformer with RecentChange::getPerformerIdentity
...
Bug: T276412
Change-Id: I8a55bd5cb17bbc259ec36c40261058e0b46ee4a6
2021-03-15 16:57:40 +02:00
Translation updater bot
d11aac3a5d
Localisation updates from https://translatewiki.net .
...
Change-Id: I97e71f3e371aabef2a99424466911da0262c8d1e
2021-03-15 08:39:28 +01:00
jenkins-bot
c0cb48abaf
Merge "UserIdentityValue: do not provide actor ID"
2021-03-13 21:30:27 +00:00
jenkins-bot
1c5e5eb1e2
Merge "Create distinct builders for plain and ace editor"
2021-03-13 13:36:53 +00:00
daniel
05e416ef11
UserIdentityValue: do not provide actor ID
...
Depends-On: Ic2ca6d489db821fc2334e53bf2496c7b0d3ea5b1
Change-Id: I76e0a5b0dd68b763bdd0c5e4fe5d09f98e350ce1
Needed-By: I9925906d11e47efaec3c1f48d5cb3f9896a982c1
Bug: T274179
2021-03-12 16:38:51 +01:00
Translation updater bot
beab67757e
Localisation updates from https://translatewiki.net .
...
Change-Id: Ifb6bce639cb36070aed2a584e1433f4ae1cf1206
2021-03-12 08:44:36 +01:00
Daimona Eaytoy
3413d15b68
Apply proper visibility checks for recentchanges queries
...
Follow-up: I6063c02fa261c4cc0e6dbbb2db4e111eb85912c2
Bug: T274152
Bug: T274158
Change-Id: I71a6d521bd12931ce60eec4d2dc35af19146000f
2021-03-11 11:52:48 +01:00
Translation updater bot
e28d15c55e
Localisation updates from https://translatewiki.net .
...
Change-Id: I762b4898d206f735e307f551027119213b0ec8d1
2021-03-11 08:35:48 +01:00
libraryupgrader
aeccd5b8b9
build: Updating eslint-config-wikimedia to 0.19.0
...
Additional changes:
* eslint: Renamed `wikimedia/client` profile to `client-es5` (T277085).
Change-Id: I2ef2da7d95f8f40fe9ccfa9c9a5aff34bef42ef3
2021-03-10 23:05:48 +00:00
Translation updater bot
105471ccb5
Localisation updates from https://translatewiki.net .
...
Change-Id: I0ca04a44d19720cd3520ee38deb0a8cc41393c6f
2021-03-10 08:31:25 +01:00
jenkins-bot
12f230b94b
Merge "SECURITY: Remove deleted rows from /examine and /test"
2021-03-09 23:03:42 +00:00
jenkins-bot
577aa83309
Merge "SECURITY: Avoid deleted usernames leak in page_recent_contributors"
2021-03-09 22:50:20 +00:00
jenkins-bot
01d9cb2a89
Merge "SECURITY: Skip deleted RCs in /test if we're only showing matches"
2021-03-09 22:50:17 +00:00
jenkins-bot
ecd84180c7
Merge "SECURITY: Avoid info leaks in ApiAbuseFilterCheckMatch"
2021-03-09 22:41:37 +00:00
jenkins-bot
b9bd4b9492
Merge "SECURITY: Don't filter suppressions"
2021-03-09 22:41:35 +00:00
Daimona Eaytoy
33445addff
SECURITY: Remove deleted rows from /examine and /test
...
This is kind of a nuclear option, if anything in a row is hidden, we
hide the whole row. This is just to keep this patch slim. A public
follow-up will adjust the visibility
Bug: T274152
Change-Id: I6063c02fa261c4cc0e6dbbb2db4e111eb85912c2
2021-03-09 16:10:16 -06:00
Daimona Eaytoy
f25c96f472
SECURITY: Avoid deleted usernames leak in page_recent_contributors
...
Bug: T71367
Change-Id: I8d5ed9ca84282ee50832035af86123633fc88293
2021-03-09 15:56:09 -06:00
Daimona Eaytoy
18f439053e
SECURITY: Skip deleted RCs in /test if we're only showing matches
...
Otherwise we'd be telling whether the filter matches or not the edit. If
we're showing all edits regardless of whether they match the filter, we
can keep showing the row: it will be redacted (and the filter result
hidden) by AbuseFilterChangesList.
Bug: T223654
Change-Id: I3f7dbd8b873d411e37c8c3aac2339bf5ec36907d
2021-03-09 15:46:21 -06:00
sbassett
64f3f7e6c5
SECURITY: Avoid info leaks in ApiAbuseFilterCheckMatch
...
There are various info leaks for both deleted rc rows, and suppressed
AbuseLog entries.
Bug: T223654
Change-Id: I4900b1be73323599d74e3164447f81eded094d75
2021-03-09 15:41:31 -06:00
Daimona Eaytoy
59e45409a6
SECURITY: Don't filter suppressions
...
Bug: T71617
Change-Id: I38a0a24fa32ca7a052b6940864a32b3856e84553
2021-03-09 15:38:55 -06:00
Daimona Eaytoy
c5d19577a4
Fix method names of hook interfaces
...
The hook names contain a dash, which is mapped to an underscore by the
hook runner (see Ie8c8fb603b33ff95c8f8d52f392227f147c528d8), and the
previous method names weren't matching this.
Follow-up: Ic5c82a367e34135bbc0f00ece5aeef4f2d92881b
Change-Id: Ie80b62c49b2f4aaea49d5a1883f513348689d16a
2021-03-09 17:03:14 +00:00
jenkins-bot
5c355d3acb
Merge "Use Language::userTimeAndDate"
2021-03-09 12:22:38 +00:00
Translation updater bot
be4f6a387b
Localisation updates from https://translatewiki.net .
...
Change-Id: I0bad8181ddf6f22ad959285994ca0df254204713
2021-03-09 08:31:31 +01:00
Umherirrender
5e12102b6d
Use Language::userTimeAndDate
...
Avoid use of global user
Change-Id: Ic30cfe705dfe39fca7dd45c6c2e1248dd37f08ff
2021-03-09 00:54:03 +01:00
Daimona Eaytoy
25d1abde0b
Fix hook name
...
Dashes are mapped to underscores, but following the "modern" convention,
the hook name should be pure PascalCase.
Bug: T275798
Change-Id: I77909b3ee772b983c7933f3b82230476772bd3b5
2021-03-08 16:15:23 +00:00
Vadim Kovalenko
62376f437e
Replace UserIdentity::getUserId with ::getId
...
Bug: T275482
Change-Id: Ie9fd52005ca1eb264dc791a2f87d7308a9e8810e
2021-03-08 09:18:49 -05:00
Daimona Eaytoy
6ba8e93537
Create distinct builders for plain and ace editor
...
Change-Id: I9d2b7572fed6e0b3660d3b0d5dad324d6b75fde9
2021-03-08 09:44:58 +00:00
Translation updater bot
7356f87082
Localisation updates from https://translatewiki.net .
...
Change-Id: Ia323cd056d4ce166fe00253d34ddc2ab1b741dac
2021-03-08 08:44:51 +01:00
jenkins-bot
12f4e81964
Merge "Simplify AbuseFilterBlockTest"
2021-03-06 09:23:26 +00:00
Daimona Eaytoy
92ecccbdc7
Simplify AbuseFilterBlockTest
...
Requires injecting a temporary block factory, and excluding
ManualLogEntry::insert from the test, but it's now much cleaner and
quicker.
It still cannot be a unit test due to the usage of User.
Change-Id: Iba9732d6d79733b31b45eb4d0187b1c8a82499dc
2021-03-05 14:18:01 +00:00
Translation updater bot
51f37697dc
Localisation updates from https://translatewiki.net .
...
Change-Id: I89853907ba659a8b715622e386db41c97eeef3bd
2021-03-05 08:54:53 +01:00
libraryupgrader
ebea8cd3de
build: Updating eslint-config-wikimedia to 0.18.2
...
Change-Id: I83981fb720ee219230f9f6094c18fdf29d7f4ba0
2021-03-05 04:35:46 +00:00
Translation updater bot
17cf903cd4
Localisation updates from https://translatewiki.net .
...
Change-Id: Iffa9ae7a3620ef16f6de04cf38ce13d9d711429f
2021-03-04 08:37:05 +01:00
Translation updater bot
507e3fb0c5
Localisation updates from https://translatewiki.net .
...
Change-Id: Id111612a538f205ac19d9bad761cc94e6f1110d2
2021-03-02 08:48:17 +01:00
Daimona Eaytoy
124031fe09
Stop using deprecated User::addGroup in tests
...
Bug: T276094
Change-Id: I299f89fbb4a4f6ba36ef4b77987bda9f2159d311
2021-03-01 15:28:08 +01:00
Translation updater bot
d518c0f60c
Localisation updates from https://translatewiki.net .
...
Change-Id: Id543fd03b70ef4d3ef6639dd1510c10bffc0e9fa
2021-03-01 08:49:36 +01:00
jenkins-bot
50334c27ce
Merge "Use a different message for unprivileged users"
2021-02-28 14:05:08 +00:00
jenkins-bot
ef4a5c4115
Merge "Make FilterProfiler independent of DeferredUpdate"
2021-02-28 13:18:51 +00:00
Matěj Suchánek
709803eb46
Make FilterProfiler independent of DeferredUpdate
...
Schedule the deferred update from FilterRunner, just like
we do with EmergencyCache.
Change-Id: I121211bb02a77c191001d11d4af3796e8572967e
2021-02-28 12:03:05 +01:00
jenkins-bot
66f8e44295
Merge "Reject filters with invalid groups"
2021-02-27 20:07:29 +00:00