Commit graph

4279 commits

Author SHA1 Message Date
Translation updater bot 03158e1272 Localisation updates from https://translatewiki.net.
Change-Id: I75bc6d1a4fb91ea0a32efc0a37ae10b312a12910
2018-06-15 22:35:34 +02:00
Translation updater bot c31f384f5d Localisation updates from https://translatewiki.net.
Change-Id: I5dae60f0f98a523ad3f851d88326a32e9e0e1f20
2018-06-14 22:44:15 +02:00
jenkins-bot 519db0c6fc Merge "Make the "Load filter ID:" field on Special:AbuseFilter/test wider" 2018-06-13 23:03:08 +00:00
Translation updater bot 18b46d71cb Localisation updates from https://translatewiki.net.
Change-Id: I68db4a2ea26ba7fc6a89f79f8cf3badf3791b42e
2018-06-13 22:22:27 +02:00
Bartosz Dziewoński abe72f2937 Make the "Load filter ID:" field on Special:AbuseFilter/test wider
The translation can be a lot longer in languages which have no common
abbreviation like "ID" for the word "identifier". For example, the
label currently wraps over 3 lines in Polish (pl).

Change-Id: I822aafb52bbe840c00d2f0edbaeec37e3748f96f
2018-06-13 02:32:48 +00:00
Daimona Eaytoy 29492513cf Add phan seccheck to composer and remove deprecated module
Seccheck is currently being executed as non-voting, but it always
succeeds because AbuseFilter is not requiring it in composer. Instead,
let's add it: tests will start to fail, but we'll be able to see how
things are going with it. As a bonus, remove the mediawiki.api.parse
module, which is deprecated in 1.32 and replaced by mediawiki.api
(already loaded).

Change-Id: I094a8af4f97c03f8b538ede00420b123de25138a
2018-06-12 15:37:03 +02:00
Translation updater bot e2232714f8 Localisation updates from https://translatewiki.net.
Change-Id: Iaa5e133700405433dae57dfcb9da0c6727ff25b4
2018-06-11 22:33:20 +02:00
jenkins-bot 9eb736d63d Merge "Enable OOUI and add unused button to the output" 2018-06-10 03:13:20 +00:00
jenkins-bot a4a6511972 Merge "Don't allow invalid IP ranges to be entered in ip_in_range()" 2018-06-10 00:33:27 +00:00
jenkins-bot 8fa73341cf Merge "Remove all not needed & from hook handler signatures" 2018-06-09 09:22:29 +00:00
Translation updater bot 2dfc0b62d8 Localisation updates from https://translatewiki.net.
Change-Id: I0ab4a872a8d5094ab084bf9e6f8c0795189da6e6
2018-06-09 10:26:30 +02:00
jenkins-bot 075ccac1a2 Merge "Show throttled filters in Special:AbuseFilter" 2018-06-08 20:21:53 +00:00
Max Semenik 5c8a8da1f2 Fix some Doxygen problems
Change-Id: I04ce5564ec73e45a6d94c51be94bd1423a86780a
2018-06-08 13:02:40 -07:00
Daimona Eaytoy cf4ac34420 Show throttled filters in Special:AbuseFilter
With this patch, filters which are both enabled and throttled have an
"actions automatically disabled" label together with "enabled" and the
row is displayed in red. Plus, some minor changes like removing unused
fields from sortable ones and added a comment to getQueryInfo about used
columns (the idea is that it'll be easy to understand if a given column
is already there, plus if we'll need the missing one we may just replace
it with '*').

Bug: T154206
Change-Id: Iab157d094cbf2d50e9db537535fd48243e74af0b
2018-06-08 21:54:58 +02:00
jenkins-bot 1981c9f8b8 Merge "Add an option to hide private filters on Special:AbuseFilter" 2018-06-08 19:46:53 +00:00
jenkins-bot 5820b21ae3 Merge "Remove all default "return true" from hook handlers" 2018-06-08 19:42:02 +00:00
jenkins-bot 617e045483 Merge "Get rid of call_user_func_array()" 2018-06-08 19:32:31 +00:00
Thiemo Kreuz 9a185042b8 Update \AbuseFilter::checkSyntax documentation
Change-Id: I5c5caefab8d46773a459809d956a91fda7471863
2018-06-08 19:18:39 +00:00
libraryupgrader 25ddc87667 build: Updating mediawiki/mediawiki-phan-config to 0.3.0
Change-Id: I31b5a108f79ca1360338ecf07add2c07efe5b1e5
2018-06-08 06:37:45 +00:00
Max Semenik 4c312a2693 Get rid of call_user_func_array()
Yay PHP7!

Change-Id: I2ec13d1a51981c6922949bed0c7dd2525c48f591
2018-06-07 23:01:27 -07:00
Thiemo Kreuz 7f600d2ebe Remove all not needed & from hook handler signatures
Most of these are accidential, obsolete from a time when PHP4 required
these & to enforce passing by reference. This is the default since PHP5.
The issue with this & is that is (in theory) allows hook handlers to
replace the object with an entirely different one. Luckily this does
not work in all cases I'm aware of. But it is confusing, semantically.

Change-Id: If1e9e2723ef96308f9b4b27377398a5e497bfe70
2018-06-07 13:29:22 +02:00
Thiemo Kreuz 7ec9725c42 Remove all default "return true" from hook handlers
This is the default for many years now. Returning true is not different
from returning nothing.

I'm not touching functions that can either return true or false.

Change-Id: I6c70b8ef44f17271201a69a85301a631b32763c0
2018-06-07 13:26:13 +02:00
Translation updater bot 1eb684447e Localisation updates from https://translatewiki.net.
Change-Id: Ic3643bd782a3366e4eca15589e037131e30cc56f
2018-06-06 23:05:43 +02:00
Translation updater bot 5a0efd342f Localisation updates from https://translatewiki.net.
Change-Id: Id76dc8fa759fceaa3e09c498a8e609a60ae9c628
2018-06-05 22:16:33 +02:00
Daimona Eaytoy 94b570673e Ace: use built-in function indexToPosition
I copied that function from github, but I realised that ace already
includes it, so no reason to have unnecessary function declarations.
Also, this fixes a minor bug that prevents the caret from moving to the
very last character when checking syntax.

Change-Id: Ia243b75803008b801dc24faaacbe7844618ccb45
2018-06-04 11:21:44 +00:00
Daimona Eaytoy 9fe281e704 Enable OOUI and add unused button to the output
In If67035991a0835ec3edc13be4543e6b40c76c3ea I changed a couple of links
to OOUI buttons, but forgot to add one of these to the output (and to
enable OOUI as well).

Change-Id: I7dd4b554bae406bc0c8326867298302ee10b47f2
2018-06-04 11:21:41 +00:00
Daimona Eaytoy 74569e20a7 Improve the check for block durations equality
With I5e3764dbec8ac21f20c460181ae78ed73eca92f6 I introduced a function
to check that two blocks with different wordings refer to the same
duration. While that functions works good 99.9% of the time, there's a
highly unlikely but actual problem: if one of the operand is parsed at
time x and the other at time x+1 (in seconds, and this may happen even
if it gets parsed 1 ms later), the 2 durations will be considered
different and this may be annoying. With this patch I introduce another
tiny function which uses strtotime to parse a duration, but uses the
second parameter (=0) to avoid relativeness to the current time. Again,
this isn't likely to occurr, but since the fix is straightforward we'd
better do it. Also, now global durations aren't parsed at every
iteration (previously they were due to the same problem, amplified by
time distance between the first and the last iteration).

Change-Id: I11a078f298aaed9631d7f422c6b9b722d28e73cc
2018-06-04 11:21:37 +00:00
Daimona Eaytoy 43ec6cf830 Add an option to hide private filters on Special:AbuseFilter
While the change itself is simple, the only problem here is the desing,
since we're adding even more vertical space with this.

Bug: T164108
Change-Id: Ic5373dd4f0b85dc1311d90ac165d4520ac956e68
2018-06-04 11:21:18 +00:00
Huji Lee 2792fce41e Introduce sanitize() function
Normalizes HTML entities into unicode characters

Bug: T169122
Change-Id: Ic916a6f8976e486d62d65156fa2dab56a55cf22a
2018-06-03 16:37:23 -04:00
Translation updater bot 384c70ffc8 Localisation updates from https://translatewiki.net.
Change-Id: I67b2295ebf1e824c76a01a9ac252fbae3cd751aa
2018-06-03 22:35:54 +02:00
Translation updater bot 7afce94ecd Localisation updates from https://translatewiki.net.
Change-Id: I4b0f7fbdc24808810c45af23c321fb40bb1c350f
2018-06-02 22:41:09 +02:00
Translation updater bot e23ca56bbb Localisation updates from https://translatewiki.net.
Change-Id: I2983fba32d2a5883085058e872d5ee024f9ff599
2018-06-01 22:27:20 +02:00
Translation updater bot dee7bc6a33 Localisation updates from https://translatewiki.net.
Change-Id: Ic95c2e6a86b7c029b9ef00124bf5e4d47f48c350
2018-05-31 22:28:17 +02:00
Max Semenik 94f3bc67ca Use PHP7 ?? operator
Change-Id: I757b832ac86f52d8b70ffc42fdb60796ab81e7fe
2018-05-31 11:53:03 -07:00
Translation updater bot ecb919e5de Localisation updates from https://translatewiki.net.
Change-Id: I29c343434513ac82400698e534cd24b73066b6ae
2018-05-29 22:24:34 +02:00
Translation updater bot 296605472d Localisation updates from https://translatewiki.net.
Change-Id: I9322124272a25293829094b9f6e62880fb686bc7
2018-05-28 22:41:43 +02:00
jenkins-bot 7682a61786 Merge "Reset condCount when entering checkAllFilters" 2018-05-27 11:03:56 +00:00
libraryupgrader 99c212226d build: Updating mediawiki/mediawiki-codesniffer to 20.0.0
Change-Id: Ib1d0dfa76babc01c30f4e905e8f6fb80e1e9a0bc
2018-05-25 23:31:49 +00:00
Translation updater bot 751b27181f Localisation updates from https://translatewiki.net.
Change-Id: I5763f4f16c825492bda7dd2ddd6fdbb19b241d0c
2018-05-25 22:13:56 +02:00
jenkins-bot 424e5eab70 Merge "Simplify contentToString function" 2018-05-25 12:12:22 +00:00
jenkins-bot 027d0d55e4 Merge "Sync up sqlite schema" 2018-05-24 22:03:56 +00:00
Translation updater bot 2bd7ec820a Localisation updates from https://translatewiki.net.
Change-Id: Ic3c3bbcef9b6338c25ebc142ffb3c788a1a52ae8
2018-05-24 22:24:42 +02:00
jenkins-bot 96a91ac9b2 Merge "Allow IP addresses in user selectors" 2018-05-24 18:15:33 +00:00
jenkins-bot 16d496e436 Merge "Compare with null instead of using $config->has" 2018-05-24 17:08:45 +00:00
Matěj Suchánek 45b8855754 Allow IP addresses in user selectors
Also unify username normalisation in Special:AbuseLog with /examine and /test.

Change-Id: I85e10ba9262c698b8c279b5cad9fae4a0ab3d7b0
2018-05-24 18:53:23 +02:00
Reedy f258d36ed0 Sync up sqlite schema
Change-Id: I026472dec2629a969c46feb046f7fe64d8ab8144
2018-05-24 14:34:14 +00:00
Translation updater bot cce90f853a Localisation updates from https://translatewiki.net.
Change-Id: Ibacdb826324e656612208d32ca8b5d50eec80b99
2018-05-23 22:20:05 +02:00
Translation updater bot 55715e1b38 Localisation updates from https://translatewiki.net.
Change-Id: I9119e8d680c27fea459dcc9bb4fb8cb6e9073693
2018-05-21 22:10:12 +02:00
Daimona Eaytoy ba9df944c8 Compare with null instead of using $config->has
With I91a9c5cca55e540a6c95b750579c1c369a760b15 we replaced some globals
with Config and, in doing this, we added "$config->has()" to check if a
variable was null. However, "has" will always return true even if the
value is null (it only checks if it exists), and thus we end up showing
a global abusefilter pager even if no central DB is set.

Bug: T195022
Change-Id: I751fdefd29b6af1361021d4343ba67f16c99a037
2018-05-21 12:11:45 +02:00
Translation updater bot 0804a7ea12 Localisation updates from https://translatewiki.net.
Change-Id: I1c2421a7f3d47a85be339ac5f37548a8ab73dab4
2018-05-20 22:44:15 +02:00