Commit graph

4342 commits

Author SHA1 Message Date
Andrew Garrett 92698e95ba Improve AbuseFilter performance by implementing lazy initialisation of computed variables.
This has been done by replacing simple associative arrays with an AbuseFilterVariableHolder, which recognises helper classes called AFComputedVariables.
Computation may occur during the abuse filter analysis, or later when testing and reviewing filters.
2009-02-26 12:15:14 +00:00
Raimond Spekking 3beeec7250 Remove unused message 2009-02-26 09:54:30 +00:00
Siebrand Mazeland 4481cb5afa Localisation updates for extension messages from translatewiki.net (2009-02-25 22:32 UTC) 2009-02-25 22:58:35 +00:00
Raimond Spekking 68909a26dd * Remove full stops from 2 messages
* Add colon to 1 message
for consistency with similar messages
2009-02-25 21:52:44 +00:00
Andrew Garrett 98a94ff5d9 Fix Abuse Filter after-the-fact var generation -- was using request IP address in place of IPs for anonymous changes 2009-02-25 04:31:53 +00:00
Andrew Garrett e0cd6a327c Fatal 2009-02-25 02:40:05 +00:00
Andrew Garrett 057f9f80db Normalise usernames before searching for them in Abuse Filter examine and test interfaces. 2009-02-25 02:33:09 +00:00
Raimond Spekking 4f7bf955de Localisation updates for extension messages from translatewiki.net (2009-02-24 19:52 UTC) 2009-02-24 20:22:25 +00:00
Siebrand Mazeland 0ffb9504ff Localisation updates for extension messages from translatewiki.net (2009-02-23 21:43 UTC) 2009-02-23 22:00:14 +00:00
Raimond Spekking 8c2f0144cd Localisation updates for extension messages from translatewiki.net (2009-02-22 21:02 UTC) 2009-02-22 20:27:34 +00:00
Siebrand Mazeland ff9c349a2c Localisation updates for extension messages from translatewiki.net (2009-02-21 17:44 UTC) 2009-02-21 18:23:03 +00:00
Raimond Spekking fb96e5aab9 Localisation updates for extension messages from translatewiki.net (2009-02-20 20:09 UTC) 2009-02-20 20:33:43 +00:00
Andrew Garrett 2f4a66e862 Do not display tools if there are not any 2009-02-19 23:52:08 +00:00
Siebrand Mazeland e5ab9fa681 Localisation updates for extension messages from translatewiki.net (2009-02-19 21:36 UTC) 2009-02-19 22:12:31 +00:00
Rotem Liss 56c1db6bec Localization update for he. 2009-02-19 12:25:30 +00:00
Andrew Garrett 20c9542fe3 Another silly reautoconfirm bug -- nothing was being returned. 2009-02-19 00:18:31 +00:00
Andrew Garrett feae69f031 Silly syntax error 2009-02-18 23:32:56 +00:00
Andrew Garrett 08d6218ee1 Always include afh_pattern in the fields to select. 2009-02-18 21:43:32 +00:00
Andrew Garrett 05ea5b783d Add rmwhitespace function 2009-02-18 19:42:01 +00:00
Andrew Garrett 1c87a7ba69 Fix some silly bugs in reautoconfirmation 2009-02-18 19:34:36 +00:00
Siebrand Mazeland 7442d14517 Localisation updates for extension messages from translatewiki.net (2009-02-17 21:00 UTC) 2009-02-17 21:23:38 +00:00
Siebrand Mazeland 11da5f1530 Localisation updates for extensions from translatewiki.net
* updates for special page aliases
2009-02-17 18:47:38 +00:00
Raimond Spekking 73b3d3ac89 Localisation updates for extension messages from translatewiki.net (2009-02-16 17:30 UTC) 2009-02-16 18:44:29 +00:00
Siebrand Mazeland 4639579c09 Localisation updates for extension messages from translatewiki.net (2009-02-15 18:43 UTC) 2009-02-15 19:02:29 +00:00
Siebrand Mazeland 5bbe5f2782 Localisation updates for extension messages from translatewiki.net (2009-02-14 11:51 UTC) 2009-02-14 12:03:26 +00:00
Raimond Spekking 22f57ec7d7 * Replace hardcoded '...' as indication of a truncation with the 'ellipsis' message
Per Brion's suggestion in http://lists.wikimedia.org/pipermail/wikitech-l/2008-December/040796.html
2009-02-13 19:13:48 +00:00
Andrew Garrett d3d4333f42 Fix silly fatal 2009-02-13 18:30:34 +00:00
Andrew Garrett 64154e283d Correctly deal with emergency disabling, hit counts, etc for filters with 'throttle' and 'warn' actions. 2009-02-13 01:40:57 +00:00
Rotem Liss cd8a17af7e Localization update for he. 2009-02-12 12:56:38 +00:00
Andrew Garrett 32d676942d Remove remnants of ctype_, and replace them with appropriate regexes (which, while slower, are locale-safe). 2009-02-11 20:01:00 +00:00
Andrew Garrett 35e61feeb6 Abuse Filter Parser updates
* Deprecate parseTokens in favour of a parse-as-you-go approach, faster and uses less memory.
* Display variables in lower_case so they aren't SHOUTING_AT_PEOPLE.
* Tell people if they try to use variables that don't exist, rather than silently returning NULL.
2009-02-11 20:00:33 +00:00
Rotem Liss e1d2743d7a Localization update for he. 2009-02-11 19:20:18 +00:00
Siebrand Mazeland 271a0a7aad Localisation updates for extension messages from translatewiki.net (2009-02-11 18:17 UTC) 2009-02-11 18:38:18 +00:00
Andrew Garrett 0880f444b1 Abuse Filter Parser updates:
* Use strcspn to scan ahead for long regions of uninteresting text in string handling (performance).
* Remove cruft specific to my system in phpTest.php.
* Remove a test that was in incorrect syntax, and useless without adding variable support.
2009-02-11 18:23:21 +00:00
Andrew Garrett bfe57be65d Rewrite of Abuse Filter parser tokeniser.
I've made it more performant and fixed a few bugs by using regexes
instead of PHP loops, where possible, under the assumption that the
PCRE parser is more efficient than the same thing implemented in pure PHP.
Also, I'm now passing the same string around and calculating offsets, which
Tim tells me is far more performant than continually truncating the same string.

All tests still pass, with the exception of string.t, which I've modified
to remove the offending code, which never worked.
2009-02-11 01:41:51 +00:00
Siebrand Mazeland 6c9266d8e3 Localisation updates for extension messages from translatewiki.net (2009-02-10 23:29 UTC) 2009-02-10 23:48:58 +00:00
Siebrand Mazeland 112e031ecd Localisation updates for extension messages from translatewiki.net (2009-02-10 06:41 UTC) 2009-02-10 07:01:19 +00:00
Siebrand Mazeland bc91dc3843 Localisation updates for extension messages from translatewiki.net (2009-02-08 22:48 UTC) 2009-02-08 23:02:36 +00:00
Siebrand Mazeland 1df448d530 Localisation updates for extensions messages from translatewiki.net (2009-02-07 21:24 UTC) 2009-02-07 22:04:21 +00:00
Tim Starling c8b0007232 * Break long lines. If I'm going to review this code, I need to be able to read it.
* Write array literals with one item per line. This makes diffs which add or remove items far easier to interpret, and makes merging such changes feasible. And it looks nicer too.
* Use line breaks to show the logical structure of your code. This enhances readability. Bring similar elements in a list into alignment, in order to reveal the differences between those elements at a glance.
* Removed a fun game of spot-the-difference in AbuseFilterHistoryPager::getQueryInfo(). If I want fun games I'll play UFO:AI.
* Moved some oddly placed assignments (in expressions) to their own statements: such assignments reduce readbility.
2009-02-07 09:34:11 +00:00
Andrew Garrett 53edcafc69 Reduce exception on encountering an unrecognised action to a debug log message. 2009-02-07 02:26:56 +00:00
Siebrand Mazeland 050e623836 Localisation updates for extension messages from translatewiki.net (2009-02-05 18:09 UTC) 2009-02-05 18:20:16 +00:00
Andrew Garrett 0b9f621633 Whitespace 2009-02-04 22:16:06 +00:00
Andrew Garrett 334e5a6b09 Fix examine links in AbuseLog. 2009-02-04 21:22:41 +00:00
Rotem Liss c202f89003 Localization update for he. 2009-02-04 20:52:06 +00:00
Andrew Garrett dd52ffe658 Variable naming conflict. 2009-02-04 19:59:52 +00:00
Andrew Garrett 7dd35167ee Show filter itself, rather than the private comments, in the recent filter changes display. 2009-02-04 19:56:21 +00:00
Andrew Garrett fcdfd79c67 Allow Abuse Log entries to be examined in the same way recent changes items are. 2009-02-04 19:51:03 +00:00
Siebrand Mazeland 3617248d13 Localisation updates for extension messages from translatewiki.net (2009-02-04 18:04 UTC) 2009-02-04 18:20:54 +00:00
Rotem Liss 7fc78be483 Localization update for he. 2009-02-04 13:20:40 +00:00