Commit graph

6329 commits

Author SHA1 Message Date
DannyS712 745d911d68 Add tests for afl_rev_id being set
Regression tests to make sure T286140 does not
happen again.

In the process, discovered what caused that bug
with afl_rev_id not being set: EditRevUpdater::updateRev()
compares the WikiPage given in the PageSaveComplete hook
to the one given to it by AbuseFilterHooks from
onEditFilterMergedContent, and compares the two using
`===`, meaning that they must refer to the same underlying
object. That bug was caused because AbuseFilterHooks
changed to providing a different object, despite still
referring to the same underlying page.

We should probably change that behavior in EditRevUpdater,
but for now updated AbuseFilterConsequencesTest to pass
the same object around by using RequestContext::setWikiPage()
and providing the WikiPage object to
MediaWikiIntegrationTestCase::editPage().

Bug: T286140
Change-Id: I6562f513c463538af6b59b12a64564b254024613
2021-07-04 08:04:06 +00:00
jenkins-bot edaf650151 Merge "Revert "Replace depricating method IContextSource::getWikiPage to WikiPageFactory usage"" 2021-07-04 06:17:09 +00:00
DannyS712 3f4430473e Revert "Replace depricating method IContextSource::getWikiPage to WikiPageFactory usage"
This reverts commit 15fc159cb1.

Reason for revert: this is breaking the addition of rev ids to filter
hits after edits are saved. I suspect this is because the context wikipage
is for a different title than the one being edited, though I'm not sure
way - regardless, testing on patchdemo shows that with this revert
is applied, rev ids are once again added to filter hits.

Bug: T286140
Change-Id: I3ab6324a73050154cef1c20a2bf8307eb11eea2d
2021-07-04 05:54:30 +00:00
jenkins-bot db15b13396 Merge "SECURITY: Avoid database for MediaWiki:Abusefilter-blocker fallback" 2021-07-02 15:46:53 +00:00
jenkins-bot 39dfd40abc Merge "ViewImport/ViewList: Use setTitle instead of addHiddenField/setAction" 2021-07-02 12:27:55 +00:00
Kosta Harlan 833aa70f10 ViewImport/ViewList: Use setTitle instead of addHiddenField/setAction
Bug: T285464
Change-Id: I3845f3261373d2aa3318ab39d125210f64f65447
2021-07-02 13:18:01 +02:00
Translation updater bot 6dc2c068b5 Localisation updates from https://translatewiki.net.
Change-Id: If8edba4e6f02ea70bd04560be865d6491d130f7d
2021-07-02 08:30:46 +02:00
DannyS712 71bf9faf49 SECURITY: Avoid database for MediaWiki:Abusefilter-blocker fallback
If the content language is English and the message is invalid as
a username, or the content language is not English and both the
content language version and the English version are invalid, the
user in FilterUser would not be created - now, avoid the onwiki
version of the English message in the fallback, so it could only
be invalid if the default in the i18n files was invalid.

Bug: T284364
Change-Id: I9e9f44b7663e810de70fb9ac7f6760f83dd4895b
2021-07-01 17:35:54 -05:00
Translation updater bot 2b1de9ef11 Localisation updates from https://translatewiki.net.
Change-Id: Iad7177f8703306251cd600b8690894b734e6c7ce
2021-06-30 08:25:44 +02:00
jenkins-bot 2deac909ad Merge "Pass a user to WikiPage::prepareContentForEdit()" 2021-06-28 22:50:38 +00:00
Roman Stolar 15fc159cb1 Replace depricating method IContextSource::getWikiPage to WikiPageFactory usage
Bug: T275710
Change-Id: I7fe24059e9909352e95aaa82fb48688f9260b207
2021-06-28 16:12:48 +03:00
Translation updater bot 3b0eadd666 Localisation updates from https://translatewiki.net.
Change-Id: I6cd76ac36ae88fec74fd32ecb7baa25333f67874
2021-06-28 09:22:21 +02:00
jenkins-bot 97f805b67c Merge "Bump MW requirement to 1.37" 2021-06-26 14:19:01 +00:00
jenkins-bot eb24f02c25 Merge "Handle EditFilterMergedContent hook properly to break hook chains and display error message" 2021-06-26 12:21:55 +00:00
Daimona Eaytoy e56dcc7cb1 Bump MW requirement to 1.37
The master version of the extension is only meant to support the most
recent version of MediaWiki.

Change-Id: I33612e69fc37bf5eb70133c8f0e95199dd7fcb65
2021-06-26 14:18:43 +02:00
DannyS712 47f861b6f6 Pass a user to WikiPage::prepareContentForEdit()
Bug: T285447
Change-Id: I4d277419106c3af5222377a863c80dd866ba188b
2021-06-24 04:01:33 +00:00
jenkins-bot 4dd9644bf6 Merge "Make phan not complain about Throttle::throttleIdentifier" 2021-06-22 12:07:22 +00:00
Matěj Suchánek d7ec0b992c Make phan not complain about Throttle::throttleIdentifier
UserEditTracker::getUserEditCount now allows anonymous users,
but it returns null and phan is aware of this. Suppress this
warning until at least 1.37 is required.

Change-Id: I9962abe08fa31d55421d8bdda23ea0a1c0471a86
2021-06-22 11:37:58 +02:00
Translation updater bot a52ebcf221 Localisation updates from https://translatewiki.net.
Change-Id: I27bda07624cec34e8a19a6d974ee49f93c128f17
2021-06-21 14:11:06 +02:00
Translation updater bot 98dee510fb Localisation updates from https://translatewiki.net.
Change-Id: I6021746b15ab9873e14f9bb36c3b1fac9ffeb6a7
2021-06-18 08:20:09 +02:00
Translation updater bot 05f913952b Localisation updates from https://translatewiki.net.
Change-Id: I8df697d1846f890d8e1edfedf652df54ccf9d6ce
2021-06-16 08:19:06 +02:00
Translation updater bot 829d97b1ed Localisation updates from https://translatewiki.net.
Change-Id: If8908b167b231e864c9de62337869464cccf99bd
2021-06-15 08:31:48 +02:00
Translation updater bot 369f9269ae Localisation updates from https://translatewiki.net.
Change-Id: I48f17bb712431bd2db09d53c7b07a285ab5b8db8
2021-06-14 08:35:36 +02:00
sahil fb04dada81 selenium: Upgrade WebdriverIO to v7
Update npm packages: @wdio/* and webdriverio.

Bug: T274579
Change-Id: I76323458eb45642990370ecbae5b159ffda40ddd
2021-06-09 20:45:38 +05:30
Translation updater bot e5af5e0ce1 Localisation updates from https://translatewiki.net.
Change-Id: I24c9b57cb63e05606380062d8dec0500fdf46c48
2021-06-09 08:27:58 +02:00
jenkins-bot 805ea5b4ff Merge "User mock must return Block instance from getBlock." 2021-06-08 19:14:52 +00:00
jenkins-bot 405e6a7771 Merge "selenium: Update wdio-mediawiki" 2021-06-08 17:35:08 +00:00
daniel 54285fe984 User mock must return Block instance from getBlock.
Change-Id: I569e91dd07b8f89af42344b6d6df87560dcb6bbe
Needed-By: T271494
2021-06-08 17:12:48 +02:00
Translation updater bot b592251616 Localisation updates from https://translatewiki.net.
Change-Id: I340b1f363ce073a61e24971abf176c83ae33f267
2021-06-08 08:35:23 +02:00
Translation updater bot b7a085bacb Localisation updates from https://translatewiki.net.
Change-Id: Ib6175679a947805cdb92701275e367ca3ca01653
2021-06-07 08:40:56 +02:00
jenkins-bot 52024847e8 Merge "Pass a valid regexp to preg_match in checkRegexMatchesEmpty" 2021-06-04 09:11:50 +00:00
jenkins-bot 997e665530 Merge "Don't use p class="success" for success messages" 2021-06-04 08:59:58 +00:00
Translation updater bot f0136ad0ee Localisation updates from https://translatewiki.net.
Change-Id: I39d36b47dfa7ddd3c964edf3941fcbf66b9ea055
2021-06-04 08:35:32 +02:00
Translation updater bot e642d954a3 Localisation updates from https://translatewiki.net.
Change-Id: I71c785186d3d01430a69ddaf5169c4287949c5d1
2021-06-01 08:34:12 +02:00
Roman Stolar c347a0d33e Update DatabaseBlock construct option 'by' to use User Identity only
Bug: T283641
Change-Id: I16b07e18441143a5d5d470eef4c28037a150b605
2021-05-31 17:36:55 +03:00
Translation updater bot 9ddd1affa7 Localisation updates from https://translatewiki.net.
Change-Id: I78146b2b666eba71cd803dd9dd7e7b4cf0204a66
2021-05-31 08:29:28 +02:00
Daimona Eaytoy 57f11631ba Pass a valid regexp to preg_match in checkRegexMatchesEmpty
Bug: T283966
Change-Id: I99688aa8f3e62e410392a9142df56b1a3c708987
2021-05-29 11:38:07 +00:00
sahil 5fca7c2f51 selenium: Update wdio-mediawiki
wdio-mediawiki v1.1.1:
- Includes wdio-defaults.conf.js file that vastly simplifies wdio.conf.js.
- Replaces @wdio/spec-reporter with @wdio/dot-reporter.
- Introduces video recording.

Bug: T283597
Change-Id: I603626d20eb060ba6d90b1a91d49afe13e29d945
2021-05-28 01:04:55 +05:30
Translation updater bot fa325f1ea5 Localisation updates from https://translatewiki.net.
Change-Id: I359f465b4f1ed9c8c2e881cc0d9f3088f62d1792
2021-05-27 12:04:28 +02:00
Translation updater bot 3a8a4849b2 Localisation updates from https://translatewiki.net.
Change-Id: Ibfb09f7afdca631a09622042f75824bfc380984d
2021-05-26 09:03:30 +02:00
Translation updater bot 642af0440d Localisation updates from https://translatewiki.net.
Change-Id: I0a2f9032d48d03752a5214e789eb70151981ee18
2021-05-25 08:50:27 +02:00
libraryupgrader 4b6d70a482 build: Updating browserslist to 4.16.6
* https://npmjs.com/advisories/1747 (CVE-2021-23364)

Change-Id: Id46ac5238524a965abb694cf60f61811996b84ed
2021-05-25 05:21:25 +00:00
Translation updater bot 446c36ff06 Localisation updates from https://translatewiki.net.
Change-Id: I687d47f81aa66502f8bca4f55598c475c3b77d0e
2021-05-24 09:52:10 +02:00
Translation updater bot c544392c0f Localisation updates from https://translatewiki.net.
Change-Id: Ided8798d3fc8b0e70a931ff8ab43e685a3123de1
2021-05-21 08:33:12 +02:00
libraryupgrader df603761b7 build: Updating hosted-git-info to 2.8.9
Change-Id: I9e6eb50df11ecd7495d89f5b6701a183432cd34d
2021-05-21 04:12:01 +00:00
Translation updater bot 6ce61e71d2 Localisation updates from https://translatewiki.net.
Change-Id: Ia9f0cb7ae648a0473a87143a5e2e8bd59d26c33a
2021-05-20 09:09:09 +02:00
Translation updater bot 41b885b50a Localisation updates from https://translatewiki.net.
Change-Id: I6b75a6c728344eeb37c5a12aacd490502070938e
2021-05-19 08:41:39 +02:00
jenkins-bot 7e8cf0d101 Merge "Selenium: update README.md file" 2021-05-18 15:45:15 +00:00
Translation updater bot ec92e55b99 Localisation updates from https://translatewiki.net.
Change-Id: I4cbb7b8b05769a7e4b91f901f1565928e87057e9
2021-05-18 08:45:15 +02:00
Translation updater bot 9371abef4e Localisation updates from https://translatewiki.net.
Change-Id: I205f125b86434872eaf0ec7c140603ce1ab006bf
2021-05-17 08:40:19 +02:00