Go to file
DannyS712 745d911d68 Add tests for afl_rev_id being set
Regression tests to make sure T286140 does not
happen again.

In the process, discovered what caused that bug
with afl_rev_id not being set: EditRevUpdater::updateRev()
compares the WikiPage given in the PageSaveComplete hook
to the one given to it by AbuseFilterHooks from
onEditFilterMergedContent, and compares the two using
`===`, meaning that they must refer to the same underlying
object. That bug was caused because AbuseFilterHooks
changed to providing a different object, despite still
referring to the same underlying page.

We should probably change that behavior in EditRevUpdater,
but for now updated AbuseFilterConsequencesTest to pass
the same object around by using RequestContext::setWikiPage()
and providing the WikiPage object to
MediaWikiIntegrationTestCase::editPage().

Bug: T286140
Change-Id: I6562f513c463538af6b59b12a64564b254024613
2021-07-04 08:04:06 +00:00
.phan Notify of a throttled filter 2020-12-19 10:31:29 +01:00
db_patches Give MySQL indexes explicit names, align MySQL and SQLite 2021-04-15 11:30:30 +02:00
i18n Localisation updates from https://translatewiki.net. 2021-07-02 08:30:46 +02:00
includes Merge "Revert "Replace depricating method IContextSource::getWikiPage to WikiPageFactory usage"" 2021-07-04 06:17:09 +00:00
maintenance Replace uses of DB_MASTER with DB_PRIMARY 2021-05-13 01:43:37 +02:00
modules Check response code and prevent exception in worker-abusefilter 2021-02-12 00:01:51 +00:00
tests Add tests for afl_rev_id being set 2021-07-04 08:04:06 +00:00
.eslintrc.json build: Updating eslint-config-wikimedia to 0.19.0 2021-03-10 23:05:48 +00:00
.gitignore Add config for Selenium and basic tests 2019-09-17 16:23:07 +00:00
.gitreview Whoops, track not trace 2016-10-24 17:01:30 -07:00
.phpcs.xml Merge "Use FauxRequest::setUpload in AbuseFilterUploadTestTrait::doUpload" 2021-05-15 12:22:10 +00:00
.stylelintrc.json build: Bump devDependencies to latest 2018-02-10 21:00:53 +00:00
AbuseFilter.alias.php Add aliases for Serbian language 2018-12-24 02:16:55 +00:00
CODE_OF_CONDUCT.md build: Updating mediawiki/phan-taint-check-plugin to 1.4.0 2018-09-01 05:29:54 +00:00
composer.json build: Updating composer dependencies 2021-05-02 06:41:54 +00:00
COPYING
extension.json Merge "Bump MW requirement to 1.37" 2021-06-26 14:19:01 +00:00
Gruntfile.js eslint config tweaks 2020-06-09 19:39:03 +01:00
package-lock.json selenium: Upgrade WebdriverIO to v7 2021-06-09 20:45:38 +05:30
package.json selenium: Upgrade WebdriverIO to v7 2021-06-09 20:45:38 +05:30