Commit graph

75 commits

Author SHA1 Message Date
alistair3149 e53afa51dc
fix(core): config CitizenThemeDefault should set theme correctly
Previously the config did set the theme correctly but get overridden by the inline
script to auto, this will fix it.

Closes: #418
2022-06-29 15:29:44 -04:00
alistair3149 eba22354e5
fix(core): run script when DOM is ready
Sometimes the scripts start to run before DOM is fully ready. It causes things
like #475 where the checkbox is not in DOM yet but the script is already asking for it.
2022-06-04 17:44:03 -04:00
alistair3149 da619c793b
refactor(core): remove duplicated auto theme handling
Refactor auto theme handling into inline script since theme.js is basically duplicated code
at this point. Also add the event listener whenever auto theme is set.

Closes: #461
2022-05-20 17:33:10 -04:00
alistair3149 9d711d4ee2
refactor(core): use scroll-padding-top for top margin 2022-05-17 15:35:04 -04:00
alistair3149 1be7f5faaf refactor(core): rewrite ToC scrollspy based on Vector 2022-05-17 15:11:16 -04:00
alistair3149 c978bb1320
refactor(core): rename title hidden class 2022-05-13 00:30:46 -04:00
alistair3149 d59ca5c83a
refactor(core): move intersection observer into a module
* We will likely use it for other things in the future
* Based on Vector's implementation
* Also do not get toc element twice
2022-05-13 00:26:53 -04:00
alistair3149 23795e05e3
chore(ci): disable mediawiki/class-doc 2022-05-13 00:20:05 -04:00
alistair3149 13a2b710ea
refactor(core): remove duplicated check for ToC 2022-05-12 23:24:32 -04:00
alistair3149 194c73d5bb
style(core): use arrow function 2022-05-12 22:44:17 -04:00
alistair3149 86150d492d
refactor(core): clean up checkboxHack implementation
Mostly based on Vector 2022. Now we target checkbox hacks by the HTML classes
.mw-checkbox-hack-TYPE instead of defining each individually, which would
make it more scalable.
2022-05-12 22:37:28 -04:00
alistair3149 508c96ae9d
refactor(core): merge ToC script into core scripts 2022-05-12 17:18:39 -04:00
alistair3149 e0d5eb9657
feat(core): set toc-enabled through Mustache template
Since somewhere around MW 1.37, buildSkinFeatures() no longer have access to OutputPage.
That causes $out->isTOCenabled always return null, which makes ToC
broken for any wikis since 1.37. This should fix the issue for now.
More optimizations on the loading behavior will come soon.
2022-05-12 17:01:01 -04:00
github-actions a2577db3c8 ci: lint code to MediaWiki standards
Check commit and GitHub actions for more details
2022-05-12 01:41:40 +00:00
alistair3149 b73357cf7c
feat(core): update checkboxHack API 2022-05-11 21:32:36 -04:00
alistair3149 da26d4bc7f
refactor(core): add null check search button checkbox 2022-05-11 19:08:51 -04:00
alistair3149 cae7deb945
refactor(core): clean up header icon styles 2022-05-10 11:59:43 -04:00
alistair3149 6e35212007 refactor(core): clean up search box implementation
* Clean up DOM structure
* Clean up HTML classes
* Use relative units
* Remove unnessecary CSS
2022-05-10 10:52:36 -04:00
alistair3149 5ccfbcfdeb refactor(core): clean up drawer implementation
This is a part of the site header refactor
* Use relative units
* Add title to toggle button
* Remove unnessecary CSS
* Rewrite HTML classes
* Temporary remove drawer subsearch, it will be re-explored in a later patch
2022-05-10 10:52:36 -04:00
alistair3149 96013bb126
feat: deprecate --background-color-dp-XX in favor of --color-surface-X
--background-color-dp-XX is now fully deprecated in favor of a simpler 4 color surface system. It can be accessed through the --color-surface-X CSS var.
2022-04-25 22:27:52 -04:00
alistair3149 fed5369847
fix: add null check for checkboxObj.target
It should no longer throw an exception which causes other script to fail

Closes #432
2022-04-25 21:48:52 -04:00
alistair3149 2c79c061c4 feat: pass styles as style element instead of inline 2022-04-25 20:34:40 -04:00
alistair3149 047f830d1a
fix: FOUC of light theme when user is using auto theme and prefer dark
The prefer-dark script was previously deferred which causes a delay to detect and switch theme for the user. It is now inlined to prevent the delay.
2022-04-19 18:17:53 -04:00
alistair3149 7ecf3a81eb
feat: depreciate theme preferences in MW user preferences
Just local storage is good enough
2022-04-19 17:31:23 -04:00
alistair3149 f5c5c996fa
fix: fix eslint no-shadow error 2021-12-15 22:19:39 -05:00
alistair3149 f7e73cf171
feat: add security header deprecation message for upcoming version 2021-08-05 11:41:31 -04:00
alistair3149 f5a2a831d1
feat: add user customizable line height 2021-08-05 11:24:52 -04:00
alistair3149 7dc0d14c70
feat: simplify background color variables in core styles
--background-color-dp-XX is soft depreciated, please use --color-surface-X instead
2021-07-25 19:16:05 -04:00
alistair3149 63d21cf318 fix: add additional check for ToC elements
that should fix the null querySelector bug:
2021-07-12 15:11:11 -04:00
alistair3149 5f168f03ee
feat: add page load progress bar 2021-06-12 09:54:47 -04:00
alistair3149 19119f2b5d
feat: add auto theme to preferences 2021-06-09 14:40:44 -04:00
alistair3149 b2bd79196d
feat: rework search module (#386)
* feat: rewrite search module (WIP)
There are some caveats because it is a WIP
- Messages are not i18n yet
- Missing placeholder suggestion thumbnail
- Only REST mode works
- Missing greeting message when there is no search query
- Code might look like a mess (I learned JS not long ago)

* refactor: remove old search module

* feat: clean up search suggestion styles

* feat: hide overflow for suggestion text

* feat: add action API and various cleanup

* feat: re-add abort controller

* feat: add message support and tweaks

* feat: use virtual config instead of ResourceLoader hook

* fix: missing comma in const definition

* feat: add ARIA attributes
2021-05-17 16:34:14 -04:00
alistair3149 3202c1d9e6
fix: prevent Firefox quickfind overriding the search toggle shortcut 2021-05-10 13:36:44 -04:00
github-actions fef76149d1 ci: lint code to MediaWiki standards
Check commit and GitHub actions for more details
2021-05-10 17:27:36 +00:00
alistair3149 74873da01f
refactor: better detection for slash toggle 2021-05-10 13:26:39 -04:00
alistair3149 e79e707ce3
fix: disable search shortcut when VE is activated 2021-04-30 13:28:51 -04:00
alistair3149 51ac47691e feat: implement reading preferences
allow visitor to adjust theme, font size, and page width
2021-04-27 13:51:03 -04:00
alistair3149 e2b4a4e49a
feat: show page title on header after scroll
The page header also acts as a jump to top link
2021-04-26 11:39:27 -04:00
alistair3149 4bbb59f978
refactor: improve search loading indicator behavior 2021-04-22 12:09:14 -04:00
alistair3149 546fa36d33
refactor: drop dependency for mediawiki.page.ready 2021-04-22 11:44:48 -04:00
alistair3149 38882334c8
refactor: use checkboxHack module for search script 2021-04-21 18:47:03 -04:00
alistair3149 8129ca0e5b
feat: use MW core checkboxHack scripts instead
Cloned and tweaked to a local file as the core file can be different across MW builds
2021-04-21 16:45:52 -04:00
alistair3149 f44aaa4e4c
refactor: refactor skins.citizen.scripts to ES6 2021-04-21 13:44:28 -04:00
alistair3149 117d839f00
doc: fix lettercase for Window and Document object 2021-04-21 11:32:44 -04:00
alistair3149 c4c607d154
fix: theme toggle button not appearing in initial load 2021-04-20 23:54:32 -04:00
alistair3149 2cec33906e
refactor: integrate skins.citizen.scripts.theme into core scripts 2021-04-20 23:42:45 -04:00
github-actions 3f9117a2cd ci: lint code to MediaWiki standards
Check commit and GitHub actions for more details
2021-04-17 04:07:47 +00:00
alistair3149 ad78883461
fix: search shortcut being triggered in textarea 2021-04-17 00:06:57 -04:00
alistair3149 8ef0e927f8
refactor: simplify search key handler 2021-04-12 16:22:16 -04:00
alistair3149 5a3b64252d
feat: tweak search shortcut key behavior 2021-04-12 15:55:59 -04:00