refactor(core): use scroll-padding-top for top margin

This commit is contained in:
alistair3149 2022-05-17 15:35:04 -04:00
parent 1be7f5faaf
commit 9d711d4ee2
No known key found for this signature in database
GPG key ID: 94D081060FD3DD9C

View file

@ -41,15 +41,23 @@ function changeActiveSection( id ) {
* @return {void}
*/
function initToC() {
const
header = document.querySelector( '.citizen-header' ),
bodyContent = document.getElementById( 'bodyContent' );
const bodyContent = document.getElementById( 'bodyContent' );
// We use scroll-padding-top to handle scrolling with fixed header
// It is better to respect that so it is consistent
const getTopMargin = () => {
return Number(
window.getComputedStyle( document.documentElement )
.getPropertyValue( 'scroll-padding-top' )
.slice( 0, -2 )
) + 20;
};
const initSectionObserver = require( './sectionObserver.js' ).init;
const sectionObserver = initSectionObserver( {
elements: bodyContent.querySelectorAll( '.mw-headline' ),
topMargin: header.getBoundingClientRect().height,
topMargin: getTopMargin(),
onIntersection: ( section ) => { changeActiveSection( section.id ); }
} );